Commit graph

2954 commits

Author SHA1 Message Date
Treehugger Robot
fa824cd1ff Merge "Add a function to check missing deps" am: 2259132d96 am: a8ce65d348 am: a16d1231f4
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2596965

Change-Id: I91f60789ff4771770dd9d30240c55d126708fe91
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 18:15:56 +00:00
Treehugger Robot
a16d1231f4 Merge "Add a function to check missing deps" am: 2259132d96 am: a8ce65d348
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2596965

Change-Id: I2a4d505e8ff2b2348a8ab0d66afeb681e037a6ce
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 17:31:50 +00:00
Treehugger Robot
a8ce65d348 Merge "Add a function to check missing deps" am: 2259132d96
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2596965

Change-Id: Ia459100e758a52d2b1a38afda3ee84c25335337b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-23 16:53:43 +00:00
Treehugger Robot
2259132d96 Merge "Add a function to check missing deps" 2023-05-23 16:07:01 +00:00
LaMont Jones
8e289aeb47 context: Allow running some singletons in parallel. am: 12ccb17d4e am: 22ff6aea90 am: 45d4f12ee1 am: b2835befaa am: d44da0a6bb am: 19ba5547f0
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592647

Change-Id: I5c91dcd0107c561c38ece495db86d6fb4f8e45f1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:17:47 +00:00
LaMont Jones
e9521a061f live_tracker: wrap add functions with mutex am: ff04c33f2a am: 5e8c2df08f am: cbc5498930 am: 97864c2fdc am: e1c9d00d23 am: a4e385a900
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592646

Change-Id: I7a2d403e9e27474ea3a82b9fec5253711e61d875
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:17:41 +00:00
LaMont Jones
19ba5547f0 context: Allow running some singletons in parallel. am: 12ccb17d4e am: 22ff6aea90 am: 45d4f12ee1 am: b2835befaa am: d44da0a6bb
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592647

Change-Id: Ia419547e06ae960b81712a2ecda727d62e146fda
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:12:39 +00:00
LaMont Jones
a4e385a900 live_tracker: wrap add functions with mutex am: ff04c33f2a am: 5e8c2df08f am: cbc5498930 am: 97864c2fdc am: e1c9d00d23
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592646

Change-Id: I9bf9a025a50ec1a5e0d5bef935390d7da720d9f9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 20:12:32 +00:00
LaMont Jones
d44da0a6bb context: Allow running some singletons in parallel. am: 12ccb17d4e am: 22ff6aea90 am: 45d4f12ee1 am: b2835befaa
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592647

Change-Id: I0d049d6cac1a29444113ff052955ea849404965a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 19:48:59 +00:00
LaMont Jones
e1c9d00d23 live_tracker: wrap add functions with mutex am: ff04c33f2a am: 5e8c2df08f am: cbc5498930 am: 97864c2fdc
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592646

Change-Id: I25bfe75b4021477bdd2a2408831138a5d1612a17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 19:48:54 +00:00
LaMont Jones
b2835befaa context: Allow running some singletons in parallel. am: 12ccb17d4e am: 22ff6aea90 am: 45d4f12ee1
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592647

Change-Id: Ia9da283a76bdebe623b76c54bb0cc4699b970670
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 19:00:29 +00:00
LaMont Jones
97864c2fdc live_tracker: wrap add functions with mutex am: ff04c33f2a am: 5e8c2df08f am: cbc5498930
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592646

Change-Id: I5b6646670c54eec967740c3d90576551a0a9eba9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 19:00:23 +00:00
LaMont Jones
45d4f12ee1 context: Allow running some singletons in parallel. am: 12ccb17d4e am: 22ff6aea90
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592647

Change-Id: I9e4f66601381837039082df27819f325ede627b5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 18:14:12 +00:00
LaMont Jones
cbc5498930 live_tracker: wrap add functions with mutex am: ff04c33f2a am: 5e8c2df08f
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592646

Change-Id: I5fbefbef2f13119dcfa4f014efaa381500349a18
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 18:14:06 +00:00
LaMont Jones
22ff6aea90 context: Allow running some singletons in parallel. am: 12ccb17d4e
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592647

Change-Id: I0a6d414effcaaec16bf7f66f4343730b437e80de
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 17:11:33 +00:00
LaMont Jones
5e8c2df08f live_tracker: wrap add functions with mutex am: ff04c33f2a
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2592646

Change-Id: Id2851dd5282c377aa8e7b54ea9f74adad5cc9755
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-22 17:11:27 +00:00
LaMont Jones
12ccb17d4e context: Allow running some singletons in parallel.
Many of the singletons are trivial and can be run in parallel, improving
the performance during analysis.

Bug: 281536768
Test: manual, presubmit
Change-Id: Ia63e4bc42a68e65dfa800e770982fa5826355fad
2023-05-19 19:03:08 +00:00
LaMont Jones
ff04c33f2a live_tracker: wrap add functions with mutex
There is already a mutex for the structure, but several add functions do
not use the mutex to protect access.

Bug: 281536768
Test: manual, presubmits
Change-Id: I34e95d8722b8e5fb753c099d7aedee5c4734715d
2023-05-19 18:01:16 +00:00
Liz Kammer
6af6061b12 Add a function to check missing deps
Test: go test Soong tests
Change-Id: If24e52b51a00bc45d6b6a2212d4e045bb36c598c
2023-05-18 09:52:46 -04:00
William Escande
2476187fea bpfmt: Test comment line while sorting arrays am: a74d05b939 am: 26801b1c03 am: 438d864e2f am: d46299e855 am: 82cb863d8e am: 8573f723e0
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2593367

Change-Id: Ic5a98028747732cc65970527ab7b4b996aec045f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 08:03:06 +00:00
David Duarte
79edb93953 bpfmt: Preserve line of comment when sorting arrays am: 65aa5a505f am: 9ef2774045 am: 81818b05db am: a54e139252 am: 1b08025c76 am: f71927c68b
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2542770

Change-Id: Ic12cd4120a646aabcd17f51d7089343fe37ab9ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 08:03:05 +00:00
William Escande
8573f723e0 bpfmt: Test comment line while sorting arrays am: a74d05b939 am: 26801b1c03 am: 438d864e2f am: d46299e855 am: 82cb863d8e
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2593367

Change-Id: I4405727240fe1fed314dd92fdfd5bdf395636621
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 07:21:22 +00:00
David Duarte
f71927c68b bpfmt: Preserve line of comment when sorting arrays am: 65aa5a505f am: 9ef2774045 am: 81818b05db am: a54e139252 am: 1b08025c76
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2542770

Change-Id: I085ddc067e7b5cb9ff5e4ae4a997e5453877fb54
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 07:21:20 +00:00
William Escande
82cb863d8e bpfmt: Test comment line while sorting arrays am: a74d05b939 am: 26801b1c03 am: 438d864e2f am: d46299e855
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2593367

Change-Id: Ib5b6667cd8e2570c3007c8cdc1519a81159bd890
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 06:15:06 +00:00
David Duarte
1b08025c76 bpfmt: Preserve line of comment when sorting arrays am: 65aa5a505f am: 9ef2774045 am: 81818b05db am: a54e139252
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2542770

Change-Id: I09b7fd6a5540204fedcfe93f1d030f47ae0adffe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 06:15:04 +00:00
William Escande
d46299e855 bpfmt: Test comment line while sorting arrays am: a74d05b939 am: 26801b1c03 am: 438d864e2f
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2593367

Change-Id: I191adfc05652ddd75b832296c32a663eb6d92fad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 05:31:59 +00:00
David Duarte
a54e139252 bpfmt: Preserve line of comment when sorting arrays am: 65aa5a505f am: 9ef2774045 am: 81818b05db
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2542770

Change-Id: I3936f90ae7e5f64e07c24c57f8d63a18fca21432
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 05:31:57 +00:00
William Escande
438d864e2f bpfmt: Test comment line while sorting arrays am: a74d05b939 am: 26801b1c03
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2593367

Change-Id: I9f85b2d7c1788f466f31189fb000066f8442bf53
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 04:25:59 +00:00
David Duarte
81818b05db bpfmt: Preserve line of comment when sorting arrays am: 65aa5a505f am: 9ef2774045
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2542770

Change-Id: Ife79eb744ef2a18324636ad94c613e640038e6d6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 04:25:57 +00:00
William Escande
26801b1c03 bpfmt: Test comment line while sorting arrays am: a74d05b939
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2593367

Change-Id: Ic45a7c6b2d443d51520b63553ed6a5461860044b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 03:42:47 +00:00
David Duarte
9ef2774045 bpfmt: Preserve line of comment when sorting arrays am: 65aa5a505f
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2542770

Change-Id: Ied01a8f28324d01c6bbcd77170a3c6f48949979e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-18 03:42:46 +00:00
William Escande
a74d05b939 bpfmt: Test comment line while sorting arrays
Test: bpfmt test
Change-Id: I4a11ac200a7b10d3abb76db78f4be2ef772763cf
2023-05-17 15:17:49 -07:00
David Duarte
65aa5a505f bpfmt: Preserve line of comment when sorting arrays
When given as an input
```
array: [
    "a",
    // Unicorn
    "b",
]
```
bpfmt with `-s` option was outputing
```
array: [
    "a", // Unicorn
    "b",
]
```

Which is not ideal because the comment was targetting
the second value and now it seems to be targetting the
first one

This patch preserve the difference in line number between
the value and the comment to give the same output when
```
array: [
    "a",
    // Unicorn
    "b",
]
```
is given as input

Test: Manual tests + run bpfmt -w -s on packages/modules/Bluetooth
Change-Id: I2b58f20da463bea77c22a4e6978aa9beb4b4fcc8
2023-05-17 13:36:13 -07:00
Jeongik Cha
fe75917416 Replace GetOutputsFromModuleNames with GetWeightedOutputsFromPredicate am: 2621c909e5 am: 1828108878 am: 513b7b0ca9 am: 495550b9a4 am: 15d2ed8603 am: 04da6d4709
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2527126

Change-Id: I5143e70af08e35523d9aca9088397967b976bb40
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 09:52:19 +00:00
Jeongik Cha
04da6d4709 Replace GetOutputsFromModuleNames with GetWeightedOutputsFromPredicate am: 2621c909e5 am: 1828108878 am: 513b7b0ca9 am: 495550b9a4 am: 15d2ed8603
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2527126

Change-Id: I9069e8362f17c06ab7b1c5318244776c8ee3c39a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 09:03:35 +00:00
Jeongik Cha
15d2ed8603 Replace GetOutputsFromModuleNames with GetWeightedOutputsFromPredicate am: 2621c909e5 am: 1828108878 am: 513b7b0ca9 am: 495550b9a4
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2527126

Change-Id: I20c3162903b705e46a30222e57364de71439499e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 08:23:11 +00:00
Jeongik Cha
495550b9a4 Replace GetOutputsFromModuleNames with GetWeightedOutputsFromPredicate am: 2621c909e5 am: 1828108878 am: 513b7b0ca9
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2527126

Change-Id: I849a658ed09c3125d4d53c53a72d80fd9271c7c2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 07:41:23 +00:00
Jeongik Cha
513b7b0ca9 Replace GetOutputsFromModuleNames with GetWeightedOutputsFromPredicate am: 2621c909e5 am: 1828108878
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2527126

Change-Id: I620d2feaee22960f0a9df50aa1aa81d108b64154
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 06:53:54 +00:00
Jeongik Cha
1828108878 Replace GetOutputsFromModuleNames with GetWeightedOutputsFromPredicate am: 2621c909e5
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2527126

Change-Id: I9102f23cea1b52c66b0b2964d591c7a8eaf7e8c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-04 06:13:59 +00:00
Jeongik Cha
2621c909e5 Replace GetOutputsFromModuleNames with GetWeightedOutputsFromPredicate
Bug: 273282046
Test: m --ninja_weight_source=ninja_log
Change-Id: I3f35406a7334f737ea010d5453c85e5f2d993708
2023-04-15 00:57:28 +09:00
Steven Moreland
d998c31ea5 Merge "Add name hint to blueprint." am: aefc0a9b9b am: b72e38080e am: bedb263bc4 am: 85934ee063 am: b69e2c12fa
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2518036

Change-Id: Ia9b2ec810b3a405a88c711ec0d51f26da04806ed
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-12 04:46:35 +00:00
Steven Moreland
07a75e1780 Merge "Add name hint to blueprint." am: aefc0a9b9b am: b72e38080e am: bedb263bc4 am: 85934ee063 am: bbbced136f
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2518036

Change-Id: Ie426ce34497b1c86f46d2ab6894d4f41221c4c67
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-12 04:45:43 +00:00
Steven Moreland
b69e2c12fa Merge "Add name hint to blueprint." am: aefc0a9b9b am: b72e38080e am: bedb263bc4 am: 85934ee063
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2518036

Change-Id: I2b87ffe635740d642071950fc5a95e2460ad716e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-12 04:04:30 +00:00
Steven Moreland
bbbced136f Merge "Add name hint to blueprint." am: aefc0a9b9b am: b72e38080e am: bedb263bc4 am: 85934ee063
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2518036

Change-Id: I87de89b5c8ec6a47c3a2c20f516a314e7f470255
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-12 04:03:03 +00:00
Steven Moreland
85934ee063 Merge "Add name hint to blueprint." am: aefc0a9b9b am: b72e38080e am: bedb263bc4
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2518036

Change-Id: Idb96d125caa7dc5bef7e9febb63e2050a11210c1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-12 03:18:16 +00:00
Steven Moreland
bedb263bc4 Merge "Add name hint to blueprint." am: aefc0a9b9b am: b72e38080e
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2518036

Change-Id: If5b3eb3f21248362f9e819f1ab71d72446319eb7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-12 02:47:27 +00:00
Steven Moreland
b72e38080e Merge "Add name hint to blueprint." am: aefc0a9b9b
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2518036

Change-Id: I2c633c44ed61150808c578c5c1338d6e68d7f185
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-12 02:16:35 +00:00
Steven Moreland
aefc0a9b9b Merge "Add name hint to blueprint." 2023-04-11 20:26:04 +00:00
Steven Moreland
d457f11884 Add name hint to blueprint.
Bug: N/A
Test: updated
Change-Id: Iac9218aa7621dd6223dc26a9f2ebec5d68211328
2023-04-10 20:21:15 +00:00
Treehugger Robot
8691d3f817 Merge "Add variant name to module info" am: a85a30c611 am: 0dbf7c740f am: b1b9cbc149 am: 10b9f13f96 am: f988bdde8d
Original change: https://android-review.googlesource.com/c/platform/build/blueprint/+/2526240

Change-Id: I3a6826700498837070942dc06f893e7cadd06ce3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-07 20:06:51 +00:00