b138d49adf
Add an option "-property", which is an alias to the option "-parameter". For example if Android.bp contains: cc_foo { name: "foo", } Then `bpmodify -m foo -a bar -property baz.buz Android.bp` outputs: cc_foo { name: "foo", baz: { buz: ["bar"], }, } Bug: 149715904 Test: go test -v Change-Id: I9660cff1b5239ccf5aa9ef1a41835b8ac6cd4b9f
411 lines
10 KiB
Go
411 lines
10 KiB
Go
// Mostly copied from Go's src/cmd/gofmt:
|
|
// Copyright 2009 The Go Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"flag"
|
|
"fmt"
|
|
"io"
|
|
"io/ioutil"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"unicode"
|
|
|
|
"github.com/google/blueprint/parser"
|
|
)
|
|
|
|
var (
|
|
// main operation modes
|
|
list = flag.Bool("l", false, "list files that would be modified by bpmodify")
|
|
write = flag.Bool("w", false, "write result to (source) file instead of stdout")
|
|
doDiff = flag.Bool("d", false, "display diffs instead of rewriting files")
|
|
sortLists = flag.Bool("s", false, "sort touched lists, even if they were unsorted")
|
|
targetedModules = new(identSet)
|
|
targetedProperty = new(qualifiedProperty)
|
|
addIdents = new(identSet)
|
|
removeIdents = new(identSet)
|
|
)
|
|
|
|
func init() {
|
|
flag.Var(targetedModules, "m", "comma or whitespace separated list of modules on which to operate")
|
|
flag.Var(targetedProperty, "parameter", "alias to -property=`name`")
|
|
flag.Var(targetedProperty, "property", "fully qualified `name` of property to modify (default \"deps\")")
|
|
flag.Var(addIdents, "a", "comma or whitespace separated list of identifiers to add")
|
|
flag.Var(removeIdents, "r", "comma or whitespace separated list of identifiers to remove")
|
|
flag.Usage = usage
|
|
}
|
|
|
|
var (
|
|
exitCode = 0
|
|
)
|
|
|
|
func report(err error) {
|
|
fmt.Fprintln(os.Stderr, err)
|
|
exitCode = 2
|
|
}
|
|
|
|
func usage() {
|
|
fmt.Fprintf(flag.CommandLine.Output(), "Usage: %s [flags] [path ...]\n", os.Args[0])
|
|
flag.PrintDefaults()
|
|
}
|
|
|
|
// If in == nil, the source is the contents of the file with the given filename.
|
|
func processFile(filename string, in io.Reader, out io.Writer) error {
|
|
if in == nil {
|
|
f, err := os.Open(filename)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer f.Close()
|
|
in = f
|
|
}
|
|
|
|
src, err := ioutil.ReadAll(in)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
r := bytes.NewBuffer(src)
|
|
|
|
file, errs := parser.Parse(filename, r, parser.NewScope(nil))
|
|
if len(errs) > 0 {
|
|
for _, err := range errs {
|
|
fmt.Fprintln(os.Stderr, err)
|
|
}
|
|
return fmt.Errorf("%d parsing errors", len(errs))
|
|
}
|
|
|
|
modified, errs := findModules(file)
|
|
if len(errs) > 0 {
|
|
for _, err := range errs {
|
|
fmt.Fprintln(os.Stderr, err)
|
|
}
|
|
fmt.Fprintln(os.Stderr, "continuing...")
|
|
}
|
|
|
|
if modified {
|
|
res, err := parser.Print(file)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if *list {
|
|
fmt.Fprintln(out, filename)
|
|
}
|
|
if *write {
|
|
err = ioutil.WriteFile(filename, res, 0644)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
if *doDiff {
|
|
data, err := diff(src, res)
|
|
if err != nil {
|
|
return fmt.Errorf("computing diff: %s", err)
|
|
}
|
|
fmt.Printf("diff %s bpfmt/%s\n", filename, filename)
|
|
out.Write(data)
|
|
}
|
|
|
|
if !*list && !*write && !*doDiff {
|
|
_, err = out.Write(res)
|
|
}
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
func findModules(file *parser.File) (modified bool, errs []error) {
|
|
|
|
for _, def := range file.Defs {
|
|
if module, ok := def.(*parser.Module); ok {
|
|
for _, prop := range module.Properties {
|
|
if prop.Name == "name" && prop.Value.Type() == parser.StringType {
|
|
if targetedModule(prop.Value.Eval().(*parser.String).Value) {
|
|
m, newErrs := processModule(module, prop.Name, file)
|
|
errs = append(errs, newErrs...)
|
|
modified = modified || m
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return modified, errs
|
|
}
|
|
|
|
func processModule(module *parser.Module, moduleName string,
|
|
file *parser.File) (modified bool, errs []error) {
|
|
prop, err := getRecursiveProperty(module, targetedProperty.name(), targetedProperty.prefixes())
|
|
if err != nil {
|
|
return false, []error{err}
|
|
}
|
|
if prop == nil {
|
|
if len(addIdents.idents) == 0 {
|
|
// We cannot find an existing prop, and we aren't adding anything to the prop,
|
|
// which means we must be removing something from a non-existing prop,
|
|
// which means this is a noop.
|
|
return false, nil
|
|
}
|
|
// Else we are adding something to a non-existing prop, so we need to create it first.
|
|
prop, modified, err = createRecursiveProperty(module, targetedProperty.name(), targetedProperty.prefixes())
|
|
if err != nil {
|
|
// Here should be unreachable, but still handle it for completeness.
|
|
return false, []error{err}
|
|
}
|
|
}
|
|
m, errs := processParameter(prop.Value, targetedProperty.String(), moduleName, file)
|
|
modified = modified || m
|
|
return modified, errs
|
|
}
|
|
|
|
func getRecursiveProperty(module *parser.Module, name string, prefixes []string) (prop *parser.Property, err error) {
|
|
prop, _, err = getOrCreateRecursiveProperty(module, name, prefixes, false)
|
|
return prop, err
|
|
}
|
|
|
|
func createRecursiveProperty(module *parser.Module, name string, prefixes []string) (prop *parser.Property, modified bool, err error) {
|
|
return getOrCreateRecursiveProperty(module, name, prefixes, true)
|
|
}
|
|
|
|
func getOrCreateRecursiveProperty(module *parser.Module, name string, prefixes []string,
|
|
createIfNotFound bool) (prop *parser.Property, modified bool, err error) {
|
|
m := &module.Map
|
|
for i, prefix := range prefixes {
|
|
if prop, found := m.GetProperty(prefix); found {
|
|
if mm, ok := prop.Value.Eval().(*parser.Map); ok {
|
|
m = mm
|
|
} else {
|
|
// We've found a property in the AST and such property is not of type
|
|
// *parser.Map, which must mean we didn't modify the AST.
|
|
return nil, false, fmt.Errorf("Expected property %q to be a map, found %s",
|
|
strings.Join(prefixes[:i+1], "."), prop.Value.Type())
|
|
}
|
|
} else if createIfNotFound {
|
|
mm := &parser.Map{}
|
|
m.Properties = append(m.Properties, &parser.Property{Name: prefix, Value: mm})
|
|
m = mm
|
|
// We've created a new node in the AST. This means the m.GetProperty(name)
|
|
// check after this for loop must fail, because the node we inserted is an
|
|
// empty parser.Map, thus this function will return |modified| is true.
|
|
} else {
|
|
return nil, false, nil
|
|
}
|
|
}
|
|
if prop, found := m.GetProperty(name); found {
|
|
// We've found a property in the AST, which must mean we didn't modify the AST.
|
|
return prop, false, nil
|
|
} else if createIfNotFound {
|
|
prop = &parser.Property{Name: name, Value: &parser.List{}}
|
|
m.Properties = append(m.Properties, prop)
|
|
return prop, true, nil
|
|
} else {
|
|
return nil, false, nil
|
|
}
|
|
}
|
|
|
|
func processParameter(value parser.Expression, paramName, moduleName string,
|
|
file *parser.File) (modified bool, errs []error) {
|
|
if _, ok := value.(*parser.Variable); ok {
|
|
return false, []error{fmt.Errorf("parameter %s in module %s is a variable, unsupported",
|
|
paramName, moduleName)}
|
|
}
|
|
|
|
if _, ok := value.(*parser.Operator); ok {
|
|
return false, []error{fmt.Errorf("parameter %s in module %s is an expression, unsupported",
|
|
paramName, moduleName)}
|
|
}
|
|
|
|
list, ok := value.(*parser.List)
|
|
if !ok {
|
|
return false, []error{fmt.Errorf("expected parameter %s in module %s to be list, found %s",
|
|
paramName, moduleName, value.Type().String())}
|
|
}
|
|
|
|
wasSorted := parser.ListIsSorted(list)
|
|
|
|
for _, a := range addIdents.idents {
|
|
m := parser.AddStringToList(list, a)
|
|
modified = modified || m
|
|
}
|
|
|
|
for _, r := range removeIdents.idents {
|
|
m := parser.RemoveStringFromList(list, r)
|
|
modified = modified || m
|
|
}
|
|
|
|
if (wasSorted || *sortLists) && modified {
|
|
parser.SortList(file, list)
|
|
}
|
|
|
|
return modified, nil
|
|
}
|
|
|
|
func targetedModule(name string) bool {
|
|
if targetedModules.all {
|
|
return true
|
|
}
|
|
for _, m := range targetedModules.idents {
|
|
if m == name {
|
|
return true
|
|
}
|
|
}
|
|
|
|
return false
|
|
}
|
|
|
|
func visitFile(path string, f os.FileInfo, err error) error {
|
|
if err == nil && f.Name() == "Blueprints" {
|
|
err = processFile(path, nil, os.Stdout)
|
|
}
|
|
if err != nil {
|
|
report(err)
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func walkDir(path string) {
|
|
filepath.Walk(path, visitFile)
|
|
}
|
|
|
|
func main() {
|
|
defer func() {
|
|
if err := recover(); err != nil {
|
|
report(fmt.Errorf("error: %s", err))
|
|
}
|
|
os.Exit(exitCode)
|
|
}()
|
|
|
|
flag.Parse()
|
|
|
|
if len(targetedProperty.parts) == 0 {
|
|
targetedProperty.Set("deps")
|
|
}
|
|
|
|
if flag.NArg() == 0 {
|
|
if *write {
|
|
report(fmt.Errorf("error: cannot use -w with standard input"))
|
|
return
|
|
}
|
|
if err := processFile("<standard input>", os.Stdin, os.Stdout); err != nil {
|
|
report(err)
|
|
}
|
|
return
|
|
}
|
|
|
|
if len(targetedModules.idents) == 0 {
|
|
report(fmt.Errorf("-m parameter is required"))
|
|
return
|
|
}
|
|
|
|
if len(addIdents.idents) == 0 && len(removeIdents.idents) == 0 {
|
|
report(fmt.Errorf("-a or -r parameter is required"))
|
|
return
|
|
}
|
|
|
|
for i := 0; i < flag.NArg(); i++ {
|
|
path := flag.Arg(i)
|
|
switch dir, err := os.Stat(path); {
|
|
case err != nil:
|
|
report(err)
|
|
case dir.IsDir():
|
|
walkDir(path)
|
|
default:
|
|
if err := processFile(path, nil, os.Stdout); err != nil {
|
|
report(err)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
func diff(b1, b2 []byte) (data []byte, err error) {
|
|
f1, err := ioutil.TempFile("", "bpfmt")
|
|
if err != nil {
|
|
return
|
|
}
|
|
defer os.Remove(f1.Name())
|
|
defer f1.Close()
|
|
|
|
f2, err := ioutil.TempFile("", "bpfmt")
|
|
if err != nil {
|
|
return
|
|
}
|
|
defer os.Remove(f2.Name())
|
|
defer f2.Close()
|
|
|
|
f1.Write(b1)
|
|
f2.Write(b2)
|
|
|
|
data, err = exec.Command("diff", "-uw", f1.Name(), f2.Name()).CombinedOutput()
|
|
if len(data) > 0 {
|
|
// diff exits with a non-zero status when the files don't match.
|
|
// Ignore that failure as long as we get output.
|
|
err = nil
|
|
}
|
|
return
|
|
|
|
}
|
|
|
|
type identSet struct {
|
|
idents []string
|
|
all bool
|
|
}
|
|
|
|
func (m *identSet) String() string {
|
|
return strings.Join(m.idents, ",")
|
|
}
|
|
|
|
func (m *identSet) Set(s string) error {
|
|
m.idents = strings.FieldsFunc(s, func(c rune) bool {
|
|
return unicode.IsSpace(c) || c == ','
|
|
})
|
|
if len(m.idents) == 1 && m.idents[0] == "*" {
|
|
m.all = true
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (m *identSet) Get() interface{} {
|
|
return m.idents
|
|
}
|
|
|
|
type qualifiedProperty struct {
|
|
parts []string
|
|
}
|
|
|
|
var _ flag.Getter = (*qualifiedProperty)(nil)
|
|
|
|
func (p *qualifiedProperty) name() string {
|
|
return p.parts[len(p.parts)-1]
|
|
}
|
|
|
|
func (p *qualifiedProperty) prefixes() []string {
|
|
return p.parts[:len(p.parts)-1]
|
|
}
|
|
|
|
func (p *qualifiedProperty) String() string {
|
|
return strings.Join(p.parts, ".")
|
|
}
|
|
|
|
func (p *qualifiedProperty) Set(s string) error {
|
|
p.parts = strings.Split(s, ".")
|
|
if len(p.parts) == 0 {
|
|
return fmt.Errorf("%q is not a valid property name", s)
|
|
}
|
|
for _, part := range p.parts {
|
|
if part == "" {
|
|
return fmt.Errorf("%q is not a valid property name", s)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (p *qualifiedProperty) Get() interface{} {
|
|
return p.parts
|
|
}
|