2ce594e446
There are 8935901 *ninjaString objects generated in an AOSP aosp_blueline-userdebug build, and 7865180 of those are a literal string with no ninja variables. Each of those *ninjaString objects takes a minimum of 48 bytes for 2 slices, plus 8 bytes for the pointer to the ninjaString. For the literal string case, one of those slices has a single element, (costing another 16 bytes for the backing array), and the other slice is empty, for a total of 72 bytes. Replace *ninjaString with a ninjaString interface. This increases the size of the reference from 8 bytes to 16 bytes, but using a type alias of a string for the literal string implementation uses only 16 bytes, saving 40 bytes per literal string or 314 MB. Test: ninja_strings_test Change-Id: Ic5fe16ed1f2a244fe6a8ccdf762919634d825cbe
221 lines
5.3 KiB
Go
221 lines
5.3 KiB
Go
// Copyright 2014 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package blueprint
|
|
|
|
import (
|
|
"reflect"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
var ninjaParseTestCases = []struct {
|
|
input string
|
|
vars []string
|
|
strs []string
|
|
literal bool
|
|
err string
|
|
}{
|
|
{
|
|
input: "abc def $ghi jkl",
|
|
vars: []string{"ghi"},
|
|
strs: []string{"abc def ", " jkl"},
|
|
},
|
|
{
|
|
input: "abc def $ghi$jkl",
|
|
vars: []string{"ghi", "jkl"},
|
|
strs: []string{"abc def ", "", ""},
|
|
},
|
|
{
|
|
input: "foo $012_-345xyz_! bar",
|
|
vars: []string{"012_-345xyz_"},
|
|
strs: []string{"foo ", "! bar"},
|
|
},
|
|
{
|
|
input: "foo ${012_-345xyz_} bar",
|
|
vars: []string{"012_-345xyz_"},
|
|
strs: []string{"foo ", " bar"},
|
|
},
|
|
{
|
|
input: "foo ${012_-345xyz_} bar",
|
|
vars: []string{"012_-345xyz_"},
|
|
strs: []string{"foo ", " bar"},
|
|
},
|
|
{
|
|
input: "foo $$ bar",
|
|
vars: nil,
|
|
strs: []string{"foo $$ bar"},
|
|
// this is technically a literal, but not recognized as such due to the $$
|
|
},
|
|
{
|
|
input: "$foo${bar}",
|
|
vars: []string{"foo", "bar"},
|
|
strs: []string{"", "", ""},
|
|
},
|
|
{
|
|
input: "$foo$$",
|
|
vars: []string{"foo"},
|
|
strs: []string{"", "$$"},
|
|
},
|
|
{
|
|
input: "foo bar",
|
|
vars: nil,
|
|
strs: []string{"foo bar"},
|
|
literal: true,
|
|
},
|
|
{
|
|
input: " foo ",
|
|
vars: nil,
|
|
strs: []string{"$ foo "},
|
|
literal: true,
|
|
},
|
|
{
|
|
input: " $foo ",
|
|
vars: []string{"foo"},
|
|
strs: []string{"$ ", " "},
|
|
}, {
|
|
input: "foo $ bar",
|
|
err: "invalid character after '$' at byte offset 5",
|
|
},
|
|
{
|
|
input: "foo $",
|
|
err: "unexpected end of string after '$'",
|
|
},
|
|
{
|
|
input: "foo ${} bar",
|
|
err: "empty variable name at byte offset 6",
|
|
},
|
|
{
|
|
input: "foo ${abc!} bar",
|
|
err: "invalid character in variable name at byte offset 9",
|
|
},
|
|
{
|
|
input: "foo ${abc",
|
|
err: "unexpected end of string in variable name",
|
|
},
|
|
}
|
|
|
|
func TestParseNinjaString(t *testing.T) {
|
|
for _, testCase := range ninjaParseTestCases {
|
|
scope := newLocalScope(nil, "namespace")
|
|
expectedVars := []Variable{}
|
|
for _, varName := range testCase.vars {
|
|
v, err := scope.LookupVariable(varName)
|
|
if err != nil {
|
|
v, err = scope.AddLocalVariable(varName, "")
|
|
if err != nil {
|
|
t.Fatalf("error creating scope: %s", err)
|
|
}
|
|
}
|
|
expectedVars = append(expectedVars, v)
|
|
}
|
|
|
|
var expected ninjaString
|
|
if len(testCase.strs) > 0 {
|
|
if testCase.literal {
|
|
expected = literalNinjaString(testCase.strs[0])
|
|
} else {
|
|
expected = &varNinjaString{
|
|
strings: testCase.strs,
|
|
variables: expectedVars,
|
|
}
|
|
}
|
|
}
|
|
|
|
output, err := parseNinjaString(scope, testCase.input)
|
|
if err == nil {
|
|
if !reflect.DeepEqual(output, expected) {
|
|
t.Errorf("incorrect ninja string:")
|
|
t.Errorf(" input: %q", testCase.input)
|
|
t.Errorf(" expected: %#v", expected)
|
|
t.Errorf(" got: %#v", output)
|
|
}
|
|
}
|
|
var errStr string
|
|
if err != nil {
|
|
errStr = err.Error()
|
|
}
|
|
if err != nil && err.Error() != testCase.err {
|
|
t.Errorf("unexpected error:")
|
|
t.Errorf(" input: %q", testCase.input)
|
|
t.Errorf(" expected: %q", testCase.err)
|
|
t.Errorf(" got: %q", errStr)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseNinjaStringWithImportedVar(t *testing.T) {
|
|
ImpVar := &staticVariable{name_: "ImpVar"}
|
|
impScope := newScope(nil)
|
|
impScope.AddVariable(ImpVar)
|
|
scope := newScope(nil)
|
|
scope.AddImport("impPkg", impScope)
|
|
|
|
input := "abc def ${impPkg.ImpVar} ghi"
|
|
output, err := parseNinjaString(scope, input)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
|
|
expect := []Variable{ImpVar}
|
|
if !reflect.DeepEqual(output.(*varNinjaString).variables, expect) {
|
|
t.Errorf("incorrect output:")
|
|
t.Errorf(" input: %q", input)
|
|
t.Errorf(" expected: %#v", expect)
|
|
t.Errorf(" got: %#v", output)
|
|
}
|
|
}
|
|
|
|
func BenchmarkNinjaString_Value(b *testing.B) {
|
|
b.Run("constant", func(b *testing.B) {
|
|
for _, l := range []int{1, 10, 100, 1000} {
|
|
ns := simpleNinjaString(strings.Repeat("a", l))
|
|
b.Run(strconv.Itoa(l), func(b *testing.B) {
|
|
for n := 0; n < b.N; n++ {
|
|
ns.Value(nil)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
b.Run("variable", func(b *testing.B) {
|
|
for _, l := range []int{1, 10, 100, 1000} {
|
|
scope := newLocalScope(nil, "")
|
|
scope.AddLocalVariable("a", strings.Repeat("b", l/3))
|
|
ns, _ := parseNinjaString(scope, strings.Repeat("a", l/3)+"${a}"+strings.Repeat("a", l/3))
|
|
b.Run(strconv.Itoa(l), func(b *testing.B) {
|
|
for n := 0; n < b.N; n++ {
|
|
ns.Value(nil)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
b.Run("variables", func(b *testing.B) {
|
|
for _, l := range []int{1, 2, 3, 4, 5, 10, 100, 1000} {
|
|
scope := newLocalScope(nil, "")
|
|
str := strings.Repeat("a", 10)
|
|
for i := 0; i < l; i++ {
|
|
scope.AddLocalVariable("a"+strconv.Itoa(i), strings.Repeat("b", 10))
|
|
str += "${a" + strconv.Itoa(i) + "}"
|
|
}
|
|
ns, _ := parseNinjaString(scope, str)
|
|
b.Run(strconv.Itoa(l), func(b *testing.B) {
|
|
for n := 0; n < b.N; n++ {
|
|
ns.Value(nil)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
|
|
}
|