19ff727ad5
ninjaString.ValueWithEscaper is a relatively hot function, rewrite it with strings.Builder to avoid repeated string concatenation, which requires an allocation each time. Before: BenchmarkNinjaString_Value/constant/1-72 100000000 11.9 ns/op BenchmarkNinjaString_Value/constant/10-72 100000000 18.9 ns/op BenchmarkNinjaString_Value/constant/100-72 50000000 22.1 ns/op BenchmarkNinjaString_Value/constant/1000-72 30000000 39.3 ns/op BenchmarkNinjaString_Value/variable/1-72 20000000 95.1 ns/op BenchmarkNinjaString_Value/variable/10-72 10000000 223 ns/op BenchmarkNinjaString_Value/variable/100-72 3000000 437 ns/op BenchmarkNinjaString_Value/variable/1000-72 2000000 948 ns/op BenchmarkNinjaString_Value/variables/1-72 10000000 161 ns/op BenchmarkNinjaString_Value/variables/2-72 5000000 368 ns/op BenchmarkNinjaString_Value/variables/3-72 3000000 560 ns/op BenchmarkNinjaString_Value/variables/4-72 2000000 795 ns/op BenchmarkNinjaString_Value/variables/5-72 1000000 1004 ns/op BenchmarkNinjaString_Value/variables/10-72 1000000 2275 ns/op BenchmarkNinjaString_Value/variables/100-72 50000 39667 ns/op BenchmarkNinjaString_Value/variables/1000-72 1000 2146592 ns/op After: BenchmarkNinjaString_Value/constant/1-72 200000000 11.3 ns/op BenchmarkNinjaString_Value/constant/10-72 100000000 17.2 ns/op BenchmarkNinjaString_Value/constant/100-72 50000000 21.7 ns/op BenchmarkNinjaString_Value/constant/1000-72 30000000 38.3 ns/op BenchmarkNinjaString_Value/variable/1-72 20000000 91.8 ns/op BenchmarkNinjaString_Value/variable/10-72 10000000 199 ns/op BenchmarkNinjaString_Value/variable/100-72 5000000 377 ns/op BenchmarkNinjaString_Value/variable/1000-72 2000000 855 ns/op BenchmarkNinjaString_Value/variables/1-72 10000000 141 ns/op BenchmarkNinjaString_Value/variables/2-72 5000000 312 ns/op BenchmarkNinjaString_Value/variables/3-72 5000000 362 ns/op BenchmarkNinjaString_Value/variables/4-72 3000000 417 ns/op BenchmarkNinjaString_Value/variables/5-72 2000000 621 ns/op BenchmarkNinjaString_Value/variables/10-72 2000000 837 ns/op BenchmarkNinjaString_Value/variables/100-72 200000 9141 ns/op BenchmarkNinjaString_Value/variables/1000-72 20000 95094 ns/op Test: ninja_strings_test.go Change-Id: I6c61e747d8e67f7f1e6cff0cc0c705745301a35f
207 lines
5.1 KiB
Go
207 lines
5.1 KiB
Go
// Copyright 2014 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package blueprint
|
|
|
|
import (
|
|
"reflect"
|
|
"strconv"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
var ninjaParseTestCases = []struct {
|
|
input string
|
|
vars []string
|
|
strs []string
|
|
err string
|
|
}{
|
|
{
|
|
input: "abc def $ghi jkl",
|
|
vars: []string{"ghi"},
|
|
strs: []string{"abc def ", " jkl"},
|
|
},
|
|
{
|
|
input: "abc def $ghi$jkl",
|
|
vars: []string{"ghi", "jkl"},
|
|
strs: []string{"abc def ", "", ""},
|
|
},
|
|
{
|
|
input: "foo $012_-345xyz_! bar",
|
|
vars: []string{"012_-345xyz_"},
|
|
strs: []string{"foo ", "! bar"},
|
|
},
|
|
{
|
|
input: "foo ${012_-345xyz_} bar",
|
|
vars: []string{"012_-345xyz_"},
|
|
strs: []string{"foo ", " bar"},
|
|
},
|
|
{
|
|
input: "foo ${012_-345xyz_} bar",
|
|
vars: []string{"012_-345xyz_"},
|
|
strs: []string{"foo ", " bar"},
|
|
},
|
|
{
|
|
input: "foo $$ bar",
|
|
vars: nil,
|
|
strs: []string{"foo $$ bar"},
|
|
},
|
|
{
|
|
input: "$foo${bar}",
|
|
vars: []string{"foo", "bar"},
|
|
strs: []string{"", "", ""},
|
|
},
|
|
{
|
|
input: "$foo$$",
|
|
vars: []string{"foo"},
|
|
strs: []string{"", "$$"},
|
|
},
|
|
{
|
|
input: "foo bar",
|
|
vars: nil,
|
|
strs: []string{"foo bar"},
|
|
},
|
|
{
|
|
input: " foo ",
|
|
vars: nil,
|
|
strs: []string{"$ foo "},
|
|
},
|
|
{
|
|
input: "foo $ bar",
|
|
err: "invalid character after '$' at byte offset 5",
|
|
},
|
|
{
|
|
input: "foo $",
|
|
err: "unexpected end of string after '$'",
|
|
},
|
|
{
|
|
input: "foo ${} bar",
|
|
err: "empty variable name at byte offset 6",
|
|
},
|
|
{
|
|
input: "foo ${abc!} bar",
|
|
err: "invalid character in variable name at byte offset 9",
|
|
},
|
|
{
|
|
input: "foo ${abc",
|
|
err: "unexpected end of string in variable name",
|
|
},
|
|
}
|
|
|
|
func TestParseNinjaString(t *testing.T) {
|
|
for _, testCase := range ninjaParseTestCases {
|
|
scope := newLocalScope(nil, "namespace")
|
|
expectedVars := []Variable{}
|
|
for _, varName := range testCase.vars {
|
|
v, err := scope.LookupVariable(varName)
|
|
if err != nil {
|
|
v, err = scope.AddLocalVariable(varName, "")
|
|
if err != nil {
|
|
t.Fatalf("error creating scope: %s", err)
|
|
}
|
|
}
|
|
expectedVars = append(expectedVars, v)
|
|
}
|
|
|
|
output, err := parseNinjaString(scope, testCase.input)
|
|
if err == nil {
|
|
if !reflect.DeepEqual(output.variables, expectedVars) {
|
|
t.Errorf("incorrect variable list:")
|
|
t.Errorf(" input: %q", testCase.input)
|
|
t.Errorf(" expected: %#v", expectedVars)
|
|
t.Errorf(" got: %#v", output.variables)
|
|
}
|
|
if !reflect.DeepEqual(output.strings, testCase.strs) {
|
|
t.Errorf("incorrect string list:")
|
|
t.Errorf(" input: %q", testCase.input)
|
|
t.Errorf(" expected: %#v", testCase.strs)
|
|
t.Errorf(" got: %#v", output.strings)
|
|
}
|
|
}
|
|
var errStr string
|
|
if err != nil {
|
|
errStr = err.Error()
|
|
}
|
|
if err != nil && err.Error() != testCase.err {
|
|
t.Errorf("unexpected error:")
|
|
t.Errorf(" input: %q", testCase.input)
|
|
t.Errorf(" expected: %q", testCase.err)
|
|
t.Errorf(" got: %q", errStr)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestParseNinjaStringWithImportedVar(t *testing.T) {
|
|
ImpVar := &staticVariable{name_: "ImpVar"}
|
|
impScope := newScope(nil)
|
|
impScope.AddVariable(ImpVar)
|
|
scope := newScope(nil)
|
|
scope.AddImport("impPkg", impScope)
|
|
|
|
input := "abc def ${impPkg.ImpVar} ghi"
|
|
output, err := parseNinjaString(scope, input)
|
|
if err != nil {
|
|
t.Fatalf("unexpected error: %s", err)
|
|
}
|
|
|
|
expect := []Variable{ImpVar}
|
|
if !reflect.DeepEqual(output.variables, expect) {
|
|
t.Errorf("incorrect output:")
|
|
t.Errorf(" input: %q", input)
|
|
t.Errorf(" expected: %#v", expect)
|
|
t.Errorf(" got: %#v", output)
|
|
}
|
|
}
|
|
|
|
func BenchmarkNinjaString_Value(b *testing.B) {
|
|
b.Run("constant", func(b *testing.B) {
|
|
for _, l := range []int{1, 10, 100, 1000} {
|
|
ns := simpleNinjaString(strings.Repeat("a", l))
|
|
b.Run(strconv.Itoa(l), func(b *testing.B) {
|
|
for n := 0; n < b.N; n++ {
|
|
ns.Value(nil)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
b.Run("variable", func(b *testing.B) {
|
|
for _, l := range []int{1, 10, 100, 1000} {
|
|
scope := newLocalScope(nil, "")
|
|
scope.AddLocalVariable("a", strings.Repeat("b", l/3))
|
|
ns, _ := parseNinjaString(scope, strings.Repeat("a", l/3)+"${a}"+strings.Repeat("a", l/3))
|
|
b.Run(strconv.Itoa(l), func(b *testing.B) {
|
|
for n := 0; n < b.N; n++ {
|
|
ns.Value(nil)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
b.Run("variables", func(b *testing.B) {
|
|
for _, l := range []int{1, 2, 3, 4, 5, 10, 100, 1000} {
|
|
scope := newLocalScope(nil, "")
|
|
str := strings.Repeat("a", 10)
|
|
for i := 0; i < l; i++ {
|
|
scope.AddLocalVariable("a"+strconv.Itoa(i), strings.Repeat("b", 10))
|
|
str += "${a" + strconv.Itoa(i) + "}"
|
|
}
|
|
ns, _ := parseNinjaString(scope, str)
|
|
b.Run(strconv.Itoa(l), func(b *testing.B) {
|
|
for n := 0; n < b.N; n++ {
|
|
ns.Value(nil)
|
|
}
|
|
})
|
|
}
|
|
})
|
|
|
|
}
|