2019-08-27 21:03:00 +02:00
|
|
|
// Copyright 2019 The Android Open Source Project
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package rust
|
|
|
|
|
|
|
|
import (
|
|
|
|
"io/ioutil"
|
|
|
|
"os"
|
2019-09-03 22:49:39 +02:00
|
|
|
"runtime"
|
2019-09-24 22:23:50 +02:00
|
|
|
"strings"
|
2019-08-27 21:03:00 +02:00
|
|
|
"testing"
|
|
|
|
|
2020-04-09 15:56:02 +02:00
|
|
|
"github.com/google/blueprint/proptools"
|
|
|
|
|
2019-08-27 21:03:00 +02:00
|
|
|
"android/soong/android"
|
2020-02-15 20:00:10 +01:00
|
|
|
"android/soong/cc"
|
2019-08-27 21:03:00 +02:00
|
|
|
)
|
|
|
|
|
|
|
|
var (
|
|
|
|
buildDir string
|
|
|
|
)
|
|
|
|
|
|
|
|
func setUp() {
|
|
|
|
var err error
|
|
|
|
buildDir, err = ioutil.TempDir("", "soong_rust_test")
|
|
|
|
if err != nil {
|
|
|
|
panic(err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func tearDown() {
|
|
|
|
os.RemoveAll(buildDir)
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestMain(m *testing.M) {
|
|
|
|
run := func() int {
|
|
|
|
setUp()
|
|
|
|
defer tearDown()
|
|
|
|
|
|
|
|
return m.Run()
|
|
|
|
}
|
|
|
|
|
|
|
|
os.Exit(run())
|
|
|
|
}
|
|
|
|
|
2019-12-14 05:41:13 +01:00
|
|
|
func testConfig(bp string) android.Config {
|
|
|
|
bp = bp + GatherRequiredDepsForTest()
|
|
|
|
|
|
|
|
fs := map[string][]byte{
|
|
|
|
"foo.rs": nil,
|
2020-04-09 15:56:02 +02:00
|
|
|
"foo.c": nil,
|
2019-12-14 05:41:13 +01:00
|
|
|
"src/bar.rs": nil,
|
2020-05-16 02:36:30 +02:00
|
|
|
"src/any.h": nil,
|
2020-08-21 12:01:58 +02:00
|
|
|
"buf.proto": nil,
|
2019-12-14 05:41:13 +01:00
|
|
|
"liby.so": nil,
|
|
|
|
"libz.so": nil,
|
|
|
|
}
|
|
|
|
|
2020-02-15 20:00:10 +01:00
|
|
|
cc.GatherRequiredFilesForTest(fs)
|
|
|
|
|
2019-12-14 05:41:13 +01:00
|
|
|
return android.TestArchConfig(buildDir, nil, bp, fs)
|
|
|
|
}
|
|
|
|
|
2019-08-27 21:03:00 +02:00
|
|
|
func testRust(t *testing.T, bp string) *android.TestContext {
|
2020-04-09 15:56:02 +02:00
|
|
|
return testRustContext(t, bp, false)
|
|
|
|
}
|
|
|
|
|
|
|
|
func testRustCov(t *testing.T, bp string) *android.TestContext {
|
|
|
|
return testRustContext(t, bp, true)
|
|
|
|
}
|
|
|
|
|
|
|
|
func testRustContext(t *testing.T, bp string, coverage bool) *android.TestContext {
|
2019-09-03 22:49:39 +02:00
|
|
|
// TODO (b/140435149)
|
|
|
|
if runtime.GOOS != "linux" {
|
|
|
|
t.Skip("Only the Linux toolchain is supported for Rust")
|
|
|
|
}
|
|
|
|
|
2019-08-27 21:03:00 +02:00
|
|
|
t.Helper()
|
2019-12-14 05:41:13 +01:00
|
|
|
config := testConfig(bp)
|
2019-08-27 21:03:00 +02:00
|
|
|
|
2020-04-09 15:56:02 +02:00
|
|
|
if coverage {
|
2020-06-17 02:51:46 +02:00
|
|
|
config.TestProductVariables.GcovCoverage = proptools.BoolPtr(true)
|
2020-04-09 15:56:02 +02:00
|
|
|
config.TestProductVariables.Native_coverage = proptools.BoolPtr(true)
|
2020-06-09 13:44:06 +02:00
|
|
|
config.TestProductVariables.NativeCoveragePaths = []string{"*"}
|
2020-04-09 15:56:02 +02:00
|
|
|
}
|
|
|
|
|
2019-12-14 05:41:13 +01:00
|
|
|
ctx := CreateTestContext()
|
|
|
|
ctx.Register(config)
|
2019-08-27 21:03:00 +02:00
|
|
|
|
|
|
|
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
|
|
|
|
android.FailIfErrored(t, errs)
|
|
|
|
_, errs = ctx.PrepareBuildActions(config)
|
|
|
|
android.FailIfErrored(t, errs)
|
|
|
|
|
|
|
|
return ctx
|
|
|
|
}
|
|
|
|
|
|
|
|
func testRustError(t *testing.T, pattern string, bp string) {
|
2019-09-03 22:49:39 +02:00
|
|
|
// TODO (b/140435149)
|
|
|
|
if runtime.GOOS != "linux" {
|
|
|
|
t.Skip("Only the Linux toolchain is supported for Rust")
|
|
|
|
}
|
|
|
|
|
2019-08-27 21:03:00 +02:00
|
|
|
t.Helper()
|
2019-12-14 05:41:13 +01:00
|
|
|
config := testConfig(bp)
|
2019-08-27 21:03:00 +02:00
|
|
|
|
2019-12-14 05:41:13 +01:00
|
|
|
ctx := CreateTestContext()
|
|
|
|
ctx.Register(config)
|
2019-08-27 21:03:00 +02:00
|
|
|
|
|
|
|
_, errs := ctx.ParseFileList(".", []string{"Android.bp"})
|
|
|
|
if len(errs) > 0 {
|
|
|
|
android.FailIfNoMatchingErrors(t, pattern, errs)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
_, errs = ctx.PrepareBuildActions(config)
|
|
|
|
if len(errs) > 0 {
|
|
|
|
android.FailIfNoMatchingErrors(t, pattern, errs)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
t.Fatalf("missing expected error %q (0 errors are returned)", pattern)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test that we can extract the link path from a lib path.
|
|
|
|
func TestLinkPathFromFilePath(t *testing.T) {
|
|
|
|
barPath := android.PathForTesting("out/soong/.intermediates/external/libbar/libbar/linux_glibc_x86_64_shared/libbar.so")
|
|
|
|
libName := linkPathFromFilePath(barPath)
|
|
|
|
expectedResult := "out/soong/.intermediates/external/libbar/libbar/linux_glibc_x86_64_shared/"
|
|
|
|
|
|
|
|
if libName != expectedResult {
|
|
|
|
t.Errorf("libNameFromFilePath returned the wrong name; expected '%#v', got '%#v'", expectedResult, libName)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Test to make sure dependencies are being picked up correctly.
|
|
|
|
func TestDepsTracking(t *testing.T) {
|
|
|
|
ctx := testRust(t, `
|
2020-06-23 23:28:53 +02:00
|
|
|
rust_ffi_host_static {
|
2019-10-18 23:49:46 +02:00
|
|
|
name: "libstatic",
|
|
|
|
srcs: ["foo.rs"],
|
2019-11-01 03:38:29 +01:00
|
|
|
crate_name: "static",
|
2019-10-18 23:49:46 +02:00
|
|
|
}
|
2020-06-23 23:28:53 +02:00
|
|
|
rust_ffi_host_shared {
|
2019-10-18 23:49:46 +02:00
|
|
|
name: "libshared",
|
|
|
|
srcs: ["foo.rs"],
|
2019-11-01 03:38:29 +01:00
|
|
|
crate_name: "shared",
|
2019-10-18 23:49:46 +02:00
|
|
|
}
|
2019-08-27 21:03:00 +02:00
|
|
|
rust_library_host_dylib {
|
2019-10-18 23:49:46 +02:00
|
|
|
name: "libdylib",
|
2019-08-27 21:03:00 +02:00
|
|
|
srcs: ["foo.rs"],
|
2019-11-01 03:38:29 +01:00
|
|
|
crate_name: "dylib",
|
2019-08-27 21:03:00 +02:00
|
|
|
}
|
|
|
|
rust_library_host_rlib {
|
2019-10-18 23:49:46 +02:00
|
|
|
name: "librlib",
|
2020-07-10 03:03:28 +02:00
|
|
|
srcs: ["foo.rs"],
|
2019-11-01 03:38:29 +01:00
|
|
|
crate_name: "rlib",
|
2019-08-27 21:03:00 +02:00
|
|
|
}
|
|
|
|
rust_proc_macro {
|
|
|
|
name: "libpm",
|
|
|
|
srcs: ["foo.rs"],
|
2019-11-01 03:38:29 +01:00
|
|
|
crate_name: "pm",
|
2019-08-27 21:03:00 +02:00
|
|
|
}
|
|
|
|
rust_binary_host {
|
2020-07-10 03:03:28 +02:00
|
|
|
name: "fizz-buzz",
|
2019-10-18 23:49:46 +02:00
|
|
|
dylibs: ["libdylib"],
|
|
|
|
rlibs: ["librlib"],
|
2019-08-27 21:03:00 +02:00
|
|
|
proc_macros: ["libpm"],
|
2019-10-18 23:49:46 +02:00
|
|
|
static_libs: ["libstatic"],
|
|
|
|
shared_libs: ["libshared"],
|
2020-07-10 03:03:28 +02:00
|
|
|
srcs: ["foo.rs"],
|
2019-08-27 21:03:00 +02:00
|
|
|
}
|
|
|
|
`)
|
2020-07-10 03:03:28 +02:00
|
|
|
module := ctx.ModuleForTests("fizz-buzz", "linux_glibc_x86_64").Module().(*Module)
|
2019-08-27 21:03:00 +02:00
|
|
|
|
|
|
|
// Since dependencies are added to AndroidMk* properties, we can check these to see if they've been picked up.
|
2019-10-18 23:49:46 +02:00
|
|
|
if !android.InList("libdylib", module.Properties.AndroidMkDylibs) {
|
2019-08-27 21:03:00 +02:00
|
|
|
t.Errorf("Dylib dependency not detected (dependency missing from AndroidMkDylibs)")
|
|
|
|
}
|
|
|
|
|
2019-10-18 23:49:46 +02:00
|
|
|
if !android.InList("librlib", module.Properties.AndroidMkRlibs) {
|
2019-08-27 21:03:00 +02:00
|
|
|
t.Errorf("Rlib dependency not detected (dependency missing from AndroidMkRlibs)")
|
|
|
|
}
|
|
|
|
|
|
|
|
if !android.InList("libpm", module.Properties.AndroidMkProcMacroLibs) {
|
|
|
|
t.Errorf("Proc_macro dependency not detected (dependency missing from AndroidMkProcMacroLibs)")
|
|
|
|
}
|
|
|
|
|
2019-10-18 23:49:46 +02:00
|
|
|
if !android.InList("libshared", module.Properties.AndroidMkSharedLibs) {
|
|
|
|
t.Errorf("Shared library dependency not detected (dependency missing from AndroidMkSharedLibs)")
|
|
|
|
}
|
|
|
|
|
|
|
|
if !android.InList("libstatic", module.Properties.AndroidMkStaticLibs) {
|
|
|
|
t.Errorf("Static library dependency not detected (dependency missing from AndroidMkStaticLibs)")
|
|
|
|
}
|
2019-08-27 21:03:00 +02:00
|
|
|
}
|
2019-09-24 22:23:50 +02:00
|
|
|
|
2020-07-10 03:03:28 +02:00
|
|
|
func TestSourceProviderDeps(t *testing.T) {
|
|
|
|
ctx := testRust(t, `
|
|
|
|
rust_binary {
|
|
|
|
name: "fizz-buzz-dep",
|
|
|
|
srcs: [
|
|
|
|
"foo.rs",
|
|
|
|
":my_generator",
|
|
|
|
":libbindings",
|
|
|
|
],
|
2020-07-31 19:40:31 +02:00
|
|
|
rlibs: ["libbindings"],
|
2020-07-10 03:03:28 +02:00
|
|
|
}
|
|
|
|
rust_proc_macro {
|
|
|
|
name: "libprocmacro",
|
|
|
|
srcs: [
|
|
|
|
"foo.rs",
|
|
|
|
":my_generator",
|
|
|
|
":libbindings",
|
|
|
|
],
|
2020-07-31 19:40:31 +02:00
|
|
|
rlibs: ["libbindings"],
|
2020-07-10 03:03:28 +02:00
|
|
|
crate_name: "procmacro",
|
|
|
|
}
|
|
|
|
rust_library {
|
|
|
|
name: "libfoo",
|
|
|
|
srcs: [
|
|
|
|
"foo.rs",
|
|
|
|
":my_generator",
|
2020-07-31 19:40:31 +02:00
|
|
|
":libbindings",
|
|
|
|
],
|
|
|
|
rlibs: ["libbindings"],
|
2020-07-10 03:03:28 +02:00
|
|
|
crate_name: "foo",
|
|
|
|
}
|
|
|
|
genrule {
|
|
|
|
name: "my_generator",
|
|
|
|
tools: ["any_rust_binary"],
|
|
|
|
cmd: "$(location) -o $(out) $(in)",
|
|
|
|
srcs: ["src/any.h"],
|
|
|
|
out: ["src/any.rs"],
|
|
|
|
}
|
|
|
|
rust_bindgen {
|
|
|
|
name: "libbindings",
|
2020-07-31 19:40:31 +02:00
|
|
|
crate_name: "bindings",
|
|
|
|
source_stem: "bindings",
|
2020-07-10 03:03:28 +02:00
|
|
|
host_supported: true,
|
|
|
|
wrapper_src: "src/any.h",
|
|
|
|
}
|
|
|
|
`)
|
|
|
|
|
|
|
|
libfoo := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_rlib").Rule("rustc")
|
|
|
|
if !android.SuffixInList(libfoo.Implicits.Strings(), "/out/bindings.rs") {
|
|
|
|
t.Errorf("rust_bindgen generated source not included as implicit input for libfoo; Implicits %#v", libfoo.Implicits.Strings())
|
|
|
|
}
|
|
|
|
if !android.SuffixInList(libfoo.Implicits.Strings(), "/out/any.rs") {
|
|
|
|
t.Errorf("genrule generated source not included as implicit input for libfoo; Implicits %#v", libfoo.Implicits.Strings())
|
|
|
|
}
|
|
|
|
|
|
|
|
fizzBuzz := ctx.ModuleForTests("fizz-buzz-dep", "android_arm64_armv8-a").Rule("rustc")
|
|
|
|
if !android.SuffixInList(fizzBuzz.Implicits.Strings(), "/out/bindings.rs") {
|
|
|
|
t.Errorf("rust_bindgen generated source not included as implicit input for fizz-buzz-dep; Implicits %#v", libfoo.Implicits.Strings())
|
|
|
|
}
|
|
|
|
if !android.SuffixInList(fizzBuzz.Implicits.Strings(), "/out/any.rs") {
|
|
|
|
t.Errorf("genrule generated source not included as implicit input for fizz-buzz-dep; Implicits %#v", libfoo.Implicits.Strings())
|
|
|
|
}
|
|
|
|
|
|
|
|
libprocmacro := ctx.ModuleForTests("libprocmacro", "linux_glibc_x86_64").Rule("rustc")
|
|
|
|
if !android.SuffixInList(libprocmacro.Implicits.Strings(), "/out/bindings.rs") {
|
|
|
|
t.Errorf("rust_bindgen generated source not included as implicit input for libprocmacro; Implicits %#v", libfoo.Implicits.Strings())
|
|
|
|
}
|
|
|
|
if !android.SuffixInList(libprocmacro.Implicits.Strings(), "/out/any.rs") {
|
|
|
|
t.Errorf("genrule generated source not included as implicit input for libprocmacro; Implicits %#v", libfoo.Implicits.Strings())
|
|
|
|
}
|
2020-07-31 19:40:31 +02:00
|
|
|
|
|
|
|
// Check that our bindings are picked up as crate dependencies as well
|
|
|
|
libfooMod := ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_dylib").Module().(*Module)
|
|
|
|
if !android.InList("libbindings", libfooMod.Properties.AndroidMkRlibs) {
|
|
|
|
t.Errorf("bindgen dependency not detected as a rlib dependency (dependency missing from AndroidMkRlibs)")
|
|
|
|
}
|
|
|
|
fizzBuzzMod := ctx.ModuleForTests("fizz-buzz-dep", "android_arm64_armv8-a").Module().(*Module)
|
|
|
|
if !android.InList("libbindings", fizzBuzzMod.Properties.AndroidMkRlibs) {
|
|
|
|
t.Errorf("bindgen dependency not detected as a rlib dependency (dependency missing from AndroidMkRlibs)")
|
|
|
|
}
|
|
|
|
libprocmacroMod := ctx.ModuleForTests("libprocmacro", "linux_glibc_x86_64").Module().(*Module)
|
|
|
|
if !android.InList("libbindings", libprocmacroMod.Properties.AndroidMkRlibs) {
|
|
|
|
t.Errorf("bindgen dependency not detected as a rlib dependency (dependency missing from AndroidMkRlibs)")
|
|
|
|
}
|
|
|
|
|
2020-07-10 03:03:28 +02:00
|
|
|
}
|
|
|
|
|
2020-07-22 22:09:13 +02:00
|
|
|
func TestSourceProviderTargetMismatch(t *testing.T) {
|
|
|
|
// This might error while building the dependency tree or when calling depsToPaths() depending on the lunched
|
|
|
|
// target, which results in two different errors. So don't check the error, just confirm there is one.
|
|
|
|
testRustError(t, ".*", `
|
|
|
|
rust_proc_macro {
|
|
|
|
name: "libprocmacro",
|
|
|
|
srcs: [
|
|
|
|
"foo.rs",
|
|
|
|
":libbindings",
|
|
|
|
],
|
|
|
|
crate_name: "procmacro",
|
|
|
|
}
|
|
|
|
rust_bindgen {
|
|
|
|
name: "libbindings",
|
2020-07-31 19:40:31 +02:00
|
|
|
crate_name: "bindings",
|
|
|
|
source_stem: "bindings",
|
2020-07-22 22:09:13 +02:00
|
|
|
wrapper_src: "src/any.h",
|
|
|
|
}
|
|
|
|
`)
|
|
|
|
}
|
|
|
|
|
2019-09-24 22:23:50 +02:00
|
|
|
// Test to make sure proc_macros use host variants when building device modules.
|
|
|
|
func TestProcMacroDeviceDeps(t *testing.T) {
|
|
|
|
ctx := testRust(t, `
|
|
|
|
rust_library_host_rlib {
|
|
|
|
name: "libbar",
|
|
|
|
srcs: ["foo.rs"],
|
2019-11-01 03:38:29 +01:00
|
|
|
crate_name: "bar",
|
2019-09-24 22:23:50 +02:00
|
|
|
}
|
|
|
|
rust_proc_macro {
|
|
|
|
name: "libpm",
|
|
|
|
rlibs: ["libbar"],
|
|
|
|
srcs: ["foo.rs"],
|
2019-11-01 03:38:29 +01:00
|
|
|
crate_name: "pm",
|
2019-09-24 22:23:50 +02:00
|
|
|
}
|
|
|
|
rust_binary {
|
|
|
|
name: "fizz-buzz",
|
|
|
|
proc_macros: ["libpm"],
|
|
|
|
srcs: ["foo.rs"],
|
|
|
|
}
|
|
|
|
`)
|
|
|
|
rustc := ctx.ModuleForTests("libpm", "linux_glibc_x86_64").Rule("rustc")
|
|
|
|
|
|
|
|
if !strings.Contains(rustc.Args["libFlags"], "libbar/linux_glibc_x86_64") {
|
|
|
|
t.Errorf("Proc_macro is not using host variant of dependent modules.")
|
|
|
|
}
|
|
|
|
}
|
2019-10-31 18:44:40 +01:00
|
|
|
|
|
|
|
// Test that no_stdlibs suppresses dependencies on rust standard libraries
|
|
|
|
func TestNoStdlibs(t *testing.T) {
|
|
|
|
ctx := testRust(t, `
|
|
|
|
rust_binary {
|
|
|
|
name: "fizz-buzz",
|
|
|
|
srcs: ["foo.rs"],
|
2020-04-28 16:10:23 +02:00
|
|
|
no_stdlibs: true,
|
2019-10-31 18:44:40 +01:00
|
|
|
}`)
|
2019-11-21 01:39:12 +01:00
|
|
|
module := ctx.ModuleForTests("fizz-buzz", "android_arm64_armv8-a").Module().(*Module)
|
2019-10-31 18:44:40 +01:00
|
|
|
|
|
|
|
if android.InList("libstd", module.Properties.AndroidMkDylibs) {
|
|
|
|
t.Errorf("no_stdlibs did not suppress dependency on libstd")
|
|
|
|
}
|
|
|
|
}
|
2020-04-28 16:10:23 +02:00
|
|
|
|
|
|
|
// Test that libraries provide both 32-bit and 64-bit variants.
|
|
|
|
func TestMultilib(t *testing.T) {
|
|
|
|
ctx := testRust(t, `
|
|
|
|
rust_library_rlib {
|
|
|
|
name: "libfoo",
|
|
|
|
srcs: ["foo.rs"],
|
|
|
|
crate_name: "foo",
|
|
|
|
}`)
|
|
|
|
|
|
|
|
_ = ctx.ModuleForTests("libfoo", "android_arm64_armv8-a_rlib")
|
|
|
|
_ = ctx.ModuleForTests("libfoo", "android_arm_armv7-a-neon_rlib")
|
|
|
|
}
|