2017-07-13 23:43:27 +02:00
|
|
|
// Copyright 2017 Google Inc. All rights reserved.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package android
|
|
|
|
|
|
|
|
import (
|
|
|
|
"fmt"
|
2019-12-10 14:41:51 +01:00
|
|
|
"path/filepath"
|
2018-03-12 09:34:26 +01:00
|
|
|
"regexp"
|
2020-05-13 02:13:50 +02:00
|
|
|
"sort"
|
2017-07-13 23:43:27 +02:00
|
|
|
"strings"
|
2018-03-12 09:29:17 +01:00
|
|
|
"testing"
|
2017-07-13 23:43:27 +02:00
|
|
|
|
|
|
|
"github.com/google/blueprint"
|
|
|
|
)
|
|
|
|
|
2020-10-30 01:09:13 +01:00
|
|
|
func NewTestContext(config Config) *TestContext {
|
2017-11-30 01:47:17 +01:00
|
|
|
namespaceExportFilter := func(namespace *Namespace) bool {
|
|
|
|
return true
|
|
|
|
}
|
2017-12-02 02:10:33 +01:00
|
|
|
|
|
|
|
nameResolver := NewNameResolver(namespaceExportFilter)
|
|
|
|
ctx := &TestContext{
|
2020-10-30 01:09:13 +01:00
|
|
|
Context: &Context{blueprint.NewContext(), config},
|
2017-12-02 02:10:33 +01:00
|
|
|
NameResolver: nameResolver,
|
|
|
|
}
|
|
|
|
|
|
|
|
ctx.SetNameInterface(nameResolver)
|
2017-11-30 01:47:17 +01:00
|
|
|
|
2019-03-05 07:33:56 +01:00
|
|
|
ctx.postDeps = append(ctx.postDeps, registerPathDepsMutator)
|
|
|
|
|
2020-10-30 01:09:13 +01:00
|
|
|
ctx.SetFs(ctx.config.fs)
|
|
|
|
if ctx.config.mockBpList != "" {
|
|
|
|
ctx.SetModuleListFile(ctx.config.mockBpList)
|
|
|
|
}
|
|
|
|
|
2017-11-30 01:47:17 +01:00
|
|
|
return ctx
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
|
2020-10-30 01:09:13 +01:00
|
|
|
func NewTestArchContext(config Config) *TestContext {
|
|
|
|
ctx := NewTestContext(config)
|
2017-09-16 02:33:55 +02:00
|
|
|
ctx.preDeps = append(ctx.preDeps, registerArchMutator)
|
|
|
|
return ctx
|
|
|
|
}
|
|
|
|
|
2017-07-13 23:43:27 +02:00
|
|
|
type TestContext struct {
|
2019-02-25 23:54:28 +01:00
|
|
|
*Context
|
2020-01-16 16:12:04 +01:00
|
|
|
preArch, preDeps, postDeps, finalDeps []RegisterMutatorFunc
|
|
|
|
NameResolver *NameResolver
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (ctx *TestContext) PreArchMutators(f RegisterMutatorFunc) {
|
|
|
|
ctx.preArch = append(ctx.preArch, f)
|
|
|
|
}
|
|
|
|
|
2020-01-14 13:09:36 +01:00
|
|
|
func (ctx *TestContext) HardCodedPreArchMutators(f RegisterMutatorFunc) {
|
|
|
|
// Register mutator function as normal for testing.
|
|
|
|
ctx.PreArchMutators(f)
|
|
|
|
}
|
|
|
|
|
2017-07-13 23:43:27 +02:00
|
|
|
func (ctx *TestContext) PreDepsMutators(f RegisterMutatorFunc) {
|
|
|
|
ctx.preDeps = append(ctx.preDeps, f)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (ctx *TestContext) PostDepsMutators(f RegisterMutatorFunc) {
|
|
|
|
ctx.postDeps = append(ctx.postDeps, f)
|
|
|
|
}
|
|
|
|
|
2020-01-16 16:12:04 +01:00
|
|
|
func (ctx *TestContext) FinalDepsMutators(f RegisterMutatorFunc) {
|
|
|
|
ctx.finalDeps = append(ctx.finalDeps, f)
|
|
|
|
}
|
|
|
|
|
2020-10-30 01:09:13 +01:00
|
|
|
func (ctx *TestContext) Register() {
|
2020-01-16 16:12:04 +01:00
|
|
|
registerMutators(ctx.Context.Context, ctx.preArch, ctx.preDeps, ctx.postDeps, ctx.finalDeps)
|
2017-07-13 23:43:27 +02:00
|
|
|
|
2019-11-23 00:25:03 +01:00
|
|
|
ctx.RegisterSingletonType("env", EnvSingleton)
|
2019-12-31 03:45:15 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
func (ctx *TestContext) ParseFileList(rootDir string, filePaths []string) (deps []string, errs []error) {
|
|
|
|
// This function adapts the old style ParseFileList calls that are spread throughout the tests
|
|
|
|
// to the new style that takes a config.
|
|
|
|
return ctx.Context.ParseFileList(rootDir, filePaths, ctx.config)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (ctx *TestContext) ParseBlueprintsFiles(rootDir string) (deps []string, errs []error) {
|
|
|
|
// This function adapts the old style ParseBlueprintsFiles calls that are spread throughout the
|
|
|
|
// tests to the new style that takes a config.
|
|
|
|
return ctx.Context.ParseBlueprintsFiles(rootDir, ctx.config)
|
2019-11-23 00:25:03 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
func (ctx *TestContext) RegisterModuleType(name string, factory ModuleFactory) {
|
|
|
|
ctx.Context.RegisterModuleType(name, ModuleFactoryAdaptor(factory))
|
|
|
|
}
|
|
|
|
|
|
|
|
func (ctx *TestContext) RegisterSingletonType(name string, factory SingletonFactory) {
|
|
|
|
ctx.Context.RegisterSingletonType(name, SingletonFactoryAdaptor(factory))
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (ctx *TestContext) ModuleForTests(name, variant string) TestingModule {
|
|
|
|
var module Module
|
|
|
|
ctx.VisitAllModules(func(m blueprint.Module) {
|
|
|
|
if ctx.ModuleName(m) == name && ctx.ModuleSubDir(m) == variant {
|
|
|
|
module = m.(Module)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
if module == nil {
|
2017-09-28 02:05:30 +02:00
|
|
|
// find all the modules that do exist
|
2020-08-11 21:02:11 +02:00
|
|
|
var allModuleNames []string
|
|
|
|
var allVariants []string
|
2017-09-28 02:05:30 +02:00
|
|
|
ctx.VisitAllModules(func(m blueprint.Module) {
|
2020-08-11 21:02:11 +02:00
|
|
|
allModuleNames = append(allModuleNames, ctx.ModuleName(m))
|
|
|
|
if ctx.ModuleName(m) == name {
|
|
|
|
allVariants = append(allVariants, ctx.ModuleSubDir(m))
|
|
|
|
}
|
2017-09-28 02:05:30 +02:00
|
|
|
})
|
2020-05-13 02:13:50 +02:00
|
|
|
sort.Strings(allModuleNames)
|
2020-08-11 21:02:11 +02:00
|
|
|
sort.Strings(allVariants)
|
|
|
|
|
|
|
|
if len(allVariants) == 0 {
|
|
|
|
panic(fmt.Errorf("failed to find module %q. All modules:\n %s",
|
|
|
|
name, strings.Join(allModuleNames, "\n ")))
|
|
|
|
} else {
|
|
|
|
panic(fmt.Errorf("failed to find module %q variant %q. All variants:\n %s",
|
|
|
|
name, variant, strings.Join(allVariants, "\n ")))
|
|
|
|
}
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
return TestingModule{module}
|
|
|
|
}
|
|
|
|
|
2018-07-11 03:49:27 +02:00
|
|
|
func (ctx *TestContext) ModuleVariantsForTests(name string) []string {
|
|
|
|
var variants []string
|
|
|
|
ctx.VisitAllModules(func(m blueprint.Module) {
|
|
|
|
if ctx.ModuleName(m) == name {
|
|
|
|
variants = append(variants, ctx.ModuleSubDir(m))
|
|
|
|
}
|
|
|
|
})
|
|
|
|
return variants
|
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
// SingletonForTests returns a TestingSingleton for the singleton registered with the given name.
|
|
|
|
func (ctx *TestContext) SingletonForTests(name string) TestingSingleton {
|
|
|
|
allSingletonNames := []string{}
|
|
|
|
for _, s := range ctx.Singletons() {
|
|
|
|
n := ctx.SingletonName(s)
|
|
|
|
if n == name {
|
|
|
|
return TestingSingleton{
|
|
|
|
singleton: s.(*singletonAdaptor).Singleton,
|
|
|
|
provider: s.(testBuildProvider),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
allSingletonNames = append(allSingletonNames, n)
|
|
|
|
}
|
|
|
|
|
|
|
|
panic(fmt.Errorf("failed to find singleton %q."+
|
|
|
|
"\nall singletons: %v", name, allSingletonNames))
|
|
|
|
}
|
|
|
|
|
|
|
|
type testBuildProvider interface {
|
|
|
|
BuildParamsForTests() []BuildParams
|
|
|
|
RuleParamsForTests() map[blueprint.Rule]blueprint.RuleParams
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
type TestingBuildParams struct {
|
|
|
|
BuildParams
|
|
|
|
RuleParams blueprint.RuleParams
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
func newTestingBuildParams(provider testBuildProvider, bparams BuildParams) TestingBuildParams {
|
|
|
|
return TestingBuildParams{
|
|
|
|
BuildParams: bparams,
|
|
|
|
RuleParams: provider.RuleParamsForTests()[bparams.Rule],
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-08-27 15:50:24 +02:00
|
|
|
func maybeBuildParamsFromRule(provider testBuildProvider, rule string) (TestingBuildParams, []string) {
|
|
|
|
var searchedRules []string
|
2019-02-25 23:54:28 +01:00
|
|
|
for _, p := range provider.BuildParamsForTests() {
|
2020-08-27 15:50:24 +02:00
|
|
|
searchedRules = append(searchedRules, p.Rule.String())
|
2017-07-13 23:43:27 +02:00
|
|
|
if strings.Contains(p.Rule.String(), rule) {
|
2020-08-27 15:50:24 +02:00
|
|
|
return newTestingBuildParams(provider, p), searchedRules
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
}
|
2020-08-27 15:50:24 +02:00
|
|
|
return TestingBuildParams{}, searchedRules
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
func buildParamsFromRule(provider testBuildProvider, rule string) TestingBuildParams {
|
2020-08-27 15:50:24 +02:00
|
|
|
p, searchRules := maybeBuildParamsFromRule(provider, rule)
|
2019-01-06 07:09:19 +01:00
|
|
|
if p.Rule == nil {
|
2020-08-27 15:50:24 +02:00
|
|
|
panic(fmt.Errorf("couldn't find rule %q.\nall rules: %v", rule, searchRules))
|
2019-01-06 07:09:19 +01:00
|
|
|
}
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
func maybeBuildParamsFromDescription(provider testBuildProvider, desc string) TestingBuildParams {
|
|
|
|
for _, p := range provider.BuildParamsForTests() {
|
2019-06-11 00:15:17 +02:00
|
|
|
if strings.Contains(p.Description, desc) {
|
2019-02-25 23:54:28 +01:00
|
|
|
return newTestingBuildParams(provider, p)
|
2017-10-19 22:06:22 +02:00
|
|
|
}
|
|
|
|
}
|
2019-02-25 23:54:28 +01:00
|
|
|
return TestingBuildParams{}
|
2017-10-19 22:06:22 +02:00
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
func buildParamsFromDescription(provider testBuildProvider, desc string) TestingBuildParams {
|
|
|
|
p := maybeBuildParamsFromDescription(provider, desc)
|
2019-01-06 07:09:19 +01:00
|
|
|
if p.Rule == nil {
|
|
|
|
panic(fmt.Errorf("couldn't find description %q", desc))
|
|
|
|
}
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
func maybeBuildParamsFromOutput(provider testBuildProvider, file string) (TestingBuildParams, []string) {
|
2017-12-05 18:26:15 +01:00
|
|
|
var searchedOutputs []string
|
2019-02-25 23:54:28 +01:00
|
|
|
for _, p := range provider.BuildParamsForTests() {
|
2017-07-13 23:43:27 +02:00
|
|
|
outputs := append(WritablePaths(nil), p.Outputs...)
|
2019-03-29 23:33:06 +01:00
|
|
|
outputs = append(outputs, p.ImplicitOutputs...)
|
2017-07-13 23:43:27 +02:00
|
|
|
if p.Output != nil {
|
|
|
|
outputs = append(outputs, p.Output)
|
|
|
|
}
|
|
|
|
for _, f := range outputs {
|
2017-12-01 05:13:19 +01:00
|
|
|
if f.String() == file || f.Rel() == file {
|
2019-02-25 23:54:28 +01:00
|
|
|
return newTestingBuildParams(provider, p), nil
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
2017-12-05 18:26:15 +01:00
|
|
|
searchedOutputs = append(searchedOutputs, f.Rel())
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
|
|
|
}
|
2019-02-25 23:54:28 +01:00
|
|
|
return TestingBuildParams{}, searchedOutputs
|
2019-01-06 07:09:19 +01:00
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
func buildParamsFromOutput(provider testBuildProvider, file string) TestingBuildParams {
|
|
|
|
p, searchedOutputs := maybeBuildParamsFromOutput(provider, file)
|
2019-01-06 07:09:19 +01:00
|
|
|
if p.Rule == nil {
|
|
|
|
panic(fmt.Errorf("couldn't find output %q.\nall outputs: %v",
|
|
|
|
file, searchedOutputs))
|
|
|
|
}
|
|
|
|
return p
|
2017-07-13 23:43:27 +02:00
|
|
|
}
|
2018-03-12 09:29:17 +01:00
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
func allOutputs(provider testBuildProvider) []string {
|
2019-01-24 01:27:47 +01:00
|
|
|
var outputFullPaths []string
|
2019-02-25 23:54:28 +01:00
|
|
|
for _, p := range provider.BuildParamsForTests() {
|
2019-01-24 01:27:47 +01:00
|
|
|
outputs := append(WritablePaths(nil), p.Outputs...)
|
2019-03-29 23:33:06 +01:00
|
|
|
outputs = append(outputs, p.ImplicitOutputs...)
|
2019-01-24 01:27:47 +01:00
|
|
|
if p.Output != nil {
|
|
|
|
outputs = append(outputs, p.Output)
|
|
|
|
}
|
|
|
|
outputFullPaths = append(outputFullPaths, outputs.Strings()...)
|
|
|
|
}
|
|
|
|
return outputFullPaths
|
|
|
|
}
|
|
|
|
|
2019-02-25 23:54:28 +01:00
|
|
|
// TestingModule is wrapper around an android.Module that provides methods to find information about individual
|
|
|
|
// ctx.Build parameters for verification in tests.
|
|
|
|
type TestingModule struct {
|
|
|
|
module Module
|
|
|
|
}
|
|
|
|
|
|
|
|
// Module returns the Module wrapped by the TestingModule.
|
|
|
|
func (m TestingModule) Module() Module {
|
|
|
|
return m.module
|
|
|
|
}
|
|
|
|
|
|
|
|
// MaybeRule finds a call to ctx.Build with BuildParams.Rule set to a rule with the given name. Returns an empty
|
|
|
|
// BuildParams if no rule is found.
|
|
|
|
func (m TestingModule) MaybeRule(rule string) TestingBuildParams {
|
2020-08-27 15:50:24 +02:00
|
|
|
r, _ := maybeBuildParamsFromRule(m.module, rule)
|
|
|
|
return r
|
2019-02-25 23:54:28 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// Rule finds a call to ctx.Build with BuildParams.Rule set to a rule with the given name. Panics if no rule is found.
|
|
|
|
func (m TestingModule) Rule(rule string) TestingBuildParams {
|
|
|
|
return buildParamsFromRule(m.module, rule)
|
|
|
|
}
|
|
|
|
|
|
|
|
// MaybeDescription finds a call to ctx.Build with BuildParams.Description set to a the given string. Returns an empty
|
|
|
|
// BuildParams if no rule is found.
|
|
|
|
func (m TestingModule) MaybeDescription(desc string) TestingBuildParams {
|
|
|
|
return maybeBuildParamsFromDescription(m.module, desc)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Description finds a call to ctx.Build with BuildParams.Description set to a the given string. Panics if no rule is
|
|
|
|
// found.
|
|
|
|
func (m TestingModule) Description(desc string) TestingBuildParams {
|
|
|
|
return buildParamsFromDescription(m.module, desc)
|
|
|
|
}
|
|
|
|
|
|
|
|
// MaybeOutput finds a call to ctx.Build with a BuildParams.Output or BuildParams.Outputs whose String() or Rel()
|
|
|
|
// value matches the provided string. Returns an empty BuildParams if no rule is found.
|
|
|
|
func (m TestingModule) MaybeOutput(file string) TestingBuildParams {
|
|
|
|
p, _ := maybeBuildParamsFromOutput(m.module, file)
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
|
|
|
|
// Output finds a call to ctx.Build with a BuildParams.Output or BuildParams.Outputs whose String() or Rel()
|
|
|
|
// value matches the provided string. Panics if no rule is found.
|
|
|
|
func (m TestingModule) Output(file string) TestingBuildParams {
|
|
|
|
return buildParamsFromOutput(m.module, file)
|
|
|
|
}
|
|
|
|
|
|
|
|
// AllOutputs returns all 'BuildParams.Output's and 'BuildParams.Outputs's in their full path string forms.
|
|
|
|
func (m TestingModule) AllOutputs() []string {
|
|
|
|
return allOutputs(m.module)
|
|
|
|
}
|
|
|
|
|
|
|
|
// TestingSingleton is wrapper around an android.Singleton that provides methods to find information about individual
|
|
|
|
// ctx.Build parameters for verification in tests.
|
|
|
|
type TestingSingleton struct {
|
|
|
|
singleton Singleton
|
|
|
|
provider testBuildProvider
|
|
|
|
}
|
|
|
|
|
|
|
|
// Singleton returns the Singleton wrapped by the TestingSingleton.
|
|
|
|
func (s TestingSingleton) Singleton() Singleton {
|
|
|
|
return s.singleton
|
|
|
|
}
|
|
|
|
|
|
|
|
// MaybeRule finds a call to ctx.Build with BuildParams.Rule set to a rule with the given name. Returns an empty
|
|
|
|
// BuildParams if no rule is found.
|
|
|
|
func (s TestingSingleton) MaybeRule(rule string) TestingBuildParams {
|
2020-08-27 15:50:24 +02:00
|
|
|
r, _ := maybeBuildParamsFromRule(s.provider, rule)
|
|
|
|
return r
|
2019-02-25 23:54:28 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
// Rule finds a call to ctx.Build with BuildParams.Rule set to a rule with the given name. Panics if no rule is found.
|
|
|
|
func (s TestingSingleton) Rule(rule string) TestingBuildParams {
|
|
|
|
return buildParamsFromRule(s.provider, rule)
|
|
|
|
}
|
|
|
|
|
|
|
|
// MaybeDescription finds a call to ctx.Build with BuildParams.Description set to a the given string. Returns an empty
|
|
|
|
// BuildParams if no rule is found.
|
|
|
|
func (s TestingSingleton) MaybeDescription(desc string) TestingBuildParams {
|
|
|
|
return maybeBuildParamsFromDescription(s.provider, desc)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Description finds a call to ctx.Build with BuildParams.Description set to a the given string. Panics if no rule is
|
|
|
|
// found.
|
|
|
|
func (s TestingSingleton) Description(desc string) TestingBuildParams {
|
|
|
|
return buildParamsFromDescription(s.provider, desc)
|
|
|
|
}
|
|
|
|
|
|
|
|
// MaybeOutput finds a call to ctx.Build with a BuildParams.Output or BuildParams.Outputs whose String() or Rel()
|
|
|
|
// value matches the provided string. Returns an empty BuildParams if no rule is found.
|
|
|
|
func (s TestingSingleton) MaybeOutput(file string) TestingBuildParams {
|
|
|
|
p, _ := maybeBuildParamsFromOutput(s.provider, file)
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
|
|
|
|
// Output finds a call to ctx.Build with a BuildParams.Output or BuildParams.Outputs whose String() or Rel()
|
|
|
|
// value matches the provided string. Panics if no rule is found.
|
|
|
|
func (s TestingSingleton) Output(file string) TestingBuildParams {
|
|
|
|
return buildParamsFromOutput(s.provider, file)
|
|
|
|
}
|
|
|
|
|
|
|
|
// AllOutputs returns all 'BuildParams.Output's and 'BuildParams.Outputs's in their full path string forms.
|
|
|
|
func (s TestingSingleton) AllOutputs() []string {
|
|
|
|
return allOutputs(s.provider)
|
|
|
|
}
|
|
|
|
|
2018-03-12 09:29:17 +01:00
|
|
|
func FailIfErrored(t *testing.T, errs []error) {
|
|
|
|
t.Helper()
|
|
|
|
if len(errs) > 0 {
|
|
|
|
for _, err := range errs {
|
|
|
|
t.Error(err)
|
|
|
|
}
|
|
|
|
t.FailNow()
|
|
|
|
}
|
|
|
|
}
|
2018-03-12 09:34:26 +01:00
|
|
|
|
|
|
|
func FailIfNoMatchingErrors(t *testing.T, pattern string, errs []error) {
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
matcher, err := regexp.Compile(pattern)
|
|
|
|
if err != nil {
|
|
|
|
t.Errorf("failed to compile regular expression %q because %s", pattern, err)
|
|
|
|
}
|
|
|
|
|
|
|
|
found := false
|
|
|
|
for _, err := range errs {
|
|
|
|
if matcher.FindStringIndex(err.Error()) != nil {
|
|
|
|
found = true
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if !found {
|
|
|
|
t.Errorf("missing the expected error %q (checked %d error(s))", pattern, len(errs))
|
|
|
|
for i, err := range errs {
|
Reland: Deduplicate APEX variants that would build identically
APEX variants that share the same SDK version and updatability
almost always use identical command line arguments to build but
with different intermediates directories. This causes unnecessary
build time and disk space for duplicated work.
Deduplicate APEX variants that would build identically. Create
aliases from the per-APEX variations to the new shared variations
so that the APEX modules can continue to depend on them via the
APEX name as the variation.
This has one significant change in behavior. Before this change,
if an APEX had two libraries in its direct dependencies and one
of those libraries depended on the other, and the second library
had stubs, then the first library would depend on the implementation
of the second library and not the stubs. After this change, if
the first library is also present in a second APEX but the second
library is not, then the common variant shared between the two
APEXes would use the stubs, not the implementation.
In a correctly configured set of build rules this change will
be irrelevant, because if the compilation worked for the second
APEX using stubs then it will work for the common variant using
stubs. However, if an incorrect change to the build rules is
made this could lead to confusing errors, as a previously-working
common variant could suddenly stop building when a module is added
to a new APEX without its dependencies that require implementation
APIs to compile.
This change reduces the number of modules in an AOSP arm64-userdebug
build by 3% (52242 to 50586), reduces the number of variants of the
libcutils module from 74 to 53, and reduces the number of variants
of the massive libart[d] modules from 44 to 32.
This relands I0529837476a253c32b3dfb98dcccf107427c742c with a fix
to always mark permissions XML files of java_sdk_library modules as
unique per apex since they contain the APEX filename, and a fix
to UpdateUniqueApexVariationsForDeps to check ApexInfo.InApexes
instead of DepIsInSameApex to check if two modules are in the same
apex to account for a module that depends on another in a way that
doesn't normally include the dependency in the APEX (e.g. a libs
property), but the dependency is directly included in the APEX.
Bug: 164216768
Test: go test ./build/soong/apex/...
Change-Id: I2ae170601f764e5b88d0be2e0e6adc84e3a4d9cc
2020-08-11 21:17:01 +02:00
|
|
|
t.Errorf("errs[%d] = %q", i, err)
|
2018-03-12 09:34:26 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2019-04-04 00:47:29 +02:00
|
|
|
|
2019-08-05 16:07:57 +02:00
|
|
|
func CheckErrorsAgainstExpectations(t *testing.T, errs []error, expectedErrorPatterns []string) {
|
|
|
|
t.Helper()
|
|
|
|
|
|
|
|
if expectedErrorPatterns == nil {
|
|
|
|
FailIfErrored(t, errs)
|
|
|
|
} else {
|
|
|
|
for _, expectedError := range expectedErrorPatterns {
|
|
|
|
FailIfNoMatchingErrors(t, expectedError, errs)
|
|
|
|
}
|
|
|
|
if len(errs) > len(expectedErrorPatterns) {
|
|
|
|
t.Errorf("additional errors found, expected %d, found %d",
|
|
|
|
len(expectedErrorPatterns), len(errs))
|
|
|
|
for i, expectedError := range expectedErrorPatterns {
|
|
|
|
t.Errorf("expectedErrors[%d] = %s", i, expectedError)
|
|
|
|
}
|
|
|
|
for i, err := range errs {
|
|
|
|
t.Errorf("errs[%d] = %s", i, err)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
2020-03-04 21:15:08 +01:00
|
|
|
func SetInMakeForTests(config Config) {
|
|
|
|
config.inMake = true
|
|
|
|
}
|
|
|
|
|
2019-12-03 05:24:29 +01:00
|
|
|
func AndroidMkEntriesForTest(t *testing.T, config Config, bpPath string, mod blueprint.Module) []AndroidMkEntries {
|
2019-04-04 00:47:29 +02:00
|
|
|
var p AndroidMkEntriesProvider
|
|
|
|
var ok bool
|
|
|
|
if p, ok = mod.(AndroidMkEntriesProvider); !ok {
|
2019-07-23 17:53:32 +02:00
|
|
|
t.Errorf("module does not implement AndroidMkEntriesProvider: " + mod.Name())
|
2019-04-04 00:47:29 +02:00
|
|
|
}
|
2019-12-03 05:24:29 +01:00
|
|
|
|
|
|
|
entriesList := p.AndroidMkEntries()
|
|
|
|
for i, _ := range entriesList {
|
|
|
|
entriesList[i].fillInEntries(config, bpPath, mod)
|
|
|
|
}
|
|
|
|
return entriesList
|
2019-04-04 00:47:29 +02:00
|
|
|
}
|
2019-07-11 09:18:47 +02:00
|
|
|
|
|
|
|
func AndroidMkDataForTest(t *testing.T, config Config, bpPath string, mod blueprint.Module) AndroidMkData {
|
|
|
|
var p AndroidMkDataProvider
|
|
|
|
var ok bool
|
|
|
|
if p, ok = mod.(AndroidMkDataProvider); !ok {
|
2019-07-23 17:53:32 +02:00
|
|
|
t.Errorf("module does not implement AndroidMkDataProvider: " + mod.Name())
|
2019-07-11 09:18:47 +02:00
|
|
|
}
|
|
|
|
data := p.AndroidMk()
|
|
|
|
data.fillInData(config, bpPath, mod)
|
|
|
|
return data
|
|
|
|
}
|
2019-12-10 14:41:51 +01:00
|
|
|
|
|
|
|
// Normalize the path for testing.
|
|
|
|
//
|
|
|
|
// If the path is relative to the build directory then return the relative path
|
|
|
|
// to avoid tests having to deal with the dynamically generated build directory.
|
|
|
|
//
|
|
|
|
// Otherwise, return the supplied path as it is almost certainly a source path
|
|
|
|
// that is relative to the root of the source tree.
|
|
|
|
//
|
|
|
|
// The build and source paths should be distinguishable based on their contents.
|
|
|
|
func NormalizePathForTesting(path Path) string {
|
|
|
|
p := path.String()
|
|
|
|
if w, ok := path.(WritablePath); ok {
|
|
|
|
rel, err := filepath.Rel(w.buildDir(), p)
|
|
|
|
if err != nil {
|
|
|
|
panic(err)
|
|
|
|
}
|
|
|
|
return rel
|
|
|
|
}
|
|
|
|
return p
|
|
|
|
}
|
|
|
|
|
|
|
|
func NormalizePathsForTesting(paths Paths) []string {
|
|
|
|
var result []string
|
|
|
|
for _, path := range paths {
|
|
|
|
relative := NormalizePathForTesting(path)
|
|
|
|
result = append(result, relative)
|
|
|
|
}
|
|
|
|
return result
|
|
|
|
}
|