2017-07-14 01:23:21 +02:00
// Copyright 2017 Google Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package java
import (
"io/ioutil"
"os"
"path/filepath"
2019-06-15 03:51:47 +02:00
"reflect"
2020-05-26 19:13:57 +02:00
"regexp"
2017-11-02 21:28:15 +01:00
"strconv"
2017-07-14 01:23:21 +02:00
"strings"
"testing"
2018-05-29 23:44:55 +02:00
2019-11-11 02:46:36 +01:00
"github.com/google/blueprint/proptools"
2018-10-03 07:03:40 +02:00
"android/soong/android"
"android/soong/cc"
2019-02-25 23:20:47 +01:00
"android/soong/dexpreopt"
2018-10-03 07:03:40 +02:00
"android/soong/genrule"
2020-06-13 01:38:45 +02:00
"android/soong/python"
2017-07-14 01:23:21 +02:00
)
var buildDir string
func setUp ( ) {
var err error
buildDir , err = ioutil . TempDir ( "" , "soong_java_test" )
if err != nil {
panic ( err )
}
}
func tearDown ( ) {
os . RemoveAll ( buildDir )
}
func TestMain ( m * testing . M ) {
run := func ( ) int {
setUp ( )
defer tearDown ( )
return m . Run ( )
}
os . Exit ( run ( ) )
}
2017-12-01 07:56:16 +01:00
2019-12-14 05:41:13 +01:00
func testConfig ( env map [ string ] string , bp string , fs map [ string ] [ ] byte ) android . Config {
2020-01-11 01:37:30 +01:00
bp += dexpreopt . BpToolModulesForTest ( )
2020-01-10 21:32:59 +01:00
config := TestConfig ( buildDir , env , bp , fs )
// Set up the global Once cache used for dexpreopt.GlobalSoongConfig, so that
// it doesn't create a real one, which would fail.
_ = dexpreopt . GlobalSoongConfigForTests ( config )
return config
2017-09-30 02:58:17 +02:00
}
2019-12-14 05:41:13 +01:00
func testContext ( ) * android . TestContext {
2017-07-14 01:23:21 +02:00
2017-09-16 02:36:05 +02:00
ctx := android . NewTestArchContext ( )
2019-12-18 20:51:55 +01:00
RegisterJavaBuildComponents ( ctx )
RegisterAppBuildComponents ( ctx )
RegisterAARBuildComponents ( ctx )
2019-12-19 11:28:56 +01:00
RegisterGenRuleBuildComponents ( ctx )
2019-12-19 12:18:54 +01:00
RegisterSystemModulesBuildComponents ( ctx )
2019-11-23 00:25:03 +01:00
ctx . RegisterModuleType ( "java_plugin" , PluginFactory )
ctx . RegisterModuleType ( "filegroup" , android . FileGroupFactory )
ctx . RegisterModuleType ( "genrule" , genrule . GenRuleFactory )
2020-06-13 01:38:45 +02:00
ctx . RegisterModuleType ( "python_binary_host" , python . PythonBinaryHostFactory )
2019-12-19 11:21:09 +01:00
RegisterDocsBuildComponents ( ctx )
RegisterStubsBuildComponents ( ctx )
2019-12-19 12:18:54 +01:00
RegisterSdkLibraryBuildComponents ( ctx )
2017-07-07 23:35:50 +02:00
ctx . PreArchMutators ( android . RegisterDefaultsPreArchMutators )
2020-06-26 21:17:02 +02:00
ctx . PreArchMutators ( android . RegisterComponentsMutator )
2019-12-19 12:25:19 +01:00
RegisterPrebuiltApisBuildComponents ( ctx )
2020-06-13 01:38:45 +02:00
ctx . PreDepsMutators ( python . RegisterPythonPreDepsMutators )
2019-05-11 00:16:29 +02:00
ctx . PostDepsMutators ( android . RegisterOverridePostDepsMutators )
2017-11-23 01:19:37 +01:00
ctx . RegisterPreSingletonType ( "overlay" , android . SingletonFactoryAdaptor ( OverlaySingletonFactory ) )
2019-04-18 19:56:44 +02:00
ctx . RegisterPreSingletonType ( "sdk_versions" , android . SingletonFactoryAdaptor ( sdkPreSingletonFactory ) )
2018-10-03 07:03:40 +02:00
2020-07-30 17:04:17 +02:00
android . RegisterPrebuiltMutators ( ctx )
2018-10-03 07:03:40 +02:00
// Register module types and mutators from cc needed for JNI testing
2019-12-19 17:01:36 +01:00
cc . RegisterRequiredBuildComponentsForTest ( ctx )
2018-10-03 07:03:40 +02:00
2020-01-11 01:37:30 +01:00
dexpreopt . RegisterToolModulesForTest ( ctx )
2017-12-01 07:56:16 +01:00
return ctx
}
func run ( t * testing . T , ctx * android . TestContext , config android . Config ) {
2017-12-05 22:42:45 +01:00
t . Helper ( )
2019-02-25 23:20:47 +01:00
2019-12-14 05:41:13 +01:00
pathCtx := android . PathContextForTesting ( config )
2020-01-20 19:12:23 +01:00
dexpreopt . SetTestGlobalConfig ( config , dexpreopt . GlobalConfigForTests ( pathCtx ) )
2019-02-25 23:20:47 +01:00
2019-12-14 05:41:13 +01:00
ctx . Register ( config )
2019-06-11 12:58:30 +02:00
_ , errs := ctx . ParseBlueprintsFiles ( "Android.bp" )
2018-03-12 09:29:17 +01:00
android . FailIfErrored ( t , errs )
2017-07-14 01:23:21 +02:00
_ , errs = ctx . PrepareBuildActions ( config )
2018-03-12 09:29:17 +01:00
android . FailIfErrored ( t , errs )
2017-12-01 07:56:16 +01:00
}
2019-10-29 07:44:45 +01:00
func testJavaError ( t * testing . T , pattern string , bp string ) ( * android . TestContext , android . Config ) {
t . Helper ( )
2019-12-14 05:41:13 +01:00
return testJavaErrorWithConfig ( t , pattern , testConfig ( nil , bp , nil ) )
2019-10-29 07:44:45 +01:00
}
2019-12-14 05:41:13 +01:00
func testJavaErrorWithConfig ( t * testing . T , pattern string , config android . Config ) ( * android . TestContext , android . Config ) {
2019-07-11 08:54:27 +02:00
t . Helper ( )
2019-12-14 05:41:13 +01:00
ctx := testContext ( )
2019-07-11 08:54:27 +02:00
2019-12-14 05:41:13 +01:00
pathCtx := android . PathContextForTesting ( config )
2020-01-20 19:12:23 +01:00
dexpreopt . SetTestGlobalConfig ( config , dexpreopt . GlobalConfigForTests ( pathCtx ) )
2019-07-11 08:54:27 +02:00
2019-12-14 05:41:13 +01:00
ctx . Register ( config )
2019-07-11 08:54:27 +02:00
_ , errs := ctx . ParseBlueprintsFiles ( "Android.bp" )
if len ( errs ) > 0 {
android . FailIfNoMatchingErrors ( t , pattern , errs )
2019-10-29 07:44:45 +01:00
return ctx , config
2019-07-11 08:54:27 +02:00
}
_ , errs = ctx . PrepareBuildActions ( config )
if len ( errs ) > 0 {
android . FailIfNoMatchingErrors ( t , pattern , errs )
2019-10-29 07:44:45 +01:00
return ctx , config
2019-07-11 08:54:27 +02:00
}
t . Fatalf ( "missing expected error %q (0 errors are returned)" , pattern )
2019-10-29 07:44:45 +01:00
return ctx , config
2019-07-11 08:54:27 +02:00
}
2020-06-08 01:58:18 +02:00
func testJavaWithFS ( t * testing . T , bp string , fs map [ string ] [ ] byte ) ( * android . TestContext , android . Config ) {
t . Helper ( )
return testJavaWithConfig ( t , testConfig ( nil , bp , fs ) )
}
2019-07-17 20:15:09 +02:00
func testJava ( t * testing . T , bp string ) ( * android . TestContext , android . Config ) {
2017-12-05 22:42:45 +01:00
t . Helper ( )
2020-06-08 01:58:18 +02:00
return testJavaWithFS ( t , bp , nil )
2019-10-29 07:44:45 +01:00
}
2019-12-14 05:41:13 +01:00
func testJavaWithConfig ( t * testing . T , config android . Config ) ( * android . TestContext , android . Config ) {
2019-10-29 07:44:45 +01:00
t . Helper ( )
2019-12-14 05:41:13 +01:00
ctx := testContext ( )
2017-12-01 07:56:16 +01:00
run ( t , ctx , config )
2017-07-14 01:23:21 +02:00
2019-07-17 20:15:09 +02:00
return ctx , config
2017-07-14 01:23:21 +02:00
}
2017-09-16 04:44:24 +02:00
func moduleToPath ( name string ) string {
switch {
case name == ` "" ` :
return name
2017-09-19 02:41:52 +02:00
case strings . HasSuffix ( name , ".jar" ) :
return name
2017-10-19 22:06:22 +02:00
default :
return filepath . Join ( buildDir , ".intermediates" , name , "android_common" , "turbine-combined" , name + ".jar" )
2017-09-16 04:44:24 +02:00
}
}
2019-12-06 16:16:24 +01:00
func TestJavaLinkType ( t * testing . T ) {
testJava ( t , `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
libs : [ "bar" ] ,
static_libs : [ "baz" ] ,
}
java_library {
name : "bar" ,
sdk_version : "current" ,
srcs : [ "b.java" ] ,
}
java_library {
name : "baz" ,
sdk_version : "system_current" ,
srcs : [ "c.java" ] ,
}
` )
testJavaError ( t , "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source." , `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
libs : [ "bar" ] ,
sdk_version : "current" ,
static_libs : [ "baz" ] ,
}
java_library {
name : "bar" ,
sdk_version : "current" ,
srcs : [ "b.java" ] ,
}
java_library {
name : "baz" ,
sdk_version : "system_current" ,
srcs : [ "c.java" ] ,
}
` )
testJava ( t , `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
libs : [ "bar" ] ,
sdk_version : "system_current" ,
static_libs : [ "baz" ] ,
}
java_library {
name : "bar" ,
sdk_version : "current" ,
srcs : [ "b.java" ] ,
}
java_library {
name : "baz" ,
sdk_version : "system_current" ,
srcs : [ "c.java" ] ,
}
` )
testJavaError ( t , "Adjust sdk_version: property of the source or target module so that target module is built with the same or smaller API set than the source." , `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
libs : [ "bar" ] ,
sdk_version : "system_current" ,
static_libs : [ "baz" ] ,
}
java_library {
name : "bar" ,
sdk_version : "current" ,
srcs : [ "b.java" ] ,
}
java_library {
name : "baz" ,
srcs : [ "c.java" ] ,
}
` )
}
2017-07-14 01:23:21 +02:00
func TestSimple ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-07-14 01:23:21 +02:00
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
2017-07-19 20:22:16 +02:00
libs : [ "bar" ] ,
static_libs : [ "baz" ] ,
2017-07-14 01:23:21 +02:00
}
java_library {
name : "bar" ,
srcs : [ "b.java" ] ,
}
java_library {
name : "baz" ,
srcs : [ "c.java" ] ,
}
2017-10-02 22:55:26 +02:00
` )
2017-07-14 01:23:21 +02:00
2017-09-16 02:36:05 +02:00
javac := ctx . ModuleForTests ( "foo" , "android_common" ) . Rule ( "javac" )
2017-10-19 22:06:22 +02:00
combineJar := ctx . ModuleForTests ( "foo" , "android_common" ) . Description ( "for javac" )
2017-07-14 01:23:21 +02:00
if len ( javac . Inputs ) != 1 || javac . Inputs [ 0 ] . String ( ) != "a.java" {
t . Errorf ( ` foo inputs %v != ["a.java"] ` , javac . Inputs )
}
2017-10-18 23:44:18 +02:00
baz := ctx . ModuleForTests ( "baz" , "android_common" ) . Rule ( "javac" ) . Output . String ( )
2017-10-19 22:06:22 +02:00
barTurbine := filepath . Join ( buildDir , ".intermediates" , "bar" , "android_common" , "turbine-combined" , "bar.jar" )
bazTurbine := filepath . Join ( buildDir , ".intermediates" , "baz" , "android_common" , "turbine-combined" , "baz.jar" )
2017-08-30 23:24:55 +02:00
2017-10-19 22:06:22 +02:00
if ! strings . Contains ( javac . Args [ "classpath" ] , barTurbine ) {
t . Errorf ( "foo classpath %v does not contain %q" , javac . Args [ "classpath" ] , barTurbine )
2017-07-14 01:23:21 +02:00
}
2017-10-19 22:06:22 +02:00
if ! strings . Contains ( javac . Args [ "classpath" ] , bazTurbine ) {
t . Errorf ( "foo classpath %v does not contain %q" , javac . Args [ "classpath" ] , bazTurbine )
2017-08-30 23:24:55 +02:00
}
if len ( combineJar . Inputs ) != 2 || combineJar . Inputs [ 1 ] . String ( ) != baz {
t . Errorf ( "foo combineJar inputs %v does not contain %q" , combineJar . Inputs , baz )
2017-07-14 01:23:21 +02:00
}
}
2019-11-26 19:08:34 +01:00
func TestExportedPlugins ( t * testing . T ) {
type Result struct {
library string
processors string
}
var tests = [ ] struct {
name string
extra string
results [ ] Result
} {
{
name : "Exported plugin is not a direct plugin" ,
extra : ` java_library { name: "exports", srcs: ["a.java"], exported_plugins: ["plugin"] } ` ,
results : [ ] Result { { library : "exports" , processors : "-proc:none" } } ,
} ,
{
name : "Exports plugin to dependee" ,
extra : `
java_library { name : "exports" , exported_plugins : [ "plugin" ] }
java_library { name : "foo" , srcs : [ "a.java" ] , libs : [ "exports" ] }
java_library { name : "bar" , srcs : [ "a.java" ] , static_libs : [ "exports" ] }
` ,
results : [ ] Result {
{ library : "foo" , processors : "-processor com.android.TestPlugin" } ,
{ library : "bar" , processors : "-processor com.android.TestPlugin" } ,
} ,
} ,
{
name : "Exports plugin to android_library" ,
extra : `
java_library { name : "exports" , exported_plugins : [ "plugin" ] }
android_library { name : "foo" , srcs : [ "a.java" ] , libs : [ "exports" ] }
android_library { name : "bar" , srcs : [ "a.java" ] , static_libs : [ "exports" ] }
` ,
results : [ ] Result {
{ library : "foo" , processors : "-processor com.android.TestPlugin" } ,
{ library : "bar" , processors : "-processor com.android.TestPlugin" } ,
} ,
} ,
{
name : "Exports plugin is not propagated via transitive deps" ,
extra : `
java_library { name : "exports" , exported_plugins : [ "plugin" ] }
java_library { name : "foo" , srcs : [ "a.java" ] , libs : [ "exports" ] }
java_library { name : "bar" , srcs : [ "a.java" ] , static_libs : [ "foo" ] }
` ,
results : [ ] Result {
{ library : "foo" , processors : "-processor com.android.TestPlugin" } ,
{ library : "bar" , processors : "-proc:none" } ,
} ,
} ,
{
name : "Exports plugin appends to plugins" ,
extra : `
java_plugin { name : "plugin2" , processor_class : "com.android.TestPlugin2" }
java_library { name : "exports" , exported_plugins : [ "plugin" ] }
java_library { name : "foo" , srcs : [ "a.java" ] , libs : [ "exports" ] , plugins : [ "plugin2" ] }
` ,
results : [ ] Result {
{ library : "foo" , processors : "-processor com.android.TestPlugin,com.android.TestPlugin2" } ,
} ,
} ,
}
for _ , test := range tests {
t . Run ( test . name , func ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_plugin {
name : "plugin" ,
processor_class : "com.android.TestPlugin" ,
}
` + test . extra )
for _ , want := range test . results {
javac := ctx . ModuleForTests ( want . library , "android_common" ) . Rule ( "javac" )
if javac . Args [ "processor" ] != want . processors {
t . Errorf ( "For library %v, expected %v, found %v" , want . library , want . processors , javac . Args [ "processor" ] )
}
}
} )
}
}
2019-10-29 07:44:45 +01:00
func TestSdkVersionByPartition ( t * testing . T ) {
testJavaError ( t , "sdk_version must have a value when the module is located at vendor or product" , `
2019-06-25 09:26:18 +02:00
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
vendor : true ,
}
2019-10-29 07:44:45 +01:00
` )
2019-06-25 09:26:18 +02:00
2019-10-29 07:44:45 +01:00
testJava ( t , `
2019-06-25 09:26:18 +02:00
java_library {
name : "bar" ,
srcs : [ "b.java" ] ,
}
` )
2019-10-29 07:44:45 +01:00
for _ , enforce := range [ ] bool { true , false } {
bp := `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
product_specific : true ,
}
`
2019-12-14 05:41:13 +01:00
config := testConfig ( nil , bp , nil )
config . TestProductVariables . EnforceProductPartitionInterface = proptools . BoolPtr ( enforce )
2019-10-29 07:44:45 +01:00
if enforce {
2019-12-14 05:41:13 +01:00
testJavaErrorWithConfig ( t , "sdk_version must have a value when the module is located at vendor or product" , config )
2019-10-29 07:44:45 +01:00
} else {
2019-12-14 05:41:13 +01:00
testJavaWithConfig ( t , config )
2019-10-29 07:44:45 +01:00
}
2019-06-25 09:26:18 +02:00
}
}
2017-10-02 22:55:26 +02:00
func TestArchSpecific ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-10-02 22:55:26 +02:00
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
target : {
android : {
srcs : [ "b.java" ] ,
} ,
} ,
}
` )
javac := ctx . ModuleForTests ( "foo" , "android_common" ) . Rule ( "javac" )
if len ( javac . Inputs ) != 2 || javac . Inputs [ 0 ] . String ( ) != "a.java" || javac . Inputs [ 1 ] . String ( ) != "b.java" {
t . Errorf ( ` foo inputs %v != ["a.java", "b.java"] ` , javac . Inputs )
}
}
2017-12-05 22:42:45 +01:00
func TestBinary ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-12-05 22:42:45 +01:00
java_library_host {
name : "foo" ,
srcs : [ "a.java" ] ,
}
java_binary_host {
name : "bar" ,
srcs : [ "b.java" ] ,
static_libs : [ "foo" ] ,
}
` )
buildOS := android . BuildOs . String ( )
bar := ctx . ModuleForTests ( "bar" , buildOS + "_common" )
barJar := bar . Output ( "bar.jar" ) . Output . String ( )
barWrapper := ctx . ModuleForTests ( "bar" , buildOS + "_x86_64" )
barWrapperDeps := barWrapper . Output ( "bar" ) . Implicits . Strings ( )
// Test that the install binary wrapper depends on the installed jar file
if len ( barWrapperDeps ) != 1 || barWrapperDeps [ 0 ] != barJar {
t . Errorf ( "expected binary wrapper implicits [%q], got %v" ,
barJar , barWrapperDeps )
}
2020-06-10 02:23:08 +02:00
}
func TestHostBinaryNoJavaDebugInfoOverride ( t * testing . T ) {
bp := `
java_library {
name : "target_library" ,
srcs : [ "a.java" ] ,
}
java_binary_host {
name : "host_binary" ,
srcs : [ "b.java" ] ,
}
`
config := testConfig ( nil , bp , nil )
config . TestProductVariables . MinimizeJavaDebugInfo = proptools . BoolPtr ( true )
ctx , _ := testJavaWithConfig ( t , config )
2020-07-28 22:27:34 +02:00
// first, check that the -g flag is added to target modules
2020-06-10 02:23:08 +02:00
targetLibrary := ctx . ModuleForTests ( "target_library" , "android_common" )
targetJavaFlags := targetLibrary . Module ( ) . VariablesForTests ( ) [ "javacFlags" ]
if ! strings . Contains ( targetJavaFlags , "-g:source,lines" ) {
t . Errorf ( "target library javac flags %v should contain " +
"-g:source,lines override with MinimizeJavaDebugInfo" , targetJavaFlags )
}
2017-12-05 22:42:45 +01:00
2020-06-10 02:23:08 +02:00
// check that -g is not overridden for host modules
buildOS := android . BuildOs . String ( )
hostBinary := ctx . ModuleForTests ( "host_binary" , buildOS + "_common" )
hostJavaFlags := hostBinary . Module ( ) . VariablesForTests ( ) [ "javacFlags" ]
if strings . Contains ( hostJavaFlags , "-g:source,lines" ) {
t . Errorf ( "java_binary_host javac flags %v should not have " +
"-g:source,lines override with MinimizeJavaDebugInfo" , hostJavaFlags )
}
2017-12-05 22:42:45 +01:00
}
2017-07-14 01:23:21 +02:00
func TestPrebuilts ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-07-14 01:23:21 +02:00
java_library {
name : "foo" ,
2019-11-12 20:39:36 +01:00
srcs : [ "a.java" , ":stubs-source" ] ,
2020-01-31 18:54:30 +01:00
libs : [ "bar" , "sdklib" ] ,
2017-07-19 20:22:16 +02:00
static_libs : [ "baz" ] ,
2017-07-14 01:23:21 +02:00
}
2017-08-02 20:05:49 +02:00
java_import {
2017-07-14 01:23:21 +02:00
name : "bar" ,
2017-08-02 20:05:49 +02:00
jars : [ "a.jar" ] ,
2017-07-14 01:23:21 +02:00
}
2017-08-02 20:05:49 +02:00
java_import {
2017-07-14 01:23:21 +02:00
name : "baz" ,
2017-08-02 20:05:49 +02:00
jars : [ "b.jar" ] ,
2020-08-06 00:40:41 +02:00
sdk_version : "current" ,
compile_dex : true ,
2017-07-14 01:23:21 +02:00
}
2019-02-22 03:12:14 +01:00
dex_import {
name : "qux" ,
jars : [ "b.jar" ] ,
}
2019-04-17 20:11:46 +02:00
2020-01-31 14:36:25 +01:00
java_sdk_library_import {
name : "sdklib" ,
public : {
jars : [ "c.jar" ] ,
} ,
}
2019-11-12 20:39:36 +01:00
prebuilt_stubs_sources {
name : "stubs-source" ,
2019-12-10 14:41:51 +01:00
srcs : [ "stubs/sources" ] ,
2019-11-12 20:39:36 +01:00
}
2019-12-03 19:06:47 +01:00
java_test_import {
name : "test" ,
jars : [ "a.jar" ] ,
test_suites : [ "cts" ] ,
test_config : "AndroidTest.xml" ,
}
2017-07-14 01:23:21 +02:00
` )
2019-12-10 14:41:51 +01:00
fooModule := ctx . ModuleForTests ( "foo" , "android_common" )
javac := fooModule . Rule ( "javac" )
2017-10-19 22:06:22 +02:00
combineJar := ctx . ModuleForTests ( "foo" , "android_common" ) . Description ( "for javac" )
2020-08-06 00:40:41 +02:00
barModule := ctx . ModuleForTests ( "bar" , "android_common" )
barJar := barModule . Rule ( "combineJar" ) . Output
bazModule := ctx . ModuleForTests ( "baz" , "android_common" )
bazJar := bazModule . Rule ( "combineJar" ) . Output
2019-04-17 20:11:46 +02:00
sdklibStubsJar := ctx . ModuleForTests ( "sdklib.stubs" , "android_common" ) . Rule ( "combineJar" ) . Output
2017-07-14 01:23:21 +02:00
2019-12-10 14:41:51 +01:00
fooLibrary := fooModule . Module ( ) . ( * Library )
assertDeepEquals ( t , "foo java sources incorrect" ,
[ ] string { "a.java" } , fooLibrary . compiledJavaSrcs . Strings ( ) )
2019-11-12 20:39:36 +01:00
2019-12-10 14:41:51 +01:00
assertDeepEquals ( t , "foo java source jars incorrect" ,
[ ] string { ".intermediates/stubs-source/android_common/stubs-source-stubs.srcjar" } ,
android . NormalizePathsForTesting ( fooLibrary . compiledSrcJars ) )
2019-11-12 20:39:36 +01:00
2018-07-12 21:28:41 +02:00
if ! strings . Contains ( javac . Args [ "classpath" ] , barJar . String ( ) ) {
t . Errorf ( "foo classpath %v does not contain %q" , javac . Args [ "classpath" ] , barJar . String ( ) )
2017-07-14 01:23:21 +02:00
}
2020-08-06 00:40:41 +02:00
barDexJar := barModule . Module ( ) . ( * Import ) . DexJarBuildPath ( )
if barDexJar != nil {
t . Errorf ( "bar dex jar build path expected to be nil, got %q" , barDexJar )
}
2019-04-17 20:11:46 +02:00
if ! strings . Contains ( javac . Args [ "classpath" ] , sdklibStubsJar . String ( ) ) {
t . Errorf ( "foo classpath %v does not contain %q" , javac . Args [ "classpath" ] , sdklibStubsJar . String ( ) )
}
2018-07-12 21:28:41 +02:00
if len ( combineJar . Inputs ) != 2 || combineJar . Inputs [ 1 ] . String ( ) != bazJar . String ( ) {
t . Errorf ( "foo combineJar inputs %v does not contain %q" , combineJar . Inputs , bazJar . String ( ) )
2017-07-14 01:23:21 +02:00
}
2019-02-22 03:12:14 +01:00
2020-08-06 00:40:41 +02:00
bazDexJar := bazModule . Module ( ) . ( * Import ) . DexJarBuildPath ( ) . String ( )
expectedDexJar := buildDir + "/.intermediates/baz/android_common/dex/baz.jar"
if bazDexJar != expectedDexJar {
t . Errorf ( "baz dex jar build path expected %q, got %q" , expectedDexJar , bazDexJar )
}
2019-02-22 03:12:14 +01:00
ctx . ModuleForTests ( "qux" , "android_common" ) . Rule ( "Cp" )
2017-07-14 01:23:21 +02:00
}
2019-12-10 14:41:51 +01:00
func assertDeepEquals ( t * testing . T , message string , expected interface { } , actual interface { } ) {
if ! reflect . DeepEqual ( expected , actual ) {
t . Errorf ( "%s: expected %q, found %q" , message , expected , actual )
}
}
2020-01-31 14:36:25 +01:00
func TestJavaSdkLibraryImport ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
libs : [ "sdklib" ] ,
sdk_version : "current" ,
}
java_library {
name : "foo.system" ,
srcs : [ "a.java" ] ,
libs : [ "sdklib" ] ,
sdk_version : "system_current" ,
}
java_library {
name : "foo.test" ,
srcs : [ "a.java" ] ,
libs : [ "sdklib" ] ,
sdk_version : "test_current" ,
}
java_sdk_library_import {
name : "sdklib" ,
public : {
jars : [ "a.jar" ] ,
} ,
system : {
jars : [ "b.jar" ] ,
} ,
test : {
jars : [ "c.jar" ] ,
2020-05-20 17:18:00 +02:00
stub_srcs : [ "c.java" ] ,
2020-01-31 14:36:25 +01:00
} ,
}
` )
for _ , scope := range [ ] string { "" , ".system" , ".test" } {
fooModule := ctx . ModuleForTests ( "foo" + scope , "android_common" )
javac := fooModule . Rule ( "javac" )
sdklibStubsJar := ctx . ModuleForTests ( "sdklib.stubs" + scope , "android_common" ) . Rule ( "combineJar" ) . Output
if ! strings . Contains ( javac . Args [ "classpath" ] , sdklibStubsJar . String ( ) ) {
t . Errorf ( "foo classpath %v does not contain %q" , javac . Args [ "classpath" ] , sdklibStubsJar . String ( ) )
}
}
2020-06-26 23:20:25 +02:00
2020-07-09 18:32:57 +02:00
CheckModuleDependencies ( t , ctx , "sdklib" , "android_common" , [ ] string {
2020-06-26 23:20:25 +02:00
` prebuilt_sdklib.stubs ` ,
` prebuilt_sdklib.stubs.source.test ` ,
` prebuilt_sdklib.stubs.system ` ,
` prebuilt_sdklib.stubs.test ` ,
} )
}
func TestJavaSdkLibraryImport_WithSource ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_sdk_library {
name : "sdklib" ,
srcs : [ "a.java" ] ,
sdk_version : "none" ,
system_modules : "none" ,
public : {
enabled : true ,
} ,
}
java_sdk_library_import {
name : "sdklib" ,
public : {
jars : [ "a.jar" ] ,
} ,
}
` )
2020-07-09 18:32:57 +02:00
CheckModuleDependencies ( t , ctx , "sdklib" , "android_common" , [ ] string {
2020-06-26 23:20:25 +02:00
` dex2oatd ` ,
` prebuilt_sdklib ` ,
` sdklib.impl ` ,
` sdklib.stubs ` ,
` sdklib.stubs.source ` ,
` sdklib.xml ` ,
} )
2020-07-09 18:32:57 +02:00
CheckModuleDependencies ( t , ctx , "prebuilt_sdklib" , "android_common" , [ ] string {
2020-06-26 21:17:02 +02:00
` prebuilt_sdklib.stubs ` ,
2020-06-26 23:20:25 +02:00
` sdklib.impl ` ,
// This should be prebuilt_sdklib.stubs but is set to sdklib.stubs because the
// dependency is added after prebuilts may have been renamed and so has to use
// the renamed name.
` sdklib.xml ` ,
} )
}
func TestJavaSdkLibraryImport_Preferred ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_sdk_library {
name : "sdklib" ,
srcs : [ "a.java" ] ,
sdk_version : "none" ,
system_modules : "none" ,
public : {
enabled : true ,
} ,
}
java_sdk_library_import {
name : "sdklib" ,
prefer : true ,
public : {
jars : [ "a.jar" ] ,
} ,
}
` )
2020-07-09 18:32:57 +02:00
CheckModuleDependencies ( t , ctx , "sdklib" , "android_common" , [ ] string {
2020-06-26 23:20:25 +02:00
` dex2oatd ` ,
` prebuilt_sdklib ` ,
` sdklib.impl ` ,
2020-06-26 23:08:43 +02:00
` sdklib.stubs ` ,
2020-06-26 23:20:25 +02:00
` sdklib.stubs.source ` ,
` sdklib.xml ` ,
} )
2020-07-09 18:32:57 +02:00
CheckModuleDependencies ( t , ctx , "prebuilt_sdklib" , "android_common" , [ ] string {
2020-06-26 23:20:25 +02:00
` prebuilt_sdklib.stubs ` ,
` sdklib.impl ` ,
` sdklib.xml ` ,
} )
2020-01-31 14:36:25 +01:00
}
2017-07-07 23:35:50 +02:00
func TestDefaults ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-07-07 23:35:50 +02:00
java_defaults {
name : "defaults" ,
srcs : [ "a.java" ] ,
libs : [ "bar" ] ,
static_libs : [ "baz" ] ,
2019-04-17 02:16:58 +02:00
optimize : { enabled : false } ,
2017-07-07 23:35:50 +02:00
}
java_library {
name : "foo" ,
defaults : [ "defaults" ] ,
}
java_library {
name : "bar" ,
srcs : [ "b.java" ] ,
}
java_library {
name : "baz" ,
srcs : [ "c.java" ] ,
}
2019-04-17 02:16:58 +02:00
android_test {
name : "atestOptimize" ,
defaults : [ "defaults" ] ,
optimize : { enabled : true } ,
}
android_test {
name : "atestNoOptimize" ,
defaults : [ "defaults" ] ,
}
android_test {
name : "atestDefault" ,
srcs : [ "a.java" ] ,
}
2017-07-07 23:35:50 +02:00
` )
2017-09-16 02:36:05 +02:00
javac := ctx . ModuleForTests ( "foo" , "android_common" ) . Rule ( "javac" )
2017-10-19 22:06:22 +02:00
combineJar := ctx . ModuleForTests ( "foo" , "android_common" ) . Description ( "for javac" )
2017-07-07 23:35:50 +02:00
if len ( javac . Inputs ) != 1 || javac . Inputs [ 0 ] . String ( ) != "a.java" {
t . Errorf ( ` foo inputs %v != ["a.java"] ` , javac . Inputs )
}
2017-10-19 22:06:22 +02:00
barTurbine := filepath . Join ( buildDir , ".intermediates" , "bar" , "android_common" , "turbine-combined" , "bar.jar" )
if ! strings . Contains ( javac . Args [ "classpath" ] , barTurbine ) {
t . Errorf ( "foo classpath %v does not contain %q" , javac . Args [ "classpath" ] , barTurbine )
2017-07-07 23:35:50 +02:00
}
2017-10-18 23:44:18 +02:00
baz := ctx . ModuleForTests ( "baz" , "android_common" ) . Rule ( "javac" ) . Output . String ( )
2017-08-30 23:24:55 +02:00
if len ( combineJar . Inputs ) != 2 || combineJar . Inputs [ 1 ] . String ( ) != baz {
t . Errorf ( "foo combineJar inputs %v does not contain %q" , combineJar . Inputs , baz )
2017-07-07 23:35:50 +02:00
}
2019-04-17 02:16:58 +02:00
atestOptimize := ctx . ModuleForTests ( "atestOptimize" , "android_common" ) . MaybeRule ( "r8" )
if atestOptimize . Output == nil {
t . Errorf ( "atestOptimize should optimize APK" )
}
atestNoOptimize := ctx . ModuleForTests ( "atestNoOptimize" , "android_common" ) . MaybeRule ( "d8" )
if atestNoOptimize . Output == nil {
t . Errorf ( "atestNoOptimize should not optimize APK" )
}
atestDefault := ctx . ModuleForTests ( "atestDefault" , "android_common" ) . MaybeRule ( "r8" )
if atestDefault . Output == nil {
t . Errorf ( "atestDefault should optimize APK" )
}
2017-07-07 23:35:50 +02:00
}
2017-09-28 02:42:05 +02:00
func TestResources ( t * testing . T ) {
var table = [ ] struct {
name string
prop string
extra string
args string
} {
{
2017-10-03 23:50:08 +02:00
// Test that a module with java_resource_dirs includes the files
2017-09-28 02:42:05 +02:00
name : "resource dirs" ,
2017-11-23 02:27:51 +01:00
prop : ` java_resource_dirs: ["java-res"] ` ,
2018-04-10 22:07:42 +02:00
args : "-C java-res -f java-res/a/a -f java-res/b/b" ,
2017-09-28 02:42:05 +02:00
} ,
{
// Test that a module with java_resources includes the files
name : "resource files" ,
2018-04-10 22:07:42 +02:00
prop : ` java_resources: ["java-res/a/a", "java-res/b/b"] ` ,
args : "-C . -f java-res/a/a -f java-res/b/b" ,
2017-09-28 02:42:05 +02:00
} ,
{
// Test that a module with a filegroup in java_resources includes the files with the
// path prefix
name : "resource filegroup" ,
prop : ` java_resources: [":foo-res"] ` ,
extra : `
filegroup {
name : "foo-res" ,
2017-11-23 02:27:51 +01:00
path : "java-res" ,
2018-04-10 22:07:42 +02:00
srcs : [ "java-res/a/a" , "java-res/b/b" ] ,
2017-09-28 02:42:05 +02:00
} ` ,
2018-04-10 22:07:42 +02:00
args : "-C java-res -f java-res/a/a -f java-res/b/b" ,
2017-09-28 02:42:05 +02:00
} ,
2018-04-10 22:07:42 +02:00
{
// Test that a module with wildcards in java_resource_dirs has the correct path prefixes
name : "wildcard dirs" ,
prop : ` java_resource_dirs: ["java-res/*"] ` ,
args : "-C java-res/a -f java-res/a/a -C java-res/b -f java-res/b/b" ,
} ,
{
// Test that a module exclude_java_resource_dirs excludes the files
name : "wildcard dirs" ,
prop : ` java_resource_dirs: ["java-res/*"], exclude_java_resource_dirs: ["java-res/b"] ` ,
args : "-C java-res/a -f java-res/a/a" ,
} ,
2018-09-13 20:26:19 +02:00
{
// Test wildcards in java_resources
name : "wildcard files" ,
prop : ` java_resources: ["java-res/**/*"] ` ,
args : "-C . -f java-res/a/a -f java-res/b/b" ,
} ,
{
// Test exclude_java_resources with java_resources
name : "wildcard files with exclude" ,
prop : ` java_resources: ["java-res/**/*"], exclude_java_resources: ["java-res/b/*"] ` ,
args : "-C . -f java-res/a/a" ,
} ,
{
// Test exclude_java_resources with java_resource_dirs
name : "resource dirs with exclude files" ,
prop : ` java_resource_dirs: ["java-res"], exclude_java_resources: ["java-res/b/b"] ` ,
args : "-C java-res -f java-res/a/a" ,
} ,
{
// Test exclude_java_resource_dirs with java_resource_dirs
name : "resource dirs with exclude files" ,
prop : ` java_resource_dirs: ["java-res", "java-res2"], exclude_java_resource_dirs: ["java-res2"] ` ,
args : "-C java-res -f java-res/a/a -f java-res/b/b" ,
} ,
2017-09-28 02:42:05 +02:00
}
for _ , test := range table {
t . Run ( test . name , func ( t * testing . T ) {
2020-06-08 01:58:18 +02:00
ctx , _ := testJavaWithFS ( t , `
2017-09-28 02:42:05 +02:00
java_library {
name : "foo" ,
srcs : [
"a.java" ,
"b.java" ,
"c.java" ,
] ,
` +test.prop+ ` ,
}
2020-06-08 01:58:18 +02:00
` + test . extra ,
map [ string ] [ ] byte {
"java-res/a/a" : nil ,
"java-res/b/b" : nil ,
"java-res2/a" : nil ,
} ,
)
2017-09-28 02:42:05 +02:00
2018-08-16 05:40:52 +02:00
foo := ctx . ModuleForTests ( "foo" , "android_common" ) . Output ( "withres/foo.jar" )
2017-10-18 23:44:18 +02:00
fooRes := ctx . ModuleForTests ( "foo" , "android_common" ) . Output ( "res/foo.jar" )
2017-09-28 02:42:05 +02:00
if ! inList ( fooRes . Output . String ( ) , foo . Inputs . Strings ( ) ) {
t . Errorf ( "foo combined jars %v does not contain %q" ,
foo . Inputs . Strings ( ) , fooRes . Output . String ( ) )
}
2017-10-03 23:50:08 +02:00
if fooRes . Args [ "jarArgs" ] != test . args {
t . Errorf ( "foo resource jar args %q is not %q" ,
2017-09-28 02:42:05 +02:00
fooRes . Args [ "jarArgs" ] , test . args )
}
} )
}
}
2019-05-04 00:28:19 +02:00
func TestIncludeSrcs ( t * testing . T ) {
2020-06-08 01:58:18 +02:00
ctx , _ := testJavaWithFS ( t , `
2019-05-04 00:28:19 +02:00
java_library {
name : "foo" ,
srcs : [
"a.java" ,
"b.java" ,
"c.java" ,
] ,
include_srcs : true ,
}
java_library {
name : "bar" ,
srcs : [
"a.java" ,
"b.java" ,
"c.java" ,
] ,
java_resource_dirs : [ "java-res" ] ,
include_srcs : true ,
}
2020-06-08 01:58:18 +02:00
` , map [ string ] [ ] byte {
"java-res/a/a" : nil ,
"java-res/b/b" : nil ,
"java-res2/a" : nil ,
} )
2019-05-04 00:28:19 +02:00
// Test a library with include_srcs: true
foo := ctx . ModuleForTests ( "foo" , "android_common" ) . Output ( "withres/foo.jar" )
fooSrcJar := ctx . ModuleForTests ( "foo" , "android_common" ) . Output ( "foo.srcjar" )
if g , w := fooSrcJar . Output . String ( ) , foo . Inputs . Strings ( ) ; ! inList ( g , w ) {
t . Errorf ( "foo combined jars %v does not contain %q" , w , g )
}
if g , w := fooSrcJar . Args [ "jarArgs" ] , "-C . -f a.java -f b.java -f c.java" ; g != w {
t . Errorf ( "foo source jar args %q is not %q" , w , g )
}
// Test a library with include_srcs: true and resources
bar := ctx . ModuleForTests ( "bar" , "android_common" ) . Output ( "withres/bar.jar" )
barResCombined := ctx . ModuleForTests ( "bar" , "android_common" ) . Output ( "res-combined/bar.jar" )
barRes := ctx . ModuleForTests ( "bar" , "android_common" ) . Output ( "res/bar.jar" )
barSrcJar := ctx . ModuleForTests ( "bar" , "android_common" ) . Output ( "bar.srcjar" )
if g , w := barSrcJar . Output . String ( ) , barResCombined . Inputs . Strings ( ) ; ! inList ( g , w ) {
t . Errorf ( "bar combined resource jars %v does not contain %q" , w , g )
}
if g , w := barRes . Output . String ( ) , barResCombined . Inputs . Strings ( ) ; ! inList ( g , w ) {
t . Errorf ( "bar combined resource jars %v does not contain %q" , w , g )
}
if g , w := barResCombined . Output . String ( ) , bar . Inputs . Strings ( ) ; ! inList ( g , w ) {
t . Errorf ( "bar combined jars %v does not contain %q" , w , g )
}
if g , w := barSrcJar . Args [ "jarArgs" ] , "-C . -f a.java -f b.java -f c.java" ; g != w {
t . Errorf ( "bar source jar args %q is not %q" , w , g )
}
if g , w := barRes . Args [ "jarArgs" ] , "-C java-res -f java-res/a/a -f java-res/b/b" ; g != w {
t . Errorf ( "bar resource jar args %q is not %q" , w , g )
}
}
2017-10-10 00:34:10 +02:00
func TestGeneratedSources ( t * testing . T ) {
2020-06-08 01:58:18 +02:00
ctx , _ := testJavaWithFS ( t , `
2017-10-10 00:34:10 +02:00
java_library {
name : "foo" ,
srcs : [
"a*.java" ,
":gen" ,
"b*.java" ,
] ,
}
genrule {
name : "gen" ,
2017-11-23 02:27:51 +01:00
tool_files : [ "java-res/a" ] ,
2017-10-10 00:34:10 +02:00
out : [ "gen.java" ] ,
}
2020-06-08 01:58:18 +02:00
` , map [ string ] [ ] byte {
"a.java" : nil ,
"b.java" : nil ,
} )
2017-10-10 00:34:10 +02:00
javac := ctx . ModuleForTests ( "foo" , "android_common" ) . Rule ( "javac" )
genrule := ctx . ModuleForTests ( "gen" , "" ) . Rule ( "generator" )
2017-10-21 00:07:08 +02:00
if filepath . Base ( genrule . Output . String ( ) ) != "gen.java" {
t . Fatalf ( ` gen output file %v is not ".../gen.java" ` , genrule . Output . String ( ) )
2017-10-10 00:34:10 +02:00
}
if len ( javac . Inputs ) != 3 ||
javac . Inputs [ 0 ] . String ( ) != "a.java" ||
2017-10-21 00:07:08 +02:00
javac . Inputs [ 1 ] . String ( ) != genrule . Output . String ( ) ||
2017-10-10 00:34:10 +02:00
javac . Inputs [ 2 ] . String ( ) != "b.java" {
t . Errorf ( ` foo inputs %v != ["a.java", ".../gen.java", "b.java"] ` , javac . Inputs )
}
}
2017-11-02 21:28:15 +01:00
func TestTurbine ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-11-02 21:28:15 +01:00
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
2018-03-05 09:44:10 +01:00
sdk_version : "14" ,
2017-11-02 21:28:15 +01:00
}
java_library {
name : "bar" ,
2017-12-16 05:20:39 +01:00
srcs : [ "b.java" ] ,
2017-11-02 21:28:15 +01:00
static_libs : [ "foo" ] ,
2018-03-05 09:44:10 +01:00
sdk_version : "14" ,
2017-11-02 21:28:15 +01:00
}
java_library {
name : "baz" ,
srcs : [ "c.java" ] ,
libs : [ "bar" ] ,
sdk_version : "14" ,
}
` )
fooTurbine := ctx . ModuleForTests ( "foo" , "android_common" ) . Rule ( "turbine" )
barTurbine := ctx . ModuleForTests ( "bar" , "android_common" ) . Rule ( "turbine" )
barJavac := ctx . ModuleForTests ( "bar" , "android_common" ) . Rule ( "javac" )
barTurbineCombined := ctx . ModuleForTests ( "bar" , "android_common" ) . Description ( "for turbine" )
bazJavac := ctx . ModuleForTests ( "baz" , "android_common" ) . Rule ( "javac" )
if len ( fooTurbine . Inputs ) != 1 || fooTurbine . Inputs [ 0 ] . String ( ) != "a.java" {
t . Errorf ( ` foo inputs %v != ["a.java"] ` , fooTurbine . Inputs )
}
fooHeaderJar := filepath . Join ( buildDir , ".intermediates" , "foo" , "android_common" , "turbine-combined" , "foo.jar" )
if ! strings . Contains ( barTurbine . Args [ "classpath" ] , fooHeaderJar ) {
t . Errorf ( "bar turbine classpath %v does not contain %q" , barTurbine . Args [ "classpath" ] , fooHeaderJar )
}
if ! strings . Contains ( barJavac . Args [ "classpath" ] , fooHeaderJar ) {
t . Errorf ( "bar javac classpath %v does not contain %q" , barJavac . Args [ "classpath" ] , fooHeaderJar )
}
if len ( barTurbineCombined . Inputs ) != 2 || barTurbineCombined . Inputs [ 1 ] . String ( ) != fooHeaderJar {
t . Errorf ( "bar turbine combineJar inputs %v does not contain %q" , barTurbineCombined . Inputs , fooHeaderJar )
}
2018-04-11 14:57:30 +02:00
if ! strings . Contains ( bazJavac . Args [ "classpath" ] , "prebuilts/sdk/14/public/android.jar" ) {
2017-11-02 21:28:15 +01:00
t . Errorf ( "baz javac classpath %v does not contain %q" , bazJavac . Args [ "classpath" ] ,
2018-04-11 14:57:30 +02:00
"prebuilts/sdk/14/public/android.jar" )
2017-11-02 21:28:15 +01:00
}
}
func TestSharding ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-11-02 21:28:15 +01:00
java_library {
name : "bar" ,
srcs : [ "a.java" , "b.java" , "c.java" ] ,
javac_shard_size : 1
}
` )
barHeaderJar := filepath . Join ( buildDir , ".intermediates" , "bar" , "android_common" , "turbine-combined" , "bar.jar" )
for i := 0 ; i < 3 ; i ++ {
barJavac := ctx . ModuleForTests ( "bar" , "android_common" ) . Description ( "javac" + strconv . Itoa ( i ) )
if ! strings . Contains ( barJavac . Args [ "classpath" ] , barHeaderJar ) {
t . Errorf ( "bar javac classpath %v does not contain %q" , barJavac . Args [ "classpath" ] , barHeaderJar )
}
}
}
2018-01-11 01:06:12 +01:00
func TestDroiddoc ( t * testing . T ) {
2020-06-08 01:58:18 +02:00
ctx , _ := testJavaWithFS ( t , `
2019-12-19 11:21:09 +01:00
droiddoc_exported_dir {
Add droiddoc_template
We prefer not to use absolute paths in modules, but to reference modules
that have associated paths. This a few benefits:
* it's easier to move a module than to update all the references
* if the module doesn't exist, we treat it as a normal missing
dependency, not having to deal with the missing dependency in path.go
* implementing visibility(etc) in the future would be simpler if there
was a module attached to the reference, so we don't have to do various
path-based lookups to try and match things up.
So define a `droiddoc_template` module, which takes a path, and will run
the glob once in that module. All of the `droiddoc` modules can then
specify it through the `custom_template` property, which will pull the
necessary data.
Also fix that htmldirs should be references from the local path, the
htmldir2 argument never being specified, and complain if more than two
htmldirs are specified, or if the custom template isn't specified.
Test: m core-docs
Test: out/soong/build.ninja is nearly identical
- line numbers in comments
- adds directories to droiddoc template dependency lists, which
is more correct, since we need to rerun on added or removed
files too.
Change-Id: Iff630bddb3818b8eeed439de7e41fc7fbe7cdcb0
2018-02-26 23:33:31 +01:00
name : "droiddoc-templates-sdk" ,
path : "." ,
}
2019-07-07 09:27:47 +02:00
filegroup {
name : "bar-doc-aidl-srcs" ,
srcs : [ "bar-doc/IBar.aidl" ] ,
path : "bar-doc" ,
}
2020-09-10 17:29:25 +02:00
droidstubs {
name : "bar-stubs" ,
2020-08-14 21:14:02 +02:00
srcs : [
2020-09-01 19:58:01 +02:00
"bar-doc/a.java" ,
2020-08-14 21:14:02 +02:00
] ,
2020-09-01 19:58:01 +02:00
exclude_srcs : [
"bar-doc/b.java"
] ,
2020-09-10 17:29:25 +02:00
api_levels_annotations_dirs : [
"droiddoc-templates-sdk" ,
] ,
api_levels_annotations_enabled : true ,
}
droiddoc {
name : "bar-doc" ,
srcs : [
":bar-stubs" ,
"bar-doc/IFoo.aidl" ,
":bar-doc-aidl-srcs" ,
] ,
Add droiddoc_template
We prefer not to use absolute paths in modules, but to reference modules
that have associated paths. This a few benefits:
* it's easier to move a module than to update all the references
* if the module doesn't exist, we treat it as a normal missing
dependency, not having to deal with the missing dependency in path.go
* implementing visibility(etc) in the future would be simpler if there
was a module attached to the reference, so we don't have to do various
path-based lookups to try and match things up.
So define a `droiddoc_template` module, which takes a path, and will run
the glob once in that module. All of the `droiddoc` modules can then
specify it through the `custom_template` property, which will pull the
necessary data.
Also fix that htmldirs should be references from the local path, the
htmldir2 argument never being specified, and complain if more than two
htmldirs are specified, or if the custom template isn't specified.
Test: m core-docs
Test: out/soong/build.ninja is nearly identical
- line numbers in comments
- adds directories to droiddoc template dependency lists, which
is more correct, since we need to rerun on added or removed
files too.
Change-Id: Iff630bddb3818b8eeed439de7e41fc7fbe7cdcb0
2018-02-26 23:33:31 +01:00
custom_template : "droiddoc-templates-sdk" ,
2018-01-11 01:06:12 +01:00
hdf : [
"android.whichdoc offline" ,
] ,
knowntags : [
"bar-doc/known_oj_tags.txt" ,
] ,
proofread_file : "libcore-proofread.txt" ,
todo_file : "libcore-docs-todo.html" ,
2020-07-06 18:12:57 +02:00
flags : [ "-offlinemode -title \"libcore\"" ] ,
2018-01-11 01:06:12 +01:00
}
2020-06-08 01:58:18 +02:00
` ,
map [ string ] [ ] byte {
"bar-doc/a.java" : nil ,
"bar-doc/b.java" : nil ,
} )
2020-09-10 17:29:25 +02:00
barStubs := ctx . ModuleForTests ( "bar-stubs" , "android_common" )
barStubsOutputs , err := barStubs . Module ( ) . ( * Droidstubs ) . OutputFiles ( "" )
if err != nil {
t . Errorf ( "Unexpected error %q retrieving \"bar-stubs\" output file" , err )
}
if len ( barStubsOutputs ) != 1 {
t . Errorf ( "Expected one output from \"bar-stubs\" got %s" , barStubsOutputs )
2020-07-31 00:07:22 +02:00
}
2018-01-11 01:06:12 +01:00
2020-09-10 17:29:25 +02:00
barStubsOutput := barStubsOutputs [ 0 ]
barDoc := ctx . ModuleForTests ( "bar-doc" , "android_common" )
javaDoc := barDoc . Rule ( "javadoc" )
if g , w := javaDoc . Implicits . Strings ( ) , barStubsOutput . String ( ) ; ! inList ( w , g ) {
t . Errorf ( "implicits of bar-doc must contain %q, but was %q." , w , g )
2018-05-23 11:42:04 +02:00
}
2020-09-10 17:29:25 +02:00
expected := "-sourcepath " + buildDir + "/.intermediates/bar-doc/android_common/srcjars "
if ! strings . Contains ( javaDoc . RuleParams . Command , expected ) {
t . Errorf ( "bar-doc command does not contain flag %q, but should\n%q" , expected , javaDoc . RuleParams . Command )
2019-07-07 09:27:47 +02:00
}
2020-09-10 17:29:25 +02:00
aidl := barDoc . Rule ( "aidl" )
if g , w := javaDoc . Implicits . Strings ( ) , aidl . Output . String ( ) ; ! inList ( w , g ) {
2019-06-15 03:51:47 +02:00
t . Errorf ( "implicits of bar-doc must contain %q, but was %q." , w , g )
}
if g , w := aidl . Implicits . Strings ( ) , [ ] string { "bar-doc/IBar.aidl" , "bar-doc/IFoo.aidl" } ; ! reflect . DeepEqual ( w , g ) {
t . Errorf ( "aidl inputs must be %q, but was %q" , w , g )
2018-05-23 11:42:04 +02:00
}
2018-01-11 01:06:12 +01:00
}
2020-07-06 18:12:57 +02:00
func TestDroiddocArgsAndFlagsCausesError ( t * testing . T ) {
testJavaError ( t , "flags is set. Cannot set args" , `
droiddoc_exported_dir {
name : "droiddoc-templates-sdk" ,
path : "." ,
}
filegroup {
name : "bar-doc-aidl-srcs" ,
srcs : [ "bar-doc/IBar.aidl" ] ,
path : "bar-doc" ,
}
2020-09-10 17:29:25 +02:00
droidstubs {
name : "bar-stubs" ,
2020-08-14 21:14:02 +02:00
srcs : [
2020-09-01 19:58:01 +02:00
"bar-doc/a.java" ,
2020-08-14 21:14:02 +02:00
] ,
2020-09-01 19:58:01 +02:00
exclude_srcs : [
"bar-doc/b.java"
] ,
2020-09-10 17:29:25 +02:00
api_levels_annotations_dirs : [
"droiddoc-templates-sdk" ,
] ,
api_levels_annotations_enabled : true ,
}
droiddoc {
name : "bar-doc" ,
srcs : [
":bar-stubs" ,
"bar-doc/IFoo.aidl" ,
":bar-doc-aidl-srcs" ,
] ,
2020-07-06 18:12:57 +02:00
custom_template : "droiddoc-templates-sdk" ,
hdf : [
"android.whichdoc offline" ,
] ,
knowntags : [
"bar-doc/known_oj_tags.txt" ,
] ,
proofread_file : "libcore-proofread.txt" ,
todo_file : "libcore-docs-todo.html" ,
flags : [ "-offlinemode -title \"libcore\"" ] ,
args : "-offlinemode -title \"libcore\"" ,
}
` )
}
2020-08-04 18:55:13 +02:00
func TestDroidstubs ( t * testing . T ) {
ctx , _ := testJavaWithFS ( t , `
droiddoc_exported_dir {
name : "droiddoc-templates-sdk" ,
path : "." ,
}
droidstubs {
name : "bar-stubs" ,
srcs : [
"bar-doc/a.java" ,
] ,
api_levels_annotations_dirs : [
"droiddoc-templates-sdk" ,
] ,
api_levels_annotations_enabled : true ,
}
droidstubs {
name : "bar-stubs-other" ,
srcs : [
"bar-doc/a.java" ,
] ,
api_levels_annotations_dirs : [
"droiddoc-templates-sdk" ,
] ,
api_levels_annotations_enabled : true ,
api_levels_jar_filename : "android.other.jar" ,
}
` ,
map [ string ] [ ] byte {
"bar-doc/a.java" : nil ,
} )
testcases := [ ] struct {
moduleName string
expectedJarFilename string
} {
{
moduleName : "bar-stubs" ,
expectedJarFilename : "android.jar" ,
} ,
{
moduleName : "bar-stubs-other" ,
expectedJarFilename : "android.other.jar" ,
} ,
}
for _ , c := range testcases {
m := ctx . ModuleForTests ( c . moduleName , "android_common" )
metalava := m . Rule ( "metalava" )
expected := "--android-jar-pattern ./%/public/" + c . expectedJarFilename
if actual := metalava . RuleParams . Command ; ! strings . Contains ( actual , expected ) {
t . Errorf ( "For %q, expected metalava argument %q, but was not found %q" , c . moduleName , expected , actual )
}
}
}
2019-11-19 20:44:10 +01:00
func TestDroidstubsWithSystemModules ( t * testing . T ) {
ctx , _ := testJava ( t , `
droidstubs {
name : "stubs-source-system-modules" ,
srcs : [
2020-06-08 01:58:18 +02:00
"bar-doc/a.java" ,
2019-11-19 20:44:10 +01:00
] ,
sdk_version : "none" ,
system_modules : "source-system-modules" ,
}
java_library {
name : "source-jar" ,
srcs : [
"a.java" ,
] ,
}
java_system_modules {
name : "source-system-modules" ,
libs : [ "source-jar" ] ,
}
droidstubs {
name : "stubs-prebuilt-system-modules" ,
srcs : [
2020-06-08 01:58:18 +02:00
"bar-doc/a.java" ,
2019-11-19 20:44:10 +01:00
] ,
sdk_version : "none" ,
system_modules : "prebuilt-system-modules" ,
}
java_import {
name : "prebuilt-jar" ,
jars : [ "a.jar" ] ,
}
java_system_modules_import {
name : "prebuilt-system-modules" ,
libs : [ "prebuilt-jar" ] ,
}
` )
checkSystemModulesUseByDroidstubs ( t , ctx , "stubs-source-system-modules" , "source-jar.jar" )
checkSystemModulesUseByDroidstubs ( t , ctx , "stubs-prebuilt-system-modules" , "prebuilt-jar.jar" )
}
func checkSystemModulesUseByDroidstubs ( t * testing . T , ctx * android . TestContext , moduleName string , systemJar string ) {
metalavaRule := ctx . ModuleForTests ( moduleName , "android_common" ) . Rule ( "metalava" )
var systemJars [ ] string
for _ , i := range metalavaRule . Implicits {
systemJars = append ( systemJars , i . Base ( ) )
}
2020-04-30 09:08:37 +02:00
if len ( systemJars ) < 1 || systemJars [ 0 ] != systemJar {
2019-11-19 20:44:10 +01:00
t . Errorf ( "inputs of %q must be []string{%q}, but was %#v." , moduleName , systemJar , systemJars )
}
}
2017-12-05 18:28:08 +01:00
func TestJarGenrules ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2017-12-05 18:28:08 +01:00
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
}
java_genrule {
name : "jargen" ,
tool_files : [ "b.java" ] ,
cmd : "$(location b.java) $(in) $(out)" ,
out : [ "jargen.jar" ] ,
srcs : [ ":foo" ] ,
}
java_library {
name : "bar" ,
static_libs : [ "jargen" ] ,
srcs : [ "c.java" ] ,
}
java_library {
name : "baz" ,
libs : [ "jargen" ] ,
srcs : [ "c.java" ] ,
}
` )
foo := ctx . ModuleForTests ( "foo" , "android_common" ) . Output ( "javac/foo.jar" )
jargen := ctx . ModuleForTests ( "jargen" , "android_common" ) . Output ( "jargen.jar" )
bar := ctx . ModuleForTests ( "bar" , "android_common" ) . Output ( "javac/bar.jar" )
baz := ctx . ModuleForTests ( "baz" , "android_common" ) . Output ( "javac/baz.jar" )
barCombined := ctx . ModuleForTests ( "bar" , "android_common" ) . Output ( "combined/bar.jar" )
if len ( jargen . Inputs ) != 1 || jargen . Inputs [ 0 ] . String ( ) != foo . Output . String ( ) {
t . Errorf ( "expected jargen inputs [%q], got %q" , foo . Output . String ( ) , jargen . Inputs . Strings ( ) )
}
if ! strings . Contains ( bar . Args [ "classpath" ] , jargen . Output . String ( ) ) {
t . Errorf ( "bar classpath %v does not contain %q" , bar . Args [ "classpath" ] , jargen . Output . String ( ) )
}
if ! strings . Contains ( baz . Args [ "classpath" ] , jargen . Output . String ( ) ) {
t . Errorf ( "baz classpath %v does not contain %q" , baz . Args [ "classpath" ] , jargen . Output . String ( ) )
}
if len ( barCombined . Inputs ) != 2 ||
barCombined . Inputs [ 0 ] . String ( ) != bar . Output . String ( ) ||
barCombined . Inputs [ 1 ] . String ( ) != jargen . Output . String ( ) {
t . Errorf ( "bar combined jar inputs %v is not [%q, %q]" ,
barCombined . Inputs . Strings ( ) , bar . Output . String ( ) , jargen . Output . String ( ) )
}
}
2018-02-09 22:03:53 +01:00
func TestExcludeFileGroupInSrcs ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2018-02-09 22:03:53 +01:00
java_library {
name : "foo" ,
srcs : [ "a.java" , ":foo-srcs" ] ,
exclude_srcs : [ "a.java" , ":foo-excludes" ] ,
}
filegroup {
name : "foo-srcs" ,
srcs : [ "java-fg/a.java" , "java-fg/b.java" , "java-fg/c.java" ] ,
}
filegroup {
name : "foo-excludes" ,
srcs : [ "java-fg/a.java" , "java-fg/b.java" ] ,
}
` )
javac := ctx . ModuleForTests ( "foo" , "android_common" ) . Rule ( "javac" )
if len ( javac . Inputs ) != 1 || javac . Inputs [ 0 ] . String ( ) != "java-fg/c.java" {
t . Errorf ( ` foo inputs %v != ["java-fg/c.java"] ` , javac . Inputs )
}
}
2018-04-10 06:07:10 +02:00
2019-06-11 13:31:14 +02:00
func TestJavaLibrary ( t * testing . T ) {
2019-12-14 05:41:13 +01:00
config := testConfig ( nil , "" , map [ string ] [ ] byte {
2019-06-11 13:31:14 +02:00
"libcore/Android.bp" : [ ] byte ( `
java_library {
name : "core" ,
sdk_version : "none" ,
system_modules : "none" ,
} ` ) ,
} )
2019-12-14 05:41:13 +01:00
ctx := testContext ( )
2019-06-11 13:31:14 +02:00
run ( t , ctx , config )
}
2018-04-10 06:07:10 +02:00
func TestJavaSdkLibrary ( t * testing . T ) {
2019-07-17 20:15:09 +02:00
ctx , _ := testJava ( t , `
2019-12-19 11:21:09 +01:00
droiddoc_exported_dir {
2018-04-10 06:07:10 +02:00
name : "droiddoc-templates-sdk" ,
path : "." ,
}
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" , "b.java" ] ,
api_packages : [ "foo" ] ,
}
java_sdk_library {
name : "bar" ,
srcs : [ "a.java" , "b.java" ] ,
api_packages : [ "bar" ] ,
}
java_library {
name : "baz" ,
srcs : [ "c.java" ] ,
2020-05-15 11:20:31 +02:00
libs : [ "foo" , "bar.stubs" ] ,
2018-04-10 06:07:10 +02:00
sdk_version : "system_current" ,
}
2020-05-15 21:37:11 +02:00
java_sdk_library {
name : "barney" ,
srcs : [ "c.java" ] ,
api_only : true ,
}
java_sdk_library {
name : "betty" ,
srcs : [ "c.java" ] ,
shared_library : false ,
}
2020-05-15 11:20:31 +02:00
java_sdk_library_import {
name : "quuz" ,
public : {
jars : [ "c.jar" ] ,
} ,
}
java_sdk_library_import {
name : "fred" ,
public : {
jars : [ "b.jar" ] ,
} ,
}
2020-05-15 21:37:11 +02:00
java_sdk_library_import {
name : "wilma" ,
public : {
jars : [ "b.jar" ] ,
} ,
shared_library : false ,
}
2018-05-28 11:02:19 +02:00
java_library {
name : "qux" ,
srcs : [ "c.java" ] ,
2020-05-15 21:37:11 +02:00
libs : [ "baz" , "fred" , "quuz.stubs" , "wilma" , "barney" , "betty" ] ,
2018-05-28 11:02:19 +02:00
sdk_version : "system_current" ,
}
2020-01-22 17:30:37 +01:00
java_library {
name : "baz-test" ,
srcs : [ "c.java" ] ,
libs : [ "foo" ] ,
sdk_version : "test_current" ,
}
2020-01-22 18:11:15 +01:00
java_library {
name : "baz-29" ,
srcs : [ "c.java" ] ,
libs : [ "foo" ] ,
sdk_version : "system_29" ,
}
2020-09-30 16:17:25 +02:00
java_library {
name : "baz-module-30" ,
srcs : [ "c.java" ] ,
libs : [ "foo" ] ,
sdk_version : "module_30" ,
}
2018-04-10 06:07:10 +02:00
` )
// check the existence of the internal modules
ctx . ModuleForTests ( "foo" , "android_common" )
2020-05-08 16:52:37 +02:00
ctx . ModuleForTests ( apiScopePublic . stubsLibraryModuleName ( "foo" ) , "android_common" )
ctx . ModuleForTests ( apiScopeSystem . stubsLibraryModuleName ( "foo" ) , "android_common" )
ctx . ModuleForTests ( apiScopeTest . stubsLibraryModuleName ( "foo" ) , "android_common" )
ctx . ModuleForTests ( apiScopePublic . stubsSourceModuleName ( "foo" ) , "android_common" )
ctx . ModuleForTests ( apiScopeSystem . stubsSourceModuleName ( "foo" ) , "android_common" )
ctx . ModuleForTests ( apiScopeTest . stubsSourceModuleName ( "foo" ) , "android_common" )
2020-02-17 09:28:10 +01:00
ctx . ModuleForTests ( "foo" + sdkXmlFileSuffix , "android_common" )
2018-05-12 15:29:12 +02:00
ctx . ModuleForTests ( "foo.api.public.28" , "" )
ctx . ModuleForTests ( "foo.api.system.28" , "" )
ctx . ModuleForTests ( "foo.api.test.28" , "" )
2018-04-10 06:07:10 +02:00
bazJavac := ctx . ModuleForTests ( "baz" , "android_common" ) . Rule ( "javac" )
// tests if baz is actually linked to the stubs lib
if ! strings . Contains ( bazJavac . Args [ "classpath" ] , "foo.stubs.system.jar" ) {
t . Errorf ( "baz javac classpath %v does not contain %q" , bazJavac . Args [ "classpath" ] ,
"foo.stubs.system.jar" )
}
// ... and not to the impl lib
2018-10-19 06:46:09 +02:00
if strings . Contains ( bazJavac . Args [ "classpath" ] , "foo.jar" ) {
2018-04-10 06:07:10 +02:00
t . Errorf ( "baz javac classpath %v should not contain %q" , bazJavac . Args [ "classpath" ] ,
2018-10-19 06:46:09 +02:00
"foo.jar" )
2018-04-10 06:07:10 +02:00
}
// test if baz is not linked to the system variant of foo
if strings . Contains ( bazJavac . Args [ "classpath" ] , "foo.stubs.jar" ) {
t . Errorf ( "baz javac classpath %v should not contain %q" , bazJavac . Args [ "classpath" ] ,
"foo.stubs.jar" )
}
2018-05-28 11:02:19 +02:00
2020-01-22 17:30:37 +01:00
bazTestJavac := ctx . ModuleForTests ( "baz-test" , "android_common" ) . Rule ( "javac" )
// tests if baz-test is actually linked to the test stubs lib
if ! strings . Contains ( bazTestJavac . Args [ "classpath" ] , "foo.stubs.test.jar" ) {
t . Errorf ( "baz-test javac classpath %v does not contain %q" , bazTestJavac . Args [ "classpath" ] ,
"foo.stubs.test.jar" )
}
2020-01-22 18:11:15 +01:00
baz29Javac := ctx . ModuleForTests ( "baz-29" , "android_common" ) . Rule ( "javac" )
// tests if baz-29 is actually linked to the system 29 stubs lib
if ! strings . Contains ( baz29Javac . Args [ "classpath" ] , "prebuilts/sdk/29/system/foo.jar" ) {
t . Errorf ( "baz-29 javac classpath %v does not contain %q" , baz29Javac . Args [ "classpath" ] ,
"prebuilts/sdk/29/system/foo.jar" )
}
2020-09-30 16:17:25 +02:00
bazModule30Javac := ctx . ModuleForTests ( "baz-module-30" , "android_common" ) . Rule ( "javac" )
// tests if "baz-module-30" is actually linked to the module 30 stubs lib
if ! strings . Contains ( bazModule30Javac . Args [ "classpath" ] , "prebuilts/sdk/30/module-lib/foo.jar" ) {
t . Errorf ( "baz-module-30 javac classpath %v does not contain %q" , bazModule30Javac . Args [ "classpath" ] ,
"prebuilts/sdk/30/module-lib/foo.jar" )
}
2018-05-28 11:02:19 +02:00
// test if baz has exported SDK lib names foo and bar to qux
qux := ctx . ModuleForTests ( "qux" , "android_common" )
if quxLib , ok := qux . Module ( ) . ( * Library ) ; ok {
2020-08-20 12:33:12 +02:00
sdkLibs := android . SortedStringKeys ( quxLib . ExportedSdkLibs ( ) )
2020-05-15 11:20:31 +02:00
if w := [ ] string { "bar" , "foo" , "fred" , "quuz" } ; ! reflect . DeepEqual ( w , sdkLibs ) {
t . Errorf ( "qux should export %q but exports %q" , w , sdkLibs )
2018-05-28 11:02:19 +02:00
}
}
2018-04-10 06:07:10 +02:00
}
2018-08-21 17:10:29 +02:00
2020-05-26 19:13:57 +02:00
func TestJavaSdkLibrary_DoNotAccessImplWhenItIsNotBuilt ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" ] ,
api_only : true ,
public : {
enabled : true ,
} ,
}
java_library {
name : "bar" ,
srcs : [ "b.java" ] ,
libs : [ "foo" ] ,
}
` )
// The bar library should depend on the stubs jar.
barLibrary := ctx . ModuleForTests ( "bar" , "android_common" ) . Rule ( "javac" )
if expected , actual := ` ^-classpath .*:/[^:]*/turbine-combined/foo\.stubs\.jar$ ` , barLibrary . Args [ "classpath" ] ; ! regexp . MustCompile ( expected ) . MatchString ( actual ) {
t . Errorf ( "expected %q, found %#q" , expected , actual )
}
}
2020-05-14 16:39:10 +02:00
func TestJavaSdkLibrary_UseSourcesFromAnotherSdkLibrary ( t * testing . T ) {
testJava ( t , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" ] ,
api_packages : [ "foo" ] ,
public : {
enabled : true ,
} ,
}
java_library {
name : "bar" ,
srcs : [ "b.java" , ":foo{.public.stubs.source}" ] ,
}
` )
}
func TestJavaSdkLibrary_AccessOutputFiles_MissingScope ( t * testing . T ) {
testJavaError ( t , ` "foo" does not provide api scope system ` , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" ] ,
api_packages : [ "foo" ] ,
public : {
enabled : true ,
} ,
}
java_library {
name : "bar" ,
srcs : [ "b.java" , ":foo{.system.stubs.source}" ] ,
}
` )
}
2020-06-26 23:20:25 +02:00
func TestJavaSdkLibrary_Deps ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_sdk_library {
name : "sdklib" ,
srcs : [ "a.java" ] ,
sdk_version : "none" ,
system_modules : "none" ,
public : {
enabled : true ,
} ,
}
` )
2020-07-09 18:32:57 +02:00
CheckModuleDependencies ( t , ctx , "sdklib" , "android_common" , [ ] string {
2020-06-26 23:20:25 +02:00
` dex2oatd ` ,
` sdklib.impl ` ,
` sdklib.stubs ` ,
` sdklib.stubs.source ` ,
` sdklib.xml ` ,
} )
}
2020-05-14 16:39:10 +02:00
func TestJavaSdkLibraryImport_AccessOutputFiles ( t * testing . T ) {
testJava ( t , `
java_sdk_library_import {
name : "foo" ,
public : {
jars : [ "a.jar" ] ,
stub_srcs : [ "a.java" ] ,
current_api : "api/current.txt" ,
removed_api : "api/removed.txt" ,
} ,
}
java_library {
name : "bar" ,
srcs : [ ":foo{.public.stubs.source}" ] ,
java_resources : [
":foo{.public.api.txt}" ,
":foo{.public.removed-api.txt}" ,
] ,
}
` )
}
func TestJavaSdkLibraryImport_AccessOutputFiles_Invalid ( t * testing . T ) {
bp := `
java_sdk_library_import {
name : "foo" ,
public : {
jars : [ "a.jar" ] ,
} ,
}
`
t . Run ( "stubs.source" , func ( t * testing . T ) {
testJavaError ( t , ` stubs.source not available for api scope public ` , bp + `
java_library {
name : "bar" ,
srcs : [ ":foo{.public.stubs.source}" ] ,
java_resources : [
":foo{.public.api.txt}" ,
":foo{.public.removed-api.txt}" ,
] ,
}
` )
} )
t . Run ( "api.txt" , func ( t * testing . T ) {
testJavaError ( t , ` api.txt not available for api scope public ` , bp + `
java_library {
name : "bar" ,
srcs : [ "a.java" ] ,
java_resources : [
":foo{.public.api.txt}" ,
] ,
}
` )
} )
t . Run ( "removed-api.txt" , func ( t * testing . T ) {
testJavaError ( t , ` removed-api.txt not available for api scope public ` , bp + `
java_library {
name : "bar" ,
srcs : [ "a.java" ] ,
java_resources : [
":foo{.public.removed-api.txt}" ,
] ,
}
` )
} )
}
2020-04-28 11:44:03 +02:00
func TestJavaSdkLibrary_InvalidScopes ( t * testing . T ) {
testJavaError ( t , ` module "foo": enabled api scope "system" depends on disabled scope "public" ` , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" , "b.java" ] ,
api_packages : [ "foo" ] ,
// Explicitly disable public to test the check that ensures the set of enabled
// scopes is consistent.
public : {
enabled : false ,
} ,
system : {
enabled : true ,
} ,
}
` )
}
2020-05-12 12:50:28 +02:00
func TestJavaSdkLibrary_SdkVersion_ForScope ( t * testing . T ) {
testJava ( t , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" , "b.java" ] ,
api_packages : [ "foo" ] ,
system : {
enabled : true ,
sdk_version : "module_current" ,
} ,
}
` )
}
2020-06-02 14:00:08 +02:00
func TestJavaSdkLibrary_ModuleLib ( t * testing . T ) {
testJava ( t , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" , "b.java" ] ,
api_packages : [ "foo" ] ,
system : {
enabled : true ,
} ,
module_lib : {
enabled : true ,
} ,
}
` )
}
func TestJavaSdkLibrary_SystemServer ( t * testing . T ) {
testJava ( t , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" , "b.java" ] ,
api_packages : [ "foo" ] ,
system : {
enabled : true ,
} ,
system_server : {
enabled : true ,
} ,
}
` )
}
2020-05-20 12:52:25 +02:00
func TestJavaSdkLibrary_MissingScope ( t * testing . T ) {
testJavaError ( t , ` requires api scope module-lib from foo but it only has \[\] available ` , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" ] ,
public : {
enabled : false ,
} ,
}
java_library {
name : "baz" ,
srcs : [ "a.java" ] ,
libs : [ "foo" ] ,
sdk_version : "module_current" ,
}
` )
}
func TestJavaSdkLibrary_FallbackScope ( t * testing . T ) {
testJava ( t , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" ] ,
system : {
enabled : true ,
} ,
}
java_library {
name : "baz" ,
srcs : [ "a.java" ] ,
libs : [ "foo" ] ,
// foo does not have module-lib scope so it should fallback to system
sdk_version : "module_current" ,
}
` )
}
2020-05-27 17:19:53 +02:00
func TestJavaSdkLibrary_DefaultToStubs ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_sdk_library {
name : "foo" ,
srcs : [ "a.java" ] ,
system : {
enabled : true ,
} ,
default_to_stubs : true ,
}
java_library {
name : "baz" ,
srcs : [ "a.java" ] ,
libs : [ "foo" ] ,
// does not have sdk_version set, should fallback to module,
// which will then fallback to system because the module scope
// is not enabled.
}
` )
// The baz library should depend on the system stubs jar.
bazLibrary := ctx . ModuleForTests ( "baz" , "android_common" ) . Rule ( "javac" )
if expected , actual := ` ^-classpath .*:/[^:]*/turbine-combined/foo\.stubs.system\.jar$ ` , bazLibrary . Args [ "classpath" ] ; ! regexp . MustCompile ( expected ) . MatchString ( actual ) {
t . Errorf ( "expected %q, found %#q" , expected , actual )
}
}
2018-08-21 17:10:29 +02:00
var compilerFlagsTestCases = [ ] struct {
in string
out bool
} {
{
in : "a" ,
out : false ,
} ,
{
in : "-a" ,
out : true ,
} ,
{
in : "-no-jdk" ,
out : false ,
} ,
{
in : "-no-stdlib" ,
out : false ,
} ,
{
in : "-kotlin-home" ,
out : false ,
} ,
{
in : "-kotlin-home /some/path" ,
out : false ,
} ,
{
in : "-include-runtime" ,
out : false ,
} ,
{
in : "-Xintellij-plugin-root" ,
out : false ,
} ,
}
type mockContext struct {
android . ModuleContext
result bool
}
func ( ctx * mockContext ) PropertyErrorf ( property , format string , args ... interface { } ) {
// CheckBadCompilerFlags calls this function when the flag should be rejected
ctx . result = false
}
func TestCompilerFlags ( t * testing . T ) {
for _ , testCase := range compilerFlagsTestCases {
ctx := & mockContext { result : true }
CheckKotlincFlags ( ctx , [ ] string { testCase . in } )
if ctx . result != testCase . out {
t . Errorf ( "incorrect output:" )
t . Errorf ( " input: %#v" , testCase . in )
t . Errorf ( " expected: %#v" , testCase . out )
t . Errorf ( " got: %#v" , ctx . result )
}
}
}
2018-12-12 18:01:34 +01:00
// TODO(jungjw): Consider making this more robust by ignoring path order.
func checkPatchModuleFlag ( t * testing . T , ctx * android . TestContext , moduleName string , expected string ) {
variables := ctx . ModuleForTests ( moduleName , "android_common" ) . Module ( ) . VariablesForTests ( )
flags := strings . Split ( variables [ "javacFlags" ] , " " )
got := ""
for _ , flag := range flags {
keyEnd := strings . Index ( flag , "=" )
if keyEnd > - 1 && flag [ : keyEnd ] == "--patch-module" {
got = flag [ keyEnd + 1 : ]
break
}
}
if expected != got {
t . Errorf ( "Unexpected patch-module flag for module %q - expected %q, but got %q" , moduleName , expected , got )
}
}
func TestPatchModule ( t * testing . T ) {
2019-05-02 16:32:11 +02:00
t . Run ( "Java language level 8" , func ( t * testing . T ) {
2019-10-01 14:57:31 +02:00
// Test with legacy javac -source 1.8 -target 1.8
2019-10-21 15:29:58 +02:00
bp := `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
java_version : "1.8" ,
}
java_library {
name : "bar" ,
srcs : [ "b.java" ] ,
sdk_version : "none" ,
system_modules : "none" ,
patch_module : "java.base" ,
java_version : "1.8" ,
}
java_library {
name : "baz" ,
srcs : [ "c.java" ] ,
patch_module : "java.base" ,
java_version : "1.8" ,
}
`
ctx , _ := testJava ( t , bp )
2018-12-12 18:01:34 +01:00
checkPatchModuleFlag ( t , ctx , "foo" , "" )
checkPatchModuleFlag ( t , ctx , "bar" , "" )
checkPatchModuleFlag ( t , ctx , "baz" , "" )
} )
2019-05-02 16:32:11 +02:00
t . Run ( "Java language level 9" , func ( t * testing . T ) {
2019-10-01 14:57:31 +02:00
// Test with default javac -source 9 -target 9
2019-10-21 15:29:58 +02:00
bp := `
java_library {
name : "foo" ,
srcs : [ "a.java" ] ,
}
java_library {
name : "bar" ,
srcs : [ "b.java" ] ,
sdk_version : "none" ,
system_modules : "none" ,
patch_module : "java.base" ,
}
java_library {
name : "baz" ,
srcs : [ "c.java" ] ,
patch_module : "java.base" ,
}
`
2019-10-01 14:57:31 +02:00
ctx , _ := testJava ( t , bp )
2018-12-12 18:01:34 +01:00
checkPatchModuleFlag ( t , ctx , "foo" , "" )
expected := "java.base=.:" + buildDir
checkPatchModuleFlag ( t , ctx , "bar" , expected )
2019-12-18 09:28:17 +01:00
expected = "java.base=" + strings . Join ( [ ] string { "." , buildDir , moduleToPath ( "ext" ) , moduleToPath ( "framework" ) } , ":" )
2018-12-12 18:01:34 +01:00
checkPatchModuleFlag ( t , ctx , "baz" , expected )
} )
}
2020-01-10 18:12:18 +01:00
func TestJavaSystemModules ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_system_modules {
name : "system-modules" ,
libs : [ "system-module1" , "system-module2" ] ,
}
java_library {
name : "system-module1" ,
srcs : [ "a.java" ] ,
sdk_version : "none" ,
system_modules : "none" ,
}
java_library {
name : "system-module2" ,
srcs : [ "b.java" ] ,
sdk_version : "none" ,
system_modules : "none" ,
}
` )
// check the existence of the module
systemModules := ctx . ModuleForTests ( "system-modules" , "android_common" )
cmd := systemModules . Rule ( "jarsTosystemModules" )
// make sure the command compiles against the supplied modules.
for _ , module := range [ ] string { "system-module1.jar" , "system-module2.jar" } {
if ! strings . Contains ( cmd . Args [ "classpath" ] , module ) {
t . Errorf ( "system modules classpath %v does not contain %q" , cmd . Args [ "classpath" ] ,
module )
}
}
}
2020-01-10 18:16:44 +01:00
func TestJavaSystemModulesImport ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_system_modules_import {
name : "system-modules" ,
libs : [ "system-module1" , "system-module2" ] ,
}
java_import {
name : "system-module1" ,
jars : [ "a.jar" ] ,
}
java_import {
name : "system-module2" ,
jars : [ "b.jar" ] ,
}
` )
// check the existence of the module
systemModules := ctx . ModuleForTests ( "system-modules" , "android_common" )
cmd := systemModules . Rule ( "jarsTosystemModules" )
// make sure the command compiles against the supplied modules.
for _ , module := range [ ] string { "system-module1.jar" , "system-module2.jar" } {
if ! strings . Contains ( cmd . Args [ "classpath" ] , module ) {
t . Errorf ( "system modules classpath %v does not contain %q" , cmd . Args [ "classpath" ] ,
module )
}
}
}
2019-11-19 20:44:10 +01:00
func TestJavaLibraryWithSystemModules ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_library {
name : "lib-with-source-system-modules" ,
srcs : [
"a.java" ,
] ,
sdk_version : "none" ,
system_modules : "source-system-modules" ,
}
java_library {
name : "source-jar" ,
srcs : [
"a.java" ,
] ,
}
java_system_modules {
name : "source-system-modules" ,
libs : [ "source-jar" ] ,
}
java_library {
name : "lib-with-prebuilt-system-modules" ,
srcs : [
"a.java" ,
] ,
sdk_version : "none" ,
system_modules : "prebuilt-system-modules" ,
}
java_import {
name : "prebuilt-jar" ,
jars : [ "a.jar" ] ,
}
java_system_modules_import {
name : "prebuilt-system-modules" ,
libs : [ "prebuilt-jar" ] ,
}
` )
checkBootClasspathForSystemModule ( t , ctx , "lib-with-source-system-modules" , "/source-jar.jar" )
checkBootClasspathForSystemModule ( t , ctx , "lib-with-prebuilt-system-modules" , "/prebuilt-jar.jar" )
}
func checkBootClasspathForSystemModule ( t * testing . T , ctx * android . TestContext , moduleName string , expectedSuffix string ) {
javacRule := ctx . ModuleForTests ( moduleName , "android_common" ) . Rule ( "javac" )
bootClasspath := javacRule . Args [ "bootClasspath" ]
if strings . HasPrefix ( bootClasspath , "--system " ) && strings . HasSuffix ( bootClasspath , expectedSuffix ) {
t . Errorf ( "bootclasspath of %q must start with --system and end with %q, but was %#v." , moduleName , expectedSuffix , bootClasspath )
}
}
2020-03-24 08:44:11 +01:00
func TestAidlExportIncludeDirsFromImports ( t * testing . T ) {
ctx , _ := testJava ( t , `
java_library {
name : "foo" ,
srcs : [ "aidl/foo/IFoo.aidl" ] ,
libs : [ "bar" ] ,
}
java_import {
name : "bar" ,
jars : [ "a.jar" ] ,
aidl : {
export_include_dirs : [ "aidl/bar" ] ,
} ,
}
` )
aidlCommand := ctx . ModuleForTests ( "foo" , "android_common" ) . Rule ( "aidl" ) . RuleParams . Command
expectedAidlFlag := "-Iaidl/bar"
if ! strings . Contains ( aidlCommand , expectedAidlFlag ) {
t . Errorf ( "aidl command %q does not contain %q" , aidlCommand , expectedAidlFlag )
}
}
2020-06-13 01:38:45 +02:00
func TestDataNativeBinaries ( t * testing . T ) {
ctx , config := testJava ( t , `
java_test_host {
name : "foo" ,
srcs : [ "a.java" ] ,
data_native_bins : [ "bin" ]
}
python_binary_host {
name : "bin" ,
srcs : [ "bin.py" ] ,
}
` )
buildOS := android . BuildOs . String ( )
test := ctx . ModuleForTests ( "foo" , buildOS + "_common" ) . Module ( ) . ( * TestHost )
entries := android . AndroidMkEntriesForTest ( t , config , "" , test ) [ 0 ]
expected := [ ] string { buildDir + "/.intermediates/bin/" + buildOS + "_x86_64_PY3/bin:bin" }
actual := entries . EntryMap [ "LOCAL_COMPATIBILITY_SUPPORT_FILES" ]
if ! reflect . DeepEqual ( expected , actual ) {
t . Errorf ( "Unexpected test data - expected: %q, actual: %q" , expected , actual )
}
}