2015-04-13 22:58:27 +02:00
|
|
|
// Copyright 2015 Google Inc. All rights reserved.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package java
|
|
|
|
|
2020-12-21 21:29:12 +01:00
|
|
|
// This file contains the module implementations for android_app, android_test, and some more
|
|
|
|
// related module types, including their override variants.
|
2015-04-13 22:58:27 +02:00
|
|
|
|
|
|
|
import (
|
2023-06-01 16:16:58 +02:00
|
|
|
"fmt"
|
2019-04-26 23:31:50 +02:00
|
|
|
"path/filepath"
|
|
|
|
"strings"
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2023-10-06 21:54:58 +02:00
|
|
|
"android/soong/testing"
|
2023-12-01 23:01:06 +01:00
|
|
|
|
2019-05-16 21:28:22 +02:00
|
|
|
"github.com/google/blueprint"
|
|
|
|
"github.com/google/blueprint/proptools"
|
|
|
|
|
2016-05-19 00:37:25 +02:00
|
|
|
"android/soong/android"
|
2018-10-03 07:03:40 +02:00
|
|
|
"android/soong/cc"
|
2020-06-03 15:57:22 +02:00
|
|
|
"android/soong/dexpreopt"
|
2023-08-30 06:27:09 +02:00
|
|
|
"android/soong/genrule"
|
2018-08-08 01:49:25 +02:00
|
|
|
"android/soong/tradefed"
|
2015-04-13 22:58:27 +02:00
|
|
|
)
|
|
|
|
|
2017-11-23 01:19:37 +01:00
|
|
|
func init() {
|
2019-12-18 20:51:55 +01:00
|
|
|
RegisterAppBuildComponents(android.InitRegistrationContext)
|
2022-08-17 18:53:46 +02:00
|
|
|
pctx.HostBinToolVariable("ModifyAllowlistCmd", "modify_permissions_allowlist")
|
2017-11-23 01:19:37 +01:00
|
|
|
}
|
|
|
|
|
2022-08-17 18:53:46 +02:00
|
|
|
var (
|
|
|
|
modifyAllowlist = pctx.AndroidStaticRule("modifyAllowlist",
|
|
|
|
blueprint.RuleParams{
|
|
|
|
Command: "${ModifyAllowlistCmd} $in $packageName $out",
|
|
|
|
CommandDeps: []string{"${ModifyAllowlistCmd}"},
|
|
|
|
}, "packageName")
|
|
|
|
)
|
|
|
|
|
2019-12-18 20:51:55 +01:00
|
|
|
func RegisterAppBuildComponents(ctx android.RegistrationContext) {
|
|
|
|
ctx.RegisterModuleType("android_app", AndroidAppFactory)
|
|
|
|
ctx.RegisterModuleType("android_test", AndroidTestFactory)
|
|
|
|
ctx.RegisterModuleType("android_test_helper_app", AndroidTestHelperAppFactory)
|
|
|
|
ctx.RegisterModuleType("android_app_certificate", AndroidAppCertificateFactory)
|
|
|
|
ctx.RegisterModuleType("override_android_app", OverrideAndroidAppModuleFactory)
|
|
|
|
ctx.RegisterModuleType("override_android_test", OverrideAndroidTestModuleFactory)
|
|
|
|
}
|
|
|
|
|
2015-04-13 22:58:27 +02:00
|
|
|
// AndroidManifest.xml merging
|
|
|
|
// package splits
|
|
|
|
|
2018-02-21 02:22:23 +01:00
|
|
|
type appProperties struct {
|
2018-10-05 00:21:03 +02:00
|
|
|
// Names of extra android_app_certificate modules to sign the apk with in the form ":module".
|
2015-05-11 22:39:40 +02:00
|
|
|
Additional_certificates []string
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2015-05-11 22:39:40 +02:00
|
|
|
// If set, create package-export.apk, which other packages can
|
|
|
|
// use to get PRODUCT-agnostic resource data like IDs and type definitions.
|
2017-11-09 06:20:04 +01:00
|
|
|
Export_package_resources *bool
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2018-03-28 23:58:31 +02:00
|
|
|
// Specifies that this app should be installed to the priv-app directory,
|
|
|
|
// where the system will grant it additional privileges not available to
|
|
|
|
// normal apps.
|
|
|
|
Privileged *bool
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2015-05-11 22:39:40 +02:00
|
|
|
// list of resource labels to generate individual resource packages
|
|
|
|
Package_splits []string
|
2018-08-10 15:33:36 +02:00
|
|
|
|
2018-10-03 07:03:40 +02:00
|
|
|
// list of native libraries that will be provided in or alongside the resulting jar
|
|
|
|
Jni_libs []string `android:"arch_variant"`
|
|
|
|
|
2020-05-07 02:51:39 +02:00
|
|
|
// if true, use JNI libraries that link against platform APIs even if this module sets
|
2020-02-20 01:57:15 +01:00
|
|
|
// sdk_version.
|
|
|
|
Jni_uses_platform_apis *bool
|
|
|
|
|
2020-05-07 02:51:39 +02:00
|
|
|
// if true, use JNI libraries that link against SDK APIs even if this module does not set
|
|
|
|
// sdk_version.
|
|
|
|
Jni_uses_sdk_apis *bool
|
|
|
|
|
2019-05-07 00:48:44 +02:00
|
|
|
// STL library to use for JNI libraries.
|
|
|
|
Stl *string `android:"arch_variant"`
|
|
|
|
|
2019-02-06 06:55:21 +01:00
|
|
|
// Store native libraries uncompressed in the APK and set the android:extractNativeLibs="false" manifest
|
|
|
|
// flag so that they are used from inside the APK at runtime. Defaults to true for android_test modules unless
|
2019-11-11 02:14:32 +01:00
|
|
|
// sdk_version or min_sdk_version is set to a version that doesn't support it (<23), defaults to true for
|
|
|
|
// android_app modules that are embedded to APEXes, defaults to false for other module types where the native
|
|
|
|
// libraries are generally preinstalled outside the APK.
|
2019-02-06 06:55:21 +01:00
|
|
|
Use_embedded_native_libs *bool
|
2019-02-07 22:07:08 +01:00
|
|
|
|
|
|
|
// Store dex files uncompressed in the APK and set the android:useEmbeddedDex="true" manifest attribute so that
|
|
|
|
// they are used from inside the APK at runtime.
|
|
|
|
Use_embedded_dex *bool
|
2019-03-26 18:51:39 +01:00
|
|
|
|
|
|
|
// Forces native libraries to always be packaged into the APK,
|
|
|
|
// Use_embedded_native_libs still selects whether they are stored uncompressed and aligned or compressed.
|
|
|
|
// True for android_test* modules.
|
|
|
|
AlwaysPackageNativeLibs bool `blueprint:"mutated"`
|
2019-06-18 02:40:56 +02:00
|
|
|
|
|
|
|
// If set, find and merge all NOTICE files that this module and its dependencies have and store
|
|
|
|
// it in the APK as an asset.
|
|
|
|
Embed_notices *bool
|
2020-03-26 22:01:48 +01:00
|
|
|
|
|
|
|
// cc.Coverage related properties
|
|
|
|
PreventInstall bool `blueprint:"mutated"`
|
|
|
|
IsCoverageVariant bool `blueprint:"mutated"`
|
2020-04-08 20:09:30 +02:00
|
|
|
|
2022-06-10 13:24:05 +02:00
|
|
|
// It can be set to test the behaviour of default target sdk version.
|
|
|
|
// Only required when updatable: false. It is an error if updatable: true and this is false.
|
|
|
|
Enforce_default_target_sdk_version *bool
|
|
|
|
|
|
|
|
// If set, the targetSdkVersion for the target is set to the latest default API level.
|
|
|
|
// This would be by default false, unless updatable: true or
|
|
|
|
// enforce_default_target_sdk_version: true in which case this defaults to true.
|
|
|
|
EnforceDefaultTargetSdkVersion bool `blueprint:"mutated"`
|
|
|
|
|
2020-04-08 20:09:30 +02:00
|
|
|
// Whether this app is considered mainline updatable or not. When set to true, this will enforce
|
2020-04-16 14:43:02 +02:00
|
|
|
// additional rules to make sure an app can safely be updated. Default is false.
|
|
|
|
// Prefer using other specific properties if build behaviour must be changed; avoid using this
|
|
|
|
// flag for anything but neverallow rules (unless the behaviour change is invisible to owners).
|
2020-04-08 20:09:30 +02:00
|
|
|
Updatable *bool
|
2022-08-17 18:53:46 +02:00
|
|
|
|
|
|
|
// Specifies the file that contains the allowlist for this app.
|
|
|
|
Privapp_allowlist *string `android:"path"`
|
2023-11-07 05:37:14 +01:00
|
|
|
|
|
|
|
// If set, create an RRO package which contains only resources having PRODUCT_CHARACTERISTICS
|
|
|
|
// and install the RRO package to /product partition, instead of passing --product argument
|
|
|
|
// to aapt2. Default is false.
|
|
|
|
// Setting this will make this APK identical to all targets, regardless of
|
|
|
|
// PRODUCT_CHARACTERISTICS.
|
|
|
|
Generate_product_characteristics_rro *bool
|
|
|
|
|
|
|
|
ProductCharacteristicsRROPackageName *string `blueprint:"mutated"`
|
|
|
|
ProductCharacteristicsRROManifestModuleName *string `blueprint:"mutated"`
|
2015-05-11 22:39:40 +02:00
|
|
|
}
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2019-03-01 00:35:54 +01:00
|
|
|
// android_app properties that can be overridden by override_android_app
|
|
|
|
type overridableAppProperties struct {
|
|
|
|
// The name of a certificate in the default certificate directory, blank to use the default product certificate,
|
|
|
|
// or an android_app_certificate module name in the form ":module".
|
|
|
|
Certificate *string
|
2019-03-13 18:13:24 +01:00
|
|
|
|
2021-03-10 00:02:31 +01:00
|
|
|
// Name of the signing certificate lineage file or filegroup module.
|
|
|
|
Lineage *string `android:"path"`
|
2020-05-07 22:24:05 +02:00
|
|
|
|
2021-11-03 15:39:39 +01:00
|
|
|
// For overriding the --rotation-min-sdk-version property of apksig
|
|
|
|
RotationMinSdkVersion *string
|
|
|
|
|
2019-03-13 18:13:24 +01:00
|
|
|
// the package name of this app. The package name in the manifest file is used if one was not given.
|
|
|
|
Package_name *string
|
2020-02-12 02:27:19 +01:00
|
|
|
|
|
|
|
// the logging parent of this app.
|
|
|
|
Logging_parent *string
|
2020-06-18 21:44:06 +02:00
|
|
|
|
|
|
|
// Whether to rename the package in resources to the override name rather than the base name. Defaults to true.
|
|
|
|
Rename_resources_package *bool
|
2022-02-17 03:33:12 +01:00
|
|
|
|
|
|
|
// Names of modules to be overridden. Listed modules can only be other binaries
|
|
|
|
// (in Make or Soong).
|
|
|
|
// This does not completely prevent installation of the overridden binaries, but if both
|
|
|
|
// binaries would be installed by default (in PRODUCT_PACKAGES) the other binary will be removed
|
|
|
|
// from PRODUCT_PACKAGES.
|
|
|
|
Overrides []string
|
2019-03-01 00:35:54 +01:00
|
|
|
}
|
|
|
|
|
2015-05-11 22:39:40 +02:00
|
|
|
type AndroidApp struct {
|
2018-03-28 23:58:31 +02:00
|
|
|
Library
|
|
|
|
aapt
|
2019-03-01 00:35:54 +01:00
|
|
|
android.OverridableModuleBase
|
2015-05-11 22:39:40 +02:00
|
|
|
|
2018-10-30 13:20:05 +01:00
|
|
|
certificate Certificate
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2018-03-28 23:58:31 +02:00
|
|
|
appProperties appProperties
|
2018-05-22 20:11:52 +02:00
|
|
|
|
2019-03-01 00:35:54 +01:00
|
|
|
overridableAppProperties overridableAppProperties
|
|
|
|
|
2020-07-06 23:15:24 +02:00
|
|
|
jniLibs []jniLib
|
|
|
|
installPathForJNISymbols android.Path
|
|
|
|
embeddedJniLibs bool
|
|
|
|
jniCoverageOutputs android.Paths
|
2018-10-30 07:14:58 +01:00
|
|
|
|
|
|
|
bundleFile android.Path
|
2019-01-24 01:27:47 +01:00
|
|
|
|
|
|
|
// the install APK name is normally the same as the module name, but can be overridden with PRODUCT_PACKAGE_NAME_OVERRIDES.
|
|
|
|
installApkName string
|
2019-02-28 01:26:28 +01:00
|
|
|
|
2019-10-02 07:05:35 +02:00
|
|
|
installDir android.InstallPath
|
2019-09-11 19:25:18 +02:00
|
|
|
|
2019-09-28 02:13:15 +02:00
|
|
|
onDeviceDir string
|
|
|
|
|
2019-02-28 01:26:28 +01:00
|
|
|
additionalAaptFlags []string
|
2019-07-02 02:15:13 +02:00
|
|
|
|
2020-02-28 08:51:07 +01:00
|
|
|
overriddenManifestPackageName string
|
2020-04-27 20:05:28 +02:00
|
|
|
|
|
|
|
android.ApexBundleDepsInfo
|
2022-04-01 19:48:31 +02:00
|
|
|
|
|
|
|
javaApiUsedByOutputFile android.ModuleOutPath
|
2022-08-17 18:53:46 +02:00
|
|
|
|
|
|
|
privAppAllowlist android.OptionalPath
|
2017-12-14 20:22:55 +01:00
|
|
|
}
|
|
|
|
|
2020-01-31 18:10:36 +01:00
|
|
|
func (a *AndroidApp) IsInstallable() bool {
|
|
|
|
return Bool(a.properties.Installable)
|
|
|
|
}
|
|
|
|
|
2023-07-14 19:23:41 +02:00
|
|
|
func (a *AndroidApp) ResourcesNodeDepSet() *android.DepSet[*resourcesNode] {
|
|
|
|
return a.aapt.resourcesNodesDepSet
|
2018-05-02 21:58:28 +02:00
|
|
|
}
|
|
|
|
|
2019-08-27 06:55:42 +02:00
|
|
|
func (a *AndroidApp) OutputFile() android.Path {
|
|
|
|
return a.outputFile
|
|
|
|
}
|
|
|
|
|
2020-01-28 23:00:53 +01:00
|
|
|
func (a *AndroidApp) Certificate() Certificate {
|
|
|
|
return a.certificate
|
|
|
|
}
|
|
|
|
|
2020-03-26 22:01:48 +01:00
|
|
|
func (a *AndroidApp) JniCoverageOutputs() android.Paths {
|
|
|
|
return a.jniCoverageOutputs
|
|
|
|
}
|
|
|
|
|
2022-08-17 18:53:46 +02:00
|
|
|
func (a *AndroidApp) PrivAppAllowlist() android.OptionalPath {
|
|
|
|
return a.privAppAllowlist
|
|
|
|
}
|
|
|
|
|
2018-03-28 23:58:31 +02:00
|
|
|
var _ AndroidLibraryDependency = (*AndroidApp)(nil)
|
|
|
|
|
2018-10-30 13:20:05 +01:00
|
|
|
type Certificate struct {
|
2020-01-28 23:00:53 +01:00
|
|
|
Pem, Key android.Path
|
|
|
|
presigned bool
|
|
|
|
}
|
|
|
|
|
2020-05-28 01:36:07 +02:00
|
|
|
var PresignedCertificate = Certificate{presigned: true}
|
2020-01-28 23:00:53 +01:00
|
|
|
|
|
|
|
func (c Certificate) AndroidMkString() string {
|
|
|
|
if c.presigned {
|
|
|
|
return "PRESIGNED"
|
|
|
|
} else {
|
|
|
|
return c.Pem.String()
|
|
|
|
}
|
2015-04-13 22:58:27 +02:00
|
|
|
}
|
|
|
|
|
2017-06-23 01:51:17 +02:00
|
|
|
func (a *AndroidApp) DepsMutator(ctx android.BottomUpMutatorContext) {
|
2021-04-02 01:45:46 +02:00
|
|
|
if String(a.appProperties.Stl) == "c++_shared" && !a.SdkVersion(ctx).Specified() {
|
2019-05-07 00:48:44 +02:00
|
|
|
ctx.PropertyErrorf("stl", "sdk_version must be set in order to use c++_shared")
|
|
|
|
}
|
|
|
|
|
2021-03-29 13:11:58 +02:00
|
|
|
sdkDep := decodeSdkDep(ctx, android.SdkContext(a))
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
a.usesLibrary.deps(ctx, sdkDep.hasFrameworkLibs())
|
|
|
|
a.Module.deps(ctx)
|
2019-06-07 11:44:37 +02:00
|
|
|
if sdkDep.hasFrameworkLibs() {
|
|
|
|
a.aapt.deps(ctx, sdkDep)
|
2015-04-13 22:58:27 +02:00
|
|
|
}
|
2018-10-03 07:03:40 +02:00
|
|
|
|
2021-04-02 01:45:46 +02:00
|
|
|
usesSDK := a.SdkVersion(ctx).Specified() && a.SdkVersion(ctx).Kind != android.SdkCorePlatform
|
2020-05-08 20:20:24 +02:00
|
|
|
|
|
|
|
if usesSDK && Bool(a.appProperties.Jni_uses_sdk_apis) {
|
|
|
|
ctx.PropertyErrorf("jni_uses_sdk_apis",
|
|
|
|
"can only be set for modules that do not set sdk_version")
|
|
|
|
} else if !usesSDK && Bool(a.appProperties.Jni_uses_platform_apis) {
|
|
|
|
ctx.PropertyErrorf("jni_uses_platform_apis",
|
|
|
|
"can only be set for modules that set sdk_version")
|
|
|
|
}
|
|
|
|
|
2018-10-03 07:03:40 +02:00
|
|
|
for _, jniTarget := range ctx.MultiTargets() {
|
2019-10-16 20:03:10 +02:00
|
|
|
variation := append(jniTarget.Variations(),
|
|
|
|
blueprint.Variation{Mutator: "link", Variation: "shared"})
|
2020-04-07 18:50:32 +02:00
|
|
|
|
|
|
|
// If the app builds against an Android SDK use the SDK variant of JNI dependencies
|
|
|
|
// unless jni_uses_platform_apis is set.
|
2020-05-13 20:05:02 +02:00
|
|
|
// Don't require the SDK variant for apps that are shipped on vendor, etc., as they already
|
|
|
|
// have stable APIs through the VNDK.
|
|
|
|
if (usesSDK && !a.RequiresStableAPIs(ctx) &&
|
|
|
|
!Bool(a.appProperties.Jni_uses_platform_apis)) ||
|
2020-05-07 02:51:39 +02:00
|
|
|
Bool(a.appProperties.Jni_uses_sdk_apis) {
|
2020-04-07 18:50:32 +02:00
|
|
|
variation = append(variation, blueprint.Variation{Mutator: "sdk", Variation: "sdk"})
|
|
|
|
}
|
2020-10-10 03:59:49 +02:00
|
|
|
ctx.AddFarVariationDependencies(variation, jniLibTag, a.appProperties.Jni_libs...)
|
2018-10-03 07:03:40 +02:00
|
|
|
}
|
2024-03-19 22:57:36 +01:00
|
|
|
for _, aconfig_declaration := range a.aaptProperties.Flags_packages {
|
|
|
|
ctx.AddDependency(ctx.Module(), aconfigDeclarationTag, aconfig_declaration)
|
|
|
|
}
|
2019-05-11 00:16:29 +02:00
|
|
|
}
|
2018-10-05 00:21:03 +02:00
|
|
|
|
2019-05-11 00:16:29 +02:00
|
|
|
func (a *AndroidApp) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
|
2019-01-18 23:27:16 +01:00
|
|
|
cert := android.SrcIsModule(a.getCertString(ctx))
|
2018-10-05 00:21:03 +02:00
|
|
|
if cert != "" {
|
|
|
|
ctx.AddDependency(ctx.Module(), certificateTag, cert)
|
|
|
|
}
|
|
|
|
|
2022-08-17 18:53:46 +02:00
|
|
|
if a.appProperties.Privapp_allowlist != nil && !Bool(a.appProperties.Privileged) {
|
2023-06-03 10:53:47 +02:00
|
|
|
// There are a few uids that are explicitly considered privileged regardless of their
|
|
|
|
// app's location. Bluetooth is one such app. It should arguably be moved to priv-app,
|
|
|
|
// but for now, allow it not to be in priv-app.
|
|
|
|
privilegedBecauseOfUid := ctx.ModuleName() == "Bluetooth"
|
|
|
|
if !privilegedBecauseOfUid {
|
|
|
|
ctx.PropertyErrorf("privapp_allowlist", "privileged must be set in order to use privapp_allowlist (with a few exceptions)")
|
|
|
|
}
|
2022-08-17 18:53:46 +02:00
|
|
|
}
|
|
|
|
|
2018-10-05 00:21:03 +02:00
|
|
|
for _, cert := range a.appProperties.Additional_certificates {
|
|
|
|
cert = android.SrcIsModule(cert)
|
|
|
|
if cert != "" {
|
|
|
|
ctx.AddDependency(ctx.Module(), certificateTag, cert)
|
|
|
|
} else {
|
|
|
|
ctx.PropertyErrorf("additional_certificates",
|
|
|
|
`must be names of android_app_certificate modules in the form ":module"`)
|
|
|
|
}
|
|
|
|
}
|
2015-04-13 22:58:27 +02:00
|
|
|
}
|
|
|
|
|
2019-07-11 08:54:27 +02:00
|
|
|
func (a *AndroidTestHelperApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
2023-08-31 17:48:23 +02:00
|
|
|
applicationId := a.appTestHelperAppProperties.Manifest_values.ApplicationId
|
|
|
|
if applicationId != nil {
|
|
|
|
if a.overridableAppProperties.Package_name != nil {
|
|
|
|
ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
|
|
|
|
}
|
|
|
|
a.aapt.manifestValues.applicationId = *applicationId
|
|
|
|
}
|
2019-07-11 08:54:27 +02:00
|
|
|
a.generateAndroidBuildActions(ctx)
|
|
|
|
}
|
|
|
|
|
2017-06-23 01:51:17 +02:00
|
|
|
func (a *AndroidApp) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
2020-04-08 20:09:30 +02:00
|
|
|
a.checkAppSdkVersions(ctx)
|
2018-05-22 20:11:52 +02:00
|
|
|
a.generateAndroidBuildActions(ctx)
|
2022-04-01 19:48:31 +02:00
|
|
|
a.generateJavaUsedByApex(ctx)
|
2018-05-22 20:11:52 +02:00
|
|
|
}
|
|
|
|
|
2023-08-19 00:43:28 +02:00
|
|
|
func (a *AndroidApp) MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel {
|
|
|
|
defaultMinSdkVersion := a.Module.MinSdkVersion(ctx)
|
|
|
|
if proptools.Bool(a.appProperties.Updatable) {
|
|
|
|
overrideApiLevel := android.MinSdkVersionFromValue(ctx, ctx.DeviceConfig().ApexGlobalMinSdkVersionOverride())
|
|
|
|
if !overrideApiLevel.IsNone() && overrideApiLevel.CompareTo(defaultMinSdkVersion) > 0 {
|
|
|
|
return overrideApiLevel
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return defaultMinSdkVersion
|
|
|
|
}
|
|
|
|
|
2020-04-08 20:09:30 +02:00
|
|
|
func (a *AndroidApp) checkAppSdkVersions(ctx android.ModuleContext) {
|
2020-04-28 15:57:42 +02:00
|
|
|
if a.Updatable() {
|
2021-04-02 01:45:46 +02:00
|
|
|
if !a.SdkVersion(ctx).Stable() {
|
|
|
|
ctx.PropertyErrorf("sdk_version", "Updatable apps must use stable SDKs, found %v", a.SdkVersion(ctx))
|
2020-04-08 20:09:30 +02:00
|
|
|
}
|
2020-04-16 14:43:02 +02:00
|
|
|
if String(a.deviceProperties.Min_sdk_version) == "" {
|
|
|
|
ctx.PropertyErrorf("updatable", "updatable apps must set min_sdk_version.")
|
|
|
|
}
|
2020-04-15 04:03:39 +02:00
|
|
|
|
2021-04-02 01:45:46 +02:00
|
|
|
if minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx); err == nil {
|
2020-04-29 07:01:06 +02:00
|
|
|
a.checkJniLibsSdkVersion(ctx, minSdkVersion)
|
2021-12-02 14:59:35 +01:00
|
|
|
android.CheckMinSdkVersion(ctx, minSdkVersion, a.WalkPayloadDeps)
|
2020-04-29 07:01:06 +02:00
|
|
|
} else {
|
|
|
|
ctx.PropertyErrorf("min_sdk_version", "%s", err.Error())
|
|
|
|
}
|
2022-06-10 13:24:05 +02:00
|
|
|
|
|
|
|
if !BoolDefault(a.appProperties.Enforce_default_target_sdk_version, true) {
|
|
|
|
ctx.PropertyErrorf("enforce_default_target_sdk_version", "Updatable apps must enforce default target sdk version")
|
|
|
|
}
|
|
|
|
// TODO(b/227460469) after all the modules removes the target sdk version, throw an error if the target sdk version is explicitly set.
|
|
|
|
if a.deviceProperties.Target_sdk_version == nil {
|
|
|
|
a.SetEnforceDefaultTargetSdkVersion(true)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-04-08 20:09:30 +02:00
|
|
|
a.checkPlatformAPI(ctx)
|
|
|
|
a.checkSdkVersions(ctx)
|
|
|
|
}
|
|
|
|
|
2020-04-29 07:01:06 +02:00
|
|
|
// If an updatable APK sets min_sdk_version, min_sdk_vesion of JNI libs should match with it.
|
|
|
|
// This check is enforced for "updatable" APKs (including APK-in-APEX).
|
2021-03-31 11:17:53 +02:00
|
|
|
func (a *AndroidApp) checkJniLibsSdkVersion(ctx android.ModuleContext, minSdkVersion android.ApiLevel) {
|
2020-04-29 07:01:06 +02:00
|
|
|
// It's enough to check direct JNI deps' sdk_version because all transitive deps from JNI deps are checked in cc.checkLinkType()
|
|
|
|
ctx.VisitDirectDeps(func(m android.Module) {
|
|
|
|
if !IsJniDepTag(ctx.OtherModuleDependencyTag(m)) {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
dep, _ := m.(*cc.Module)
|
2020-05-20 10:12:13 +02:00
|
|
|
// The domain of cc.sdk_version is "current" and <number>
|
2021-03-29 13:11:58 +02:00
|
|
|
// We can rely on android.SdkSpec to convert it to <number> so that "current" is
|
|
|
|
// handled properly regardless of sdk finalization.
|
2022-05-08 02:39:35 +02:00
|
|
|
jniSdkVersion, err := android.SdkSpecFrom(ctx, dep.MinSdkVersion()).EffectiveVersion(ctx)
|
2021-03-31 11:17:53 +02:00
|
|
|
if err != nil || minSdkVersion.LessThan(jniSdkVersion) {
|
2022-05-08 02:39:35 +02:00
|
|
|
ctx.OtherModuleErrorf(dep, "min_sdk_version(%v) is higher than min_sdk_version(%v) of the containing android_app(%v)",
|
|
|
|
dep.MinSdkVersion(), minSdkVersion, ctx.ModuleName())
|
2020-04-29 07:01:06 +02:00
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
2019-05-01 22:16:22 +02:00
|
|
|
// Returns true if the native libraries should be stored in the APK uncompressed and the
|
2019-02-06 06:55:21 +01:00
|
|
|
// extractNativeLibs application flag should be set to false in the manifest.
|
2019-05-01 22:16:22 +02:00
|
|
|
func (a *AndroidApp) useEmbeddedNativeLibs(ctx android.ModuleContext) bool {
|
2021-04-02 01:45:46 +02:00
|
|
|
minSdkVersion, err := a.MinSdkVersion(ctx).EffectiveVersion(ctx)
|
2019-02-06 06:55:21 +01:00
|
|
|
if err != nil {
|
2021-04-02 01:45:46 +02:00
|
|
|
ctx.PropertyErrorf("min_sdk_version", "invalid value %q: %s", a.MinSdkVersion(ctx), err)
|
2019-02-06 06:55:21 +01:00
|
|
|
}
|
|
|
|
|
2023-12-14 00:54:49 +01:00
|
|
|
apexInfo, _ := android.ModuleProvider(ctx, android.ApexInfoProvider)
|
2021-03-31 11:17:53 +02:00
|
|
|
return (minSdkVersion.FinalOrFutureInt() >= 23 && Bool(a.appProperties.Use_embedded_native_libs)) ||
|
2020-09-16 03:30:11 +02:00
|
|
|
!apexInfo.IsForPlatform()
|
2019-02-06 06:55:21 +01:00
|
|
|
}
|
|
|
|
|
2018-11-12 19:13:39 +01:00
|
|
|
// Returns whether this module should have the dex file stored uncompressed in the APK.
|
|
|
|
func (a *AndroidApp) shouldUncompressDex(ctx android.ModuleContext) bool {
|
2019-02-07 22:07:08 +01:00
|
|
|
if Bool(a.appProperties.Use_embedded_dex) {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2019-06-25 22:35:30 +02:00
|
|
|
// Uncompress dex in APKs of privileged apps (even for unbundled builds, they may
|
|
|
|
// be preinstalled as prebuilts).
|
2019-10-17 05:54:30 +02:00
|
|
|
if ctx.Config().UncompressPrivAppDex() && a.Privileged() {
|
2019-02-12 14:12:16 +01:00
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2019-06-25 22:35:30 +02:00
|
|
|
if ctx.Config().UnbundledBuild() {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
2024-01-24 00:56:29 +01:00
|
|
|
return shouldUncompressDex(ctx, android.RemoveOptionalPrebuiltPrefix(ctx.ModuleName()), &a.dexpreopter)
|
2018-10-05 23:20:06 +02:00
|
|
|
}
|
|
|
|
|
2019-05-07 00:48:44 +02:00
|
|
|
func (a *AndroidApp) shouldEmbedJnis(ctx android.BaseModuleContext) bool {
|
2023-12-14 00:54:49 +01:00
|
|
|
apexInfo, _ := android.ModuleProvider(ctx, android.ApexInfoProvider)
|
2019-05-07 00:48:44 +02:00
|
|
|
return ctx.Config().UnbundledBuild() || Bool(a.appProperties.Use_embedded_native_libs) ||
|
2020-09-16 03:30:11 +02:00
|
|
|
!apexInfo.IsForPlatform() || a.appProperties.AlwaysPackageNativeLibs
|
2019-05-07 00:48:44 +02:00
|
|
|
}
|
|
|
|
|
2020-06-18 21:44:06 +02:00
|
|
|
func generateAaptRenamePackageFlags(packageName string, renameResourcesPackage bool) []string {
|
|
|
|
aaptFlags := []string{"--rename-manifest-package " + packageName}
|
|
|
|
if renameResourcesPackage {
|
|
|
|
// Required to rename the package name in the resources table.
|
|
|
|
aaptFlags = append(aaptFlags, "--rename-resources-package "+packageName)
|
|
|
|
}
|
|
|
|
return aaptFlags
|
|
|
|
}
|
|
|
|
|
2020-02-28 08:51:07 +01:00
|
|
|
func (a *AndroidApp) OverriddenManifestPackageName() string {
|
|
|
|
return a.overriddenManifestPackageName
|
|
|
|
}
|
|
|
|
|
2020-06-18 21:44:06 +02:00
|
|
|
func (a *AndroidApp) renameResourcesPackage() bool {
|
|
|
|
return proptools.BoolDefault(a.overridableAppProperties.Rename_resources_package, true)
|
|
|
|
}
|
|
|
|
|
2024-03-19 22:57:36 +01:00
|
|
|
func getAconfigFilePaths(ctx android.ModuleContext) (aconfigTextFilePaths android.Paths) {
|
|
|
|
ctx.VisitDirectDepsWithTag(aconfigDeclarationTag, func(dep android.Module) {
|
|
|
|
if provider, ok := android.OtherModuleProvider(ctx, dep, android.AconfigDeclarationsProviderKey); ok {
|
|
|
|
aconfigTextFilePaths = append(aconfigTextFilePaths, provider.IntermediateDumpOutputPath)
|
|
|
|
} else {
|
|
|
|
ctx.ModuleErrorf("Only aconfig_declarations module type is allowed for "+
|
|
|
|
"flags_packages property, but %s is not aconfig_declarations module type",
|
|
|
|
dep.Name(),
|
|
|
|
)
|
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
return aconfigTextFilePaths
|
|
|
|
}
|
|
|
|
|
2019-01-23 01:40:58 +01:00
|
|
|
func (a *AndroidApp) aaptBuildActions(ctx android.ModuleContext) {
|
2021-03-30 03:38:26 +02:00
|
|
|
usePlatformAPI := proptools.Bool(a.Module.deviceProperties.Platform_apis)
|
2021-04-02 01:45:46 +02:00
|
|
|
if ctx.Module().(android.SdkContext).SdkVersion(ctx).Kind == android.SdkModule {
|
2021-03-30 03:38:26 +02:00
|
|
|
usePlatformAPI = true
|
|
|
|
}
|
|
|
|
a.aapt.usesNonSdkApis = usePlatformAPI
|
2019-02-18 19:24:16 +01:00
|
|
|
|
2019-05-31 00:51:14 +02:00
|
|
|
// Ask manifest_fixer to add or update the application element indicating this app has no code.
|
|
|
|
a.aapt.hasNoCode = !a.hasCode(ctx)
|
|
|
|
|
2019-01-22 20:19:56 +01:00
|
|
|
aaptLinkFlags := []string{}
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2019-01-22 20:19:56 +01:00
|
|
|
// Add TARGET_AAPT_CHARACTERISTICS values to AAPT link flags if they exist and --product flags were not provided.
|
2023-11-07 05:37:14 +01:00
|
|
|
autogenerateRRO := proptools.Bool(a.appProperties.Generate_product_characteristics_rro)
|
2020-02-11 16:54:35 +01:00
|
|
|
hasProduct := android.PrefixInList(a.aaptProperties.Aaptflags, "--product")
|
2024-02-13 04:56:46 +01:00
|
|
|
characteristics := ctx.Config().ProductAAPTCharacteristics()
|
|
|
|
if !autogenerateRRO && !hasProduct && len(characteristics) > 0 && characteristics != "default" {
|
|
|
|
aaptLinkFlags = append(aaptLinkFlags, "--product", characteristics)
|
2018-04-20 00:25:19 +02:00
|
|
|
}
|
|
|
|
|
2018-10-25 05:24:57 +02:00
|
|
|
if !Bool(a.aaptProperties.Aapt_include_all_resources) {
|
|
|
|
// Product AAPT config
|
|
|
|
for _, aaptConfig := range ctx.Config().ProductAAPTConfig() {
|
2019-01-22 20:19:56 +01:00
|
|
|
aaptLinkFlags = append(aaptLinkFlags, "-c", aaptConfig)
|
2018-10-25 05:24:57 +02:00
|
|
|
}
|
2018-04-20 00:25:19 +02:00
|
|
|
|
2018-10-25 05:24:57 +02:00
|
|
|
// Product AAPT preferred config
|
|
|
|
if len(ctx.Config().ProductAAPTPreferredConfig()) > 0 {
|
2019-01-22 20:19:56 +01:00
|
|
|
aaptLinkFlags = append(aaptLinkFlags, "--preferred-density", ctx.Config().ProductAAPTPreferredConfig())
|
2018-10-25 05:24:57 +02:00
|
|
|
}
|
2018-04-20 00:25:19 +02:00
|
|
|
}
|
|
|
|
|
2019-01-05 04:57:48 +01:00
|
|
|
manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(ctx.ModuleName())
|
2019-03-13 18:13:24 +01:00
|
|
|
if overridden || a.overridableAppProperties.Package_name != nil {
|
|
|
|
// The product override variable has a priority over the package_name property.
|
|
|
|
if !overridden {
|
|
|
|
manifestPackageName = *a.overridableAppProperties.Package_name
|
|
|
|
}
|
2020-06-18 21:44:06 +02:00
|
|
|
aaptLinkFlags = append(aaptLinkFlags, generateAaptRenamePackageFlags(manifestPackageName, a.renameResourcesPackage())...)
|
2020-02-28 08:51:07 +01:00
|
|
|
a.overriddenManifestPackageName = manifestPackageName
|
2019-01-05 04:57:48 +01:00
|
|
|
}
|
|
|
|
|
2019-02-28 01:26:28 +01:00
|
|
|
aaptLinkFlags = append(aaptLinkFlags, a.additionalAaptFlags...)
|
|
|
|
|
2019-03-20 00:03:11 +01:00
|
|
|
a.aapt.splitNames = a.appProperties.Package_splits
|
2020-02-12 02:27:19 +01:00
|
|
|
a.aapt.LoggingParent = String(a.overridableAppProperties.Logging_parent)
|
2022-07-27 15:59:18 +02:00
|
|
|
if a.Updatable() {
|
|
|
|
a.aapt.defaultManifestVersion = android.DefaultUpdatableModuleVersion
|
|
|
|
}
|
2023-12-01 23:01:06 +01:00
|
|
|
|
2024-03-13 13:09:17 +01:00
|
|
|
// Use non final ids if we are doing optimized shrinking and are using R8.
|
|
|
|
nonFinalIds := Bool(a.dexProperties.Optimize.Optimized_shrink_resources) && a.dexer.effectiveOptimizeEnabled()
|
2023-09-27 18:47:56 +02:00
|
|
|
a.aapt.buildActions(ctx,
|
|
|
|
aaptBuildActionOptions{
|
2023-12-01 23:01:06 +01:00
|
|
|
sdkContext: android.SdkContext(a),
|
|
|
|
classLoaderContexts: a.classLoaderContexts,
|
|
|
|
excludedLibs: a.usesLibraryProperties.Exclude_uses_libs,
|
|
|
|
enforceDefaultTargetSdkVersion: a.enforceDefaultTargetSdkVersion(),
|
2024-03-13 13:09:17 +01:00
|
|
|
forceNonFinalResourceIDs: nonFinalIds,
|
2023-12-01 23:01:06 +01:00
|
|
|
extraLinkFlags: aaptLinkFlags,
|
2024-03-19 22:57:36 +01:00
|
|
|
aconfigTextFiles: getAconfigFilePaths(ctx),
|
2023-09-27 18:47:56 +02:00
|
|
|
},
|
|
|
|
)
|
2017-11-23 01:19:37 +01:00
|
|
|
|
2017-06-23 01:51:17 +02:00
|
|
|
// apps manifests are handled by aapt, don't let Module see them
|
2015-09-24 00:26:20 +02:00
|
|
|
a.properties.Manifest = nil
|
2019-01-23 01:40:58 +01:00
|
|
|
}
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2019-01-23 01:40:58 +01:00
|
|
|
func (a *AndroidApp) proguardBuildActions(ctx android.ModuleContext) {
|
2018-05-01 00:55:11 +02:00
|
|
|
var staticLibProguardFlagFiles android.Paths
|
|
|
|
ctx.VisitDirectDeps(func(m android.Module) {
|
2023-12-13 22:47:44 +01:00
|
|
|
depProguardInfo, _ := android.OtherModuleProvider(ctx, m, ProguardSpecInfoProvider)
|
2023-08-03 00:00:35 +02:00
|
|
|
staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.UnconditionallyExportedProguardFlags.ToList()...)
|
|
|
|
if ctx.OtherModuleDependencyTag(m) == staticLibTag {
|
|
|
|
staticLibProguardFlagFiles = append(staticLibProguardFlagFiles, depProguardInfo.ProguardFlagsFiles.ToList()...)
|
2018-05-01 00:55:11 +02:00
|
|
|
}
|
|
|
|
})
|
|
|
|
|
|
|
|
staticLibProguardFlagFiles = android.FirstUniquePaths(staticLibProguardFlagFiles)
|
|
|
|
|
2023-11-22 00:13:56 +01:00
|
|
|
a.Module.extraProguardFlagsFiles = append(a.Module.extraProguardFlagsFiles, staticLibProguardFlagFiles...)
|
2024-03-13 13:09:17 +01:00
|
|
|
if !Bool(a.dexProperties.Optimize.Optimized_shrink_resources) {
|
|
|
|
// When using the optimized shrinking the R8 enqueuer will traverse the xml files that become
|
|
|
|
// live for code references and (transitively) mark these as live.
|
|
|
|
// In this case we explicitly don't wan't the aapt2 generated keep files (which would keep the now
|
|
|
|
// dead code alive)
|
|
|
|
a.Module.extraProguardFlagsFiles = append(a.Module.extraProguardFlagsFiles, a.proguardOptionsFile)
|
|
|
|
}
|
2019-01-23 01:40:58 +01:00
|
|
|
}
|
2017-12-28 21:23:20 +01:00
|
|
|
|
2020-07-06 23:15:24 +02:00
|
|
|
func (a *AndroidApp) installPath(ctx android.ModuleContext) android.InstallPath {
|
2018-11-12 19:13:39 +01:00
|
|
|
var installDir string
|
|
|
|
if ctx.ModuleName() == "framework-res" {
|
|
|
|
// framework-res.apk is installed as system/framework/framework-res.apk
|
|
|
|
installDir = "framework"
|
2019-10-17 05:54:30 +02:00
|
|
|
} else if a.Privileged() {
|
2019-01-24 01:27:47 +01:00
|
|
|
installDir = filepath.Join("priv-app", a.installApkName)
|
2018-11-12 19:13:39 +01:00
|
|
|
} else {
|
2019-01-24 01:27:47 +01:00
|
|
|
installDir = filepath.Join("app", a.installApkName)
|
2018-11-12 19:13:39 +01:00
|
|
|
}
|
2020-07-06 23:15:24 +02:00
|
|
|
|
|
|
|
return android.PathForModuleInstall(ctx, installDir, a.installApkName+".apk")
|
|
|
|
}
|
|
|
|
|
2023-11-27 09:44:03 +01:00
|
|
|
func (a *AndroidApp) dexBuildActions(ctx android.ModuleContext) (android.Path, android.Path) {
|
2020-07-06 23:15:24 +02:00
|
|
|
a.dexpreopter.installPath = a.installPath(ctx)
|
2021-01-14 18:52:43 +01:00
|
|
|
a.dexpreopter.isApp = true
|
2020-07-10 00:16:41 +02:00
|
|
|
if a.dexProperties.Uncompress_dex == nil {
|
2020-05-20 23:20:28 +02:00
|
|
|
// If the value was not force-set by the user, use reasonable default based on the module.
|
2020-07-10 00:16:41 +02:00
|
|
|
a.dexProperties.Uncompress_dex = proptools.BoolPtr(a.shouldUncompressDex(ctx))
|
2020-05-20 23:20:28 +02:00
|
|
|
}
|
2020-07-10 00:16:41 +02:00
|
|
|
a.dexpreopter.uncompressedDex = *a.dexProperties.Uncompress_dex
|
2019-05-16 21:28:22 +02:00
|
|
|
a.dexpreopter.enforceUsesLibs = a.usesLibrary.enforceUsesLibraries()
|
2020-10-08 13:53:58 +02:00
|
|
|
a.dexpreopter.classLoaderContexts = a.classLoaderContexts
|
2019-05-16 21:28:22 +02:00
|
|
|
a.dexpreopter.manifestFile = a.mergedManifestFile
|
2021-11-11 01:42:38 +01:00
|
|
|
a.dexpreopter.preventInstall = a.appProperties.PreventInstall
|
2019-05-16 21:28:22 +02:00
|
|
|
|
2023-11-27 09:44:03 +01:00
|
|
|
var packageResources = a.exportPackage
|
|
|
|
|
2017-11-23 01:20:45 +01:00
|
|
|
if ctx.ModuleName() != "framework-res" {
|
2024-03-13 13:09:17 +01:00
|
|
|
if a.dexProperties.resourceShrinkingEnabled() {
|
2023-11-27 09:44:03 +01:00
|
|
|
protoFile := android.PathForModuleOut(ctx, packageResources.Base()+".proto.apk")
|
|
|
|
aapt2Convert(ctx, protoFile, packageResources, "proto")
|
|
|
|
a.dexer.resourcesInput = android.OptionalPathForPath(protoFile)
|
|
|
|
}
|
|
|
|
|
2023-06-21 07:40:02 +02:00
|
|
|
var extraSrcJars android.Paths
|
|
|
|
var extraClasspathJars android.Paths
|
|
|
|
var extraCombinedJars android.Paths
|
2024-01-25 22:39:06 +01:00
|
|
|
if a.useResourceProcessorBusyBox(ctx) {
|
2023-06-21 07:40:02 +02:00
|
|
|
// When building an app with ResourceProcessorBusyBox enabled ResourceProcessorBusyBox has already
|
|
|
|
// created R.class files that provide IDs for resources in busybox/R.jar. Pass that file in the
|
|
|
|
// classpath when compiling everything else, and add it to the final classes jar.
|
|
|
|
extraClasspathJars = android.Paths{a.aapt.rJar}
|
|
|
|
extraCombinedJars = android.Paths{a.aapt.rJar}
|
|
|
|
} else {
|
|
|
|
// When building an app without ResourceProcessorBusyBox the aapt2 rule creates R.srcjar containing
|
|
|
|
// R.java files for the app's package and the packages from all transitive static android_library
|
|
|
|
// dependencies. Compile the srcjar alongside the rest of the sources.
|
|
|
|
extraSrcJars = android.Paths{a.aapt.aaptSrcJar}
|
|
|
|
}
|
|
|
|
|
|
|
|
a.Module.compile(ctx, extraSrcJars, extraClasspathJars, extraCombinedJars)
|
2024-03-13 13:09:17 +01:00
|
|
|
if a.dexProperties.resourceShrinkingEnabled() {
|
2023-11-27 09:44:03 +01:00
|
|
|
binaryResources := android.PathForModuleOut(ctx, packageResources.Base()+".binary.out.apk")
|
|
|
|
aapt2Convert(ctx, binaryResources, a.dexer.resourcesOutput.Path(), "binary")
|
|
|
|
packageResources = binaryResources
|
|
|
|
}
|
2017-11-23 01:20:45 +01:00
|
|
|
}
|
2015-04-13 22:58:27 +02:00
|
|
|
|
2023-11-27 09:44:03 +01:00
|
|
|
return a.dexJarFile.PathOrNil(), packageResources
|
2019-01-23 01:40:58 +01:00
|
|
|
}
|
2018-10-05 00:21:03 +02:00
|
|
|
|
2022-06-10 19:05:42 +02:00
|
|
|
func (a *AndroidApp) jniBuildActions(jniLibs []jniLib, prebuiltJniPackages android.Paths, ctx android.ModuleContext) android.WritablePath {
|
2018-10-03 07:03:40 +02:00
|
|
|
var jniJarFile android.WritablePath
|
2022-06-10 19:05:42 +02:00
|
|
|
if len(jniLibs) > 0 || len(prebuiltJniPackages) > 0 {
|
2020-07-06 23:15:24 +02:00
|
|
|
a.jniLibs = jniLibs
|
2019-05-07 00:48:44 +02:00
|
|
|
if a.shouldEmbedJnis(ctx) {
|
2018-10-03 07:03:40 +02:00
|
|
|
jniJarFile = android.PathForModuleOut(ctx, "jnilibs.zip")
|
2021-11-12 03:59:15 +01:00
|
|
|
a.installPathForJNISymbols = a.installPath(ctx)
|
2022-06-10 19:05:42 +02:00
|
|
|
TransformJniLibsToJar(ctx, jniJarFile, jniLibs, prebuiltJniPackages, a.useEmbeddedNativeLibs(ctx))
|
2020-03-26 22:01:48 +01:00
|
|
|
for _, jni := range jniLibs {
|
|
|
|
if jni.coverageFile.Valid() {
|
2020-04-07 22:07:55 +02:00
|
|
|
// Only collect coverage for the first target arch if this is a multilib target.
|
|
|
|
// TODO(jungjw): Ideally, we want to collect both reports, but that would cause coverage
|
|
|
|
// data file path collisions since the current coverage file path format doesn't contain
|
|
|
|
// arch-related strings. This is fine for now though; the code coverage team doesn't use
|
|
|
|
// multi-arch targets such as test_suite_* for coverage collections yet.
|
|
|
|
//
|
|
|
|
// Work with the team to come up with a new format that handles multilib modules properly
|
|
|
|
// and change this.
|
|
|
|
if len(ctx.Config().Targets[android.Android]) == 1 ||
|
2020-10-10 02:25:15 +02:00
|
|
|
ctx.Config().AndroidFirstDeviceTarget.Arch.ArchType == jni.target.Arch.ArchType {
|
2020-04-07 22:07:55 +02:00
|
|
|
a.jniCoverageOutputs = append(a.jniCoverageOutputs, jni.coverageFile.Path())
|
|
|
|
}
|
2020-03-26 22:01:48 +01:00
|
|
|
}
|
|
|
|
}
|
2020-07-06 23:15:24 +02:00
|
|
|
a.embeddedJniLibs = true
|
2018-10-03 07:03:40 +02:00
|
|
|
}
|
|
|
|
}
|
2019-01-23 01:40:58 +01:00
|
|
|
return jniJarFile
|
|
|
|
}
|
2018-10-03 07:03:40 +02:00
|
|
|
|
2020-07-06 23:15:24 +02:00
|
|
|
func (a *AndroidApp) JNISymbolsInstalls(installPath string) android.RuleBuilderInstalls {
|
|
|
|
var jniSymbols android.RuleBuilderInstalls
|
|
|
|
for _, jniLib := range a.jniLibs {
|
|
|
|
if jniLib.unstrippedFile != nil {
|
|
|
|
jniSymbols = append(jniSymbols, android.RuleBuilderInstall{
|
|
|
|
From: jniLib.unstrippedFile,
|
|
|
|
To: filepath.Join(installPath, targetToJniDir(jniLib.target), jniLib.unstrippedFile.Base()),
|
|
|
|
})
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return jniSymbols
|
|
|
|
}
|
|
|
|
|
2019-04-15 18:48:31 +02:00
|
|
|
// Reads and prepends a main cert from the default cert dir if it hasn't been set already, i.e. it
|
|
|
|
// isn't a cert module reference. Also checks and enforces system cert restriction if applicable.
|
2022-09-14 21:45:42 +02:00
|
|
|
func processMainCert(m android.ModuleBase, certPropValue string, certificates []Certificate,
|
|
|
|
ctx android.ModuleContext) (mainCertificate Certificate, allCertificates []Certificate) {
|
2019-04-15 18:48:31 +02:00
|
|
|
if android.SrcIsModule(certPropValue) == "" {
|
|
|
|
var mainCert Certificate
|
|
|
|
if certPropValue != "" {
|
|
|
|
defaultDir := ctx.Config().DefaultAppCertificateDir(ctx)
|
|
|
|
mainCert = Certificate{
|
2020-01-28 23:00:53 +01:00
|
|
|
Pem: defaultDir.Join(ctx, certPropValue+".x509.pem"),
|
|
|
|
Key: defaultDir.Join(ctx, certPropValue+".pk8"),
|
2019-04-15 18:48:31 +02:00
|
|
|
}
|
|
|
|
} else {
|
|
|
|
pem, key := ctx.Config().DefaultAppCertificate(ctx)
|
2020-01-28 23:00:53 +01:00
|
|
|
mainCert = Certificate{
|
|
|
|
Pem: pem,
|
|
|
|
Key: key,
|
|
|
|
}
|
2018-10-05 00:21:03 +02:00
|
|
|
}
|
2019-04-15 18:48:31 +02:00
|
|
|
certificates = append([]Certificate{mainCert}, certificates...)
|
2018-10-05 00:21:03 +02:00
|
|
|
}
|
|
|
|
|
2022-09-14 21:45:42 +02:00
|
|
|
if len(certificates) > 0 {
|
|
|
|
mainCertificate = certificates[0]
|
|
|
|
} else {
|
|
|
|
// This can be reached with an empty certificate list if AllowMissingDependencies is set
|
|
|
|
// and the certificate property for this module is a module reference to a missing module.
|
|
|
|
if !ctx.Config().AllowMissingDependencies() && len(ctx.GetMissingDependencies()) > 0 {
|
|
|
|
panic("Should only get here if AllowMissingDependencies set and there are missing dependencies")
|
|
|
|
}
|
|
|
|
// Set a certificate to avoid panics later when accessing it.
|
|
|
|
mainCertificate = Certificate{
|
|
|
|
Key: android.PathForModuleOut(ctx, "missing.pk8"),
|
2022-11-21 05:35:53 +01:00
|
|
|
Pem: android.PathForModuleOut(ctx, "missing.x509.pem"),
|
2022-09-14 21:45:42 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-05-18 09:46:31 +02:00
|
|
|
if !m.Platform() {
|
|
|
|
certPath := mainCertificate.Pem.String()
|
|
|
|
systemCertPath := ctx.Config().DefaultAppCertificateDir(ctx).String()
|
|
|
|
if strings.HasPrefix(certPath, systemCertPath) {
|
|
|
|
enforceSystemCert := ctx.Config().EnforceSystemCertificate()
|
|
|
|
allowed := ctx.Config().EnforceSystemCertificateAllowList()
|
|
|
|
|
|
|
|
if enforceSystemCert && !inList(m.Name(), allowed) {
|
|
|
|
ctx.PropertyErrorf("certificate", "The module in product partition cannot be signed with certificate in system.")
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2022-09-14 21:45:42 +02:00
|
|
|
return mainCertificate, certificates
|
2019-01-23 01:40:58 +01:00
|
|
|
}
|
|
|
|
|
2020-03-23 12:21:11 +01:00
|
|
|
func (a *AndroidApp) InstallApkName() string {
|
|
|
|
return a.installApkName
|
|
|
|
}
|
|
|
|
|
2023-05-15 23:21:47 +02:00
|
|
|
func (a *AndroidApp) createPrivappAllowlist(ctx android.ModuleContext) android.Path {
|
2022-08-17 18:53:46 +02:00
|
|
|
if a.appProperties.Privapp_allowlist == nil {
|
|
|
|
return nil
|
|
|
|
}
|
2023-05-15 23:21:47 +02:00
|
|
|
|
|
|
|
isOverrideApp := a.GetOverriddenBy() != ""
|
|
|
|
if !isOverrideApp {
|
|
|
|
// if this is not an override, we don't need to rewrite the existing privapp allowlist
|
|
|
|
return android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist)
|
|
|
|
}
|
|
|
|
|
2022-08-17 18:53:46 +02:00
|
|
|
if a.overridableAppProperties.Package_name == nil {
|
|
|
|
ctx.PropertyErrorf("privapp_allowlist", "package_name must be set to use privapp_allowlist")
|
|
|
|
}
|
2023-05-15 23:21:47 +02:00
|
|
|
|
2022-08-17 18:53:46 +02:00
|
|
|
packageName := *a.overridableAppProperties.Package_name
|
|
|
|
fileName := "privapp_allowlist_" + packageName + ".xml"
|
|
|
|
outPath := android.PathForModuleOut(ctx, fileName).OutputPath
|
|
|
|
ctx.Build(pctx, android.BuildParams{
|
|
|
|
Rule: modifyAllowlist,
|
|
|
|
Input: android.PathForModuleSrc(ctx, *a.appProperties.Privapp_allowlist),
|
|
|
|
Output: outPath,
|
|
|
|
Args: map[string]string{
|
|
|
|
"packageName": packageName,
|
|
|
|
},
|
|
|
|
})
|
|
|
|
return &outPath
|
|
|
|
}
|
|
|
|
|
2019-01-23 01:40:58 +01:00
|
|
|
func (a *AndroidApp) generateAndroidBuildActions(ctx android.ModuleContext) {
|
2019-05-16 21:28:22 +02:00
|
|
|
var apkDeps android.Paths
|
|
|
|
|
2023-12-14 00:54:49 +01:00
|
|
|
apexInfo, _ := android.ModuleProvider(ctx, android.ApexInfoProvider)
|
|
|
|
if !apexInfo.IsForPlatform() {
|
2020-09-16 03:30:11 +02:00
|
|
|
a.hideApexVariantFromMake = true
|
|
|
|
}
|
|
|
|
|
2019-07-11 08:54:27 +02:00
|
|
|
a.aapt.useEmbeddedNativeLibs = a.useEmbeddedNativeLibs(ctx)
|
|
|
|
a.aapt.useEmbeddedDex = Bool(a.appProperties.Use_embedded_dex)
|
|
|
|
|
2023-07-01 02:13:47 +02:00
|
|
|
// Unlike installApkName, a.stem should respect base module name for override_android_app.
|
|
|
|
// Therefore, use ctx.ModuleName() instead of a.Name().
|
2024-03-15 10:29:29 +01:00
|
|
|
a.stem = proptools.StringDefault(a.overridableProperties.Stem, ctx.ModuleName())
|
2023-07-01 02:13:47 +02:00
|
|
|
|
2019-01-24 01:27:47 +01:00
|
|
|
// Check if the install APK name needs to be overridden.
|
2023-07-01 02:13:47 +02:00
|
|
|
// Both android_app and override_android_app module are expected to possess
|
|
|
|
// its module bound apk path. However, override_android_app inherits ctx.ModuleName()
|
|
|
|
// from the base module. Therefore, use a.Name() which represents
|
|
|
|
// the module name for both android_app and override_android_app.
|
|
|
|
a.installApkName = ctx.DeviceConfig().OverridePackageNameFor(
|
2024-03-15 10:29:29 +01:00
|
|
|
proptools.StringDefault(a.overridableProperties.Stem, a.Name()))
|
2019-01-24 01:27:47 +01:00
|
|
|
|
2019-06-18 02:40:56 +02:00
|
|
|
if ctx.ModuleName() == "framework-res" {
|
|
|
|
// framework-res.apk is installed as system/framework/framework-res.apk
|
2019-09-11 19:25:18 +02:00
|
|
|
a.installDir = android.PathForModuleInstall(ctx, "framework")
|
2019-10-17 05:54:30 +02:00
|
|
|
} else if a.Privileged() {
|
2019-09-11 19:25:18 +02:00
|
|
|
a.installDir = android.PathForModuleInstall(ctx, "priv-app", a.installApkName)
|
|
|
|
} else if ctx.InstallInTestcases() {
|
2019-11-21 19:41:00 +01:00
|
|
|
a.installDir = android.PathForModuleInstall(ctx, a.installApkName, ctx.DeviceConfig().DeviceArch())
|
2019-06-18 02:40:56 +02:00
|
|
|
} else {
|
2019-09-11 19:25:18 +02:00
|
|
|
a.installDir = android.PathForModuleInstall(ctx, "app", a.installApkName)
|
2019-06-18 02:40:56 +02:00
|
|
|
}
|
2019-09-28 02:13:15 +02:00
|
|
|
a.onDeviceDir = android.InstallPathToOnDevicePath(ctx, a.installDir)
|
2019-06-18 02:40:56 +02:00
|
|
|
|
2020-10-08 13:53:58 +02:00
|
|
|
a.classLoaderContexts = a.usesLibrary.classLoaderContextForUsesLibDeps(ctx)
|
2024-02-13 17:37:43 +01:00
|
|
|
if a.usesLibrary.shouldDisableDexpreopt {
|
|
|
|
a.dexpreopter.disableDexpreopt()
|
|
|
|
}
|
2020-11-03 16:55:11 +01:00
|
|
|
|
2022-06-23 19:46:28 +02:00
|
|
|
var noticeAssetPath android.WritablePath
|
|
|
|
if Bool(a.appProperties.Embed_notices) || ctx.Config().IsEnvTrue("ALWAYS_EMBED_NOTICES") {
|
|
|
|
// The rule to create the notice file can't be generated yet, as the final output path
|
|
|
|
// for the apk isn't known yet. Add the path where the notice file will be generated to the
|
|
|
|
// aapt rules now before calling aaptBuildActions, the rule to create the notice file will
|
|
|
|
// be generated later.
|
|
|
|
noticeAssetPath = android.PathForModuleOut(ctx, "NOTICE", "NOTICE.html.gz")
|
|
|
|
a.aapt.noticeFile = android.OptionalPathForPath(noticeAssetPath)
|
|
|
|
}
|
|
|
|
|
2023-01-09 21:45:55 +01:00
|
|
|
// For apps targeting latest target_sdk_version
|
|
|
|
if Bool(a.appProperties.Enforce_default_target_sdk_version) {
|
|
|
|
a.SetEnforceDefaultTargetSdkVersion(true)
|
|
|
|
}
|
|
|
|
|
2019-01-23 01:40:58 +01:00
|
|
|
// Process all building blocks, from AAPT to certificates.
|
|
|
|
a.aaptBuildActions(ctx)
|
2020-08-19 17:32:54 +02:00
|
|
|
// The decision to enforce <uses-library> checks is made before adding implicit SDK libraries.
|
|
|
|
a.usesLibrary.freezeEnforceUsesLibraries()
|
|
|
|
|
|
|
|
// Check that the <uses-library> list is coherent with the manifest.
|
2019-05-16 21:28:22 +02:00
|
|
|
if a.usesLibrary.enforceUsesLibraries() {
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
manifestCheckFile := a.usesLibrary.verifyUsesLibrariesManifest(
|
|
|
|
ctx, a.mergedManifestFile, &a.classLoaderContexts)
|
2019-05-16 21:28:22 +02:00
|
|
|
apkDeps = append(apkDeps, manifestCheckFile)
|
|
|
|
}
|
|
|
|
|
2019-01-23 01:40:58 +01:00
|
|
|
a.proguardBuildActions(ctx)
|
|
|
|
|
2020-06-03 05:09:13 +02:00
|
|
|
a.linter.mergedManifest = a.aapt.mergedManifestFile
|
|
|
|
a.linter.manifest = a.aapt.manifestPath
|
|
|
|
a.linter.resources = a.aapt.resourceFiles
|
2020-07-03 20:56:24 +02:00
|
|
|
a.linter.buildModuleReportZip = ctx.Config().UnbundledBuildApps()
|
2020-06-03 05:09:13 +02:00
|
|
|
|
2023-11-27 09:44:03 +01:00
|
|
|
dexJarFile, packageResources := a.dexBuildActions(ctx)
|
2019-01-23 01:40:58 +01:00
|
|
|
|
2022-09-14 21:45:42 +02:00
|
|
|
jniLibs, prebuiltJniPackages, certificates := collectAppDeps(ctx, a, a.shouldEmbedJnis(ctx), !Bool(a.appProperties.Jni_uses_platform_apis))
|
2022-06-10 19:05:42 +02:00
|
|
|
jniJarFile := a.jniBuildActions(jniLibs, prebuiltJniPackages, ctx)
|
2019-01-23 01:40:58 +01:00
|
|
|
|
|
|
|
if ctx.Failed() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2022-09-14 21:45:42 +02:00
|
|
|
a.certificate, certificates = processMainCert(a.ModuleBase, a.getCertString(ctx), certificates, ctx)
|
2019-01-23 01:40:58 +01:00
|
|
|
|
|
|
|
// Build a final signed app package.
|
2019-11-07 23:14:38 +01:00
|
|
|
packageFile := android.PathForModuleOut(ctx, a.installApkName+".apk")
|
2020-03-25 04:32:24 +01:00
|
|
|
v4SigningRequested := Bool(a.Module.deviceProperties.V4_signature)
|
|
|
|
var v4SignatureFile android.WritablePath = nil
|
|
|
|
if v4SigningRequested {
|
|
|
|
v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+".apk.idsig")
|
|
|
|
}
|
2020-05-07 22:24:05 +02:00
|
|
|
var lineageFile android.Path
|
|
|
|
if lineage := String(a.overridableAppProperties.Lineage); lineage != "" {
|
|
|
|
lineageFile = android.PathForModuleSrc(ctx, lineage)
|
|
|
|
}
|
2021-11-03 15:39:39 +01:00
|
|
|
rotationMinSdkVersion := String(a.overridableAppProperties.RotationMinSdkVersion)
|
|
|
|
|
2023-11-27 09:44:03 +01:00
|
|
|
CreateAndSignAppPackage(ctx, packageFile, packageResources, jniJarFile, dexJarFile, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion)
|
2017-11-23 01:19:37 +01:00
|
|
|
a.outputFile = packageFile
|
2020-03-25 04:32:24 +01:00
|
|
|
if v4SigningRequested {
|
|
|
|
a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
|
|
|
|
}
|
2017-11-23 01:19:37 +01:00
|
|
|
|
2022-06-23 19:46:28 +02:00
|
|
|
if a.aapt.noticeFile.Valid() {
|
|
|
|
// Generating the notice file rule has to be here after a.outputFile is known.
|
2022-05-16 21:20:04 +02:00
|
|
|
noticeFile := android.PathForModuleOut(ctx, "NOTICE.html.gz")
|
2022-06-09 00:59:35 +02:00
|
|
|
android.BuildNoticeHtmlOutputFromLicenseMetadata(
|
|
|
|
ctx, noticeFile, "", "",
|
|
|
|
[]string{
|
|
|
|
a.installDir.String() + "/",
|
|
|
|
android.PathForModuleInstall(ctx).String() + "/",
|
|
|
|
a.outputFile.String(),
|
|
|
|
})
|
2022-05-16 21:20:04 +02:00
|
|
|
builder := android.NewRuleBuilder(pctx, ctx)
|
|
|
|
builder.Command().Text("cp").
|
|
|
|
Input(noticeFile).
|
|
|
|
Output(noticeAssetPath)
|
|
|
|
builder.Build("notice_dir", "Building notice dir")
|
|
|
|
}
|
|
|
|
|
2019-03-20 00:03:11 +01:00
|
|
|
for _, split := range a.aapt.splits {
|
|
|
|
// Sign the split APKs
|
2019-11-07 23:14:38 +01:00
|
|
|
packageFile := android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk")
|
2020-03-25 04:32:24 +01:00
|
|
|
if v4SigningRequested {
|
|
|
|
v4SignatureFile = android.PathForModuleOut(ctx, a.installApkName+"_"+split.suffix+".apk.idsig")
|
|
|
|
}
|
2023-11-27 09:44:03 +01:00
|
|
|
CreateAndSignAppPackage(ctx, packageFile, split.path, nil, nil, certificates, apkDeps, v4SignatureFile, lineageFile, rotationMinSdkVersion)
|
2019-03-20 00:03:11 +01:00
|
|
|
a.extraOutputFiles = append(a.extraOutputFiles, packageFile)
|
2020-03-25 04:32:24 +01:00
|
|
|
if v4SigningRequested {
|
|
|
|
a.extraOutputFiles = append(a.extraOutputFiles, v4SignatureFile)
|
|
|
|
}
|
2019-03-20 00:03:11 +01:00
|
|
|
}
|
|
|
|
|
2019-01-23 01:40:58 +01:00
|
|
|
// Build an app bundle.
|
2018-10-30 07:14:58 +01:00
|
|
|
bundleFile := android.PathForModuleOut(ctx, "base.zip")
|
|
|
|
BuildBundleModule(ctx, bundleFile, a.exportPackage, jniJarFile, dexJarFile)
|
|
|
|
a.bundleFile = bundleFile
|
|
|
|
|
2022-08-17 18:53:46 +02:00
|
|
|
allowlist := a.createPrivappAllowlist(ctx)
|
|
|
|
if allowlist != nil {
|
|
|
|
a.privAppAllowlist = android.OptionalPathForPath(allowlist)
|
|
|
|
}
|
|
|
|
|
2019-01-23 01:40:58 +01:00
|
|
|
// Install the app package.
|
2022-08-17 18:53:46 +02:00
|
|
|
shouldInstallAppPackage := (Bool(a.Module.properties.Installable) || ctx.Host()) && apexInfo.IsForPlatform() && !a.appProperties.PreventInstall
|
|
|
|
if shouldInstallAppPackage {
|
2023-05-25 20:45:30 +02:00
|
|
|
if a.privAppAllowlist.Valid() {
|
2023-06-01 18:38:35 +02:00
|
|
|
allowlistInstallPath := android.PathForModuleInstall(ctx, "etc", "permissions")
|
|
|
|
allowlistInstallFilename := a.installApkName + ".xml"
|
|
|
|
ctx.InstallFile(allowlistInstallPath, allowlistInstallFilename, a.privAppAllowlist.Path())
|
2023-05-25 20:45:30 +02:00
|
|
|
}
|
|
|
|
|
2023-11-15 21:29:33 +01:00
|
|
|
var extraInstalledPaths android.InstallPaths
|
2019-11-13 07:01:01 +01:00
|
|
|
for _, extra := range a.extraOutputFiles {
|
2021-11-03 22:08:20 +01:00
|
|
|
installed := ctx.InstallFile(a.installDir, extra.Base(), extra)
|
|
|
|
extraInstalledPaths = append(extraInstalledPaths, installed)
|
2019-11-13 07:01:01 +01:00
|
|
|
}
|
2021-11-03 22:08:20 +01:00
|
|
|
ctx.InstallFile(a.installDir, a.outputFile.Base(), a.outputFile, extraInstalledPaths...)
|
2017-11-23 01:20:45 +01:00
|
|
|
}
|
2020-04-27 20:05:28 +02:00
|
|
|
|
|
|
|
a.buildAppDependencyInfo(ctx)
|
2024-03-11 22:37:25 +01:00
|
|
|
|
|
|
|
providePrebuiltInfo(ctx,
|
|
|
|
prebuiltInfoProps{
|
|
|
|
baseModuleName: a.BaseModuleName(),
|
|
|
|
isPrebuilt: false,
|
|
|
|
},
|
|
|
|
)
|
2015-04-13 22:58:27 +02:00
|
|
|
}
|
|
|
|
|
2020-05-13 20:05:02 +02:00
|
|
|
type appDepsInterface interface {
|
2021-04-02 01:45:46 +02:00
|
|
|
SdkVersion(ctx android.EarlyModuleContext) android.SdkSpec
|
2023-03-03 22:20:36 +01:00
|
|
|
MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
|
2020-05-13 20:05:02 +02:00
|
|
|
RequiresStableAPIs(ctx android.BaseModuleContext) bool
|
|
|
|
}
|
|
|
|
|
|
|
|
func collectAppDeps(ctx android.ModuleContext, app appDepsInterface,
|
|
|
|
shouldCollectRecursiveNativeDeps bool,
|
2022-06-10 19:05:42 +02:00
|
|
|
checkNativeSdkVersion bool) ([]jniLib, android.Paths, []Certificate) {
|
2020-05-13 20:05:02 +02:00
|
|
|
|
|
|
|
if checkNativeSdkVersion {
|
2021-04-02 01:45:46 +02:00
|
|
|
checkNativeSdkVersion = app.SdkVersion(ctx).Specified() &&
|
|
|
|
app.SdkVersion(ctx).Kind != android.SdkCorePlatform && !app.RequiresStableAPIs(ctx)
|
2020-05-13 20:05:02 +02:00
|
|
|
}
|
2024-02-10 01:15:21 +01:00
|
|
|
jniLib, prebuiltJniPackages := collectJniDeps(ctx, shouldCollectRecursiveNativeDeps,
|
|
|
|
checkNativeSdkVersion, func(dep cc.LinkableInterface) bool {
|
|
|
|
return !dep.IsNdk(ctx.Config()) && !dep.IsStubs()
|
|
|
|
})
|
|
|
|
|
|
|
|
var certificates []Certificate
|
|
|
|
|
|
|
|
ctx.VisitDirectDeps(func(module android.Module) {
|
|
|
|
otherName := ctx.OtherModuleName(module)
|
|
|
|
tag := ctx.OtherModuleDependencyTag(module)
|
|
|
|
|
|
|
|
if tag == certificateTag {
|
|
|
|
if dep, ok := module.(*AndroidAppCertificate); ok {
|
|
|
|
certificates = append(certificates, dep.Certificate)
|
|
|
|
} else {
|
|
|
|
ctx.ModuleErrorf("certificate dependency %q must be an android_app_certificate module", otherName)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
})
|
|
|
|
return jniLib, prebuiltJniPackages, certificates
|
|
|
|
}
|
|
|
|
|
|
|
|
func collectJniDeps(ctx android.ModuleContext,
|
|
|
|
shouldCollectRecursiveNativeDeps bool,
|
|
|
|
checkNativeSdkVersion bool,
|
|
|
|
filter func(cc.LinkableInterface) bool) ([]jniLib, android.Paths) {
|
|
|
|
var jniLibs []jniLib
|
|
|
|
var prebuiltJniPackages android.Paths
|
|
|
|
seenModulePaths := make(map[string]bool)
|
2020-05-13 20:05:02 +02:00
|
|
|
|
2019-12-18 01:46:18 +01:00
|
|
|
ctx.WalkDeps(func(module android.Module, parent android.Module) bool {
|
2018-10-03 07:03:40 +02:00
|
|
|
otherName := ctx.OtherModuleName(module)
|
|
|
|
tag := ctx.OtherModuleDependencyTag(module)
|
|
|
|
|
2020-07-29 21:59:39 +02:00
|
|
|
if IsJniDepTag(tag) || cc.IsSharedDepTag(tag) {
|
2022-06-27 22:00:26 +02:00
|
|
|
if dep, ok := module.(cc.LinkableInterface); ok {
|
2024-02-10 01:15:21 +01:00
|
|
|
if filter != nil && !filter(dep) {
|
2019-12-18 01:46:18 +01:00
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
2018-10-03 07:03:40 +02:00
|
|
|
lib := dep.OutputFile()
|
2021-09-15 02:32:49 +02:00
|
|
|
if lib.Valid() {
|
|
|
|
path := lib.Path()
|
|
|
|
if seenModulePaths[path.String()] {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
seenModulePaths[path.String()] = true
|
2019-12-18 01:46:18 +01:00
|
|
|
|
2021-09-15 02:32:49 +02:00
|
|
|
if checkNativeSdkVersion && dep.SdkVersion() == "" {
|
|
|
|
ctx.PropertyErrorf("jni_libs", "JNI dependency %q uses platform APIs, but this module does not",
|
|
|
|
otherName)
|
|
|
|
}
|
2020-02-15 19:38:00 +01:00
|
|
|
|
2018-10-03 07:03:40 +02:00
|
|
|
jniLibs = append(jniLibs, jniLib{
|
2020-07-06 23:15:24 +02:00
|
|
|
name: ctx.OtherModuleName(module),
|
|
|
|
path: path,
|
|
|
|
target: module.Target(),
|
|
|
|
coverageFile: dep.CoverageOutputFile(),
|
|
|
|
unstrippedFile: dep.UnstrippedOutputFile(),
|
2022-09-02 00:47:07 +02:00
|
|
|
partition: dep.Partition(),
|
2018-10-03 07:03:40 +02:00
|
|
|
})
|
2022-12-19 21:26:43 +01:00
|
|
|
} else if ctx.Config().AllowMissingDependencies() {
|
|
|
|
ctx.AddMissingDependencies([]string{otherName})
|
2018-10-03 07:03:40 +02:00
|
|
|
} else {
|
|
|
|
ctx.ModuleErrorf("dependency %q missing output file", otherName)
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
ctx.ModuleErrorf("jni_libs dependency %q must be a cc library", otherName)
|
|
|
|
}
|
2019-12-18 01:46:18 +01:00
|
|
|
|
|
|
|
return shouldCollectRecursiveNativeDeps
|
|
|
|
}
|
|
|
|
|
2023-12-13 22:47:44 +01:00
|
|
|
if info, ok := android.OtherModuleProvider(ctx, module, JniPackageProvider); ok {
|
2022-06-10 19:05:42 +02:00
|
|
|
prebuiltJniPackages = append(prebuiltJniPackages, info.JniPackages...)
|
|
|
|
}
|
|
|
|
|
2019-12-18 01:46:18 +01:00
|
|
|
return false
|
2018-10-03 07:03:40 +02:00
|
|
|
})
|
|
|
|
|
2024-02-10 01:15:21 +01:00
|
|
|
return jniLibs, prebuiltJniPackages
|
2018-10-03 07:03:40 +02:00
|
|
|
}
|
|
|
|
|
2020-04-15 04:03:39 +02:00
|
|
|
func (a *AndroidApp) WalkPayloadDeps(ctx android.ModuleContext, do android.PayloadDepsCallback) {
|
2020-04-27 20:05:28 +02:00
|
|
|
ctx.WalkDeps(func(child, parent android.Module) bool {
|
|
|
|
isExternal := !a.DepIsInSameApex(ctx, child)
|
|
|
|
if am, ok := child.(android.ApexModule); ok {
|
2020-04-15 04:03:39 +02:00
|
|
|
if !do(ctx, parent, am, isExternal) {
|
|
|
|
return false
|
|
|
|
}
|
2020-04-27 20:05:28 +02:00
|
|
|
}
|
|
|
|
return !isExternal
|
|
|
|
})
|
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidApp) buildAppDependencyInfo(ctx android.ModuleContext) {
|
|
|
|
if ctx.Host() {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
depsInfo := android.DepNameToDepInfoMap{}
|
2020-04-15 04:03:39 +02:00
|
|
|
a.WalkPayloadDeps(ctx, func(ctx android.ModuleContext, from blueprint.Module, to android.ApexModule, externalDep bool) bool {
|
2020-04-27 20:05:28 +02:00
|
|
|
depName := to.Name()
|
2021-03-11 19:03:42 +01:00
|
|
|
|
|
|
|
// Skip dependencies that are only available to APEXes; they are developed with updatability
|
|
|
|
// in mind and don't need manual approval.
|
|
|
|
if to.(android.ApexModule).NotAvailableForPlatform() {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2020-04-27 20:05:28 +02:00
|
|
|
if info, exist := depsInfo[depName]; exist {
|
|
|
|
info.From = append(info.From, from.Name())
|
|
|
|
info.IsExternal = info.IsExternal && externalDep
|
|
|
|
depsInfo[depName] = info
|
|
|
|
} else {
|
|
|
|
toMinSdkVersion := "(no version)"
|
2021-04-02 01:45:46 +02:00
|
|
|
if m, ok := to.(interface {
|
2023-03-03 22:20:36 +01:00
|
|
|
MinSdkVersion(ctx android.EarlyModuleContext) android.ApiLevel
|
2021-04-02 01:45:46 +02:00
|
|
|
}); ok {
|
2023-03-03 22:20:36 +01:00
|
|
|
if v := m.MinSdkVersion(ctx); !v.IsNone() {
|
|
|
|
toMinSdkVersion = v.String()
|
2020-04-27 20:05:28 +02:00
|
|
|
}
|
2021-04-02 01:45:46 +02:00
|
|
|
} else if m, ok := to.(interface{ MinSdkVersion() string }); ok {
|
|
|
|
// TODO(b/175678607) eliminate the use of MinSdkVersion returning
|
|
|
|
// string
|
|
|
|
if v := m.MinSdkVersion(); v != "" {
|
2021-03-29 13:11:58 +02:00
|
|
|
toMinSdkVersion = v
|
|
|
|
}
|
2020-04-27 20:05:28 +02:00
|
|
|
}
|
|
|
|
depsInfo[depName] = android.ApexModuleDepInfo{
|
|
|
|
To: depName,
|
|
|
|
From: []string{from.Name()},
|
|
|
|
IsExternal: externalDep,
|
|
|
|
MinSdkVersion: toMinSdkVersion,
|
|
|
|
}
|
|
|
|
}
|
2020-04-15 04:03:39 +02:00
|
|
|
return true
|
2020-04-27 20:05:28 +02:00
|
|
|
})
|
|
|
|
|
2021-04-02 01:45:46 +02:00
|
|
|
a.ApexBundleDepsInfo.BuildDepsInfoLists(ctx, a.MinSdkVersion(ctx).String(), depsInfo)
|
2020-04-27 20:05:28 +02:00
|
|
|
}
|
|
|
|
|
2022-06-10 13:24:05 +02:00
|
|
|
func (a *AndroidApp) enforceDefaultTargetSdkVersion() bool {
|
|
|
|
return a.appProperties.EnforceDefaultTargetSdkVersion
|
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidApp) SetEnforceDefaultTargetSdkVersion(val bool) {
|
|
|
|
a.appProperties.EnforceDefaultTargetSdkVersion = val
|
|
|
|
}
|
|
|
|
|
2020-04-28 15:57:42 +02:00
|
|
|
func (a *AndroidApp) Updatable() bool {
|
2020-09-16 03:30:11 +02:00
|
|
|
return Bool(a.appProperties.Updatable)
|
2020-04-28 15:57:42 +02:00
|
|
|
}
|
|
|
|
|
2022-05-07 00:12:55 +02:00
|
|
|
func (a *AndroidApp) SetUpdatable(val bool) {
|
|
|
|
a.appProperties.Updatable = &val
|
|
|
|
}
|
|
|
|
|
2019-06-06 23:33:29 +02:00
|
|
|
func (a *AndroidApp) getCertString(ctx android.BaseModuleContext) string {
|
2019-01-18 23:27:16 +01:00
|
|
|
certificate, overridden := ctx.DeviceConfig().OverrideCertificateFor(ctx.ModuleName())
|
|
|
|
if overridden {
|
2019-02-28 17:22:30 +01:00
|
|
|
return ":" + certificate
|
2019-01-18 23:27:16 +01:00
|
|
|
}
|
2019-03-01 00:35:54 +01:00
|
|
|
return String(a.overridableAppProperties.Certificate)
|
2019-01-18 23:27:16 +01:00
|
|
|
}
|
|
|
|
|
apex_available tracks static dependencies
This change fixes a bug that apex_available is not enforced for static
dependencies. For example, a module with 'apex_available:
["//apex_available:platform"]' was able to be statically linked to any
APEX. This was happening because the check was done on the modules that
are actually installed to an APEX. Static dependencies of the modules
were not counted as they are not installed to the APEX as files.
Fixing this bug by doing the check by traversing the tree in the method
checkApexAvailability.
This change includes a few number of related changes:
1) DepIsInSameApex implementation for cc.Module was changed as well.
Previuosly, it returned false only when the dependency is actually a
stub variant of a lib. Now, it returns false when the dependency has one
or more stub variants. To understand why, we need to recall that when
there is a dependency to a lib having stubs, we actually create two
dependencies: to the non-stub variant and to the stub variant during the
DepsMutator phase. And later in the build action generation phase, we
choose one of them depending on the context. Also recall that an APEX
variant is created only when DepIsInSameApex returns true. Given these,
with the previous implementatin of DepIsInSameApex, we did create apex
variants of the non-stub variant of the dependency, while not creating
the apex variant for the stub variant. This is not right; we needlessly
created the apex variant. The extra apex variant has caused no harm so
far, but since the apex_available check became more correct, it actually
breaks the build. To fix the issue, we stop creating the APEX variant
both for non-stub and stub variants.
2) platform variant is created regardless of the apex_available value.
This is required for the case when a library X that provides stub is in
an APEX A and is configured to be available only for A. In that case,
libs in other APEX can't use the stub library since the stub library is
mutated only for apex A. By creating the platform variant for the stub
library, it can be used from outside as the default dependency variation
is set to the platform variant when creating the APEX variations.
3) The ApexAvailableWhitelist is added with the dependencies that were
revealed with this change.
Exempt-From-Owner-Approval: cherry-pick from internal
Bug: 147671264
Test: m
Merged-In: Iaedc05494085ff4e8af227a6392bdd0c338b8e6e
(cherry picked from commit fa89944c79f19552e906b41fd03a4981903eee7e)
Change-Id: Iaedc05494085ff4e8af227a6392bdd0c338b8e6e
2020-01-30 18:49:53 +01:00
|
|
|
func (a *AndroidApp) DepIsInSameApex(ctx android.BaseModuleContext, dep android.Module) bool {
|
|
|
|
if IsJniDepTag(ctx.OtherModuleDependencyTag(dep)) {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
return a.Library.DepIsInSameApex(ctx, dep)
|
|
|
|
}
|
|
|
|
|
2019-08-19 07:56:02 +02:00
|
|
|
// For OutputFileProducer interface
|
|
|
|
func (a *AndroidApp) OutputFiles(tag string) (android.Paths, error) {
|
|
|
|
switch tag {
|
2023-03-31 01:40:24 +02:00
|
|
|
// In some instances, it can be useful to reference the aapt-generated flags from another
|
|
|
|
// target, e.g., system server implements services declared in the framework-res manifest.
|
|
|
|
case ".aapt.proguardOptionsFile":
|
|
|
|
return []android.Path{a.proguardOptionsFile}, nil
|
2019-08-19 07:56:02 +02:00
|
|
|
case ".aapt.srcjar":
|
2023-08-03 00:49:00 +02:00
|
|
|
if a.aaptSrcJar != nil {
|
|
|
|
return []android.Path{a.aaptSrcJar}, nil
|
|
|
|
}
|
|
|
|
case ".aapt.jar":
|
|
|
|
if a.rJar != nil {
|
|
|
|
return []android.Path{a.rJar}, nil
|
|
|
|
}
|
2024-02-14 08:55:33 +01:00
|
|
|
case ".apk":
|
|
|
|
return []android.Path{a.outputFile}, nil
|
2020-08-13 20:37:22 +02:00
|
|
|
case ".export-package.apk":
|
|
|
|
return []android.Path{a.exportPackage}, nil
|
2023-11-07 05:37:14 +01:00
|
|
|
case ".manifest.xml":
|
|
|
|
return []android.Path{a.aapt.manifestPath}, nil
|
2019-08-19 07:56:02 +02:00
|
|
|
}
|
|
|
|
return a.Library.OutputFiles(tag)
|
|
|
|
}
|
|
|
|
|
2019-10-17 05:54:30 +02:00
|
|
|
func (a *AndroidApp) Privileged() bool {
|
|
|
|
return Bool(a.appProperties.Privileged)
|
|
|
|
}
|
|
|
|
|
2024-01-20 00:41:48 +01:00
|
|
|
func (a *AndroidApp) IsNativeCoverageNeeded(ctx android.IncomingTransitionContext) bool {
|
2020-06-17 02:51:46 +02:00
|
|
|
return ctx.Device() && ctx.DeviceConfig().NativeCoverageEnabled()
|
2020-03-26 22:01:48 +01:00
|
|
|
}
|
|
|
|
|
2021-04-01 15:49:36 +02:00
|
|
|
func (a *AndroidApp) SetPreventInstall() {
|
2020-03-26 22:01:48 +01:00
|
|
|
a.appProperties.PreventInstall = true
|
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidApp) MarkAsCoverageVariant(coverage bool) {
|
|
|
|
a.appProperties.IsCoverageVariant = coverage
|
|
|
|
}
|
|
|
|
|
2020-04-09 15:56:02 +02:00
|
|
|
func (a *AndroidApp) EnableCoverageIfNeeded() {}
|
|
|
|
|
2020-03-26 22:01:48 +01:00
|
|
|
var _ cc.Coverage = (*AndroidApp)(nil)
|
|
|
|
|
2023-10-17 22:21:02 +02:00
|
|
|
func (a *AndroidApp) IDEInfo(dpInfo *android.IdeInfo) {
|
|
|
|
a.Library.IDEInfo(dpInfo)
|
|
|
|
a.aapt.IDEInfo(dpInfo)
|
|
|
|
}
|
|
|
|
|
2023-11-07 05:37:14 +01:00
|
|
|
func (a *AndroidApp) productCharacteristicsRROPackageName() string {
|
|
|
|
return proptools.String(a.appProperties.ProductCharacteristicsRROPackageName)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidApp) productCharacteristicsRROManifestModuleName() string {
|
|
|
|
return proptools.String(a.appProperties.ProductCharacteristicsRROManifestModuleName)
|
|
|
|
}
|
|
|
|
|
2019-02-12 23:41:32 +01:00
|
|
|
// android_app compiles sources and Android resources into an Android application package `.apk` file.
|
2017-06-24 00:06:31 +02:00
|
|
|
func AndroidAppFactory() android.Module {
|
2015-04-13 22:58:27 +02:00
|
|
|
module := &AndroidApp{}
|
|
|
|
|
2020-07-10 00:16:41 +02:00
|
|
|
module.Module.dexProperties.Optimize.EnabledByDefault = true
|
|
|
|
module.Module.dexProperties.Optimize.Shrink = proptools.BoolPtr(true)
|
2023-08-29 19:07:20 +02:00
|
|
|
module.Module.dexProperties.Optimize.Proguard_compatibility = proptools.BoolPtr(false)
|
2017-12-28 21:23:20 +01:00
|
|
|
|
2018-05-22 20:11:52 +02:00
|
|
|
module.Module.properties.Instrument = true
|
2022-05-03 02:28:40 +02:00
|
|
|
module.Module.properties.Supports_static_instrumentation = true
|
2018-06-27 02:59:05 +02:00
|
|
|
module.Module.properties.Installable = proptools.BoolPtr(true)
|
2018-05-22 20:11:52 +02:00
|
|
|
|
2020-06-16 01:09:53 +02:00
|
|
|
module.addHostAndDeviceProperties()
|
2017-06-24 00:06:31 +02:00
|
|
|
module.AddProperties(
|
2018-03-28 23:58:31 +02:00
|
|
|
&module.aaptProperties,
|
2019-03-01 00:35:54 +01:00
|
|
|
&module.appProperties,
|
2020-09-01 18:33:48 +02:00
|
|
|
&module.overridableAppProperties)
|
2017-06-24 00:06:31 +02:00
|
|
|
|
2021-01-05 13:04:17 +01:00
|
|
|
module.usesLibrary.enforce = true
|
|
|
|
|
2018-10-03 07:03:40 +02:00
|
|
|
android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
|
|
|
|
android.InitDefaultableModule(module)
|
2022-02-17 03:33:12 +01:00
|
|
|
android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
|
2019-11-11 02:14:32 +01:00
|
|
|
android.InitApexModule(module)
|
2018-10-03 07:03:40 +02:00
|
|
|
|
2023-11-07 05:37:14 +01:00
|
|
|
android.AddLoadHook(module, func(ctx android.LoadHookContext) {
|
|
|
|
a := ctx.Module().(*AndroidApp)
|
|
|
|
|
|
|
|
characteristics := ctx.Config().ProductAAPTCharacteristics()
|
|
|
|
if characteristics == "default" || characteristics == "" {
|
|
|
|
module.appProperties.Generate_product_characteristics_rro = nil
|
|
|
|
// no need to create RRO
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if !proptools.Bool(module.appProperties.Generate_product_characteristics_rro) {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
rroPackageName := a.Name() + "__" + strings.ReplaceAll(characteristics, ",", "_") + "__auto_generated_characteristics_rro"
|
|
|
|
rroManifestName := rroPackageName + "_manifest"
|
|
|
|
|
|
|
|
a.appProperties.ProductCharacteristicsRROPackageName = proptools.StringPtr(rroPackageName)
|
|
|
|
a.appProperties.ProductCharacteristicsRROManifestModuleName = proptools.StringPtr(rroManifestName)
|
|
|
|
|
|
|
|
rroManifestProperties := struct {
|
|
|
|
Name *string
|
|
|
|
Tools []string
|
|
|
|
Out []string
|
|
|
|
Srcs []string
|
|
|
|
Cmd *string
|
|
|
|
}{
|
|
|
|
Name: proptools.StringPtr(rroManifestName),
|
2024-02-14 08:55:33 +01:00
|
|
|
Tools: []string{"characteristics_rro_generator", "aapt2"},
|
2023-11-07 05:37:14 +01:00
|
|
|
Out: []string{"AndroidManifest.xml"},
|
2024-02-14 08:55:33 +01:00
|
|
|
Srcs: []string{":" + a.Name() + "{.apk}"},
|
|
|
|
Cmd: proptools.StringPtr("$(location characteristics_rro_generator) $$($(location aapt2) dump packagename $(in)) $(out)"),
|
2023-11-07 05:37:14 +01:00
|
|
|
}
|
|
|
|
ctx.CreateModule(genrule.GenRuleFactory, &rroManifestProperties)
|
|
|
|
|
|
|
|
rroProperties := struct {
|
|
|
|
Name *string
|
|
|
|
Filter_product *string
|
|
|
|
Aaptflags []string
|
|
|
|
Manifest *string
|
|
|
|
Resource_dirs []string
|
|
|
|
}{
|
|
|
|
Name: proptools.StringPtr(rroPackageName),
|
|
|
|
Filter_product: proptools.StringPtr(characteristics),
|
|
|
|
Aaptflags: []string{"--auto-add-overlay"},
|
|
|
|
Manifest: proptools.StringPtr(":" + rroManifestName),
|
|
|
|
Resource_dirs: a.aaptProperties.Resource_dirs,
|
|
|
|
}
|
|
|
|
ctx.CreateModule(RuntimeResourceOverlayFactory, &rroProperties)
|
|
|
|
})
|
|
|
|
|
2017-06-24 00:06:31 +02:00
|
|
|
return module
|
2015-04-13 22:58:27 +02:00
|
|
|
}
|
2018-05-22 20:11:52 +02:00
|
|
|
|
2023-08-31 17:48:23 +02:00
|
|
|
// A dictionary of values to be overridden in the manifest.
|
|
|
|
type Manifest_values struct {
|
|
|
|
// Overrides the value of package_name in the manifest
|
|
|
|
ApplicationId *string
|
|
|
|
}
|
|
|
|
|
2018-05-22 20:11:52 +02:00
|
|
|
type appTestProperties struct {
|
2020-04-29 01:10:55 +02:00
|
|
|
// The name of the android_app module that the tests will run against.
|
2018-05-22 20:11:52 +02:00
|
|
|
Instrumentation_for *string
|
2019-06-06 17:45:58 +02:00
|
|
|
|
2023-02-02 22:22:26 +01:00
|
|
|
// If specified, the instrumentation target package name in the manifest is overwritten by it.
|
2019-06-06 17:45:58 +02:00
|
|
|
Instrumentation_target_package *string
|
2023-02-02 22:22:26 +01:00
|
|
|
|
|
|
|
// If specified, the mainline module package name in the test config is overwritten by it.
|
|
|
|
Mainline_package_name *string
|
2023-08-31 17:48:23 +02:00
|
|
|
|
|
|
|
Manifest_values Manifest_values
|
2018-05-22 20:11:52 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
type AndroidTest struct {
|
|
|
|
AndroidApp
|
|
|
|
|
|
|
|
appTestProperties appTestProperties
|
|
|
|
|
|
|
|
testProperties testProperties
|
2018-08-08 01:49:25 +02:00
|
|
|
|
2020-08-15 21:24:26 +02:00
|
|
|
testConfig android.Path
|
|
|
|
extraTestConfigs android.Paths
|
|
|
|
data android.Paths
|
2018-05-22 20:11:52 +02:00
|
|
|
}
|
|
|
|
|
2019-09-11 19:25:18 +02:00
|
|
|
func (a *AndroidTest) InstallInTestcases() bool {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2022-07-25 02:34:18 +02:00
|
|
|
type androidTestApp interface {
|
|
|
|
includedInTestSuite(searchPrefix string) bool
|
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidTest) includedInTestSuite(searchPrefix string) bool {
|
|
|
|
return android.PrefixInList(a.testProperties.Test_suites, searchPrefix)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidTestHelperApp) includedInTestSuite(searchPrefix string) bool {
|
|
|
|
return android.PrefixInList(a.appTestHelperAppProperties.Test_suites, searchPrefix)
|
|
|
|
}
|
|
|
|
|
2018-05-22 20:11:52 +02:00
|
|
|
func (a *AndroidTest) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
2020-04-30 08:57:06 +02:00
|
|
|
var configs []tradefed.Config
|
2019-06-06 17:45:58 +02:00
|
|
|
if a.appTestProperties.Instrumentation_target_package != nil {
|
|
|
|
a.additionalAaptFlags = append(a.additionalAaptFlags,
|
|
|
|
"--rename-instrumentation-target-package "+*a.appTestProperties.Instrumentation_target_package)
|
|
|
|
} else if a.appTestProperties.Instrumentation_for != nil {
|
|
|
|
// Check if the instrumentation target package is overridden.
|
2019-02-28 01:26:28 +01:00
|
|
|
manifestPackageName, overridden := ctx.DeviceConfig().OverrideManifestPackageNameFor(*a.appTestProperties.Instrumentation_for)
|
|
|
|
if overridden {
|
|
|
|
a.additionalAaptFlags = append(a.additionalAaptFlags, "--rename-instrumentation-target-package "+manifestPackageName)
|
|
|
|
}
|
|
|
|
}
|
2023-08-31 17:48:23 +02:00
|
|
|
applicationId := a.appTestProperties.Manifest_values.ApplicationId
|
|
|
|
if applicationId != nil {
|
|
|
|
if a.overridableAppProperties.Package_name != nil {
|
|
|
|
ctx.PropertyErrorf("manifest_values.applicationId", "property is not supported when property package_name is set.")
|
|
|
|
}
|
|
|
|
a.aapt.manifestValues.applicationId = *applicationId
|
|
|
|
}
|
2018-05-22 20:11:52 +02:00
|
|
|
a.generateAndroidBuildActions(ctx)
|
2018-08-08 01:49:25 +02:00
|
|
|
|
2020-04-30 08:57:06 +02:00
|
|
|
for _, module := range a.testProperties.Test_mainline_modules {
|
|
|
|
configs = append(configs, tradefed.Option{Name: "config-descriptor:metadata", Key: "mainline-param", Value: module})
|
|
|
|
}
|
|
|
|
|
2020-01-14 19:27:18 +01:00
|
|
|
testConfig := tradefed.AutoGenInstrumentationTestConfig(ctx, a.testProperties.Test_config,
|
2020-04-30 08:57:06 +02:00
|
|
|
a.testProperties.Test_config_template, a.manifestPath, a.testProperties.Test_suites, a.testProperties.Auto_gen_config, configs)
|
2020-01-14 19:27:18 +01:00
|
|
|
a.testConfig = a.FixTestConfig(ctx, testConfig)
|
2020-08-15 21:24:26 +02:00
|
|
|
a.extraTestConfigs = android.PathsForModuleSrc(ctx, a.testProperties.Test_options.Extra_test_configs)
|
2020-01-14 19:27:18 +01:00
|
|
|
a.data = android.PathsForModuleSrc(ctx, a.testProperties.Data)
|
2023-12-14 00:19:49 +01:00
|
|
|
android.SetProvider(ctx, testing.TestModuleProviderKey, testing.TestModuleProviderData{})
|
2024-02-02 21:37:20 +01:00
|
|
|
android.SetProvider(ctx, tradefed.BaseTestProviderKey, tradefed.BaseTestProviderData{
|
|
|
|
InstalledFiles: a.data,
|
|
|
|
OutputFile: a.OutputFile(),
|
|
|
|
TestConfig: a.testConfig,
|
|
|
|
HostRequiredModuleNames: a.HostRequiredModuleNames(),
|
|
|
|
})
|
2020-01-14 19:27:18 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig android.Path) android.Path {
|
|
|
|
if testConfig == nil {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml")
|
2020-11-17 02:32:30 +01:00
|
|
|
rule := android.NewRuleBuilder(pctx, ctx)
|
|
|
|
command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig)
|
2020-01-14 19:27:18 +01:00
|
|
|
fixNeeded := false
|
|
|
|
|
2022-01-08 04:13:59 +01:00
|
|
|
// Auto-generated test config uses `ModuleName` as the APK name. So fix it if it is not the case.
|
2020-01-14 19:27:18 +01:00
|
|
|
if ctx.ModuleName() != a.installApkName {
|
|
|
|
fixNeeded = true
|
|
|
|
command.FlagWithArg("--test-file-name ", a.installApkName+".apk")
|
|
|
|
}
|
|
|
|
|
2019-11-22 23:34:55 +01:00
|
|
|
if a.overridableAppProperties.Package_name != nil {
|
2020-01-14 19:27:18 +01:00
|
|
|
fixNeeded = true
|
|
|
|
command.FlagWithInput("--manifest ", a.manifestPath).
|
|
|
|
FlagWithArg("--package-name ", *a.overridableAppProperties.Package_name)
|
|
|
|
}
|
|
|
|
|
2023-02-02 22:22:26 +01:00
|
|
|
if a.appTestProperties.Mainline_package_name != nil {
|
|
|
|
fixNeeded = true
|
|
|
|
command.FlagWithArg("--mainline-package-name ", *a.appTestProperties.Mainline_package_name)
|
|
|
|
}
|
|
|
|
|
2020-01-14 19:27:18 +01:00
|
|
|
if fixNeeded {
|
2020-11-17 02:32:30 +01:00
|
|
|
rule.Build("fix_test_config", "fix test config")
|
2020-01-14 19:27:18 +01:00
|
|
|
return fixedConfig
|
2019-11-22 23:34:55 +01:00
|
|
|
}
|
2020-01-14 19:27:18 +01:00
|
|
|
return testConfig
|
2018-08-08 01:49:25 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidTest) DepsMutator(ctx android.BottomUpMutatorContext) {
|
|
|
|
a.AndroidApp.DepsMutator(ctx)
|
2019-06-06 17:45:58 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
func (a *AndroidTest) OverridablePropertiesDepsMutator(ctx android.BottomUpMutatorContext) {
|
|
|
|
a.AndroidApp.OverridablePropertiesDepsMutator(ctx)
|
2018-10-16 01:18:06 +02:00
|
|
|
if a.appTestProperties.Instrumentation_for != nil {
|
|
|
|
// The android_app dependency listed in instrumentation_for needs to be added to the classpath for javac,
|
|
|
|
// but not added to the aapt2 link includes like a normal android_app or android_library dependency, so
|
|
|
|
// use instrumentationForTag instead of libTag.
|
|
|
|
ctx.AddVariationDependencies(nil, instrumentationForTag, String(a.appTestProperties.Instrumentation_for))
|
|
|
|
}
|
2018-05-22 20:11:52 +02:00
|
|
|
}
|
|
|
|
|
2019-02-12 23:41:32 +01:00
|
|
|
// android_test compiles test sources and Android resources into an Android application package `.apk` file and
|
|
|
|
// creates an `AndroidTest.xml` file to allow running the test with `atest` or a `TEST_MAPPING` file.
|
2018-05-22 20:11:52 +02:00
|
|
|
func AndroidTestFactory() android.Module {
|
|
|
|
module := &AndroidTest{}
|
|
|
|
|
2022-06-02 21:11:14 +02:00
|
|
|
module.Module.dexProperties.Optimize.EnabledByDefault = false
|
2018-09-18 01:46:35 +02:00
|
|
|
|
|
|
|
module.Module.properties.Instrument = true
|
2022-05-03 02:28:40 +02:00
|
|
|
module.Module.properties.Supports_static_instrumentation = true
|
2018-06-27 02:59:05 +02:00
|
|
|
module.Module.properties.Installable = proptools.BoolPtr(true)
|
2019-02-06 06:55:21 +01:00
|
|
|
module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
|
2019-03-26 18:51:39 +01:00
|
|
|
module.appProperties.AlwaysPackageNativeLibs = true
|
2018-11-12 19:13:39 +01:00
|
|
|
module.Module.dexpreopter.isTest = true
|
2022-08-11 20:59:04 +02:00
|
|
|
module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
|
2018-05-22 20:11:52 +02:00
|
|
|
|
2020-06-16 01:09:53 +02:00
|
|
|
module.addHostAndDeviceProperties()
|
2018-05-22 20:11:52 +02:00
|
|
|
module.AddProperties(
|
|
|
|
&module.aaptProperties,
|
|
|
|
&module.appProperties,
|
2018-07-17 02:21:19 +02:00
|
|
|
&module.appTestProperties,
|
2019-03-01 00:35:54 +01:00
|
|
|
&module.overridableAppProperties,
|
2018-07-17 02:21:19 +02:00
|
|
|
&module.testProperties)
|
2018-05-22 20:11:52 +02:00
|
|
|
|
2018-10-03 07:03:40 +02:00
|
|
|
android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
|
|
|
|
android.InitDefaultableModule(module)
|
2022-02-17 03:33:12 +01:00
|
|
|
android.InitOverridableModule(module, &module.overridableAppProperties.Overrides)
|
2023-08-25 11:00:16 +02:00
|
|
|
|
2018-05-22 20:11:52 +02:00
|
|
|
return module
|
|
|
|
}
|
2018-10-05 00:21:03 +02:00
|
|
|
|
2018-10-05 00:22:03 +02:00
|
|
|
type appTestHelperAppProperties struct {
|
|
|
|
// list of compatibility suites (for example "cts", "vts") that the module should be
|
|
|
|
// installed into.
|
|
|
|
Test_suites []string `android:"arch_variant"`
|
2019-09-26 20:41:36 +02:00
|
|
|
|
|
|
|
// Flag to indicate whether or not to create test config automatically. If AndroidTest.xml
|
|
|
|
// doesn't exist next to the Android.bp, this attribute doesn't need to be set to true
|
|
|
|
// explicitly.
|
|
|
|
Auto_gen_config *bool
|
2021-09-25 00:47:17 +02:00
|
|
|
|
|
|
|
// Install the test into a folder named for the module in all test suites.
|
|
|
|
Per_testcase_directory *bool
|
2023-08-31 17:48:23 +02:00
|
|
|
|
|
|
|
Manifest_values Manifest_values
|
2018-10-05 00:22:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
type AndroidTestHelperApp struct {
|
|
|
|
AndroidApp
|
|
|
|
|
|
|
|
appTestHelperAppProperties appTestHelperAppProperties
|
|
|
|
}
|
|
|
|
|
2019-11-21 19:41:00 +01:00
|
|
|
func (a *AndroidTestHelperApp) InstallInTestcases() bool {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
2019-02-12 23:41:32 +01:00
|
|
|
// android_test_helper_app compiles sources and Android resources into an Android application package `.apk` file that
|
|
|
|
// will be used by tests, but does not produce an `AndroidTest.xml` file so the module will not be run directly as a
|
|
|
|
// test.
|
2018-10-05 00:22:03 +02:00
|
|
|
func AndroidTestHelperAppFactory() android.Module {
|
|
|
|
module := &AndroidTestHelperApp{}
|
|
|
|
|
2022-06-02 21:11:14 +02:00
|
|
|
// TODO(b/192032291): Disable by default after auditing downstream usage.
|
2020-07-10 00:16:41 +02:00
|
|
|
module.Module.dexProperties.Optimize.EnabledByDefault = true
|
2018-10-05 00:22:03 +02:00
|
|
|
|
|
|
|
module.Module.properties.Installable = proptools.BoolPtr(true)
|
2019-02-06 06:55:21 +01:00
|
|
|
module.appProperties.Use_embedded_native_libs = proptools.BoolPtr(true)
|
2019-03-26 18:51:39 +01:00
|
|
|
module.appProperties.AlwaysPackageNativeLibs = true
|
2018-11-12 19:13:39 +01:00
|
|
|
module.Module.dexpreopter.isTest = true
|
2022-08-11 20:59:04 +02:00
|
|
|
module.Module.linter.properties.Lint.Test = proptools.BoolPtr(true)
|
2018-10-05 00:22:03 +02:00
|
|
|
|
2020-06-16 01:09:53 +02:00
|
|
|
module.addHostAndDeviceProperties()
|
2018-10-05 00:22:03 +02:00
|
|
|
module.AddProperties(
|
|
|
|
&module.aaptProperties,
|
|
|
|
&module.appProperties,
|
2019-03-01 00:35:54 +01:00
|
|
|
&module.appTestHelperAppProperties,
|
2020-09-01 18:33:48 +02:00
|
|
|
&module.overridableAppProperties)
|
2018-10-05 00:22:03 +02:00
|
|
|
|
|
|
|
android.InitAndroidMultiTargetsArchModule(module, android.DeviceSupported, android.MultilibCommon)
|
|
|
|
android.InitDefaultableModule(module)
|
2020-01-10 16:06:01 +01:00
|
|
|
android.InitApexModule(module)
|
2018-10-05 00:22:03 +02:00
|
|
|
return module
|
|
|
|
}
|
|
|
|
|
2018-10-05 00:21:03 +02:00
|
|
|
type AndroidAppCertificate struct {
|
|
|
|
android.ModuleBase
|
2021-07-27 07:34:59 +02:00
|
|
|
|
2018-10-05 00:21:03 +02:00
|
|
|
properties AndroidAppCertificateProperties
|
2018-10-30 13:20:05 +01:00
|
|
|
Certificate Certificate
|
2018-10-05 00:21:03 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
type AndroidAppCertificateProperties struct {
|
|
|
|
// Name of the certificate files. Extensions .x509.pem and .pk8 will be added to the name.
|
|
|
|
Certificate *string
|
|
|
|
}
|
|
|
|
|
2019-02-12 23:41:32 +01:00
|
|
|
// android_app_certificate modules can be referenced by the certificates property of android_app modules to select
|
|
|
|
// the signing key.
|
2018-10-05 00:21:03 +02:00
|
|
|
func AndroidAppCertificateFactory() android.Module {
|
|
|
|
module := &AndroidAppCertificate{}
|
|
|
|
module.AddProperties(&module.properties)
|
|
|
|
android.InitAndroidModule(module)
|
|
|
|
return module
|
|
|
|
}
|
|
|
|
|
|
|
|
func (c *AndroidAppCertificate) GenerateAndroidBuildActions(ctx android.ModuleContext) {
|
|
|
|
cert := String(c.properties.Certificate)
|
2018-10-30 13:20:05 +01:00
|
|
|
c.Certificate = Certificate{
|
2020-01-28 23:00:53 +01:00
|
|
|
Pem: android.PathForModuleSrc(ctx, cert+".x509.pem"),
|
|
|
|
Key: android.PathForModuleSrc(ctx, cert+".pk8"),
|
2018-10-05 00:21:03 +02:00
|
|
|
}
|
|
|
|
}
|
2019-03-01 00:35:54 +01:00
|
|
|
|
|
|
|
type OverrideAndroidApp struct {
|
|
|
|
android.ModuleBase
|
|
|
|
android.OverrideModuleBase
|
|
|
|
}
|
|
|
|
|
2020-06-05 19:27:23 +02:00
|
|
|
func (i *OverrideAndroidApp) GenerateAndroidBuildActions(_ android.ModuleContext) {
|
2019-03-01 00:35:54 +01:00
|
|
|
// All the overrides happen in the base module.
|
|
|
|
// TODO(jungjw): Check the base module type.
|
|
|
|
}
|
|
|
|
|
|
|
|
// override_android_app is used to create an android_app module based on another android_app by overriding
|
|
|
|
// some of its properties.
|
|
|
|
func OverrideAndroidAppModuleFactory() android.Module {
|
|
|
|
m := &OverrideAndroidApp{}
|
2022-01-08 04:16:32 +01:00
|
|
|
m.AddProperties(
|
2024-03-15 10:29:29 +01:00
|
|
|
&OverridableProperties{},
|
2022-01-08 04:16:32 +01:00
|
|
|
&overridableAppProperties{},
|
|
|
|
)
|
2019-03-01 00:35:54 +01:00
|
|
|
|
2019-05-11 00:16:29 +02:00
|
|
|
android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
|
2019-03-01 00:35:54 +01:00
|
|
|
android.InitOverrideModule(m)
|
|
|
|
return m
|
|
|
|
}
|
2019-04-15 18:48:31 +02:00
|
|
|
|
2019-06-06 17:45:58 +02:00
|
|
|
type OverrideAndroidTest struct {
|
|
|
|
android.ModuleBase
|
|
|
|
android.OverrideModuleBase
|
|
|
|
}
|
|
|
|
|
2020-06-05 19:27:23 +02:00
|
|
|
func (i *OverrideAndroidTest) GenerateAndroidBuildActions(_ android.ModuleContext) {
|
2019-06-06 17:45:58 +02:00
|
|
|
// All the overrides happen in the base module.
|
|
|
|
// TODO(jungjw): Check the base module type.
|
|
|
|
}
|
|
|
|
|
|
|
|
// override_android_test is used to create an android_app module based on another android_test by overriding
|
|
|
|
// some of its properties.
|
|
|
|
func OverrideAndroidTestModuleFactory() android.Module {
|
|
|
|
m := &OverrideAndroidTest{}
|
|
|
|
m.AddProperties(&overridableAppProperties{})
|
|
|
|
m.AddProperties(&appTestProperties{})
|
|
|
|
|
|
|
|
android.InitAndroidMultiTargetsArchModule(m, android.DeviceSupported, android.MultilibCommon)
|
|
|
|
android.InitOverrideModule(m)
|
|
|
|
return m
|
|
|
|
}
|
|
|
|
|
2019-05-16 21:28:22 +02:00
|
|
|
type UsesLibraryProperties struct {
|
|
|
|
// A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file.
|
|
|
|
Uses_libs []string
|
|
|
|
|
|
|
|
// A list of shared library modules that will be listed in uses-library tags in the AndroidManifest.xml file with
|
|
|
|
// required=false.
|
|
|
|
Optional_uses_libs []string
|
|
|
|
|
|
|
|
// If true, the list of uses_libs and optional_uses_libs modules must match the AndroidManifest.xml file. Defaults
|
|
|
|
// to true if either uses_libs or optional_uses_libs is set. Will unconditionally default to true in the future.
|
|
|
|
Enforce_uses_libs *bool
|
2020-09-01 18:33:48 +02:00
|
|
|
|
2020-09-09 15:08:23 +02:00
|
|
|
// Optional name of the <uses-library> provided by this module. This is needed for non-SDK
|
|
|
|
// libraries, because SDK ones are automatically picked up by Soong. The <uses-library> name
|
|
|
|
// normally is the same as the module name, but there are exceptions.
|
|
|
|
Provides_uses_lib *string
|
2022-02-03 18:54:15 +01:00
|
|
|
|
|
|
|
// A list of shared library names to exclude from the classpath of the APK. Adding a library here
|
|
|
|
// will prevent it from being used when precompiling the APK and prevent it from being implicitly
|
|
|
|
// added to the APK's manifest's <uses-library> elements.
|
|
|
|
//
|
|
|
|
// Care must be taken when using this as it could result in runtime errors if the APK actually
|
|
|
|
// uses classes provided by the library and which are not provided in any other way.
|
|
|
|
//
|
|
|
|
// This is primarily intended for use by various CTS tests that check the runtime handling of the
|
|
|
|
// android.test.base shared library (and related libraries) but which depend on some common
|
|
|
|
// libraries that depend on the android.test.base library. Without this those tests will end up
|
|
|
|
// with a <uses-library android:name="android.test.base"/> in their manifest which would either
|
|
|
|
// render the tests worthless (as they would be testing the wrong behavior), or would break the
|
|
|
|
// test altogether by providing access to classes that the tests were not expecting. Those tests
|
|
|
|
// provide the android.test.base statically and use jarjar to rename them so they do not collide
|
|
|
|
// with the classes provided by the android.test.base library.
|
|
|
|
Exclude_uses_libs []string
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
|
|
|
|
// The module names of optional uses-library libraries that are missing from the source tree.
|
|
|
|
Missing_optional_uses_libs []string `blueprint:"mutated"`
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// usesLibrary provides properties and helper functions for AndroidApp and AndroidAppImport to verify that the
|
|
|
|
// <uses-library> tags that end up in the manifest of an APK match the ones known to the build system through the
|
|
|
|
// uses_libs and optional_uses_libs properties. The build system's values are used by dexpreopt to preopt apps
|
|
|
|
// with knowledge of their shared libraries.
|
|
|
|
type usesLibrary struct {
|
|
|
|
usesLibraryProperties UsesLibraryProperties
|
2021-01-05 13:04:17 +01:00
|
|
|
|
|
|
|
// Whether to enforce verify_uses_library check.
|
|
|
|
enforce bool
|
2024-02-13 17:37:43 +01:00
|
|
|
|
|
|
|
// Whether dexpreopt should be disabled
|
|
|
|
shouldDisableDexpreopt bool
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|
|
|
|
|
2022-12-22 06:51:52 +01:00
|
|
|
func (u *usesLibrary) deps(ctx android.BottomUpMutatorContext, addCompatDeps bool) {
|
2021-06-08 04:35:00 +02:00
|
|
|
if !ctx.Config().UnbundledBuild() || ctx.Config().UnbundledBuildImage() {
|
2022-05-04 13:00:02 +02:00
|
|
|
ctx.AddVariationDependencies(nil, usesLibReqTag, u.usesLibraryProperties.Uses_libs...)
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
presentOptionalUsesLibs := u.presentOptionalUsesLibs(ctx)
|
|
|
|
ctx.AddVariationDependencies(nil, usesLibOptTag, presentOptionalUsesLibs...)
|
2022-12-22 06:51:52 +01:00
|
|
|
// Only add these extra dependencies if the module is an app that depends on framework
|
|
|
|
// libs. This avoids creating a cyclic dependency:
|
2019-06-07 11:44:37 +02:00
|
|
|
// e.g. framework-res -> org.apache.http.legacy -> ... -> framework-res.
|
2022-12-22 06:51:52 +01:00
|
|
|
if addCompatDeps {
|
2022-05-04 13:00:02 +02:00
|
|
|
// Dexpreopt needs paths to the dex jars of these libraries in order to construct
|
|
|
|
// class loader context for dex2oat. Add them as a dependency with a special tag.
|
|
|
|
ctx.AddVariationDependencies(nil, usesLibCompat29ReqTag, dexpreopt.CompatUsesLibs29...)
|
|
|
|
ctx.AddVariationDependencies(nil, usesLibCompat28OptTag, dexpreopt.OptionalCompatUsesLibs28...)
|
|
|
|
ctx.AddVariationDependencies(nil, usesLibCompat30OptTag, dexpreopt.OptionalCompatUsesLibs30...)
|
2019-06-07 22:18:09 +02:00
|
|
|
}
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
_, diff, _ := android.ListSetDifference(u.usesLibraryProperties.Optional_uses_libs, presentOptionalUsesLibs)
|
|
|
|
u.usesLibraryProperties.Missing_optional_uses_libs = diff
|
2022-11-29 17:19:37 +01:00
|
|
|
} else {
|
|
|
|
ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.usesLibraryProperties.Uses_libs...)
|
|
|
|
ctx.AddVariationDependencies(nil, r8LibraryJarTag, u.presentOptionalUsesLibs(ctx)...)
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2023-06-01 16:16:58 +02:00
|
|
|
// presentOptionalUsesLibs returns optional_uses_libs after filtering out libraries that don't exist in the source tree.
|
2019-05-16 21:28:22 +02:00
|
|
|
func (u *usesLibrary) presentOptionalUsesLibs(ctx android.BaseModuleContext) []string {
|
2023-06-01 16:16:58 +02:00
|
|
|
optionalUsesLibs := android.FilterListPred(u.usesLibraryProperties.Optional_uses_libs, func(s string) bool {
|
|
|
|
exists := ctx.OtherModuleExists(s)
|
2023-06-03 00:42:21 +02:00
|
|
|
if !exists && !android.InList(ctx.ModuleName(), ctx.Config().BuildWarningBadOptionalUsesLibsAllowlist()) {
|
2023-06-01 16:16:58 +02:00
|
|
|
fmt.Printf("Warning: Module '%s' depends on non-existing optional_uses_libs '%s'\n", ctx.ModuleName(), s)
|
|
|
|
}
|
|
|
|
return exists
|
|
|
|
})
|
2019-05-16 21:28:22 +02:00
|
|
|
return optionalUsesLibs
|
|
|
|
}
|
|
|
|
|
2021-07-15 15:59:34 +02:00
|
|
|
// Returns a map of module names of shared library dependencies to the paths to their dex jars on
|
|
|
|
// host and on device.
|
2020-11-03 16:15:46 +01:00
|
|
|
func (u *usesLibrary) classLoaderContextForUsesLibDeps(ctx android.ModuleContext) dexpreopt.ClassLoaderContextMap {
|
|
|
|
clcMap := make(dexpreopt.ClassLoaderContextMap)
|
2021-07-15 15:59:34 +02:00
|
|
|
|
|
|
|
// Skip when UnbundledBuild() is true, but UnbundledBuildImage() is false. With
|
|
|
|
// UnbundledBuildImage() it is necessary to generate dexpreopt.config for post-dexpreopting.
|
|
|
|
if ctx.Config().UnbundledBuild() && !ctx.Config().UnbundledBuildImage() {
|
|
|
|
return clcMap
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|
|
|
|
|
2021-07-15 15:59:34 +02:00
|
|
|
ctx.VisitDirectDeps(func(m android.Module) {
|
|
|
|
tag, isUsesLibTag := ctx.OtherModuleDependencyTag(m).(usesLibraryDependencyTag)
|
|
|
|
if !isUsesLibTag {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
2021-07-15 16:05:48 +02:00
|
|
|
dep := android.RemoveOptionalPrebuiltPrefix(ctx.OtherModuleName(m))
|
2021-07-15 15:59:34 +02:00
|
|
|
|
2021-07-15 15:34:40 +02:00
|
|
|
// Skip stub libraries. A dependency on the implementation library has been added earlier,
|
|
|
|
// so it will be added to CLC, but the stub shouldn't be. Stub libraries can be distingushed
|
|
|
|
// from implementation libraries by their name, which is different as it has a suffix.
|
|
|
|
if comp, ok := m.(SdkLibraryComponentDependency); ok {
|
|
|
|
if impl := comp.OptionalSdkLibraryImplementation(); impl != nil && *impl != dep {
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2024-02-13 17:37:43 +01:00
|
|
|
// Skip java_sdk_library dependencies that provide stubs, but not an implementation.
|
|
|
|
// This will be restricted to optional_uses_libs
|
|
|
|
if sdklib, ok := m.(SdkLibraryDependency); ok {
|
|
|
|
if tag == usesLibOptTag && sdklib.DexJarBuildPath(ctx).PathOrNil() == nil {
|
|
|
|
u.shouldDisableDexpreopt = true
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-07-15 15:59:34 +02:00
|
|
|
if lib, ok := m.(UsesLibraryDependency); ok {
|
2021-07-15 16:05:48 +02:00
|
|
|
libName := dep
|
2021-07-15 15:59:34 +02:00
|
|
|
if ulib, ok := m.(ProvidesUsesLib); ok && ulib.ProvidesUsesLib() != nil {
|
2021-07-15 16:05:48 +02:00
|
|
|
libName = *ulib.ProvidesUsesLib()
|
2021-07-15 15:59:34 +02:00
|
|
|
}
|
2022-05-04 13:00:02 +02:00
|
|
|
clcMap.AddContext(ctx, tag.sdkVersion, libName, tag.optional,
|
2024-01-09 22:35:56 +01:00
|
|
|
lib.DexJarBuildPath(ctx).PathOrNil(), lib.DexJarInstallPath(),
|
2021-09-15 04:34:04 +02:00
|
|
|
lib.ClassLoaderContexts())
|
2021-07-15 15:59:34 +02:00
|
|
|
} else if ctx.Config().AllowMissingDependencies() {
|
|
|
|
ctx.AddMissingDependencies([]string{dep})
|
|
|
|
} else {
|
|
|
|
ctx.ModuleErrorf("module %q in uses_libs or optional_uses_libs must be a java library", dep)
|
|
|
|
}
|
|
|
|
})
|
2020-11-03 16:15:46 +01:00
|
|
|
return clcMap
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|
|
|
|
|
|
|
|
// enforceUsesLibraries returns true of <uses-library> tags should be checked against uses_libs and optional_uses_libs
|
|
|
|
// properties. Defaults to true if either of uses_libs or optional_uses_libs is specified. Will default to true
|
|
|
|
// unconditionally in the future.
|
|
|
|
func (u *usesLibrary) enforceUsesLibraries() bool {
|
|
|
|
defaultEnforceUsesLibs := len(u.usesLibraryProperties.Uses_libs) > 0 ||
|
|
|
|
len(u.usesLibraryProperties.Optional_uses_libs) > 0
|
2021-01-05 13:04:17 +01:00
|
|
|
return BoolDefault(u.usesLibraryProperties.Enforce_uses_libs, u.enforce || defaultEnforceUsesLibs)
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|
|
|
|
|
2020-08-19 17:32:54 +02:00
|
|
|
// Freeze the value of `enforce_uses_libs` based on the current values of `uses_libs` and `optional_uses_libs`.
|
|
|
|
func (u *usesLibrary) freezeEnforceUsesLibraries() {
|
|
|
|
enforce := u.enforceUsesLibraries()
|
|
|
|
u.usesLibraryProperties.Enforce_uses_libs = &enforce
|
|
|
|
}
|
|
|
|
|
2021-03-03 17:38:37 +01:00
|
|
|
// verifyUsesLibraries checks the <uses-library> tags in the manifest against the ones specified
|
|
|
|
// in the `uses_libs`/`optional_uses_libs` properties. The input can be either an XML manifest, or
|
|
|
|
// an APK with the manifest embedded in it (manifest_check will know which one it is by the file
|
|
|
|
// extension: APKs are supposed to end with '.apk').
|
|
|
|
func (u *usesLibrary) verifyUsesLibraries(ctx android.ModuleContext, inputFile android.Path,
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
outputFile android.WritablePath, classLoaderContexts *dexpreopt.ClassLoaderContextMap) android.Path {
|
2021-03-03 17:38:37 +01:00
|
|
|
|
Add non-fatal mode for verify_uses_libraries check.
The new mode is enabled with environment variable
RELAX_USES_LIBRARY_CHECK. If the variable is set to true, then a
verify_uses_libraries check failure does not fail the build, instead it
sets a special compiler filter "extract" for dexpreopt, which means that
the DEX file will be extracted, but it won't be compiled to native code.
Class loader context will be set to empty in this case (not &, as it is
going to be deprecated soon).
If the variable RELAX_USES_LIBRARY_CHECK is unset or set to something
other than "true", then the old behaviour of the verify_uses_libraries
check is preserved.
The intended use case for this flag is to have a smoother migration path
for the Java modules that need to add <uses-library> information in
the build files. The flag allows to quickly silence build errors. This
flag should be used with caution and only as a temporary measure, as it
masks real errors and affects performance.
verify_uses_libraries check is reworked so that it writes the error
message to a status file (which is used instead of the former timestamp
file). Currently the stored error message is not used, but it may be
used later to produce a warning. Dexpreopt command checks if the status
file exists and is nonempty; if that is the case, then compiler filter
is set to "extract".
Bug: 132357300
Test: Manually add some mismatch between the libraries in the Android.bp
and Android.mk files for dexpreopted apps, build with
RELAX_USES_LIBRARY_CHECK=true and obsserve that the build doesn't
fail and they are compiled with compiler-filter "extract".
Unset RELAX_USES_LIBRARY_CHECK and observe that the build fails.
Change-Id: Ibb5d993a25b1df1d2e70b7d5aafc6997f9d64e67
2021-02-17 17:23:28 +01:00
|
|
|
statusFile := dexpreopt.UsesLibrariesStatusFile(ctx)
|
2019-05-16 21:28:22 +02:00
|
|
|
|
2021-03-04 13:37:50 +01:00
|
|
|
// Disable verify_uses_libraries check if dexpreopt is globally disabled. Without dexpreopt the
|
|
|
|
// check is not necessary, and although it is good to have, it is difficult to maintain on
|
|
|
|
// non-linux build platforms where dexpreopt is generally disabled (the check may fail due to
|
|
|
|
// various unrelated reasons, such as a failure to get manifest from an APK).
|
2021-03-29 15:57:34 +02:00
|
|
|
global := dexpreopt.GetGlobalConfig(ctx)
|
2023-11-09 17:47:04 +01:00
|
|
|
if global.DisablePreopt || global.OnlyPreoptArtBootImage {
|
2021-03-16 16:34:50 +01:00
|
|
|
return inputFile
|
2021-03-04 13:37:50 +01:00
|
|
|
}
|
|
|
|
|
2020-11-17 02:32:30 +01:00
|
|
|
rule := android.NewRuleBuilder(pctx, ctx)
|
|
|
|
cmd := rule.Command().BuiltTool("manifest_check").
|
2019-05-16 21:28:22 +02:00
|
|
|
Flag("--enforce-uses-libraries").
|
2021-03-03 17:38:37 +01:00
|
|
|
Input(inputFile).
|
Add non-fatal mode for verify_uses_libraries check.
The new mode is enabled with environment variable
RELAX_USES_LIBRARY_CHECK. If the variable is set to true, then a
verify_uses_libraries check failure does not fail the build, instead it
sets a special compiler filter "extract" for dexpreopt, which means that
the DEX file will be extracted, but it won't be compiled to native code.
Class loader context will be set to empty in this case (not &, as it is
going to be deprecated soon).
If the variable RELAX_USES_LIBRARY_CHECK is unset or set to something
other than "true", then the old behaviour of the verify_uses_libraries
check is preserved.
The intended use case for this flag is to have a smoother migration path
for the Java modules that need to add <uses-library> information in
the build files. The flag allows to quickly silence build errors. This
flag should be used with caution and only as a temporary measure, as it
masks real errors and affects performance.
verify_uses_libraries check is reworked so that it writes the error
message to a status file (which is used instead of the former timestamp
file). Currently the stored error message is not used, but it may be
used later to produce a warning. Dexpreopt command checks if the status
file exists and is nonempty; if that is the case, then compiler filter
is set to "extract".
Bug: 132357300
Test: Manually add some mismatch between the libraries in the Android.bp
and Android.mk files for dexpreopted apps, build with
RELAX_USES_LIBRARY_CHECK=true and obsserve that the build doesn't
fail and they are compiled with compiler-filter "extract".
Unset RELAX_USES_LIBRARY_CHECK and observe that the build fails.
Change-Id: Ibb5d993a25b1df1d2e70b7d5aafc6997f9d64e67
2021-02-17 17:23:28 +01:00
|
|
|
FlagWithOutput("--enforce-uses-libraries-status ", statusFile).
|
2022-08-08 22:21:26 +02:00
|
|
|
FlagWithInput("--aapt ", ctx.Config().HostToolPath(ctx, "aapt2"))
|
2021-03-03 17:38:37 +01:00
|
|
|
|
|
|
|
if outputFile != nil {
|
|
|
|
cmd.FlagWithOutput("-o ", outputFile)
|
|
|
|
}
|
2019-05-16 21:28:22 +02:00
|
|
|
|
Add non-fatal mode for verify_uses_libraries check.
The new mode is enabled with environment variable
RELAX_USES_LIBRARY_CHECK. If the variable is set to true, then a
verify_uses_libraries check failure does not fail the build, instead it
sets a special compiler filter "extract" for dexpreopt, which means that
the DEX file will be extracted, but it won't be compiled to native code.
Class loader context will be set to empty in this case (not &, as it is
going to be deprecated soon).
If the variable RELAX_USES_LIBRARY_CHECK is unset or set to something
other than "true", then the old behaviour of the verify_uses_libraries
check is preserved.
The intended use case for this flag is to have a smoother migration path
for the Java modules that need to add <uses-library> information in
the build files. The flag allows to quickly silence build errors. This
flag should be used with caution and only as a temporary measure, as it
masks real errors and affects performance.
verify_uses_libraries check is reworked so that it writes the error
message to a status file (which is used instead of the former timestamp
file). Currently the stored error message is not used, but it may be
used later to produce a warning. Dexpreopt command checks if the status
file exists and is nonempty; if that is the case, then compiler filter
is set to "extract".
Bug: 132357300
Test: Manually add some mismatch between the libraries in the Android.bp
and Android.mk files for dexpreopted apps, build with
RELAX_USES_LIBRARY_CHECK=true and obsserve that the build doesn't
fail and they are compiled with compiler-filter "extract".
Unset RELAX_USES_LIBRARY_CHECK and observe that the build fails.
Change-Id: Ibb5d993a25b1df1d2e70b7d5aafc6997f9d64e67
2021-02-17 17:23:28 +01:00
|
|
|
if dexpreopt.GetGlobalConfig(ctx).RelaxUsesLibraryCheck {
|
|
|
|
cmd.Flag("--enforce-uses-libraries-relax")
|
|
|
|
}
|
|
|
|
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
requiredUsesLibs, optionalUsesLibs := classLoaderContexts.UsesLibs()
|
|
|
|
for _, lib := range requiredUsesLibs {
|
2019-05-16 21:28:22 +02:00
|
|
|
cmd.FlagWithArg("--uses-library ", lib)
|
|
|
|
}
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
for _, lib := range optionalUsesLibs {
|
2019-05-16 21:28:22 +02:00
|
|
|
cmd.FlagWithArg("--optional-uses-library ", lib)
|
|
|
|
}
|
|
|
|
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
// Also add missing optional uses libs, as the manifest check expects them.
|
|
|
|
// Note that what we add here are the module names of those missing libs, not library names, while
|
|
|
|
// the manifest check actually expects library names. However, the case where a library is missing
|
|
|
|
// and the module name != the library name is too rare for us to handle.
|
|
|
|
for _, lib := range u.usesLibraryProperties.Missing_optional_uses_libs {
|
|
|
|
cmd.FlagWithArg("--missing-optional-uses-library ", lib)
|
|
|
|
}
|
|
|
|
|
2020-11-17 02:32:30 +01:00
|
|
|
rule.Build("verify_uses_libraries", "verify <uses-library>")
|
2021-03-16 16:34:50 +01:00
|
|
|
return outputFile
|
2021-03-03 17:38:37 +01:00
|
|
|
}
|
2019-05-16 21:28:22 +02:00
|
|
|
|
2021-03-03 17:38:37 +01:00
|
|
|
// verifyUsesLibrariesManifest checks the <uses-library> tags in an AndroidManifest.xml against
|
|
|
|
// the build system and returns the path to a copy of the manifest.
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path,
|
|
|
|
classLoaderContexts *dexpreopt.ClassLoaderContextMap) android.Path {
|
2021-03-03 17:38:37 +01:00
|
|
|
outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml")
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
return u.verifyUsesLibraries(ctx, manifest, outputFile, classLoaderContexts)
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|
|
|
|
|
2021-03-03 17:38:37 +01:00
|
|
|
// verifyUsesLibrariesAPK checks the <uses-library> tags in the manifest of an APK against the build
|
|
|
|
// system and returns the path to a copy of the APK.
|
Refactor the contruction of the manifest check inputs.
This is a no-op change for a majority of cases.
Before this change, the contruction of the manifest check inputs is
confusing. It mutates uses_libs properties in place just for the
manifest check, by replacing module names with library names for
direct dependencies and merging library names from CLC for both direct
denpendencies and transitive denpendencies, and then constructs manifest
check inputs from those mutated uses_libs properties. This is
error-prone and leads to insistency: the goal is to check that the CLC
matches the manifest, but the inputs to the check don't reflect the CLC.
After this change, we no longer mutate uses_libs properties in place.
Instead, we maintain a separate list of missing denpendencies, and then
construct manifest check inputs directly from the CLC for all existing
libraries, no matter they are direct or transtive, and from the separate
list of missing libraries. This change makes the logic more
consistent and straightforward, and it also allows us to easily do the
next change, which is to propagate transtive missing denpendencies.
In fact, this change revealed several bugs around library optionality
and order in CLC construction, and fixed them.
Bug: 331528424
Test: m --no-skip-soong-tests
Ignore-AOSP-First: Depends on internal changes. Will cherry-pick once merged.
Merged-In: I0de82e76c47995b54aba9efd41538d950256a95f
Change-Id: I0de82e76c47995b54aba9efd41538d950256a95f
2024-04-15 13:15:41 +02:00
|
|
|
func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path,
|
|
|
|
classLoaderContexts *dexpreopt.ClassLoaderContextMap) {
|
|
|
|
u.verifyUsesLibraries(ctx, apk, nil, classLoaderContexts) // for APKs manifest_check does not write output file
|
2019-05-16 21:28:22 +02:00
|
|
|
}
|