tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "Don't allow tree artifacts in mixed builds" into main

Browse source
This commit is contained in:
Cole Faust 2023-09-08 18:02:29 +00:00 committed by Gerrit Code Review
commit 096b7e83bc
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
bazel/aquery.go
View file

@ -177,6 +177,21 @@ func newAqueryHandler(aqueryResult *analysis_v2_proto.ActionGraphContainer) (*aq
if err != nil {
return nil, err
}
if artifact.IsTreeArtifact &&
!strings.HasPrefix(artifactPath, "bazel-out/io_bazel_rules_go/") &&
!strings.HasPrefix(artifactPath, "bazel-out/rules_java_builtin/") {
// Since we're using ninja as an executor, we can't use tree artifacts. Ninja only
// considers a file/directory "dirty" when it's mtime changes. Directories' mtimes will
// only change when a file in the directory is added/removed, but not when files in
// the directory are changed, or when files in subdirectories are changed/added/removed.
// Bazel handles this by walking the directory and generating a hash for it after the
// action runs, which we would have to do as well if we wanted to support these
// artifacts in mixed builds.
//
// However, there are some bazel built-in rules that use tree artifacts. Allow those,
// but keep in mind that they'll have incrementality issues.
return nil, fmt.Errorf("tree artifacts are currently not supported in mixed builds: " + artifactPath)
}
artifactIdToPath[artifactId(artifact.Id)] = artifactPath
}