From 6dabfdda651e2d22a39b46cddeb92f81c8087b14 Mon Sep 17 00:00:00 2001 From: Android Culprit Assistant Date: Mon, 2 Oct 2023 21:26:39 +0000 Subject: [PATCH 1/2] Revert "NDK library: enable feature flags for diffing ABI repres..." This revert was created by Android Culprit Assistant. The culprit was identified in the following culprit search session (http://go/aca-get/e18f14a6-af8b-4b9e-8f8e-73515c608887). Change-Id: I4e0b62eea9e1c0ff49fbbf92e900606ccf93b93a --- cc/ndk_library.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cc/ndk_library.go b/cc/ndk_library.go index 40bf218c1..9df628f3d 100644 --- a/cc/ndk_library.go +++ b/cc/ndk_library.go @@ -339,7 +339,7 @@ func canDumpAbi(config android.Config) bool { // Feature flag to disable diffing against prebuilts. func canDiffAbi() bool { - return true + return false } func (this *stubDecorator) dumpAbi(ctx ModuleContext, symbolList android.Path) { From cd44909edcc4f59f4ee2649cc123f098deec8aca Mon Sep 17 00:00:00 2001 From: Android Culprit Assistant Date: Mon, 2 Oct 2023 21:26:39 +0000 Subject: [PATCH 2/2] Revert "NDK library: enable feature flags for dumping ABI repres..." This revert was created by Android Culprit Assistant. The culprit was identified in the following culprit search session (http://go/aca-get/e18f14a6-af8b-4b9e-8f8e-73515c608887). Change-Id: Ia32769fc520459ce7cb61f8e5b1def623eee93ff --- cc/ndk_library.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cc/ndk_library.go b/cc/ndk_library.go index 9df628f3d..56c57b94c 100644 --- a/cc/ndk_library.go +++ b/cc/ndk_library.go @@ -334,7 +334,13 @@ func canDumpAbi(config android.Config) bool { return false } // http://b/156513478 - return true + // http://b/277624006 + // This step is expensive. We're not able to do anything with the outputs of + // this step yet (canDiffAbi is flagged off because libabigail isn't able to + // handle all our libraries), disable it. There's no sense in protecting + // against checking in code that breaks abidw since by the time any of this + // can be turned on we'll need to migrate to STG anyway. + return false } // Feature flag to disable diffing against prebuilts.