From 17ff63632227f021704f1b0a6b418a64d089a657 Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Tue, 14 Feb 2017 13:03:54 -0800 Subject: [PATCH] Ban --coverage now that we have native coverage Bug: 32749731 Test: m -j Change-Id: Icb6ca0d846cba0ca842d3fb12dde1f1e8701cf5d --- cc/check.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cc/check.go b/cc/check.go index 340464e4b..d04b14595 100644 --- a/cc/check.go +++ b/cc/check.go @@ -36,6 +36,8 @@ func CheckBadCompilerFlags(ctx BaseModuleContext, prop string, flags []string) { ctx.PropertyErrorf(prop, "Bad flag `%s`, use local_include_dirs or include_dirs instead", flag) } else if inList(flag, config.IllegalFlags) { ctx.PropertyErrorf(prop, "Illegal flag `%s`", flag) + } else if flag == "--coverage" { + ctx.PropertyErrorf(prop, "Bad flag: `%s`, use native_coverage instead", flag) } else if strings.Contains(flag, " ") { args := strings.Split(flag, " ") if args[0] == "-include" { @@ -73,6 +75,8 @@ func CheckBadLinkerFlags(ctx BaseModuleContext, prop string, flags []string) { ctx.PropertyErrorf(prop, "Bad flag: `%s` is not allowed", flag) } else if strings.HasPrefix(flag, "-Wl,--version-script") { ctx.PropertyErrorf(prop, "Bad flag: `%s`, use version_script instead", flag) + } else if flag == "--coverage" { + ctx.PropertyErrorf(prop, "Bad flag: `%s`, use native_coverage instead", flag) } else if strings.Contains(flag, " ") { args := strings.Split(flag, " ") if args[0] == "-z" {