From 1b3e949d14d87684d56bbfda411048c605cab805 Mon Sep 17 00:00:00 2001 From: Tobias Thierer Date: Sat, 2 Jan 2021 19:01:16 +0000 Subject: [PATCH] go/Android.bp: Clarify sdk_version documentation. The documentation was unclear because there are at least three different ways (codename, version, API level) to refer to each version, see https://source.android.com/setup/start/build-numbers It is further complicated by the fact that this value is taken as a String even though the API level it refers to is normally an integer. To disambiguate, this CL adds an example. Test: Treehugger only. Change-Id: I40c13104a87d16c84c2098f36f7f63447d3dda4d --- java/rro.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/java/rro.go b/java/rro.go index 98cd3793e..aafa88e3b 100644 --- a/java/rro.go +++ b/java/rro.go @@ -55,7 +55,11 @@ type RuntimeResourceOverlayProperties struct { // only when the ro.boot.vendor.overlay.theme system property is set to the same value. Theme *string - // if not blank, set to the version of the sdk to compile against. + // If not blank, set to the version of the sdk to compile against. This + // can be either an API version (e.g. "29" for API level 29 AKA Android 10) + // or special subsets of the current platform, for example "none", "current", + // "core", "system", "test". See build/soong/java/sdk.go for the full and + // up-to-date list of possible values. // Defaults to compiling against the current platform. Sdk_version *string