tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

bp2build: make generated BUILD files publicly visible.

Browse source 
This is obviously not good build hygiene, but since Soong modules are in a global namespace, making BUILD files fully public will increase our velocity during the initial migration phases.

We'd want to lock visibility down to private by default as soon as possible, but for the purposes of migration, these will be public.

Test: bazel build //bionic/...
Change-Id: I99d62f3f8826712240decd325928435333870352
This commit is contained in:
Jingwen Chen 2021-02-05 09:38:15 -05:00
parent 77e8b7b6d2
commit 1c2317315c
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
bp2build/conversion.go
View file

@ -50,7 +50,12 @@ func createBuildFiles(buildToTargets map[string]BazelTargets, mode CodegenMode)
sort.Slice(targets, func(i, j int) bool { return targets[i].name < targets[j].name })
content := soongModuleLoad
if mode == Bp2Build {
content = targets.LoadStatements()
content = `# This file was automatically generated by bp2build for the Bazel migration project.
# Feel free to edit or test it, but do *not* check it into your version control system.`
content += "\n\n"
content += "package(default_visibility = [\"//visibility:public\"])"
content += "\n\n"
content += targets.LoadStatements()
}
if content != "" {
// If there are load statements, add a couple of newlines.