From f880b58970005389583b1aab58188709c3ba0417 Mon Sep 17 00:00:00 2001 From: Dan Willemsen Date: Mon, 23 Jul 2018 23:09:05 -0700 Subject: [PATCH] Turn on phony checks --warn_real_to_phony will print a warning any time that a non-PHONY rule depends on a PHONY rule. Since PHONY rules are always considered dirty this would force rebuilds on every incremental build. Real rules should always depend on rules that have real outputs. --warn_phony_looks_real will print a warning any time that a PHONY rule has an output that looks like a file (has as / in it). This is can cause confusion for users if it's not a real file, and it shouldn't be marked as PHONY if it will be run every time (since that will slow down incremental builds). Test: run build_test on downstream branches, see few warnings Change-Id: Id135c85c991976be33cd48a34eba0caaff1eda2c --- ui/build/kati.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/build/kati.go b/ui/build/kati.go index 7cfa1cf70..de8dbf4b2 100644 --- a/ui/build/kati.go +++ b/ui/build/kati.go @@ -78,6 +78,8 @@ func runKati(ctx Context, config Config) { "--werror_find_emulator", "--no_builtin_rules", "--werror_suffix_rules", + "--warn_real_to_phony", + "--warn_phony_looks_real", "--kati_stats", "-f", "build/make/core/main.mk", }