Merge changes from topic "abigail-werror" am: e31a071389
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2065275 Change-Id: I2ad507fb59e2443ba99fc671af35e1e4d2f3e399 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
commit
30cfbf22eb
2 changed files with 14 additions and 4 deletions
|
@ -46,7 +46,7 @@ func (n *ndkAbiDumpSingleton) GenerateBuildActions(ctx android.SingletonContext)
|
|||
|
||||
if m, ok := module.(*Module); ok {
|
||||
if installer, ok := m.installer.(*stubDecorator); ok {
|
||||
if canDumpAbi() {
|
||||
if canDumpAbi(ctx.Config()) {
|
||||
depPaths = append(depPaths, installer.abiDumpPath)
|
||||
}
|
||||
}
|
||||
|
|
|
@ -321,8 +321,18 @@ func (this *stubDecorator) findPrebuiltAbiDump(ctx ModuleContext,
|
|||
}
|
||||
|
||||
// Feature flag.
|
||||
func canDumpAbi() bool {
|
||||
return runtime.GOOS != "darwin"
|
||||
func canDumpAbi(config android.Config) bool {
|
||||
if runtime.GOOS == "darwin" {
|
||||
return false
|
||||
}
|
||||
// abidw doesn't currently handle top-byte-ignore correctly. Disable ABI
|
||||
// dumping for those configs while we wait for a fix. We'll still have ABI
|
||||
// checking coverage from non-hwasan builds.
|
||||
// http://b/190554910
|
||||
if android.InList("hwaddress", config.SanitizeDevice()) {
|
||||
return false
|
||||
}
|
||||
return true
|
||||
}
|
||||
|
||||
// Feature flag to disable diffing against prebuilts.
|
||||
|
@ -458,7 +468,7 @@ func (c *stubDecorator) compile(ctx ModuleContext, flags Flags, deps PathDeps) O
|
|||
nativeAbiResult := parseNativeAbiDefinition(ctx, symbolFile, c.apiLevel, "")
|
||||
objs := compileStubLibrary(ctx, flags, nativeAbiResult.stubSrc)
|
||||
c.versionScriptPath = nativeAbiResult.versionScript
|
||||
if canDumpAbi() {
|
||||
if canDumpAbi(ctx.Config()) {
|
||||
c.dumpAbi(ctx, nativeAbiResult.symbolList)
|
||||
if canDiffAbi() {
|
||||
c.diffAbi(ctx)
|
||||
|
|
Loading…
Reference in a new issue