From 39ef52f1df0d1aa39a51cf8de0c4a2351b3f67c3 Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Tue, 12 Nov 2019 09:59:12 -0800 Subject: [PATCH] Forbid -Weverything Use of -Weverything blocks build system changes and toolchain updates on new warnings. Forbid it in the build system. Developers can experiment with -Weverything on their module by adding it to their Android.bp file and building with m ANDROID_TEMPORARILY_ALLOW_WEVERYTHING=true Fixes: 143713277 Test: manual Change-Id: If154db328c52f687161e7a41e486d56a129850ac --- cc/check.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/cc/check.go b/cc/check.go index 4e9e16080..46328e915 100644 --- a/cc/check.go +++ b/cc/check.go @@ -38,6 +38,11 @@ func CheckBadCompilerFlags(ctx BaseModuleContext, prop string, flags []string) { ctx.PropertyErrorf(prop, "Illegal flag `%s`", flag) } else if flag == "--coverage" { ctx.PropertyErrorf(prop, "Bad flag: `%s`, use native_coverage instead", flag) + } else if flag == "-Weverything" { + if !ctx.Config().IsEnvTrue("ANDROID_TEMPORARILY_ALLOW_WEVERYTHING") { + ctx.PropertyErrorf(prop, "-Weverything is not allowed in Android.bp files. "+ + "Build with `m ANDROID_TEMPORARILY_ALLOW_WEVERYTHING=true` to experiment locally with -Weverything.") + } } else if strings.Contains(flag, " ") { args := strings.Split(flag, " ") if args[0] == "-include" {