From 3f5659f268d8d32aadc7dc27a1f1a730a2a60528 Mon Sep 17 00:00:00 2001 From: Spandan Das Date: Thu, 19 Aug 2021 19:31:54 +0000 Subject: [PATCH] Revert "Revert "Apply pylint to cc/symbolfile"" This reverts commit ea28f4cae7c1a4c9dcaa4d1b9d644581553b649f. Reason for revert: Postsubmit failure was unrelated, and was fixed by this revert CL aosp/1802327 Change-Id: I2693b17c2261cfc3dce0ed69baeb2d1f45f784f8 --- cc/symbolfile/__init__.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cc/symbolfile/__init__.py b/cc/symbolfile/__init__.py index 31c444385..f8d18414c 100644 --- a/cc/symbolfile/__init__.py +++ b/cc/symbolfile/__init__.py @@ -329,7 +329,7 @@ class SymbolFileParser: def parse(self) -> List[Version]: """Parses the symbol file and returns a list of Version objects.""" versions = [] - while self.next_line() != '': + while self.next_line(): assert self.current_line is not None if '{' in self.current_line: versions.append(self.parse_version()) @@ -376,7 +376,7 @@ class SymbolFileParser: symbols: List[Symbol] = [] global_scope = True cpp_symbols = False - while self.next_line() != '': + while self.next_line(): if '}' in self.current_line: # Line is something like '} BASE; # tags'. Both base and tags # are optional here. @@ -428,11 +428,11 @@ class SymbolFileParser: A return value of '' indicates EOF. """ line = self.input_file.readline() - while line.strip() == '' or line.strip().startswith('#'): + while not line.strip() or line.strip().startswith('#'): line = self.input_file.readline() # We want to skip empty lines, but '' indicates EOF. - if line == '': + if not line: break self.current_line = line return self.current_line