tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

release_config: Do not force ranking in inheritance graph

Browse source 
Let graphvis decide how to best display the release config graph.
Also add some color to the graph.

Bug: None
Test: manual
Change-Id: If8b9eb41eb78bd553fd5543938a2c1c098b41591
This commit is contained in:
LaMont Jones 2024-06-04 17:19:45 -07:00
parent 7bd25635aa
commit 4bb19b2414
1 changed files with 19 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

36
cmd/release_config/release_config_lib/release_configs.go
View file

@ -87,16 +87,15 @@ func (configs *ReleaseConfigs) WriteInheritanceGraph(outFile string) error {
data := []string{}
usedAliases := make(map[string]bool)
priorStages := make(map[string][]string)
rankedStageNames := make(map[string]bool)
for _, config := range configs.ReleaseConfigs {
if config.Name == "root" {
continue
}
var fillColor string
inherits := []string{}
for _, inherit := range config.InheritNames {
if inherit == "root" {
// Only show "root" if we have no other inheritance.
if len(config.InheritNames) > 1 {
continue
}
continue
}
data = append(data, fmt.Sprintf(`"%s" -> "%s"`, config.Name, inherit))
inherits = append(inherits, inherit)
@ -113,14 +112,9 @@ func (configs *ReleaseConfigs) WriteInheritanceGraph(outFile string) error {
}
// Add links for all of the advancement progressions.
for priorStage := range config.PriorStagesMap {
stageName := config.Name
if len(config.OtherNames) > 0 {
stageName = config.OtherNames[0]
}
data = append(data, fmt.Sprintf(`"%s" -> "%s" [ style=dashed color="#81c995" ]`,
priorStage, stageName))
priorStages[stageName] = append(priorStages[stageName], priorStage)
rankedStageNames[stageName] = true
priorStage, config.Name))
priorStages[config.Name] = append(priorStages[config.Name], priorStage)
}
label := config.Name
if len(inherits) > 0 {
@ -129,16 +123,24 @@ func (configs *ReleaseConfigs) WriteInheritanceGraph(outFile string) error {
if len(config.OtherNames) > 0 {
label += "\\nother names: " + strings.Join(config.OtherNames, " ")
}
// The active release config has a light blue fill.
if config.Name == *configs.Artifact.ReleaseConfig.Name {
switch config.Name {
case *configs.Artifact.ReleaseConfig.Name:
// The active release config has a light blue fill.
fillColor = `fillcolor="#d2e3fc" `
case "trunk", "trunk_staging":
// Certain workflow stages have a light green fill.
fillColor = `fillcolor="#ceead6" `
default:
// Look for "next" and "*_next", make them light green as well.
for _, n := range config.OtherNames {
if n == "next" || strings.HasSuffix(n, "_next") {
fillColor = `fillcolor="#ceead6" `
}
}
}
data = append(data,
fmt.Sprintf(`"%s" [ label="%s" %s]`, config.Name, label, fillColor))
}
if len(rankedStageNames) > 0 {
data = append(data, fmt.Sprintf("subgraph {rank=same %s}", strings.Join(SortedMapKeys(rankedStageNames), " ")))
}
slices.Sort(data)
data = append([]string{
"digraph {",