From fddeaff4a639c806e640283f9d53b42686524f2e Mon Sep 17 00:00:00 2001 From: Chris Parsons Date: Wed, 17 May 2023 21:53:34 +0000 Subject: [PATCH] Revert "Turn on HINT_FROM_SOONG by default" This reverts commit f5c872f36b129d97c222df61760381c1449558f5. Revert reason: The original commit seems to have a performance regression for a number of benchmarked performance CUJs. Bug: 283143307 Test: Benchmarking results. See attached bug. Change-Id: Ib9463c8d30a5ba61640993424696a84e2e03040a --- ui/build/config.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ui/build/config.go b/ui/build/config.go index 6b6ce7154..8ec96800f 100644 --- a/ui/build/config.go +++ b/ui/build/config.go @@ -316,9 +316,8 @@ func UploadOnlyConfig(ctx Context, args ...string) Config { func NewConfig(ctx Context, args ...string) Config { ret := &configImpl{ - environ: OsEnvironment(), - sandboxConfig: &SandboxConfig{}, - ninjaWeightListSource: HINT_FROM_SOONG, + environ: OsEnvironment(), + sandboxConfig: &SandboxConfig{}, } // Default matching ninja