Add comments to {cc,rust}/strip.go
Bug: 173695621 Test: n/a Change-Id: If3086aa711507c3be6db23e3691163cdd68710bf
This commit is contained in:
parent
7a64f7e5b6
commit
588ed66364
2 changed files with 27 additions and 6 deletions
28
cc/strip.go
28
cc/strip.go
|
@ -20,20 +20,32 @@ import (
|
||||||
"android/soong/android"
|
"android/soong/android"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// StripProperties defines the type of stripping applied to the module.
|
||||||
type StripProperties struct {
|
type StripProperties struct {
|
||||||
Strip struct {
|
Strip struct {
|
||||||
None *bool `android:"arch_variant"`
|
// whether to disable all stripping.
|
||||||
All *bool `android:"arch_variant"`
|
None *bool `android:"arch_variant"`
|
||||||
Keep_symbols *bool `android:"arch_variant"`
|
|
||||||
Keep_symbols_list []string `android:"arch_variant"`
|
// whether to strip everything, including the mini debug info.
|
||||||
Keep_symbols_and_debug_frame *bool `android:"arch_variant"`
|
All *bool `android:"arch_variant"`
|
||||||
|
|
||||||
|
// whether to keep the symbols.
|
||||||
|
Keep_symbols *bool `android:"arch_variant"`
|
||||||
|
|
||||||
|
// keeps only the symbols defined here.
|
||||||
|
Keep_symbols_list []string `android:"arch_variant"`
|
||||||
|
|
||||||
|
// whether to keep the symbols and the debug frames.
|
||||||
|
Keep_symbols_and_debug_frame *bool `android:"arch_variant"`
|
||||||
} `android:"arch_variant"`
|
} `android:"arch_variant"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Stripper defines the stripping actions and properties for a module.
|
||||||
type Stripper struct {
|
type Stripper struct {
|
||||||
StripProperties StripProperties
|
StripProperties StripProperties
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// NeedsStrip determines if stripping is required for a module.
|
||||||
func (stripper *Stripper) NeedsStrip(actx android.ModuleContext) bool {
|
func (stripper *Stripper) NeedsStrip(actx android.ModuleContext) bool {
|
||||||
// TODO(ccross): enable host stripping when embedded in make? Make never had support for stripping host binaries.
|
// TODO(ccross): enable host stripping when embedded in make? Make never had support for stripping host binaries.
|
||||||
return (!actx.Config().EmbeddedInMake() || actx.Device()) && !Bool(stripper.StripProperties.Strip.None)
|
return (!actx.Config().EmbeddedInMake() || actx.Device()) && !Bool(stripper.StripProperties.Strip.None)
|
||||||
|
@ -60,11 +72,17 @@ func (stripper *Stripper) strip(actx android.ModuleContext, in android.Path, out
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// StripExecutableOrSharedLib strips a binary or shared library from its debug
|
||||||
|
// symbols and other debugging information. The helper function
|
||||||
|
// flagsToStripFlags may be used to generate the flags argument.
|
||||||
func (stripper *Stripper) StripExecutableOrSharedLib(actx android.ModuleContext, in android.Path,
|
func (stripper *Stripper) StripExecutableOrSharedLib(actx android.ModuleContext, in android.Path,
|
||||||
out android.ModuleOutPath, flags StripFlags) {
|
out android.ModuleOutPath, flags StripFlags) {
|
||||||
stripper.strip(actx, in, out, flags, false)
|
stripper.strip(actx, in, out, flags, false)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// StripStaticLib strips a static library from its debug symbols and other
|
||||||
|
// debugging information. The helper function flagsToStripFlags may be used to
|
||||||
|
// generate the flags argument.
|
||||||
func (stripper *Stripper) StripStaticLib(actx android.ModuleContext, in android.Path, out android.ModuleOutPath,
|
func (stripper *Stripper) StripStaticLib(actx android.ModuleContext, in android.Path, out android.ModuleOutPath,
|
||||||
flags StripFlags) {
|
flags StripFlags) {
|
||||||
stripper.strip(actx, in, out, flags, true)
|
stripper.strip(actx, in, out, flags, true)
|
||||||
|
|
|
@ -19,11 +19,14 @@ import (
|
||||||
"android/soong/cc"
|
"android/soong/cc"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Stripper encapsulates cc.Stripper.
|
// Stripper defines the stripping actions and properties for a module. The Rust
|
||||||
|
// implementation reuses the C++ implementation.
|
||||||
type Stripper struct {
|
type Stripper struct {
|
||||||
cc.Stripper
|
cc.Stripper
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// StripExecutableOrSharedLib strips a binary or shared library from its debug
|
||||||
|
// symbols and other debug information.
|
||||||
func (s *Stripper) StripExecutableOrSharedLib(ctx ModuleContext, in android.Path, out android.ModuleOutPath) {
|
func (s *Stripper) StripExecutableOrSharedLib(ctx ModuleContext, in android.Path, out android.ModuleOutPath) {
|
||||||
ccFlags := cc.StripFlags{Toolchain: ctx.RustModule().ccToolchain(ctx)}
|
ccFlags := cc.StripFlags{Toolchain: ctx.RustModule().ccToolchain(ctx)}
|
||||||
s.Stripper.StripExecutableOrSharedLib(ctx, in, out, ccFlags)
|
s.Stripper.StripExecutableOrSharedLib(ctx, in, out, ccFlags)
|
||||||
|
|
Loading…
Reference in a new issue