tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Handle Clang's change of defaults from -fcommon to -fno-common

Browse source 
Remove fcommon and make fno-common by default.

Bug: b/151457797
Test: make checkbuild
Change-Id: Ieb4c1e1bfff05fd0db894e8eab263fb31b376da9
This commit is contained in:
zijunzhao 2023-08-16 22:17:12 +00:00
parent d753c2e53c
commit 5bcebba331
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cc/config/global.go
View file

@ -67,10 +67,6 @@ var (
// not emit the table by default on Android since NDK still uses GNU binutils.
"-faddrsig",
// Turn on -fcommon explicitly, since Clang now defaults to -fno-common. The cleanup bug
// tracking this is http://b/151457797.
"-fcommon",
// Help catch common 32/64-bit errors.
"-Werror=int-conversion",
@ -253,6 +249,8 @@ var (
// (anything for which IsThirdPartyPath() in build/soong/android/paths.go
// returns true - includes external/, most of vendor/ and most of hardware/)
noOverrideExternalGlobalCflags = []string{
// http://b/151457797
"-fcommon",
// http://b/191699019
"-Wno-format-insufficient-args",
// http://b/296321145