tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use only single dash for tidy flags

Browse source 
* Work around RBE preprocessor bug, which rejects double dash flags.

Bug: 217778010
Test: make tidy-soong_subset
Change-Id: Ic7c0a95ae7afefb49cc9d124fd3c9f38fe2e0f56
This commit is contained in:
Chih-Hung Hsieh 2022-02-04 17:42:02 -08:00
parent 99a81c8dfd
commit 63d59eb77c
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cc/tidy.go
View file

@ -102,6 +102,12 @@ func (tidy *tidyFeature) flags(ctx ModuleContext, flags Flags) Flags {
}
flags.TidyFlags = append(flags.TidyFlags, headerFilter)
}
// Work around RBE bug in parsing clang-tidy flags, replace "--flag" with "-flag".
// Some C/C++ modules added local tidy flags like --header-filter= and --extra-arg-before=.
doubleDash := regexp.MustCompile("^('?)--(.*)$")
for i, s := range flags.TidyFlags {
flags.TidyFlags[i] = doubleDash.ReplaceAllString(s, "$1-$2")
}
// If clang-tidy is not enabled globally, add the -quiet flag.
if !ctx.Config().ClangTidy() {