From f776c8c47cb91b825cca76c97be29960c55f1d05 Mon Sep 17 00:00:00 2001 From: Pirama Arumuga Nainar Date: Thu, 27 Jan 2022 10:46:26 -0800 Subject: [PATCH 1/2] [cc/coverage] Override/disable -Wframe-larger-than We can expect frame size increase with coverage instrumentation. Test: N/A Change-Id: Ifdb50809c83939ded5a26804aa0ae9404eb1a107 --- cc/coverage.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cc/coverage.go b/cc/coverage.go index 8dd2db19d..f2b5425e6 100644 --- a/cc/coverage.go +++ b/cc/coverage.go @@ -98,6 +98,9 @@ func (cov *coverage) flags(ctx ModuleContext, flags Flags, deps PathDeps) (Flags } else if clangCoverage { flags.Local.CommonFlags = append(flags.Local.CommonFlags, profileInstrFlag, "-fcoverage-mapping", "-Wno-pass-failed", "-D__ANDROID_CLANG_COVERAGE__") + // Override -Wframe-larger-than. We can expect frame size increase after + // coverage instrumentation. + flags.Local.CFlags = append(flags.Local.CFlags, "-Wno-frame-larger-than=") } } From 0d7d3e1647b18e474cb350157dbb7e4d1558282e Mon Sep 17 00:00:00 2001 From: Pirama Arumuga Nainar Date: Thu, 27 Jan 2022 10:49:13 -0800 Subject: [PATCH 2/2] [cc] Add per-file OWNERS for cc/coverage.go Test: N/A Change-Id: I728208ed9ef10e032fd12e495ba67121e4c849e5 --- cc/OWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cc/OWNERS b/cc/OWNERS index a7e6ebb0b..a438b1564 100644 --- a/cc/OWNERS +++ b/cc/OWNERS @@ -1,4 +1,4 @@ per-file ndk_*.go = danalbert@google.com per-file tidy.go = srhines@google.com, chh@google.com per-file afdo.go,afdo_test.go,lto.go,pgo.go = srhines@google.com, pirama@google.com, yikong@google.com - +per-file coverage.go = pirama@google.com, srhines@google.com, allenhair@google.com