From 77dc7d0839c53d76092e7b75ba3c3d4734542bbd Mon Sep 17 00:00:00 2001 From: Tahsin Loqman Date: Mon, 19 Dec 2022 16:27:25 +0000 Subject: [PATCH] Revert "Allow adding extra tradefed options in the Android.bp file" This reverts commit 8ec823cba166a41eb0e9e5ff8fe679e691fec678. Reason for revert: DroidMonitor: Potential culprit for Bug b/262965953 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted. Change-Id: I236cc36981d8b30527ca286632727f8ca267e969 --- android/module.go | 1 + cc/test.go | 23 +--- java/java.go | 27 +---- java/java_test.go | 22 ---- java/robolectric.go | 11 +- python/test.go | 11 +- rust/benchmark.go | 14 +-- rust/test.go | 17 ++- sh/sh_binary.go | 12 +- tradefed/autogen.go | 271 ++++++++++++++++++++++++-------------------- 10 files changed, 177 insertions(+), 232 deletions(-) diff --git a/android/module.go b/android/module.go index bf9737aa2..681f724b0 100644 --- a/android/module.go +++ b/android/module.go @@ -27,6 +27,7 @@ import ( "text/scanner" "android/soong/bazel" + "github.com/google/blueprint" "github.com/google/blueprint/proptools" ) diff --git a/cc/test.go b/cc/test.go index ed2a58a04..536210ba4 100644 --- a/cc/test.go +++ b/cc/test.go @@ -459,16 +459,8 @@ func (test *testBinary) install(ctx ModuleContext, file android.Path) { configs = append(configs, tradefed.Object{"module_controller", "com.android.tradefed.testtype.suite.module.MinApiLevelModuleController", options}) } - test.testConfig = tradefed.NewMaybeAutoGenTestConfigBuilder(ctx). - SetTestConfigProp(test.Properties.Test_config). - SetTestTemplateConfigProp(test.Properties.Test_config_template). - SetTestSuites(test.testDecorator.InstallerProperties.Test_suites). - SetConfig(configs). - SetAutoGenConfig(test.Properties.Auto_gen_config). - SetTestInstallBase(testInstallBase). - SetDeviceTemplate("${NativeTestConfigTemplate}"). - SetHostTemplate("${NativeHostTestConfigTemplate}"). - Build() + test.testConfig = tradefed.AutoGenNativeTestConfig(ctx, test.Properties.Test_config, + test.Properties.Test_config_template, test.testDecorator.InstallerProperties.Test_suites, configs, test.Properties.Auto_gen_config, testInstallBase) test.extraTestConfigs = android.PathsForModuleSrc(ctx, test.Properties.Test_options.Extra_test_configs) @@ -624,15 +616,8 @@ func (benchmark *benchmarkDecorator) install(ctx ModuleContext, file android.Pat if Bool(benchmark.Properties.Require_root) { configs = append(configs, tradefed.Object{"target_preparer", "com.android.tradefed.targetprep.RootTargetPreparer", nil}) } - benchmark.testConfig = tradefed.NewMaybeAutoGenTestConfigBuilder(ctx). - SetTestConfigProp(benchmark.Properties.Test_config). - SetTestTemplateConfigProp(benchmark.Properties.Test_config_template). - SetTestSuites(benchmark.Properties.Test_suites). - SetConfig(configs). - SetAutoGenConfig(benchmark.Properties.Auto_gen_config). - SetDeviceTemplate("${NativeBenchmarkTestConfigTemplate}"). - SetHostTemplate("${NativeBenchmarkTestConfigTemplate}"). - Build() + benchmark.testConfig = tradefed.AutoGenNativeBenchmarkTestConfig(ctx, benchmark.Properties.Test_config, + benchmark.Properties.Test_config_template, benchmark.Properties.Test_suites, configs, benchmark.Properties.Auto_gen_config) benchmark.binaryDecorator.baseInstaller.dir = filepath.Join("benchmarktest", ctx.ModuleName()) benchmark.binaryDecorator.baseInstaller.dir64 = filepath.Join("benchmarktest64", ctx.ModuleName()) diff --git a/java/java.go b/java/java.go index dd2437621..9dd585062 100644 --- a/java/java.go +++ b/java/java.go @@ -888,10 +888,6 @@ type TestOptions struct { // a list of extra test configuration files that should be installed with the module. Extra_test_configs []string `android:"path,arch_variant"` - - // Extra