tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Globally disable -Wreorder-init-list.

Browse source 
This warning is triggered even when initializers don't have any
side effects, so it very rarely surfaces actual bugs/mistakes.
99% of the time it complains about a purely cosmetic issue.
Disable it by default in commonGlobalCFlags, which still allows
individual modules to opt into it.

Bug: 145210666
Test: presubmit
Change-Id: I671b5c457ee3d92b9cc37f020ba54e01e1a04f59
This commit is contained in:
Krzysztof Kosiński 2023-10-20 01:02:58 +00:00
parent 4193286396
commit 8f8cc1668e
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cc/config/global.go
View file

@ -69,8 +69,6 @@ var (
// Making deprecated usages an error causes extreme pain when trying to // Making deprecated usages an error causes extreme pain when trying to
// deprecate anything. // deprecate anything.
"-Wno-error=deprecated-declarations", "-Wno-error=deprecated-declarations",
// This rarely indicates a bug. http://b/145210666
"-Wno-error=reorder-init-list",
// Warnings disabled by default. // Warnings disabled by default.
@ -86,6 +84,14 @@ var (
// subsequent version of an interface, so this warning is currently // subsequent version of an interface, so this warning is currently
// infeasible to enable. // infeasible to enable.
"-Wno-inconsistent-missing-override", "-Wno-inconsistent-missing-override",
// Detects designated initializers that are in a different order than
// the fields in the initialized type, which causes the side effects
// of initializers to occur out of order with the source code.
// In practice, this warning has extremely poor signal to noise ratio,
// because it is triggered even for initializers with no side effects.
// Individual modules can still opt into it via cflags.
"-Wno-error=reorder-init-list",
"-Wno-reorder-init-list",
// Incompatible with the Google C++ style guidance to use 'int' for loop // Incompatible with the Google C++ style guidance to use 'int' for loop
// indices; poor signal to noise ratio. // indices; poor signal to noise ratio.
"-Wno-sign-compare", "-Wno-sign-compare",