tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "Exclude prebuilts/clang/host/linux-x86/clang-dev/BUILD from the symlink forest."

Browse source
This commit is contained in:
Treehugger Robot 2022-11-30 11:51:59 +00:00 committed by Gerrit Code Review
commit 9b2e24c318
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
cmd/soong_build/main.go
View file

@ -578,6 +578,17 @@ func getTemporaryExcludes() []string {
// FIXME: 'frameworks/compile/slang' has a filegroup error due to an escaping issue // FIXME: 'frameworks/compile/slang' has a filegroup error due to an escaping issue
excludes = append(excludes, "frameworks/compile/slang") excludes = append(excludes, "frameworks/compile/slang")
// FIXME(b/260809113): 'prebuilts/clang/host/linux-x86/clang-dev' is a tool-generated symlink directory that contains a BUILD file.
// The bazel files finder code doesn't traverse into symlink dirs, and hence is not aware of this BUILD file and exclude it accordingly
// during symlink forest generation when checking against keepExistingBuildFiles allowlist.
//
// This is necessary because globs in //prebuilts/clang/host/linux-x86/BUILD
// currently assume no subpackages (keepExistingBuildFile is not recursive for that directory).
//
// This is a bandaid until we the symlink forest logic can intelligently exclude BUILD files found in source symlink dirs according
// to the keepExistingBuildFile allowlist.
excludes = append(excludes, "prebuilts/clang/host/linux-x86/clang-dev")
return excludes return excludes
} }