From 9ede2803752681713244f8800c86381e9a35c501 Mon Sep 17 00:00:00 2001 From: Helen Qin Date: Wed, 1 Mar 2023 19:31:36 +0000 Subject: [PATCH] Revert "Update clang version to clang-r487747" Revert submission 2446165-update-clang-r487747 Reason for revert: DroidMonitor-triggered revert due to breakage bug b/271252582 and b/271243811 Reverted changes: /q/submissionid:2446165-update-clang-r487747 Bug: 271252582 Bug: 271243811 Change-Id: I3b5c44982d268b5c6c3db39e7af4d7aa7c6dfbf7 --- android/config.go | 5 ----- cc/config/global.go | 9 ++------- 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/android/config.go b/android/config.go index adab93b9b..c0f84c8aa 100644 --- a/android/config.go +++ b/android/config.go @@ -1363,11 +1363,6 @@ func (c *deviceConfig) NativeCoverageEnabledForPath(path string) bool { } } if coverage && len(c.config.productVariables.NativeCoverageExcludePaths) > 0 { - // Workaround coverage boot failure. - // http://b/269981180 - if strings.HasPrefix(path, "external/protobuf") { - coverage = false - } if HasAnyPrefix(path, c.config.productVariables.NativeCoverageExcludePaths) { coverage = false } diff --git a/cc/config/global.go b/cc/config/global.go index d65f88351..05dc77354 100644 --- a/cc/config/global.go +++ b/cc/config/global.go @@ -192,10 +192,6 @@ var ( } noOverrideGlobalCflags = []string{ - // Workaround for boot loop caused by stack protector. - // http://b/267839238 - "-mllvm -disable-check-noreturn-call", - "-Werror=bool-operation", "-Werror=implicit-int-float-conversion", "-Werror=int-in-bool-context", @@ -257,7 +253,6 @@ var ( "-Wno-bitwise-instead-of-logical", "-Wno-misleading-indentation", "-Wno-array-parameter", - "-Wno-gnu-offsetof-extensions", } // Extra cflags for external third-party projects to disable warnings that @@ -310,8 +305,8 @@ var ( // prebuilts/clang default settings. ClangDefaultBase = "prebuilts/clang/host" - ClangDefaultVersion = "clang-r487747" - ClangDefaultShortVersion = "17" + ClangDefaultVersion = "clang-r475365b" + ClangDefaultShortVersion = "16.0.2" // Directories with warnings from Android.bp files. WarningAllowedProjects = []string{