From aa9369b71dac6b24061c6224d83578764b7cbaf9 Mon Sep 17 00:00:00 2001 From: Spandan Das Date: Wed, 22 May 2024 19:11:09 +0000 Subject: [PATCH] Drop IncludeTags This was previously used in conjunction with blueprint_package_includes to prune Android.bp files from soong analysis. Test: m nothing Bug: 308188212 Change-Id: Ie82e20eec63bd0be70e1cf0290c70f62d5621c76 --- android/config.go | 4 ---- android/register.go | 1 - android/variable.go | 1 - cmd/soong_build/main.go | 1 - ui/build/config.go | 8 -------- ui/build/dumpvars.go | 1 - ui/build/soong.go | 1 - 7 files changed, 17 deletions(-) diff --git a/android/config.go b/android/config.go index 76c590ad9..e1eb97b9c 100644 --- a/android/config.go +++ b/android/config.go @@ -1329,10 +1329,6 @@ func (c *config) SourceRootDirs() []string { return c.productVariables.SourceRootDirs } -func (c *config) IncludeTags() []string { - return c.productVariables.IncludeTags -} - func (c *config) HostStaticBinaries() bool { return Bool(c.productVariables.HostStaticBinaries) } diff --git a/android/register.go b/android/register.go index aeb3b4c1b..eb6a35e05 100644 --- a/android/register.go +++ b/android/register.go @@ -156,7 +156,6 @@ type Context struct { func NewContext(config Config) *Context { ctx := &Context{blueprint.NewContext(), config} ctx.SetSrcDir(absSrcDir) - ctx.AddIncludeTags(config.IncludeTags()...) ctx.AddSourceRootDirs(config.SourceRootDirs()...) return ctx } diff --git a/android/variable.go b/android/variable.go index a3fdafb77..e6358ccec 100644 --- a/android/variable.go +++ b/android/variable.go @@ -471,7 +471,6 @@ type ProductVariables struct { IgnorePrefer32OnDevice bool `json:",omitempty"` - IncludeTags []string `json:",omitempty"` SourceRootDirs []string `json:",omitempty"` AfdoProfiles []string `json:",omitempty"` diff --git a/cmd/soong_build/main.go b/cmd/soong_build/main.go index 4490dd2af..3dac8bdae 100644 --- a/cmd/soong_build/main.go +++ b/cmd/soong_build/main.go @@ -98,7 +98,6 @@ func newContext(configuration android.Config) *android.Context { ctx := android.NewContext(configuration) ctx.SetNameInterface(newNameResolver(configuration)) ctx.SetAllowMissingDependencies(configuration.AllowMissingDependencies()) - ctx.AddIncludeTags(configuration.IncludeTags()...) ctx.AddSourceRootDirs(configuration.SourceRootDirs()...) return ctx } diff --git a/ui/build/config.go b/ui/build/config.go index 7426a78ee..feded1c85 100644 --- a/ui/build/config.go +++ b/ui/build/config.go @@ -1164,14 +1164,6 @@ func (c *configImpl) SetSourceRootDirs(i []string) { c.sourceRootDirs = i } -func (c *configImpl) GetIncludeTags() []string { - return c.includeTags -} - -func (c *configImpl) SetIncludeTags(i []string) { - c.includeTags = i -} - func (c *configImpl) GetLogsPrefix() string { return c.logsPrefix } diff --git a/ui/build/dumpvars.go b/ui/build/dumpvars.go index e17bd5402..6691db830 100644 --- a/ui/build/dumpvars.go +++ b/ui/build/dumpvars.go @@ -301,6 +301,5 @@ func runMakeProductConfig(ctx Context, config Config) { config.SetBuildBrokenDupRules(makeVars["BUILD_BROKEN_DUP_RULES"] == "true") config.SetBuildBrokenUsesNetwork(makeVars["BUILD_BROKEN_USES_NETWORK"] == "true") config.SetBuildBrokenNinjaUsesEnvVars(strings.Fields(makeVars["BUILD_BROKEN_NINJA_USES_ENV_VARS"])) - config.SetIncludeTags(strings.Fields(makeVars["PRODUCT_INCLUDE_TAGS"])) config.SetSourceRootDirs(strings.Fields(makeVars["PRODUCT_SOURCE_ROOT_DIRS"])) } diff --git a/ui/build/soong.go b/ui/build/soong.go index 9955b1fdc..2f3150d03 100644 --- a/ui/build/soong.go +++ b/ui/build/soong.go @@ -401,7 +401,6 @@ func bootstrapBlueprint(ctx Context, config Config) { } blueprintCtx := blueprint.NewContext() - blueprintCtx.AddIncludeTags(config.GetIncludeTags()...) blueprintCtx.AddSourceRootDirs(config.GetSourceRootDirs()...) blueprintCtx.SetIgnoreUnknownModuleTypes(true) blueprintConfig := BlueprintConfig{