tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add a warning message about missing gcert at the end of the build

Browse source 
Now that we are ready to rollout gcert, adding a warning that builds
will fail if gcert doesn't exist. Doing this only for builds with
ANDROID_BUILD_ENVIRONMENT_CONFIG=googler.

Test: Ran a build without gcert and USE_RBE=true and it printed the
warning.
Bug: b/229743321

Change-Id: I616a4a534ab277873ac7e19baecb78620f07854c
This commit is contained in:
Kousik Kumar 2022-04-27 14:52:56 -04:00
parent 2d6e6a1338
commit b018b83664
2 changed files with 25 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ui/build/config.go
View file

@ -1205,6 +1205,21 @@ func (c *configImpl) rbeAuth() (string, string) {
return "RBE_use_application_default_credentials", "true" return "RBE_use_application_default_credentials", "true"
} }
func (c *configImpl) IsGooglerEnvironment() bool {
cf := "ANDROID_BUILD_ENVIRONMENT_CONFIG"
if v, ok := c.environ.Get(cf); ok {
return v == "googler"
}
return false
}
func (c *configImpl) GoogleProdCredsExist() bool {
if _, err := exec.Command("/usr/bin/prodcertstatus", "--simple_output", "--nocheck_loas").Output(); err != nil {
return false
}
return true
}
func (c *configImpl) UseRemoteBuild() bool { func (c *configImpl) UseRemoteBuild() bool {
return c.UseGoma() || c.UseRBE() return c.UseGoma() || c.UseRBE()
} }

10
ui/build/rbe.go
View file

@ -119,6 +119,7 @@ func startRBE(ctx Context, config Config) {
} }
func stopRBE(ctx Context, config Config) { func stopRBE(ctx Context, config Config) {
defer checkProdCreds(ctx, config)
cmd := Command(ctx, config, "stopRBE bootstrap", rbeCommand(ctx, config, bootstrapCmd), "-shutdown") cmd := Command(ctx, config, "stopRBE bootstrap", rbeCommand(ctx, config, bootstrapCmd), "-shutdown")
output, err := cmd.CombinedOutput() output, err := cmd.CombinedOutput()
if err != nil { if err != nil {
@ -131,6 +132,15 @@ func stopRBE(ctx Context, config Config) {
} }
} }
func checkProdCreds(ctx Context, config Config) {
if !config.IsGooglerEnvironment() || config.GoogleProdCredsExist() {
return
}
fmt.Fprintln(ctx.Writer, "")
fmt.Fprintln(ctx.Writer, "\033[33mWARNING: Missing LOAS credentials, please run `gcert`. This will result in failing RBE builds in the future, see go/build-fast#authentication.\033[0m")
fmt.Fprintln(ctx.Writer, "")
}
// DumpRBEMetrics creates a metrics protobuf file containing RBE related metrics. // DumpRBEMetrics creates a metrics protobuf file containing RBE related metrics.
// The protobuf file is created if RBE is enabled and the proxy service has // The protobuf file is created if RBE is enabled and the proxy service has
// started. The proxy service is shutdown in order to dump the RBE metrics to the // started. The proxy service is shutdown in order to dump the RBE metrics to the