diff --git a/android/neverallow.go b/android/neverallow.go index a91d523b1..94cceb226 100644 --- a/android/neverallow.go +++ b/android/neverallow.go @@ -27,7 +27,7 @@ import ( // "neverallow" rules for the build system. // // This allows things which aren't related to the build system and are enforced -// for sanity, in progress code refactors, or policy to be expressed in a +// against assumptions, in progress code refactors, or policy to be expressed in a // straightforward away disjoint from implementations and tests which should // work regardless of these restrictions. // diff --git a/apex/builder.go b/apex/builder.go index 6df40f4b8..38e99d2b5 100644 --- a/apex/builder.go +++ b/apex/builder.go @@ -105,7 +105,7 @@ var ( Description: "convert ${in}=>${out}", }) - // TODO(b/113233103): make sure that file_contexts is sane, i.e., validate + // TODO(b/113233103): make sure that file_contexts is as expected, i.e., validate // against the binary policy using sefcontext_compiler -p . // TODO(b/114327326): automate the generation of file_contexts diff --git a/cc/ndk_sysroot.go b/cc/ndk_sysroot.go index 2726b1a3f..fd458d96b 100644 --- a/cc/ndk_sysroot.go +++ b/cc/ndk_sysroot.go @@ -33,7 +33,7 @@ package cc // Component 3: Stub Libraries // The shared libraries in the NDK are not the actual shared libraries they // refer to (to prevent people from accidentally loading them), but stub -// libraries with dummy implementations of everything for use at build time +// libraries with placeholder implementations of everything for use at build time // only. // // Since we don't actually need to know anything about the stub libraries aside diff --git a/mk2rbc/cmd/mk2rbc.go b/mk2rbc/cmd/mk2rbc.go index 7b5f298e2..345b30e28 100644 --- a/mk2rbc/cmd/mk2rbc.go +++ b/mk2rbc/cmd/mk2rbc.go @@ -60,7 +60,7 @@ var ( ) func init() { - // Poor man's flag aliasing: works, but the usage string is ugly and + // Simplistic flag aliasing: works, but the usage string is ugly and // both flag and its alias can be present on the command line flagAlias := func(target string, alias string) { if f := flag.Lookup(target); f != nil { diff --git a/mk2rbc/types.go b/mk2rbc/types.go index ebd52d8bc..46c6aa9b3 100644 --- a/mk2rbc/types.go +++ b/mk2rbc/types.go @@ -53,7 +53,7 @@ type variableRegistrar interface { NewVariable(name string, varClass varClass, valueType starlarkType) } -// ScopeBase is a dummy implementation of the mkparser.Scope. +// ScopeBase is a placeholder implementation of the mkparser.Scope. // All our scopes are read-only and resolve only simple variables. type ScopeBase struct{} diff --git a/third_party/zip/reader_test.go b/third_party/zip/reader_test.go index dfaae7843..11c6d6e66 100644 --- a/third_party/zip/reader_test.go +++ b/third_party/zip/reader_test.go @@ -786,7 +786,7 @@ func TestIssue10957(t *testing.T) { } } -// Verify the number of files is sane. +// Verify the number of files is within expected bounds func TestIssue10956(t *testing.T) { data := []byte("PK\x06\x06PK\x06\a0000\x00\x00\x00\x00\x00\x00\x00\x00" + "0000PK\x05\x06000000000000" +