From b82821340221ab665b3643af464e927c726bb6ee Mon Sep 17 00:00:00 2001 From: Colin Cross Date: Wed, 17 Jan 2024 14:57:59 -0800 Subject: [PATCH] Fix data race in finder_test.go Wait for newFinder to finish writing its dump before ticking the clock. Test: go test -race ./... Change-Id: Ib7527ebfb4e1c989deefdb0779a4f9c0928ae15d --- finder/finder_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/finder/finder_test.go b/finder/finder_test.go index 8f73719a6..be22d13b6 100644 --- a/finder/finder_test.go +++ b/finder/finder_test.go @@ -813,6 +813,7 @@ func TestFileAdded(t *testing.T) { IncludeFiles: []string{"findme.txt"}, }, ) + finder.WaitForDbDump() filesystem.Clock.Tick() foundPaths := finder.FindNamedAt("/tmp", "findme.txt") finder.Shutdown() @@ -1445,6 +1446,7 @@ func TestUpdatingDbIffChanged(t *testing.T) { IncludeFiles: []string{"hi.txt"}, }, ) + finder.WaitForDbDump() filesystem.Clock.Tick() foundPaths := finder.FindAll() finder.Shutdown() @@ -1506,6 +1508,7 @@ func TestDirectoryNotPermitted(t *testing.T) { IncludeFiles: []string{"hi.txt"}, }, ) + finder.WaitForDbDump() filesystem.Clock.Tick() foundPaths := finder.FindAll() finder.Shutdown() @@ -1552,6 +1555,7 @@ func TestFileNotPermitted(t *testing.T) { IncludeFiles: []string{"hi.txt"}, }, ) + finder.WaitForDbDump() filesystem.Clock.Tick() foundPaths := finder.FindAll() finder.Shutdown() @@ -1573,6 +1577,7 @@ func TestCacheEntryPathUnexpectedError(t *testing.T) { IncludeFiles: []string{"hi.txt"}, }, ) + finder.WaitForDbDump() filesystem.Clock.Tick() foundPaths := finder.FindAll() finder.Shutdown()