tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "Revert "Add static_libs support to android_app bp2build converter."" am: 8a9a97b4a0 am: 474eddd20b am: 9b36f4b981 am: c19a2c16bd

Browse source 
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1948756

Change-Id: I36a0fd3f7147ef9975f55b61e872020a4bcd6c9e
This commit is contained in:
Romain Jobredeaux 2022-01-13 17:57:52 +00:00 committed by Automerger Merge Worker
commit cd41dd5c33
3 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
android/bazel.go
View file

@ -281,7 +281,6 @@ var (
"development/samples/USB/MissileLauncher": Bp2BuildDefaultTrue,
"development/samples/VoiceRecognitionService": Bp2BuildDefaultTrue,
"development/samples/VoicemailProviderDemo": Bp2BuildDefaultTrue,
"development/samples/WiFiDirectDemo": Bp2BuildDefaultTrue,
"development/sdk": Bp2BuildDefaultTrueRecursively,
"external/arm-optimized-routines": Bp2BuildDefaultTrueRecursively,
"external/boringssl": Bp2BuildDefaultTrueRecursively,

4
bp2build/android_app_conversion_test.go
View file

@ -66,7 +66,7 @@ func TestAndroidAppAllSupportedFields(t *testing.T) {
"resb/res.png": "",
"manifest/AndroidManifest.xml": "",
},
blueprint: simpleModuleDoNotConvertBp2build("android_app", "static_lib_dep") + `
blueprint: `
android_app {
name: "TestApp",
srcs: ["app.java"],
@ -74,7 +74,6 @@ android_app {
package_name: "com.google",
resource_dirs: ["resa", "resb"],
manifest: "manifest/AndroidManifest.xml",
static_libs: ["static_lib_dep"]
}
`,
expectedBazelTargets: []string{
@ -86,7 +85,6 @@ android_app {
"resb/res.png",
]`,
"custom_package": `"com.google"`,
"deps": `[":static_lib_dep"]`,
}),
}})
}

4
java/app.go
View file

@ -1442,7 +1442,6 @@ type bazelAndroidAppAttributes struct {
Manifest bazel.Label
Custom_package *string
Resource_files bazel.LabelListAttribute
Deps bazel.LabelListAttribute
}
// ConvertWithBp2build is used to convert android_app to Bazel.
@ -1460,15 +1459,12 @@ func (a *AndroidApp) ConvertWithBp2build(ctx android.TopDownMutatorContext) {
resourceFiles.Includes = append(resourceFiles.Includes, files...)
}
deps := bazel.MakeLabelListAttribute(android.BazelLabelForModuleDeps(ctx, a.properties.Static_libs))
attrs := &bazelAndroidAppAttributes{
Srcs: srcs,
Manifest: android.BazelLabelForModuleSrcSingle(ctx, manifest),
// TODO(b/209576404): handle package name override by product variable PRODUCT_MANIFEST_PACKAGE_NAME_OVERRIDES
Custom_package: a.overridableAppProperties.Package_name,
Resource_files: bazel.MakeLabelListAttribute(resourceFiles),
Deps: deps,
}
props := bazel.BazelTargetModuleProperties{Rule_class: "android_binary",
Bzl_load_location: "@rules_android//rules:rules.bzl"}