Merge "Have symlink_preferred_arch: true honor the stem property."

This commit is contained in:
Roland Levillain 2019-06-11 13:45:25 +00:00 committed by Gerrit Code Review
commit d7607c1c99

View file

@ -106,13 +106,17 @@ func (binary *binaryDecorator) linkerProps() []interface{} {
} }
func (binary *binaryDecorator) getStem(ctx BaseModuleContext) string { func (binary *binaryDecorator) getStemWithoutSuffix(ctx BaseModuleContext) string {
stem := ctx.baseModuleName() stem := ctx.baseModuleName()
if String(binary.Properties.Stem) != "" { if String(binary.Properties.Stem) != "" {
stem = String(binary.Properties.Stem) stem = String(binary.Properties.Stem)
} }
return stem + String(binary.Properties.Suffix) return stem
}
func (binary *binaryDecorator) getStem(ctx BaseModuleContext) string {
return binary.getStemWithoutSuffix(ctx) + String(binary.Properties.Suffix)
} }
func (binary *binaryDecorator) linkerDeps(ctx DepsContext, deps Deps) Deps { func (binary *binaryDecorator) linkerDeps(ctx DepsContext, deps Deps) Deps {
@ -398,11 +402,11 @@ func (binary *binaryDecorator) link(ctx ModuleContext,
} }
if Bool(binary.Properties.Symlink_preferred_arch) { if Bool(binary.Properties.Symlink_preferred_arch) {
if String(binary.Properties.Stem) == "" && String(binary.Properties.Suffix) == "" { if String(binary.Properties.Suffix) == "" {
ctx.PropertyErrorf("symlink_preferred_arch", "must also specify stem or suffix") ctx.PropertyErrorf("symlink_preferred_arch", "must also specify suffix")
} }
if ctx.TargetPrimary() { if ctx.TargetPrimary() {
binary.symlinks = append(binary.symlinks, ctx.baseModuleName()) binary.symlinks = append(binary.symlinks, binary.getStemWithoutSuffix(ctx))
} }
} }