From babb750cdf0e811ee7dda2e1e23d028d533b95dc Mon Sep 17 00:00:00 2001 From: Cole Faust Date: Tue, 21 Nov 2023 13:52:52 -0800 Subject: [PATCH] Sandbox angle_commit_id Sandboxing it generates this diff: 1c1 < #define ANGLE_COMMIT_HASH "1f7a2ce0bf57" --- > #define ANGLE_COMMIT_HASH "unknown hash" 3,4c3,4 < #define ANGLE_COMMIT_DATE "2023-11-17 17:33:59 +0000" < #define ANGLE_COMMIT_POSITION 26027 --- > #define ANGLE_COMMIT_DATE "unknown date" > #define ANGLE_COMMIT_POSITION 0 These constants appear to be unused, and we don't really want the build to inspect the git history, so just let them be unkown. Bug: 307824623 Test: ./build/soong/tests/genrule_sandbox_test.py angle_commit_id Change-Id: I3e35af14d13142927ded9477e975576d7324c6b7 --- genrule/allowlists.go | 1 - 1 file changed, 1 deletion(-) diff --git a/genrule/allowlists.go b/genrule/allowlists.go index 28d3d5497..897cc822b 100644 --- a/genrule/allowlists.go +++ b/genrule/allowlists.go @@ -40,7 +40,6 @@ var ( "aidl-golden-test-build-hook-gen", "aidl_camera_build_version", "android-cts-verifier", - "angle_commit_id", "atest_integration_fake_src", "awkgram.tab.h", "c2hal_test_genc++",