diff --git a/android/bazel.go b/android/bazel.go index 94b36e3ff..37e9219a4 100644 --- a/android/bazel.go +++ b/android/bazel.go @@ -533,13 +533,13 @@ func (b *BazelModuleBase) shouldConvertWithBp2build(ctx shouldConvertModuleConte moduleTypeAllowed := allowlist.moduleTypeAlwaysConvert[p.moduleType] allowlistConvert := moduleNameAllowed || moduleTypeAllowed if moduleNameAllowed && moduleTypeAllowed { - ctx.ModuleErrorf("A module cannot be in moduleAlwaysConvert and also be in moduleTypeAlwaysConvert") + ctx.ModuleErrorf("A module %q of type %q cannot be in moduleAlwaysConvert and also be in moduleTypeAlwaysConvert", moduleName, p.moduleType) return false } if allowlist.moduleDoNotConvert[moduleName] { if moduleNameAllowed { - ctx.ModuleErrorf("a module cannot be in moduleDoNotConvert and also be in moduleAlwaysConvert") + ctx.ModuleErrorf("a module %q cannot be in moduleDoNotConvert and also be in moduleAlwaysConvert", moduleName) } return false } diff --git a/android/bazel_test.go b/android/bazel_test.go index 194a6b359..15d3a6b52 100644 --- a/android/bazel_test.go +++ b/android/bazel_test.go @@ -252,7 +252,7 @@ func TestBp2BuildAllowlist(t *testing.T) { { description: "module in name allowlist and type allowlist fails", shouldConvert: false, - expectedErrors: []string{"A module cannot be in moduleAlwaysConvert and also be in moduleTypeAlwaysConvert"}, + expectedErrors: []string{"A module \"foo\" of type \"rule1\" cannot be in moduleAlwaysConvert and also be in moduleTypeAlwaysConvert"}, module: TestBazelModule{ TestModuleInfo: bazel.TestModuleInfo{ ModuleName: "foo", @@ -273,7 +273,7 @@ func TestBp2BuildAllowlist(t *testing.T) { { description: "module in allowlist and denylist fails", shouldConvert: false, - expectedErrors: []string{"a module cannot be in moduleDoNotConvert and also be in moduleAlwaysConvert"}, + expectedErrors: []string{"a module \"foo\" cannot be in moduleDoNotConvert and also be in moduleAlwaysConvert"}, module: TestBazelModule{ TestModuleInfo: bazel.TestModuleInfo{ ModuleName: "foo",