tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Freeze environment reading after saving deps

Browse source 
Any reads after the deps are saved won't show up as dependencies later.
So panic if new environment variables are read after saving deps.

Change-Id: Ia51deaf750804d3b99e69c001939a104c2d8c9f2
This commit is contained in:
Dan Willemsen 2015-09-11 17:06:19 -07:00
parent 98b26c576a
commit e7680babe2
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
common/config.go
View file

@ -48,8 +48,9 @@ type config struct {
srcDir string // the path of the root source directory
envLock sync.Mutex
envDeps map[string]string
envLock sync.Mutex
envDeps map[string]string
envFrozen bool
}
type jsonConfigurable interface {
@ -178,6 +179,9 @@ func (c *config) Getenv(key string) string {
var exists bool
c.envLock.Lock()
if val, exists = c.envDeps[key]; !exists {
if c.envFrozen {
panic("Cannot access new environment variables after envdeps are frozen")
}
val = os.Getenv(key)
c.envDeps[key] = val
}
@ -186,6 +190,9 @@ func (c *config) Getenv(key string) string {
}
func (c *config) EnvDeps() map[string]string {
c.envLock.Lock()
c.envFrozen = true
c.envLock.Unlock()
return c.envDeps
}