tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Remove more problematic env vars

Browse source 
I got a report of a user exporting CDPATH in their shell and causing
strange issues in the build. We should never need this value (and it
probably shouldn't be exported from the shell either -- that was their
workaround).

NDK_ROOT causes issues with Android.mk files thinking that they're
building with the ndk (like external/googletest/googletest/Android.mk).

Bug: 78933670
Test: CDPATH=. NDK_ROOT=test m; check out/soong.log
Change-Id: Icce43d7e31ed5e5e1fb7a4e37fd4dfbf421af4b1
This commit is contained in:
Dan Willemsen 2018-05-01 10:07:50 -07:00
parent 5a2c9d7a46
commit ebfe33ad80
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ui/build/config.go
View file

@ -102,8 +102,10 @@ func NewConfig(ctx Context, args ...string) Config {
"OUT_DIR_COMMON_BASE",
// Variables that have caused problems in the past
"CDPATH",
"DISPLAY",
"GREP_OPTIONS",
"NDK_ROOT",
// Drop make flags
"MAKEFLAGS",