From d91939ee8473b14890b0ad5b6ca14dd06bc9a7a5 Mon Sep 17 00:00:00 2001 From: Vinh Tran Date: Mon, 18 Apr 2022 19:27:17 +0000 Subject: [PATCH] Update doc for Platform_apis field in DeviceProperties The doc for Platform_apis is outdated. The property is used by not only android_app, but also android_test and android_test_helper_app https://cs.android.com/android/platform/superproject/+/master:build/soong/java/app.go;l=382;bpv=1 Next steps: 1. Clean up existing misuse of Platform_apis and Sdk_version in android_test and android_test_helper_app. 2. Add validation check to ensure proper use of Platform_apis and Sdk_version moving forward android_test and android_test_helper_app. Currently, android_app already has validation in place. https://cs.android.com/android/platform/superproject/+/master:build/soong/java/app.go;l=275;bpv=1;bpt=1 WIP: https://android-review.googlesource.com/c/platform/build/soong/+/2065270 Test: N/A Change-Id: I934860cdc8b23268d70e205089118c6451d4cf8a --- java/base.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/java/base.go b/java/base.go index 5802099ae..f2580e853 100644 --- a/java/base.go +++ b/java/base.go @@ -207,7 +207,7 @@ type DeviceProperties struct { // Whether to compile against the platform APIs instead of an SDK. // If true, then sdk_version must be empty. The value of this field - // is ignored when module's type isn't android_app. + // is ignored when module's type isn't android_app, android_test, or android_test_helper_app. Platform_apis *bool Aidl struct {