tequilaOS/platform_build_soong
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge "Remove the arch-based filtering hack in packaging.go"

Browse source
This commit is contained in:
Jiyong Park 2020-12-02 01:24:17 +00:00 committed by Gerrit Code Review
commit f10995b7b6
3 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
android/packaging.go
View file

@ -153,15 +153,9 @@ func (p *PackagingBase) AddDeps(ctx BottomUpMutatorContext, depTag blueprint.Dep
// See PackageModule.CopyDepsToZip
func (p *PackagingBase) CopyDepsToZip(ctx ModuleContext, zipOut OutputPath) (entries []string) {
var supportedArches []string
for _, t := range p.getSupportedTargets(ctx) {
supportedArches = append(supportedArches, t.Arch.ArchType.String())
}
m := make(map[string]PackagingSpec)
ctx.WalkDeps(func(child Module, parent Module) bool {
// Don't track modules with unsupported arch
// TODO(jiyong): remove this when aosp/1501613 lands.
if !InList(child.Target().Arch.ArchType.String(), supportedArches) {
if !IsInstallDepNeeded(ctx.OtherModuleDependencyTag(child)) {
return false
}
for _, ps := range child.PackagingSpecs() {

10
android/packaging_test.go
View file

@ -29,6 +29,12 @@ type componentTestModule struct {
}
}
// dep tag used in this test. All dependencies are considered as installable.
type installDepTag struct {
blueprint.BaseDependencyTag
InstallAlwaysNeededDependencyTag
}
func componentTestModuleFactory() Module {
m := &componentTestModule{}
m.AddProperties(&m.props)
@ -37,7 +43,7 @@ func componentTestModuleFactory() Module {
}
func (m *componentTestModule) DepsMutator(ctx BottomUpMutatorContext) {
ctx.AddDependency(ctx.Module(), nil, m.props.Deps...)
ctx.AddDependency(ctx.Module(), installDepTag{}, m.props.Deps...)
}
func (m *componentTestModule) GenerateAndroidBuildActions(ctx ModuleContext) {
@ -63,7 +69,7 @@ func packageTestModuleFactory() Module {
}
func (m *packageTestModule) DepsMutator(ctx BottomUpMutatorContext) {
m.AddDeps(ctx, struct{ blueprint.BaseDependencyTag }{})
m.AddDeps(ctx, installDepTag{})
}
func (m *packageTestModule) GenerateAndroidBuildActions(ctx ModuleContext) {

2
cc/cc.go
View file

@ -584,7 +584,7 @@ var (
genHeaderExportDepTag = dependencyTag{name: "gen header export"}
objDepTag = dependencyTag{name: "obj"}
linkerFlagsDepTag = dependencyTag{name: "linker flags file"}
dynamicLinkerDepTag = dependencyTag{name: "dynamic linker"}
dynamicLinkerDepTag = installDependencyTag{name: "dynamic linker"}
reuseObjTag = dependencyTag{name: "reuse objects"}
staticVariantTag = dependencyTag{name: "static variant"}
vndkExtDepTag = dependencyTag{name: "vndk extends"}