diff --git a/android/packaging.go b/android/packaging.go index f168fa6bf..77554016b 100644 --- a/android/packaging.go +++ b/android/packaging.go @@ -163,7 +163,7 @@ func (p *PackagingBase) CopyDepsToZip(ctx ModuleContext, zipOut OutputPath) (ent return true }) - builder := NewRuleBuilder() + builder := NewRuleBuilder(pctx, ctx) dir := PathForModuleOut(ctx, ".zip").OutputPath builder.Command().Text("rm").Flag("-rf").Text(dir.String()) @@ -190,13 +190,13 @@ func (p *PackagingBase) CopyDepsToZip(ctx ModuleContext, zipOut OutputPath) (ent } builder.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). FlagWithOutput("-o ", zipOut). FlagWithArg("-C ", dir.String()). Flag("-L 0"). // no compression because this will be unzipped soon FlagWithArg("-D ", dir.String()) builder.Command().Text("rm").Flag("-rf").Text(dir.String()) - builder.Build(pctx, ctx, "zip_deps", fmt.Sprintf("Zipping deps for %s", ctx.ModuleName())) + builder.Build("zip_deps", fmt.Sprintf("Zipping deps for %s", ctx.ModuleName())) return entries } diff --git a/android/proto.go b/android/proto.go index b712258eb..0be7893c8 100644 --- a/android/proto.go +++ b/android/proto.go @@ -122,7 +122,7 @@ type ProtoProperties struct { } `android:"arch_variant"` } -func ProtoRule(ctx ModuleContext, rule *RuleBuilder, protoFile Path, flags ProtoFlags, deps Paths, +func ProtoRule(rule *RuleBuilder, protoFile Path, flags ProtoFlags, deps Paths, outDir WritablePath, depFile WritablePath, outputs WritablePaths) { var protoBase string @@ -134,7 +134,7 @@ func ProtoRule(ctx ModuleContext, rule *RuleBuilder, protoFile Path, flags Proto } rule.Command(). - BuiltTool(ctx, "aprotoc"). + BuiltTool("aprotoc"). FlagWithArg(flags.OutTypeFlag+"=", strings.Join(flags.OutParams, ",")+":"+outDir.String()). FlagWithDepFile("--dependency_out=", depFile). FlagWithArg("-I ", protoBase). @@ -144,5 +144,5 @@ func ProtoRule(ctx ModuleContext, rule *RuleBuilder, protoFile Path, flags Proto ImplicitOutputs(outputs) rule.Command(). - BuiltTool(ctx, "dep_fixer").Flag(depFile.String()) + BuiltTool("dep_fixer").Flag(depFile.String()) } diff --git a/android/rule_builder.go b/android/rule_builder.go index 3efe9f8c6..e2d81877c 100644 --- a/android/rule_builder.go +++ b/android/rule_builder.go @@ -37,6 +37,9 @@ const sboxOutDir = sboxSandboxBaseDir + "/" + sboxOutSubDir // RuleBuilder provides an alternative to ModuleContext.Rule and ModuleContext.Build to add a command line to the build // graph. type RuleBuilder struct { + pctx PackageContext + ctx BuilderContext + commands []*RuleBuilderCommand installs RuleBuilderInstalls temporariesSet map[WritablePath]bool @@ -44,14 +47,16 @@ type RuleBuilder struct { sbox bool highmem bool remoteable RemoteRuleSupports - sboxOutDir WritablePath + outDir WritablePath sboxManifestPath WritablePath missingDeps []string } // NewRuleBuilder returns a newly created RuleBuilder. -func NewRuleBuilder() *RuleBuilder { +func NewRuleBuilder(pctx PackageContext, ctx BuilderContext) *RuleBuilder { return &RuleBuilder{ + pctx: pctx, + ctx: ctx, temporariesSet: make(map[WritablePath]bool), } } @@ -130,7 +135,7 @@ func (r *RuleBuilder) Sbox(outputDir WritablePath, manifestPath WritablePath) *R panic("Sbox() is not compatible with Restat()") } r.sbox = true - r.sboxOutDir = outputDir + r.outDir = outputDir r.sboxManifestPath = manifestPath return r } @@ -146,8 +151,7 @@ func (r *RuleBuilder) Install(from Path, to string) { // race with any call to Build. func (r *RuleBuilder) Command() *RuleBuilderCommand { command := &RuleBuilderCommand{ - sbox: r.sbox, - outDir: r.sboxOutDir, + rule: r, } r.commands = append(r.commands, command) return command @@ -395,19 +399,19 @@ type BuilderContext interface { var _ BuilderContext = ModuleContext(nil) var _ BuilderContext = SingletonContext(nil) -func (r *RuleBuilder) depFileMergerCmd(ctx PathContext, depFiles WritablePaths) *RuleBuilderCommand { +func (r *RuleBuilder) depFileMergerCmd(depFiles WritablePaths) *RuleBuilderCommand { return r.Command(). - BuiltTool(ctx, "dep_fixer"). + BuiltTool("dep_fixer"). Inputs(depFiles.Paths()) } // Build adds the built command line to the build graph, with dependencies on Inputs and Tools, and output files for // Outputs. -func (r *RuleBuilder) Build(pctx PackageContext, ctx BuilderContext, name string, desc string) { +func (r *RuleBuilder) Build(name string, desc string) { name = ninjaNameEscape(name) if len(r.missingDeps) > 0 { - ctx.Build(pctx, BuildParams{ + r.ctx.Build(pctx, BuildParams{ Rule: ErrorRule, Outputs: r.Outputs(), OrderOnly: r.OrderOnlys(), @@ -426,13 +430,13 @@ func (r *RuleBuilder) Build(pctx PackageContext, ctx BuilderContext, name string depFormat = blueprint.DepsGCC if len(depFiles) > 1 { // Add a command locally that merges all depfiles together into the first depfile. - r.depFileMergerCmd(ctx, depFiles) + r.depFileMergerCmd(depFiles) if r.sbox { // Check for Rel() errors, as all depfiles should be in the output dir. Errors // will be reported to the ctx. for _, path := range depFiles[1:] { - Rel(ctx, r.sboxOutDir.String(), path.String()) + Rel(r.ctx, r.outDir.String(), path.String()) } } } @@ -468,7 +472,7 @@ func (r *RuleBuilder) Build(pctx PackageContext, ctx BuilderContext, name string // to the output directory. sboxOutputs := make([]string, len(outputs)) for i, output := range outputs { - rel := Rel(ctx, r.sboxOutDir.String(), output.String()) + rel := Rel(r.ctx, r.outDir.String(), output.String()) sboxOutputs[i] = filepath.Join(sboxOutDir, rel) command.CopyAfter = append(command.CopyAfter, &sbox_proto.Copy{ From: proto.String(filepath.Join(sboxOutSubDir, rel)), @@ -483,23 +487,27 @@ func (r *RuleBuilder) Build(pctx PackageContext, ctx BuilderContext, name string // Verify that the manifest textproto is not inside the sbox output directory, otherwise // it will get deleted when the sbox rule clears its output directory. - _, manifestInOutDir := MaybeRel(ctx, r.sboxOutDir.String(), r.sboxManifestPath.String()) + _, manifestInOutDir := MaybeRel(r.ctx, r.outDir.String(), r.sboxManifestPath.String()) if manifestInOutDir { - ReportPathErrorf(ctx, "sbox rule %q manifestPath %q must not be in outputDir %q", - name, r.sboxManifestPath.String(), r.sboxOutDir.String()) + ReportPathErrorf(r.ctx, "sbox rule %q manifestPath %q must not be in outputDir %q", + name, r.sboxManifestPath.String(), r.outDir.String()) } // Create a rule to write the manifest as a the textproto. - WriteFileRule(ctx, r.sboxManifestPath, proto.MarshalTextString(&manifest)) + WriteFileRule(r.ctx, r.sboxManifestPath, proto.MarshalTextString(&manifest)) // Generate a new string to use as the command line of the sbox rule. This uses // a RuleBuilderCommand as a convenience method of building the command line, then // converts it to a string to replace commandString. - sboxCmd := &RuleBuilderCommand{} - sboxCmd.Text("rm -rf").Output(r.sboxOutDir) + sboxCmd := &RuleBuilderCommand{ + rule: &RuleBuilder{ + ctx: r.ctx, + }, + } + sboxCmd.Text("rm -rf").Output(r.outDir) sboxCmd.Text("&&") - sboxCmd.BuiltTool(ctx, "sbox"). - Flag("--sandbox-path").Text(shared.TempDirForOutDir(PathForOutput(ctx).String())). + sboxCmd.BuiltTool("sbox"). + Flag("--sandbox-path").Text(shared.TempDirForOutDir(PathForOutput(r.ctx).String())). Flag("--manifest").Input(r.sboxManifestPath) // Replace the command string, and add the sbox tool and manifest textproto to the @@ -528,19 +536,19 @@ func (r *RuleBuilder) Build(pctx PackageContext, ctx BuilderContext, name string } var pool blueprint.Pool - if ctx.Config().UseGoma() && r.remoteable.Goma { + if r.ctx.Config().UseGoma() && r.remoteable.Goma { // When USE_GOMA=true is set and the rule is supported by goma, allow jobs to run outside the local pool. - } else if ctx.Config().UseRBE() && r.remoteable.RBE { + } else if r.ctx.Config().UseRBE() && r.remoteable.RBE { // When USE_RBE=true is set and the rule is supported by RBE, use the remotePool. pool = remotePool } else if r.highmem { pool = highmemPool - } else if ctx.Config().UseRemoteBuild() { + } else if r.ctx.Config().UseRemoteBuild() { pool = localPool } - ctx.Build(pctx, BuildParams{ - Rule: ctx.Rule(pctx, name, blueprint.RuleParams{ + r.ctx.Build(r.pctx, BuildParams{ + Rule: r.ctx.Rule(pctx, name, blueprint.RuleParams{ Command: commandString, CommandDeps: tools.Strings(), Restat: r.restat, @@ -564,6 +572,8 @@ func (r *RuleBuilder) Build(pctx PackageContext, ctx BuilderContext, name string // RuleBuilderCommand, so they can be used chained or unchained. All methods that add text implicitly add a single // space as a separator from the previous method. type RuleBuilderCommand struct { + rule *RuleBuilder + buf strings.Builder inputs Paths implicits Paths @@ -576,16 +586,11 @@ type RuleBuilderCommand struct { // spans [start,end) of the command that should not be ninja escaped unescapedSpans [][2]int - - sbox bool - // outDir is the directory that will contain the output files of the rules. sbox will copy - // the output files from the sandbox directory to this directory when it finishes. - outDir WritablePath } func (c *RuleBuilderCommand) addInput(path Path) string { - if c.sbox { - if rel, isRel, _ := maybeRelErr(c.outDir.String(), path.String()); isRel { + if c.rule.sbox { + if rel, isRel, _ := maybeRelErr(c.rule.outDir.String(), path.String()); isRel { return filepath.Join(sboxOutDir, rel) } } @@ -594,8 +599,8 @@ func (c *RuleBuilderCommand) addInput(path Path) string { } func (c *RuleBuilderCommand) addImplicit(path Path) string { - if c.sbox { - if rel, isRel, _ := maybeRelErr(c.outDir.String(), path.String()); isRel { + if c.rule.sbox { + if rel, isRel, _ := maybeRelErr(c.rule.outDir.String(), path.String()); isRel { return filepath.Join(sboxOutDir, rel) } } @@ -607,22 +612,19 @@ func (c *RuleBuilderCommand) addOrderOnly(path Path) { c.orderOnlys = append(c.orderOnlys, path) } -func (c *RuleBuilderCommand) outputStr(path WritablePath) string { - if c.sbox { - return SboxPathForOutput(path, c.outDir) +// PathForOutput takes an output path and returns the appropriate path to use on the command +// line. If sbox was enabled via a call to RuleBuilder.Sbox(), it returns a path with the +// placeholder prefix used for outputs in sbox. If sbox is not enabled it returns the +// original path. +func (c *RuleBuilderCommand) PathForOutput(path WritablePath) string { + if c.rule.sbox { + // Errors will be handled in RuleBuilder.Build where we have a context to report them + rel, _, _ := maybeRelErr(c.rule.outDir.String(), path.String()) + return filepath.Join(sboxOutDir, rel) } return path.String() } -// SboxPathForOutput takes an output path and the out directory passed to RuleBuilder.Sbox(), -// and returns the corresponding path for the output in the sbox sandbox. This can be used -// on the RuleBuilder command line to reference the output. -func SboxPathForOutput(path WritablePath, outDir WritablePath) string { - // Errors will be handled in RuleBuilder.Build where we have a context to report them - rel, _, _ := maybeRelErr(outDir.String(), path.String()) - return filepath.Join(sboxOutDir, rel) -} - // Text adds the specified raw text to the command line. The text should not contain input or output paths or the // rule will not have them listed in its dependencies or outputs. func (c *RuleBuilderCommand) Text(text string) *RuleBuilderCommand { @@ -699,8 +701,8 @@ func (c *RuleBuilderCommand) Tool(path Path) *RuleBuilderCommand { // // It is equivalent to: // cmd.Tool(ctx.Config().HostToolPath(ctx, tool)) -func (c *RuleBuilderCommand) BuiltTool(ctx PathContext, tool string) *RuleBuilderCommand { - return c.Tool(ctx.Config().HostToolPath(ctx, tool)) +func (c *RuleBuilderCommand) BuiltTool(tool string) *RuleBuilderCommand { + return c.Tool(c.rule.ctx.Config().HostToolPath(c.rule.ctx, tool)) } // PrebuiltBuildTool adds the specified tool path from prebuils/build-tools. The path will be also added to the @@ -768,7 +770,7 @@ func (c *RuleBuilderCommand) OrderOnlys(paths Paths) *RuleBuilderCommand { // RuleBuilder.Outputs. func (c *RuleBuilderCommand) Output(path WritablePath) *RuleBuilderCommand { c.outputs = append(c.outputs, path) - return c.Text(c.outputStr(path)) + return c.Text(c.PathForOutput(path)) } // Outputs adds the specified output paths to the command line, separated by spaces. The paths will also be added to @@ -783,7 +785,7 @@ func (c *RuleBuilderCommand) Outputs(paths WritablePaths) *RuleBuilderCommand { // OutputDir adds the output directory to the command line. This is only available when used with RuleBuilder.Sbox, // and will be the temporary output directory managed by sbox, not the final one. func (c *RuleBuilderCommand) OutputDir() *RuleBuilderCommand { - if !c.sbox { + if !c.rule.sbox { panic("OutputDir only valid with Sbox") } return c.Text(sboxOutDir) @@ -794,7 +796,7 @@ func (c *RuleBuilderCommand) OutputDir() *RuleBuilderCommand { // commands in a single RuleBuilder then RuleBuilder.Build will add an extra command to merge the depfiles together. func (c *RuleBuilderCommand) DepFile(path WritablePath) *RuleBuilderCommand { c.depFiles = append(c.depFiles, path) - return c.Text(c.outputStr(path)) + return c.Text(c.PathForOutput(path)) } // ImplicitOutput adds the specified output path to the dependencies returned by RuleBuilder.Outputs without modifying @@ -885,14 +887,14 @@ func (c *RuleBuilderCommand) FlagForEachInput(flag string, paths Paths) *RuleBui // will also be added to the outputs returned by RuleBuilder.Outputs. func (c *RuleBuilderCommand) FlagWithOutput(flag string, path WritablePath) *RuleBuilderCommand { c.outputs = append(c.outputs, path) - return c.Text(flag + c.outputStr(path)) + return c.Text(flag + c.PathForOutput(path)) } // FlagWithDepFile adds the specified flag and depfile path to the command line, with no separator between them. The path // will also be added to the outputs returned by RuleBuilder.Outputs. func (c *RuleBuilderCommand) FlagWithDepFile(flag string, path WritablePath) *RuleBuilderCommand { c.depFiles = append(c.depFiles, path) - return c.Text(flag + c.outputStr(path)) + return c.Text(flag + c.PathForOutput(path)) } // FlagWithRspFileInputList adds the specified flag and path to an rspfile to the command line, with no separator @@ -987,3 +989,21 @@ func hashSrcFiles(srcFiles Paths) string { h.Write([]byte(srcFileList)) return fmt.Sprintf("%x", h.Sum(nil)) } + +// BuilderContextForTesting returns a BuilderContext for the given config that can be used for tests +// that need to call methods that take a BuilderContext. +func BuilderContextForTesting(config Config) BuilderContext { + pathCtx := PathContextForTesting(config) + return builderContextForTests{ + PathContext: pathCtx, + } +} + +type builderContextForTests struct { + PathContext +} + +func (builderContextForTests) Rule(PackageContext, string, blueprint.RuleParams, ...string) blueprint.Rule { + return nil +} +func (builderContextForTests) Build(PackageContext, BuildParams) {} diff --git a/android/rule_builder_test.go b/android/rule_builder_test.go index dc360c35f..e676e4a92 100644 --- a/android/rule_builder_test.go +++ b/android/rule_builder_test.go @@ -27,8 +27,8 @@ import ( "android/soong/shared" ) -func pathContext() PathContext { - return PathContextForTesting(TestConfig("out", nil, "", map[string][]byte{ +func builderContext() BuilderContext { + return BuilderContextForTesting(TestConfig("out", nil, "", map[string][]byte{ "ld": nil, "a.o": nil, "b.o": nil, @@ -44,9 +44,9 @@ func pathContext() PathContext { } func ExampleRuleBuilder() { - rule := NewRuleBuilder() + ctx := builderContext() - ctx := pathContext() + rule := NewRuleBuilder(pctx, ctx) rule.Command(). Tool(PathForSource(ctx, "ld")). @@ -55,7 +55,7 @@ func ExampleRuleBuilder() { rule.Command().Text("echo success") // To add the command to the build graph: - // rule.Build(pctx, ctx, "link", "link") + // rule.Build("link", "link") fmt.Printf("commands: %q\n", strings.Join(rule.Commands(), " && ")) fmt.Printf("tools: %q\n", rule.Tools()) @@ -70,9 +70,9 @@ func ExampleRuleBuilder() { } func ExampleRuleBuilder_SymlinkOutputs() { - rule := NewRuleBuilder() + ctx := builderContext() - ctx := pathContext() + rule := NewRuleBuilder(pctx, ctx) rule.Command(). Tool(PathForSource(ctx, "ln")). @@ -96,9 +96,9 @@ func ExampleRuleBuilder_SymlinkOutputs() { } func ExampleRuleBuilder_Temporary() { - rule := NewRuleBuilder() + ctx := builderContext() - ctx := pathContext() + rule := NewRuleBuilder(pctx, ctx) rule.Command(). Tool(PathForSource(ctx, "cp")). @@ -123,9 +123,9 @@ func ExampleRuleBuilder_Temporary() { } func ExampleRuleBuilder_DeleteTemporaryFiles() { - rule := NewRuleBuilder() + ctx := builderContext() - ctx := pathContext() + rule := NewRuleBuilder(pctx, ctx) rule.Command(). Tool(PathForSource(ctx, "cp")). @@ -151,9 +151,9 @@ func ExampleRuleBuilder_DeleteTemporaryFiles() { } func ExampleRuleBuilder_Installs() { - rule := NewRuleBuilder() + ctx := builderContext() - ctx := pathContext() + rule := NewRuleBuilder(pctx, ctx) out := PathForOutput(ctx, "linked") @@ -171,9 +171,9 @@ func ExampleRuleBuilder_Installs() { } func ExampleRuleBuilderCommand() { - rule := NewRuleBuilder() + ctx := builderContext() - ctx := pathContext() + rule := NewRuleBuilder(pctx, ctx) // chained rule.Command(). @@ -194,24 +194,24 @@ func ExampleRuleBuilderCommand() { } func ExampleRuleBuilderCommand_Flag() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "ls")).Flag("-l")) // Output: // ls -l } func ExampleRuleBuilderCommand_Flags() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "ls")).Flags([]string{"-l", "-a"})) // Output: // ls -l -a } func ExampleRuleBuilderCommand_FlagWithArg() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "ls")). FlagWithArg("--sort=", "time")) // Output: @@ -219,8 +219,8 @@ func ExampleRuleBuilderCommand_FlagWithArg() { } func ExampleRuleBuilderCommand_FlagForEachArg() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "ls")). FlagForEachArg("--sort=", []string{"time", "size"})) // Output: @@ -228,8 +228,8 @@ func ExampleRuleBuilderCommand_FlagForEachArg() { } func ExampleRuleBuilderCommand_FlagForEachInput() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "turbine")). FlagForEachInput("--classpath ", PathsForTesting("a.jar", "b.jar"))) // Output: @@ -237,8 +237,8 @@ func ExampleRuleBuilderCommand_FlagForEachInput() { } func ExampleRuleBuilderCommand_FlagWithInputList() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "java")). FlagWithInputList("-classpath=", PathsForTesting("a.jar", "b.jar"), ":")) // Output: @@ -246,8 +246,8 @@ func ExampleRuleBuilderCommand_FlagWithInputList() { } func ExampleRuleBuilderCommand_FlagWithInput() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "java")). FlagWithInput("-classpath=", PathForSource(ctx, "a"))) // Output: @@ -255,8 +255,8 @@ func ExampleRuleBuilderCommand_FlagWithInput() { } func ExampleRuleBuilderCommand_FlagWithList() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "ls")). FlagWithList("--sort=", []string{"time", "size"}, ",")) // Output: @@ -264,8 +264,8 @@ func ExampleRuleBuilderCommand_FlagWithList() { } func ExampleRuleBuilderCommand_FlagWithRspFileInputList() { - ctx := pathContext() - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Tool(PathForSource(ctx, "javac")). FlagWithRspFileInputList("@", PathsForTesting("a.java", "b.java")). NinjaEscapedString()) @@ -274,7 +274,8 @@ func ExampleRuleBuilderCommand_FlagWithRspFileInputList() { } func ExampleRuleBuilderCommand_String() { - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Text("FOO=foo"). Text("echo $FOO"). String()) @@ -283,7 +284,8 @@ func ExampleRuleBuilderCommand_String() { } func ExampleRuleBuilderCommand_NinjaEscapedString() { - fmt.Println(NewRuleBuilder().Command(). + ctx := builderContext() + fmt.Println(NewRuleBuilder(pctx, ctx).Command(). Text("FOO=foo"). Text("echo $FOO"). NinjaEscapedString()) @@ -305,7 +307,10 @@ func TestRuleBuilder(t *testing.T) { "input3": nil, } - ctx := PathContextForTesting(TestConfig("out", nil, "", fs)) + pathCtx := PathContextForTesting(TestConfig("out", nil, "", fs)) + ctx := builderContextForTests{ + PathContext: pathCtx, + } addCommands := func(rule *RuleBuilder) { cmd := rule.Command(). @@ -355,7 +360,7 @@ func TestRuleBuilder(t *testing.T) { wantSymlinkOutputs := PathsForOutput(ctx, []string{"ImplicitSymlinkOutput", "SymlinkOutput"}) t.Run("normal", func(t *testing.T) { - rule := NewRuleBuilder() + rule := NewRuleBuilder(pctx, ctx) addCommands(rule) wantCommands := []string{ @@ -389,13 +394,13 @@ func TestRuleBuilder(t *testing.T) { t.Errorf("\nwant rule.OrderOnlys() = %#v\n got %#v", w, g) } - if g, w := rule.depFileMergerCmd(ctx, rule.DepFiles()).String(), wantDepMergerCommand; g != w { + if g, w := rule.depFileMergerCmd(rule.DepFiles()).String(), wantDepMergerCommand; g != w { t.Errorf("\nwant rule.depFileMergerCmd() = %#v\n got %#v", w, g) } }) t.Run("sbox", func(t *testing.T) { - rule := NewRuleBuilder().Sbox(PathForOutput(ctx, ""), + rule := NewRuleBuilder(pctx, ctx).Sbox(PathForOutput(ctx, ""), PathForOutput(ctx, "sbox.textproto")) addCommands(rule) @@ -427,7 +432,7 @@ func TestRuleBuilder(t *testing.T) { t.Errorf("\nwant rule.OrderOnlys() = %#v\n got %#v", w, g) } - if g, w := rule.depFileMergerCmd(ctx, rule.DepFiles()).String(), wantDepMergerCommand; g != w { + if g, w := rule.depFileMergerCmd(rule.DepFiles()).String(), wantDepMergerCommand; g != w { t.Errorf("\nwant rule.depFileMergerCmd() = %#v\n got %#v", w, g) } }) @@ -476,7 +481,7 @@ func (t *testRuleBuilderSingleton) GenerateBuildActions(ctx SingletonContext) { } func testRuleBuilder_Build(ctx BuilderContext, in Paths, out, outDep, outDir, manifestPath WritablePath, restat, sbox bool) { - rule := NewRuleBuilder() + rule := NewRuleBuilder(pctx, ctx) if sbox { rule.Sbox(outDir, manifestPath) @@ -488,7 +493,7 @@ func testRuleBuilder_Build(ctx BuilderContext, in Paths, out, outDep, outDir, ma rule.Restat() } - rule.Build(pctx, ctx, "rule", "desc") + rule.Build("rule", "desc") } func TestRuleBuilder_Build(t *testing.T) { diff --git a/android/test_suites.go b/android/test_suites.go index 19444a80d..7ecb8d27b 100644 --- a/android/test_suites.go +++ b/android/test_suites.go @@ -63,13 +63,13 @@ func robolectricTestSuite(ctx SingletonContext, files map[string]InstallPaths) W testCasesDir := pathForInstall(ctx, BuildOs, X86, "testcases", false).ToMakePath() outputFile := PathForOutput(ctx, "packaging", "robolectric-tests.zip") - rule := NewRuleBuilder() - rule.Command().BuiltTool(ctx, "soong_zip"). + rule := NewRuleBuilder(pctx, ctx) + rule.Command().BuiltTool("soong_zip"). FlagWithOutput("-o ", outputFile). FlagWithArg("-P ", "host/testcases"). FlagWithArg("-C ", testCasesDir.String()). FlagWithRspFileInputList("-r ", installedPaths.Paths()) - rule.Build(pctx, ctx, "robolectric_tests_zip", "robolectric-tests.zip") + rule.Build("robolectric_tests_zip", "robolectric-tests.zip") return outputFile } diff --git a/apex/builder.go b/apex/builder.go index b85813587..dc8e5e0ea 100644 --- a/apex/builder.go +++ b/apex/builder.go @@ -262,7 +262,7 @@ func (a *apexBundle) buildFileContexts(ctx android.ModuleContext) android.Output } output := android.PathForModuleOut(ctx, "file_contexts") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) switch a.properties.ApexType { case imageApex: @@ -294,7 +294,7 @@ func (a *apexBundle) buildFileContexts(ctx android.ModuleContext) android.Output panic(fmt.Errorf("unsupported type %v", a.properties.ApexType)) } - rule.Build(pctx, ctx, "file_contexts."+a.Name(), "Generate file_contexts") + rule.Build("file_contexts."+a.Name(), "Generate file_contexts") return output.OutputPath } @@ -329,14 +329,14 @@ func (a *apexBundle) buildNoticeFiles(ctx android.ModuleContext, apexFileName st // included in the APEX without actually downloading and extracting it. func (a *apexBundle) buildInstalledFilesFile(ctx android.ModuleContext, builtApex android.Path, imageDir android.Path) android.OutputPath { output := android.PathForModuleOut(ctx, "installed-files.txt") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). Implicit(builtApex). Text("(cd " + imageDir.String() + " ; "). Text("find . \\( -type f -o -type l \\) -printf \"%s %p\\n\") "). Text(" | sort -nr > "). Output(output) - rule.Build(pctx, ctx, "installed-files."+a.Name(), "Installed files") + rule.Build("installed-files."+a.Name(), "Installed files") return output.OutputPath } diff --git a/cc/cflag_artifacts.go b/cc/cflag_artifacts.go index 855ff25b3..be46fc0ed 100644 --- a/cc/cflag_artifacts.go +++ b/cc/cflag_artifacts.go @@ -68,7 +68,7 @@ func (s *cflagArtifactsText) GenCFlagArtifactParts(ctx android.SingletonContext, cleanedName := strings.Replace(flag, "=", "_", -1) filename, filepath := s.incrementFile(ctx, cleanedName, part) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command().Textf("rm -f %s", filepath.String()) if using { @@ -84,7 +84,7 @@ func (s *cflagArtifactsText) GenCFlagArtifactParts(ctx android.SingletonContext, length := len(modules) if length == 0 { - rule.Build(pctx, ctx, filename, "gen "+filename) + rule.Build(filename, "gen "+filename) part++ } @@ -98,11 +98,11 @@ func (s *cflagArtifactsText) GenCFlagArtifactParts(ctx android.SingletonContext, strings.Join(proptools.ShellEscapeList(shard), " ")). FlagWithOutput(">> ", filepath). Text("; done") - rule.Build(pctx, ctx, filename, "gen "+filename) + rule.Build(filename, "gen "+filename) if index+1 != len(moduleShards) { filename, filepath = s.incrementFile(ctx, cleanedName, part+index+1) - rule = android.NewRuleBuilder() + rule = android.NewRuleBuilder(pctx, ctx) rule.Command().Textf("rm -f %s", filepath.String()) } } @@ -121,14 +121,14 @@ func (s *cflagArtifactsText) GenCFlagArtifacts(ctx android.SingletonContext) { for _, flag := range TrackedCFlags { // Generate build rule to combine related intermediary files into a // C Flag artifact - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) filename := s.genFlagFilename(flag) outputpath := android.PathForOutput(ctx, "cflags", filename) rule.Command(). Text("cat"). Inputs(s.interOutputs[flag].Paths()). FlagWithOutput("> ", outputpath) - rule.Build(pctx, ctx, filename, "gen "+filename) + rule.Build(filename, "gen "+filename) s.outputs = append(s.outputs, outputpath) } } diff --git a/cc/fuzz.go b/cc/fuzz.go index dddfe9400..6b17c48be 100644 --- a/cc/fuzz.go +++ b/cc/fuzz.go @@ -246,25 +246,25 @@ func (fuzz *fuzzBinary) install(ctx ModuleContext, file android.Path) { fuzz.binaryDecorator.baseInstaller.install(ctx, file) fuzz.corpus = android.PathsForModuleSrc(ctx, fuzz.Properties.Corpus) - builder := android.NewRuleBuilder() + builder := android.NewRuleBuilder(pctx, ctx) intermediateDir := android.PathForModuleOut(ctx, "corpus") for _, entry := range fuzz.corpus { builder.Command().Text("cp"). Input(entry). Output(intermediateDir.Join(ctx, entry.Base())) } - builder.Build(pctx, ctx, "copy_corpus", "copy corpus") + builder.Build("copy_corpus", "copy corpus") fuzz.corpusIntermediateDir = intermediateDir fuzz.data = android.PathsForModuleSrc(ctx, fuzz.Properties.Data) - builder = android.NewRuleBuilder() + builder = android.NewRuleBuilder(pctx, ctx) intermediateDir = android.PathForModuleOut(ctx, "data") for _, entry := range fuzz.data { builder.Command().Text("cp"). Input(entry). Output(intermediateDir.Join(ctx, entry.Rel())) } - builder.Build(pctx, ctx, "copy_data", "copy data") + builder.Build("copy_data", "copy data") fuzz.dataIntermediateDir = intermediateDir if fuzz.Properties.Dictionary != nil { @@ -419,12 +419,12 @@ func (s *fuzzPackager) GenerateBuildActions(ctx android.SingletonContext) { sharedLibraries := collectAllSharedDependencies(ctx, module) var files []fileToZip - builder := android.NewRuleBuilder() + builder := android.NewRuleBuilder(pctx, ctx) // Package the corpora into a zipfile. if fuzzModule.corpus != nil { corpusZip := archDir.Join(ctx, module.Name()+"_seed_corpus.zip") - command := builder.Command().BuiltTool(ctx, "soong_zip"). + command := builder.Command().BuiltTool("soong_zip"). Flag("-j"). FlagWithOutput("-o ", corpusZip) command.FlagWithRspFileInputList("-r ", fuzzModule.corpus) @@ -434,7 +434,7 @@ func (s *fuzzPackager) GenerateBuildActions(ctx android.SingletonContext) { // Package the data into a zipfile. if fuzzModule.data != nil { dataZip := archDir.Join(ctx, module.Name()+"_data.zip") - command := builder.Command().BuiltTool(ctx, "soong_zip"). + command := builder.Command().BuiltTool("soong_zip"). FlagWithOutput("-o ", dataZip) for _, f := range fuzzModule.data { intermediateDir := strings.TrimSuffix(f.String(), f.Rel()) @@ -492,7 +492,7 @@ func (s *fuzzPackager) GenerateBuildActions(ctx android.SingletonContext) { } fuzzZip := archDir.Join(ctx, module.Name()+".zip") - command := builder.Command().BuiltTool(ctx, "soong_zip"). + command := builder.Command().BuiltTool("soong_zip"). Flag("-j"). FlagWithOutput("-o ", fuzzZip) for _, file := range files { @@ -504,7 +504,7 @@ func (s *fuzzPackager) GenerateBuildActions(ctx android.SingletonContext) { command.FlagWithInput("-f ", file.SourceFilePath) } - builder.Build(pctx, ctx, "create-"+fuzzZip.String(), + builder.Build("create-"+fuzzZip.String(), "Package "+module.Name()+" for "+archString+"-"+hostOrTargetString) // Don't add modules to 'make haiku' that are set to not be exported to the @@ -531,11 +531,11 @@ func (s *fuzzPackager) GenerateBuildActions(ctx android.SingletonContext) { filesToZip := archDirs[archOs] arch := archOs.arch hostOrTarget := archOs.hostOrTarget - builder := android.NewRuleBuilder() + builder := android.NewRuleBuilder(pctx, ctx) outputFile := android.PathForOutput(ctx, "fuzz-"+hostOrTarget+"-"+arch+".zip") s.packages = append(s.packages, outputFile) - command := builder.Command().BuiltTool(ctx, "soong_zip"). + command := builder.Command().BuiltTool("soong_zip"). Flag("-j"). FlagWithOutput("-o ", outputFile). Flag("-L 0") // No need to try and re-compress the zipfiles. @@ -549,7 +549,7 @@ func (s *fuzzPackager) GenerateBuildActions(ctx android.SingletonContext) { command.FlagWithInput("-f ", fileToZip.SourceFilePath) } - builder.Build(pctx, ctx, "create-fuzz-package-"+arch+"-"+hostOrTarget, + builder.Build("create-fuzz-package-"+arch+"-"+hostOrTarget, "Create fuzz target packages for "+arch+"-"+hostOrTarget) } } diff --git a/cc/gen.go b/cc/gen.go index 5895b31d2..75b9e49e5 100644 --- a/cc/gen.go +++ b/cc/gen.go @@ -75,10 +75,9 @@ func genYacc(ctx android.ModuleContext, rule *android.RuleBuilder, yaccFile andr cmd := rule.Command() // Fix up #line markers to not use the sbox temporary directory - // android.SboxPathForOutput(outDir, outDir) returns the sbox placeholder for the out + // android.sboxPathForOutput(outDir, outDir) returns the sbox placeholder for the out // directory itself, without any filename appended. - // TODO(ccross): make this cmd.PathForOutput(outDir) instead. - sboxOutDir := android.SboxPathForOutput(outDir, outDir) + sboxOutDir := cmd.PathForOutput(outDir) sedCmd := "sed -i.bak 's#" + sboxOutDir + "#" + outDir.String() + "#'" rule.Command().Text(sedCmd).Input(outFile) rule.Command().Text(sedCmd).Input(headerFile) @@ -137,7 +136,7 @@ func genAidl(ctx android.ModuleContext, rule *android.RuleBuilder, aidlFile andr } cmd := rule.Command() - cmd.BuiltTool(ctx, "aidl-cpp"). + cmd.BuiltTool("aidl-cpp"). FlagWithDepFile("-d", depFile). Flag("--ninja"). Flag(aidlFlags). @@ -232,7 +231,7 @@ func genSources(ctx android.ModuleContext, srcFiles android.Paths, var yaccRule_ *android.RuleBuilder yaccRule := func() *android.RuleBuilder { if yaccRule_ == nil { - yaccRule_ = android.NewRuleBuilder().Sbox(android.PathForModuleGen(ctx, "yacc"), + yaccRule_ = android.NewRuleBuilder(pctx, ctx).Sbox(android.PathForModuleGen(ctx, "yacc"), android.PathForModuleGen(ctx, "yacc.sbox.textproto")) } return yaccRule_ @@ -262,7 +261,7 @@ func genSources(ctx android.ModuleContext, srcFiles android.Paths, deps = append(deps, headerFile) case ".aidl": if aidlRule == nil { - aidlRule = android.NewRuleBuilder().Sbox(android.PathForModuleGen(ctx, "aidl"), + aidlRule = android.NewRuleBuilder(pctx, ctx).Sbox(android.PathForModuleGen(ctx, "aidl"), android.PathForModuleGen(ctx, "aidl.sbox.textproto")) } cppFile := android.GenPathWithExt(ctx, "aidl", srcFile, "cpp") @@ -285,11 +284,11 @@ func genSources(ctx android.ModuleContext, srcFiles android.Paths, } if aidlRule != nil { - aidlRule.Build(pctx, ctx, "aidl", "gen aidl") + aidlRule.Build("aidl", "gen aidl") } if yaccRule_ != nil { - yaccRule_.Build(pctx, ctx, "yacc", "gen yacc") + yaccRule_.Build("yacc", "gen yacc") } if len(rsFiles) > 0 { diff --git a/cc/library.go b/cc/library.go index 7ae75f277..d2a31161b 100644 --- a/cc/library.go +++ b/cc/library.go @@ -1754,13 +1754,13 @@ func maybeInjectBoringSSLHash(ctx android.ModuleContext, outputFile android.Modu hashedOutputfile := outputFile outputFile = android.PathForModuleOut(ctx, "unhashed", fileName) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). - BuiltTool(ctx, "bssl_inject_hash"). + BuiltTool("bssl_inject_hash"). Flag("-sha256"). FlagWithInput("-in-object ", outputFile). FlagWithOutput("-o ", hashedOutputfile) - rule.Build(pctx, ctx, "injectCryptoHash", "inject crypto hash") + rule.Build("injectCryptoHash", "inject crypto hash") } return outputFile diff --git a/cc/proto.go b/cc/proto.go index 9c102a216..44661447c 100644 --- a/cc/proto.go +++ b/cc/proto.go @@ -50,11 +50,11 @@ func genProto(ctx android.ModuleContext, protoFile android.Path, flags builderFl depFile := ccFile.ReplaceExtension(ctx, "d") outputs := android.WritablePaths{ccFile, headerFile} - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) - android.ProtoRule(ctx, rule, protoFile, flags.proto, protoDeps, outDir, depFile, outputs) + android.ProtoRule(rule, protoFile, flags.proto, protoDeps, outDir, depFile, outputs) - rule.Build(pctx, ctx, "protoc_"+protoFile.Rel(), "protoc "+protoFile.Rel()) + rule.Build("protoc_"+protoFile.Rel(), "protoc "+protoFile.Rel()) return ccFile, headerFile } diff --git a/cc/vendor_snapshot.go b/cc/vendor_snapshot.go index 6563f6e74..4524f2425 100644 --- a/cc/vendor_snapshot.go +++ b/cc/vendor_snapshot.go @@ -1124,7 +1124,7 @@ func (c *snapshotSingleton) GenerateBuildActions(ctx android.SingletonContext) { ctx, snapshotDir, c.name+"-"+ctx.Config().DeviceName()+".zip") - zipRule := android.NewRuleBuilder() + zipRule := android.NewRuleBuilder(pctx, ctx) // filenames in rspfile from FlagWithRspFileInputList might be single-quoted. Remove it with tr snapshotOutputList := android.PathForOutput( @@ -1140,12 +1140,12 @@ func (c *snapshotSingleton) GenerateBuildActions(ctx android.SingletonContext) { zipRule.Temporary(snapshotOutputList) zipRule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). FlagWithOutput("-o ", zipPath). FlagWithArg("-C ", android.PathForOutput(ctx, snapshotDir).String()). FlagWithInput("-l ", snapshotOutputList) - zipRule.Build(pctx, ctx, zipPath.String(), c.name+" snapshot "+zipPath.String()) + zipRule.Build(zipPath.String(), c.name+" snapshot "+zipPath.String()) zipRule.DeleteTemporaryFiles() c.snapshotZipFile = android.OptionalPathForPath(zipPath) } diff --git a/cc/vndk.go b/cc/vndk.go index 4a005f31f..4f2646cd1 100644 --- a/cc/vndk.go +++ b/cc/vndk.go @@ -762,7 +762,7 @@ func (c *vndkSnapshotSingleton) GenerateBuildActions(ctx android.SingletonContex }) zipPath := android.PathForOutput(ctx, snapshotDir, "android-vndk-"+ctx.DeviceConfig().DeviceArch()+".zip") - zipRule := android.NewRuleBuilder() + zipRule := android.NewRuleBuilder(pctx, ctx) // filenames in rspfile from FlagWithRspFileInputList might be single-quoted. Remove it with xargs snapshotOutputList := android.PathForOutput(ctx, snapshotDir, "android-vndk-"+ctx.DeviceConfig().DeviceArch()+"_list") @@ -775,12 +775,12 @@ func (c *vndkSnapshotSingleton) GenerateBuildActions(ctx android.SingletonContex zipRule.Temporary(snapshotOutputList) zipRule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). FlagWithOutput("-o ", zipPath). FlagWithArg("-C ", android.PathForOutput(ctx, snapshotDir).String()). FlagWithInput("-l ", snapshotOutputList) - zipRule.Build(pctx, ctx, zipPath.String(), "vndk snapshot "+zipPath.String()) + zipRule.Build(zipPath.String(), "vndk snapshot "+zipPath.String()) zipRule.DeleteTemporaryFiles() c.vndkSnapshotZipFile = android.OptionalPathForPath(zipPath) } diff --git a/dexpreopt/dexpreopt.go b/dexpreopt/dexpreopt.go index 65380feae..b0a684eed 100644 --- a/dexpreopt/dexpreopt.go +++ b/dexpreopt/dexpreopt.go @@ -51,7 +51,7 @@ var DexpreoptRunningInSoong = false // GenerateDexpreoptRule generates a set of commands that will preopt a module based on a GlobalConfig and a // ModuleConfig. The produced files and their install locations will be available through rule.Installs(). -func GenerateDexpreoptRule(ctx android.PathContext, globalSoong *GlobalSoongConfig, +func GenerateDexpreoptRule(ctx android.BuilderContext, globalSoong *GlobalSoongConfig, global *GlobalConfig, module *ModuleConfig) (rule *android.RuleBuilder, err error) { defer func() { @@ -67,7 +67,7 @@ func GenerateDexpreoptRule(ctx android.PathContext, globalSoong *GlobalSoongConf } }() - rule = android.NewRuleBuilder() + rule = android.NewRuleBuilder(pctx, ctx) generateProfile := module.ProfileClassListing.Valid() && !global.DisableGenerateProfile generateBootProfile := module.ProfileBootListing.Valid() && !global.DisableGenerateProfile diff --git a/dexpreopt/dexpreopt_gen/dexpreopt_gen.go b/dexpreopt/dexpreopt_gen/dexpreopt_gen.go index e89f04591..32c4f845b 100644 --- a/dexpreopt/dexpreopt_gen/dexpreopt_gen.go +++ b/dexpreopt/dexpreopt_gen/dexpreopt_gen.go @@ -27,6 +27,7 @@ import ( "android/soong/android" "android/soong/dexpreopt" + "github.com/google/blueprint" "github.com/google/blueprint/pathtools" ) @@ -38,12 +39,16 @@ var ( outDir = flag.String("out_dir", "", "path to output directory") ) -type pathContext struct { +type builderContext struct { config android.Config } -func (x *pathContext) Config() android.Config { return x.config } -func (x *pathContext) AddNinjaFileDeps(...string) {} +func (x *builderContext) Config() android.Config { return x.config } +func (x *builderContext) AddNinjaFileDeps(...string) {} +func (x *builderContext) Build(android.PackageContext, android.BuildParams) {} +func (x *builderContext) Rule(android.PackageContext, string, blueprint.RuleParams, ...string) blueprint.Rule { + return nil +} func main() { flag.Parse() @@ -76,7 +81,7 @@ func main() { usage("--module configuration file is required") } - ctx := &pathContext{android.NullConfig(*outDir)} + ctx := &builderContext{android.NullConfig(*outDir)} globalSoongConfigData, err := ioutil.ReadFile(*globalSoongConfigPath) if err != nil { @@ -133,7 +138,7 @@ func main() { writeScripts(ctx, globalSoongConfig, globalConfig, moduleConfig, *dexpreoptScriptPath) } -func writeScripts(ctx android.PathContext, globalSoong *dexpreopt.GlobalSoongConfig, +func writeScripts(ctx android.BuilderContext, globalSoong *dexpreopt.GlobalSoongConfig, global *dexpreopt.GlobalConfig, module *dexpreopt.ModuleConfig, dexpreoptScriptPath string) { dexpreoptRule, err := dexpreopt.GenerateDexpreoptRule(ctx, globalSoong, global, module) if err != nil { diff --git a/dexpreopt/dexpreopt_test.go b/dexpreopt/dexpreopt_test.go index feabd7004..59278fdd6 100644 --- a/dexpreopt/dexpreopt_test.go +++ b/dexpreopt/dexpreopt_test.go @@ -60,7 +60,7 @@ func testModuleConfig(ctx android.PathContext, name, partition string) *ModuleCo func TestDexPreopt(t *testing.T) { config := android.TestConfig("out", nil, "", nil) - ctx := android.PathContextForTesting(config) + ctx := android.BuilderContextForTesting(config) globalSoong := GlobalSoongConfigForTests(config) global := GlobalConfigForTests(ctx) module := testSystemModuleConfig(ctx, "test") @@ -82,7 +82,7 @@ func TestDexPreopt(t *testing.T) { func TestDexPreoptSystemOther(t *testing.T) { config := android.TestConfig("out", nil, "", nil) - ctx := android.PathContextForTesting(config) + ctx := android.BuilderContextForTesting(config) globalSoong := GlobalSoongConfigForTests(config) global := GlobalConfigForTests(ctx) systemModule := testSystemModuleConfig(ctx, "Stest") @@ -142,7 +142,7 @@ func TestDexPreoptSystemOther(t *testing.T) { func TestDexPreoptProfile(t *testing.T) { config := android.TestConfig("out", nil, "", nil) - ctx := android.PathContextForTesting(config) + ctx := android.BuilderContextForTesting(config) globalSoong := GlobalSoongConfigForTests(config) global := GlobalConfigForTests(ctx) module := testSystemModuleConfig(ctx, "test") diff --git a/filesystem/filesystem.go b/filesystem/filesystem.go index ac33b76ae..c6181bc15 100644 --- a/filesystem/filesystem.go +++ b/filesystem/filesystem.go @@ -63,9 +63,9 @@ func (f *filesystem) GenerateAndroidBuildActions(ctx android.ModuleContext) { f.CopyDepsToZip(ctx, zipFile) rootDir := android.PathForModuleOut(ctx, "root").OutputPath - builder := android.NewRuleBuilder() + builder := android.NewRuleBuilder(pctx, ctx) builder.Command(). - BuiltTool(ctx, "zipsync"). + BuiltTool("zipsync"). FlagWithArg("-d ", rootDir.String()). // zipsync wipes this. No need to clear. Input(zipFile) @@ -81,14 +81,14 @@ func (f *filesystem) GenerateAndroidBuildActions(ctx android.ModuleContext) { Implicit(mkuserimg) f.output = android.PathForModuleOut(ctx, "filesystem.img").OutputPath - builder.Command().BuiltTool(ctx, "build_image"). + builder.Command().BuiltTool("build_image"). Text(rootDir.String()). // input directory Input(propFile). Output(f.output). Text(rootDir.String()) // directory where to find fs_config_files|dirs // rootDir is not deleted. Might be useful for quick inspection. - builder.Build(pctx, ctx, "build_filesystem_image", fmt.Sprintf("Creating filesystem %s", f.BaseModuleName())) + builder.Build("build_filesystem_image", fmt.Sprintf("Creating filesystem %s", f.BaseModuleName())) f.installDir = android.PathForModuleInstall(ctx, "etc") ctx.InstallFile(f.installDir, f.installFileName(), f.output) diff --git a/genrule/genrule.go b/genrule/genrule.go index e5ee3fc0b..5ef63f64b 100644 --- a/genrule/genrule.go +++ b/genrule/genrule.go @@ -342,8 +342,27 @@ func (g *Module) GenerateAndroidBuildActions(ctx android.ModuleContext) { return } + // Pick a unique path outside the task.genDir for the sbox manifest textproto, + // a unique rule name, and the user-visible description. + manifestName := "genrule.sbox.textproto" + desc := "generate" + name := "generator" + if task.shards > 0 { + manifestName = "genrule_" + strconv.Itoa(task.shard) + ".sbox.textproto" + desc += " " + strconv.Itoa(task.shard) + name += strconv.Itoa(task.shard) + } else if len(task.out) == 1 { + desc += " " + task.out[0].Base() + } + + manifestPath := android.PathForModuleOut(ctx, manifestName) + + // Use a RuleBuilder to create a rule that runs the command inside an sbox sandbox. + rule := android.NewRuleBuilder(pctx, ctx).Sbox(task.genDir, manifestPath) + cmd := rule.Command() + for _, out := range task.out { - addLocationLabel(out.Rel(), []string{android.SboxPathForOutput(out, task.genDir)}) + addLocationLabel(out.Rel(), []string{cmd.PathForOutput(out)}) } referencedDepfile := false @@ -374,7 +393,7 @@ func (g *Module) GenerateAndroidBuildActions(ctx android.ModuleContext) { case "out": var sandboxOuts []string for _, out := range task.out { - sandboxOuts = append(sandboxOuts, android.SboxPathForOutput(out, task.genDir)) + sandboxOuts = append(sandboxOuts, cmd.PathForOutput(out)) } return strings.Join(sandboxOuts, " "), nil case "depfile": @@ -384,7 +403,7 @@ func (g *Module) GenerateAndroidBuildActions(ctx android.ModuleContext) { } return "__SBOX_DEPFILE__", nil case "genDir": - return android.SboxPathForOutput(task.genDir, task.genDir), nil + return cmd.PathForOutput(task.genDir), nil default: if strings.HasPrefix(name, "location ") { label := strings.TrimSpace(strings.TrimPrefix(name, "location ")) @@ -426,24 +445,6 @@ func (g *Module) GenerateAndroidBuildActions(ctx android.ModuleContext) { } g.rawCommands = append(g.rawCommands, rawCommand) - // Pick a unique path outside the task.genDir for the sbox manifest textproto, - // a unique rule name, and the user-visible description. - manifestName := "genrule.sbox.textproto" - desc := "generate" - name := "generator" - if task.shards > 0 { - manifestName = "genrule_" + strconv.Itoa(task.shard) + ".sbox.textproto" - desc += " " + strconv.Itoa(task.shard) - name += strconv.Itoa(task.shard) - } else if len(task.out) == 1 { - desc += " " + task.out[0].Base() - } - - manifestPath := android.PathForModuleOut(ctx, manifestName) - - // Use a RuleBuilder to create a rule that runs the command inside an sbox sandbox. - rule := android.NewRuleBuilder().Sbox(task.genDir, manifestPath) - cmd := rule.Command() cmd.Text(rawCommand) cmd.ImplicitOutputs(task.out) cmd.Implicits(task.in) @@ -454,7 +455,7 @@ func (g *Module) GenerateAndroidBuildActions(ctx android.ModuleContext) { } // Create the rule to run the genrule command inside sbox. - rule.Build(pctx, ctx, name, desc) + rule.Build(name, desc) if len(task.copyTo) > 0 { // If copyTo is set, multiple shards need to be copied into a single directory. @@ -612,6 +613,10 @@ func NewGenSrcs() *Module { } genDir := android.PathForModuleGen(ctx, genSubDir) + // TODO(ccross): this RuleBuilder is a hack to be able to call + // rule.Command().PathForOutput. Replace this with passing the rule into the + // generator. + rule := android.NewRuleBuilder(pctx, ctx).Sbox(genDir, nil) for _, in := range shard { outFile := android.GenPathWithExt(ctx, finalSubDir, in, String(properties.Output_extension)) @@ -634,11 +639,11 @@ func NewGenSrcs() *Module { case "in": return in.String(), nil case "out": - return android.SboxPathForOutput(outFile, genDir), nil + return rule.Command().PathForOutput(outFile), nil case "depfile": // Generate a depfile for each output file. Store the list for // later in order to combine them all into a single depfile. - depFile := android.SboxPathForOutput(outFile.ReplaceExtension(ctx, "d"), genDir) + depFile := rule.Command().PathForOutput(outFile.ReplaceExtension(ctx, "d")) commandDepFiles = append(commandDepFiles, depFile) return depFile, nil default: diff --git a/java/app.go b/java/app.go index 3384bbd39..4bf9d33ea 100755 --- a/java/app.go +++ b/java/app.go @@ -1115,8 +1115,8 @@ func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig androi } fixedConfig := android.PathForModuleOut(ctx, "test_config_fixer", "AndroidTest.xml") - rule := android.NewRuleBuilder() - command := rule.Command().BuiltTool(ctx, "test_config_fixer").Input(testConfig).Output(fixedConfig) + rule := android.NewRuleBuilder(pctx, ctx) + command := rule.Command().BuiltTool("test_config_fixer").Input(testConfig).Output(fixedConfig) fixNeeded := false if ctx.ModuleName() != a.installApkName { @@ -1131,7 +1131,7 @@ func (a *AndroidTest) FixTestConfig(ctx android.ModuleContext, testConfig androi } if fixNeeded { - rule.Build(pctx, ctx, "fix_test_config", "fix test config") + rule.Build("fix_test_config", "fix test config") return fixedConfig } return testConfig @@ -1440,15 +1440,15 @@ func (a *AndroidAppImport) uncompressEmbeddedJniLibs( }) return } - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). Textf(`if (zipinfo %s 'lib/*.so' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then`, inputPath). - BuiltTool(ctx, "zip2zip"). + BuiltTool("zip2zip"). FlagWithInput("-i ", inputPath). FlagWithOutput("-o ", outputPath). FlagWithArg("-0 ", "'lib/**/*.so'"). Textf(`; else cp -f %s %s; fi`, inputPath, outputPath) - rule.Build(pctx, ctx, "uncompress-embedded-jni-libs", "Uncompress embedded JIN libs") + rule.Build("uncompress-embedded-jni-libs", "Uncompress embedded JIN libs") } // Returns whether this module should have the dex file stored uncompressed in the APK. @@ -1467,15 +1467,15 @@ func (a *AndroidAppImport) shouldUncompressDex(ctx android.ModuleContext) bool { func (a *AndroidAppImport) uncompressDex( ctx android.ModuleContext, inputPath android.Path, outputPath android.OutputPath) { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). Textf(`if (zipinfo %s '*.dex' 2>/dev/null | grep -v ' stor ' >/dev/null) ; then`, inputPath). - BuiltTool(ctx, "zip2zip"). + BuiltTool("zip2zip"). FlagWithInput("-i ", inputPath). FlagWithOutput("-o ", outputPath). FlagWithArg("-0 ", "'classes*.dex'"). Textf(`; else cp -f %s %s; fi`, inputPath, outputPath) - rule.Build(pctx, ctx, "uncompress-dex", "Uncompress dex files") + rule.Build("uncompress-dex", "Uncompress dex files") } func (a *AndroidAppImport) GenerateAndroidBuildActions(ctx android.ModuleContext) { @@ -2015,8 +2015,8 @@ func (u *usesLibrary) freezeEnforceUsesLibraries() { func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, manifest android.Path) android.Path { outputFile := android.PathForModuleOut(ctx, "manifest_check", "AndroidManifest.xml") - rule := android.NewRuleBuilder() - cmd := rule.Command().BuiltTool(ctx, "manifest_check"). + rule := android.NewRuleBuilder(pctx, ctx) + cmd := rule.Command().BuiltTool("manifest_check"). Flag("--enforce-uses-libraries"). Input(manifest). FlagWithOutput("-o ", outputFile) @@ -2029,7 +2029,7 @@ func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, man cmd.FlagWithArg("--optional-uses-library ", lib) } - rule.Build(pctx, ctx, "verify_uses_libraries", "verify ") + rule.Build("verify_uses_libraries", "verify ") return outputFile } @@ -2039,7 +2039,7 @@ func (u *usesLibrary) verifyUsesLibrariesManifest(ctx android.ModuleContext, man func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk android.Path) android.Path { outputFile := android.PathForModuleOut(ctx, "verify_uses_libraries", apk.Base()) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) aapt := ctx.Config().HostToolPath(ctx, "aapt") rule.Command(). Textf("aapt_binary=%s", aapt.String()).Implicit(aapt). @@ -2048,7 +2048,7 @@ func (u *usesLibrary) verifyUsesLibrariesAPK(ctx android.ModuleContext, apk andr Tool(android.PathForSource(ctx, "build/make/core/verify_uses_libraries.sh")).Input(apk) rule.Command().Text("cp -f").Input(apk).Output(outputFile) - rule.Build(pctx, ctx, "verify_uses_libraries", "verify ") + rule.Build("verify_uses_libraries", "verify ") return outputFile } diff --git a/java/boot_jars.go b/java/boot_jars.go index e70654781..823275b1d 100644 --- a/java/boot_jars.go +++ b/java/boot_jars.go @@ -85,8 +85,8 @@ func (b *bootJarsSingleton) GenerateBuildActions(ctx android.SingletonContext) { timestamp := android.PathForOutput(ctx, "boot-jars-package-check/stamp") - rule := android.NewRuleBuilder() - checkBootJars := rule.Command().BuiltTool(ctx, "check_boot_jars"). + rule := android.NewRuleBuilder(pctx, ctx) + checkBootJars := rule.Command().BuiltTool("check_boot_jars"). Input(ctx.Config().HostToolPath(ctx, "dexdump")). Input(android.PathForSource(ctx, "build/soong/scripts/check_boot_jars/package_allowed_list.txt")) @@ -109,7 +109,7 @@ func (b *bootJarsSingleton) GenerateBuildActions(ctx android.SingletonContext) { } checkBootJars.Text("&& touch").Output(timestamp) - rule.Build(pctx, ctx, "boot_jars_package_check", "check boot jar packages") + rule.Build("boot_jars_package_check", "check boot jar packages") // The check-boot-jars phony target depends on the timestamp created if the check succeeds. ctx.Phony("check-boot-jars", timestamp) diff --git a/java/dexpreopt.go b/java/dexpreopt.go index a21fb7640..67738d49b 100644 --- a/java/dexpreopt.go +++ b/java/dexpreopt.go @@ -216,7 +216,7 @@ func (d *dexpreopter) dexpreopt(ctx android.ModuleContext, dexJarFile android.Mo return dexJarFile } - dexpreoptRule.Build(pctx, ctx, "dexpreopt", "dexpreopt") + dexpreoptRule.Build("dexpreopt", "dexpreopt") d.builtInstalled = dexpreoptRule.Installs().String() diff --git a/java/dexpreopt_bootjars.go b/java/dexpreopt_bootjars.go index 5df58452c..f16ddf1df 100644 --- a/java/dexpreopt_bootjars.go +++ b/java/dexpreopt_bootjars.go @@ -539,14 +539,14 @@ func buildBootImage(ctx android.SingletonContext, image *bootImageConfig) *bootI } if image.zip != nil { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). FlagWithOutput("-o ", image.zip). FlagWithArg("-C ", image.dir.Join(ctx, android.Android.String()).String()). FlagWithInputList("-f ", zipFiles, " -f ") - rule.Build(pctx, ctx, "zip_"+image.name, "zip "+image.name+" image") + rule.Build("zip_"+image.name, "zip "+image.name+" image") } return image @@ -568,7 +568,7 @@ func buildBootImageVariant(ctx android.SingletonContext, image *bootImageVariant oatLocation := dexpreopt.PathToLocation(outputPath, arch) imagePath := outputPath.ReplaceExtension(ctx, "art") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.MissingDeps(missingDeps) rule.Command().Text("mkdir").Flag("-p").Flag(symbolsDir.String()) @@ -689,7 +689,7 @@ func buildBootImageVariant(ctx android.SingletonContext, image *bootImageVariant android.RuleBuilderInstall{unstrippedOat, filepath.Join(installDir, unstrippedOat.Base())}) } - rule.Build(pctx, ctx, image.name+"JarsDexpreopt_"+image.target.String(), "dexpreopt "+image.name+" jars "+arch.String()) + rule.Build(image.name+"JarsDexpreopt_"+image.target.String(), "dexpreopt "+image.name+" jars "+arch.String()) // save output and installed files for makevars image.installs = rule.Installs() @@ -713,7 +713,7 @@ func bootImageProfileRule(ctx android.SingletonContext, image *bootImageConfig, profile := ctx.Config().Once(bootImageProfileRuleKey, func() interface{} { defaultProfile := "frameworks/base/config/boot-image-profile.txt" - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.MissingDeps(missingDeps) var bootImageProfile android.Path @@ -744,7 +744,7 @@ func bootImageProfileRule(ctx android.SingletonContext, image *bootImageConfig, rule.Install(profile, "/system/etc/boot-image.prof") - rule.Build(pctx, ctx, "bootJarsProfile", "profile boot jars") + rule.Build("bootJarsProfile", "profile boot jars") image.profileInstalls = rule.Installs() @@ -766,7 +766,7 @@ func bootFrameworkProfileRule(ctx android.SingletonContext, image *bootImageConf return nil } return ctx.Config().Once(bootFrameworkProfileRuleKey, func() interface{} { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.MissingDeps(missingDeps) // Some branches like master-art-host don't have frameworks/base, so manually @@ -794,7 +794,7 @@ func bootFrameworkProfileRule(ctx android.SingletonContext, image *bootImageConf FlagWithOutput("--reference-profile-file=", profile) rule.Install(profile, "/system/etc/boot-image.bprof") - rule.Build(pctx, ctx, "bootFrameworkProfile", "profile boot framework jars") + rule.Build("bootFrameworkProfile", "profile boot framework jars") image.profileInstalls = append(image.profileInstalls, rule.Installs()...) return profile @@ -839,7 +839,7 @@ func updatableBcpPackagesRule(ctx android.SingletonContext, image *bootImageConf // WriteFileRule automatically adds the last end-of-line. android.WriteFileRule(ctx, updatableBcpPackages, strings.Join(updatablePackages, "\n")) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.MissingDeps(missingDeps) rule.Install(updatableBcpPackages, "/system/etc/"+updatableBcpPackagesName) // TODO: Rename `profileInstalls` to `extraInstalls`? @@ -863,25 +863,25 @@ func dumpOatRules(ctx android.SingletonContext, image *bootImageConfig) { } // Create a rule to call oatdump. output := android.PathForOutput(ctx, "boot."+suffix+".oatdump.txt") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). // TODO: for now, use the debug version for better error reporting - BuiltTool(ctx, "oatdumpd"). + BuiltTool("oatdumpd"). FlagWithInputList("--runtime-arg -Xbootclasspath:", image.dexPathsDeps.Paths(), ":"). FlagWithList("--runtime-arg -Xbootclasspath-locations:", image.dexLocationsDeps, ":"). FlagWithArg("--image=", strings.Join(image.imageLocations(), ":")).Implicits(image.imagesDeps.Paths()). FlagWithOutput("--output=", output). FlagWithArg("--instruction-set=", arch.String()) - rule.Build(pctx, ctx, "dump-oat-boot-"+suffix, "dump oat boot "+arch.String()) + rule.Build("dump-oat-boot-"+suffix, "dump oat boot "+arch.String()) // Create a phony rule that depends on the output file and prints the path. phony := android.PathForPhony(ctx, "dump-oat-boot-"+suffix) - rule = android.NewRuleBuilder() + rule = android.NewRuleBuilder(pctx, ctx) rule.Command(). Implicit(output). ImplicitOutput(phony). Text("echo").FlagWithArg("Output in ", output.String()) - rule.Build(pctx, ctx, "phony-dump-oat-boot-"+suffix, "dump oat boot "+arch.String()) + rule.Build("phony-dump-oat-boot-"+suffix, "dump oat boot "+arch.String()) allPhonies = append(allPhonies, phony) } diff --git a/java/droiddoc.go b/java/droiddoc.go index da8489ac1..10f8881f5 100644 --- a/java/droiddoc.go +++ b/java/droiddoc.go @@ -671,7 +671,7 @@ func (j *Javadoc) GenerateAndroidBuildActions(ctx android.ModuleContext) { j.stubsSrcJar = nil - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command().Text("rm -rf").Text(outDir.String()) rule.Command().Text("mkdir -p").Text(outDir.String()) @@ -689,7 +689,7 @@ func (j *Javadoc) GenerateAndroidBuildActions(ctx android.ModuleContext) { Flag("-Xdoclint:none") rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). Flag("-write_if_changed"). Flag("-d"). FlagWithOutput("-o ", j.docZip). @@ -700,7 +700,7 @@ func (j *Javadoc) GenerateAndroidBuildActions(ctx android.ModuleContext) { zipSyncCleanupCmd(rule, srcJarDir) - rule.Build(pctx, ctx, "javadoc", "javadoc") + rule.Build("javadoc", "javadoc") } // @@ -845,7 +845,7 @@ func javadocCmd(ctx android.ModuleContext, rule *android.RuleBuilder, srcs andro outDir, srcJarDir, srcJarList android.Path, sourcepaths android.Paths) *android.RuleBuilderCommand { cmd := rule.Command(). - BuiltTool(ctx, "soong_javac_wrapper").Tool(config.JavadocCmd(ctx)). + BuiltTool("soong_javac_wrapper").Tool(config.JavadocCmd(ctx)). Flag(config.JavacVmFlags). FlagWithArg("-encoding ", "UTF-8"). FlagWithRspFileInputList("@", srcs). @@ -914,7 +914,7 @@ func dokkaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, dokkaClasspath := append(bootclasspath.Paths(), classpath.Paths()...) return rule.Command(). - BuiltTool(ctx, "dokka"). + BuiltTool("dokka"). Flag(config.JavacVmFlags). Flag(srcJarDir.String()). FlagWithInputList("-classpath ", dokkaClasspath, ":"). @@ -934,7 +934,7 @@ func (d *Droiddoc) GenerateAndroidBuildActions(ctx android.ModuleContext) { outDir := android.PathForModuleOut(ctx, "out") srcJarDir := android.PathForModuleOut(ctx, "srcjars") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) srcJarList := zipSyncCmd(ctx, rule, srcJarDir, d.Javadoc.srcJars) @@ -968,7 +968,7 @@ func (d *Droiddoc) GenerateAndroidBuildActions(ctx android.ModuleContext) { } rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). Flag("-write_if_changed"). Flag("-d"). FlagWithOutput("-o ", d.docZip). @@ -979,7 +979,7 @@ func (d *Droiddoc) GenerateAndroidBuildActions(ctx android.ModuleContext) { zipSyncCleanupCmd(rule, srcJarDir) - rule.Build(pctx, ctx, "javadoc", desc) + rule.Build("javadoc", desc) } // @@ -1278,7 +1278,7 @@ func metalavaCmd(ctx android.ModuleContext, rule *android.RuleBuilder, javaVersi }).NoVarTemplate(ctx.Config())) } - cmd.BuiltTool(ctx, "metalava"). + cmd.BuiltTool("metalava"). Flag(config.JavacVmFlags). Flag("-J--add-opens=java.base/java.util=ALL-UNNAMED"). FlagWithArg("-encoding ", "UTF-8"). @@ -1333,7 +1333,7 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { srcJarDir := android.PathForModuleOut(ctx, "srcjars") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) if BoolDefault(d.properties.High_mem, false) { // This metalava run uses lots of memory, restrict the number of metalava jobs that can run in parallel. @@ -1480,19 +1480,19 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { cmd.FlagWithArg("--error-message:compatibility:released ", msg) } - impRule := android.NewRuleBuilder() + impRule := android.NewRuleBuilder(pctx, ctx) impCmd := impRule.Command() // An action that copies the ninja generated rsp file to a new location. This allows us to // add a large number of inputs to a file without exceeding bash command length limits (which // would happen if we use the WriteFile rule). The cp is needed because RuleBuilder sets the // rsp file to be ${output}.rsp. impCmd.Text("cp").FlagWithRspFileInputList("", cmd.GetImplicits()).Output(implicitsRsp) - impRule.Build(pctx, ctx, "implicitsGen", "implicits generation") + impRule.Build("implicitsGen", "implicits generation") cmd.Implicit(implicitsRsp) if generateStubs { rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). Flag("-write_if_changed"). Flag("-jar"). FlagWithOutput("-o ", d.Javadoc.stubsSrcJar). @@ -1503,7 +1503,7 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { if Bool(d.properties.Write_sdk_values) { d.metadataZip = android.PathForModuleOut(ctx, ctx.ModuleName()+"-metadata.zip") rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). Flag("-write_if_changed"). Flag("-d"). FlagWithOutput("-o ", d.metadataZip). @@ -1524,7 +1524,7 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { zipSyncCleanupCmd(rule, srcJarDir) - rule.Build(pctx, ctx, "metalava", "metalava merged") + rule.Build("metalava", "metalava merged") if apiCheckEnabled(ctx, d.properties.Check_api.Current, "current") { @@ -1542,7 +1542,7 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { d.checkCurrentApiTimestamp = android.PathForModuleOut(ctx, "check_current_api.timestamp") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) // Diff command line. // -F matches the closest "opening" line, such as "package android {" @@ -1576,12 +1576,12 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { Text("; exit 38"). Text(")") - rule.Build(pctx, ctx, "metalavaCurrentApiCheck", "check current API") + rule.Build("metalavaCurrentApiCheck", "check current API") d.updateCurrentApiTimestamp = android.PathForModuleOut(ctx, "update_current_api.timestamp") // update API rule - rule = android.NewRuleBuilder() + rule = android.NewRuleBuilder(pctx, ctx) rule.Command().Text("( true") @@ -1602,7 +1602,7 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { Text("; exit 38"). Text(")") - rule.Build(pctx, ctx, "metalavaCurrentApiUpdate", "update current API") + rule.Build("metalavaCurrentApiUpdate", "update current API") } if String(d.properties.Check_nullability_warnings) != "" { @@ -1625,7 +1625,7 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { ` and submitting the updated file as part of your change.`, d.nullabilityWarningsFile, checkNullabilityWarnings) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). Text("("). @@ -1637,7 +1637,7 @@ func (d *Droidstubs) GenerateAndroidBuildActions(ctx android.ModuleContext) { Text("; exit 38"). Text(")") - rule.Build(pctx, ctx, "nullabilityWarningsCheck", "nullability warnings check") + rule.Build("nullabilityWarningsCheck", "nullability warnings check") } } @@ -1722,7 +1722,7 @@ func zipSyncCmd(ctx android.ModuleContext, rule *android.RuleBuilder, rule.Temporary(srcJarList) - rule.Command().BuiltTool(ctx, "zipsync"). + rule.Command().BuiltTool("zipsync"). FlagWithArg("-d ", srcJarDir.String()). FlagWithOutput("-l ", srcJarList). FlagWithArg("-f ", `"*.java"`). @@ -1783,9 +1783,9 @@ func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleCon srcGlob := localSrcDir + "/**/*" srcPaths := android.PathsForModuleSrc(ctx, []string{srcGlob}) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). Flag("-write_if_changed"). Flag("-jar"). FlagWithOutput("-o ", p.stubsSrcJar). @@ -1794,7 +1794,7 @@ func (p *PrebuiltStubsSources) GenerateAndroidBuildActions(ctx android.ModuleCon rule.Restat() - rule.Build(pctx, ctx, "zip src", "Create srcjar from prebuilt source") + rule.Build("zip src", "Create srcjar from prebuilt source") } func (p *PrebuiltStubsSources) Prebuilt() *android.Prebuilt { diff --git a/java/gen.go b/java/gen.go index d50a6653e..5766a9471 100644 --- a/java/gen.go +++ b/java/gen.go @@ -57,7 +57,7 @@ func genAidl(ctx android.ModuleContext, aidlFiles android.Paths, aidlFlags strin outDir := srcJarFile.ReplaceExtension(ctx, "tmp") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command().Text("rm -rf").Flag(outDir.String()) rule.Command().Text("mkdir -p").Flag(outDir.String()) @@ -98,7 +98,7 @@ func genAidl(ctx android.ModuleContext, aidlFiles android.Paths, aidlFlags strin ruleDesc += " " + strconv.Itoa(i) } - rule.Build(pctx, ctx, ruleName, ruleDesc) + rule.Build(ruleName, ruleDesc) } return srcJarFiles diff --git a/java/hiddenapi.go b/java/hiddenapi.go index 63b801a5c..71f1e576d 100644 --- a/java/hiddenapi.go +++ b/java/hiddenapi.go @@ -135,12 +135,12 @@ func (h *hiddenAPI) hiddenAPIGenerateCSV(ctx android.ModuleContext, flagsCSV, me }) h.metadataCSVPath = metadataCSV - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). - BuiltTool(ctx, "merge_csv"). + BuiltTool("merge_csv"). FlagWithInput("--zip_input=", classesJar). FlagWithOutput("--output=", indexCSV) - rule.Build(pctx, ctx, "merged-hiddenapi-index", "Merged Hidden API index") + rule.Build("merged-hiddenapi-index", "Merged Hidden API index") h.indexCSVPath = indexCSV } diff --git a/java/hiddenapi_singleton.go b/java/hiddenapi_singleton.go index 8f0e09cbd..ce8410ed4 100644 --- a/java/hiddenapi_singleton.go +++ b/java/hiddenapi_singleton.go @@ -189,7 +189,7 @@ func stubFlagsRule(ctx android.SingletonContext) { } // Singleton rule which applies hiddenapi on all boot class path dex files. - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) outputPath := hiddenAPISingletonPaths(ctx).stubFlags tempPath := android.PathForOutput(ctx, outputPath.Rel()+".tmp") @@ -208,7 +208,7 @@ func stubFlagsRule(ctx android.SingletonContext) { commitChangeForRestat(rule, tempPath, outputPath) - rule.Build(pctx, ctx, "hiddenAPIStubFlagsFile", "hiddenapi stub flags") + rule.Build("hiddenAPIStubFlagsFile", "hiddenapi stub flags") } // flagsRule creates a rule to build hiddenapi-flags.csv out of flags.csv files generated for boot image modules and @@ -236,7 +236,7 @@ func flagsRule(ctx android.SingletonContext) android.Path { ctx.Errorf("Failed to find combined-removed-dex.") } - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) outputPath := hiddenAPISingletonPaths(ctx).flags tempPath := android.PathForOutput(ctx, outputPath.Rel()+".tmp") @@ -266,7 +266,7 @@ func flagsRule(ctx android.SingletonContext) android.Path { commitChangeForRestat(rule, tempPath, outputPath) - rule.Build(pctx, ctx, "hiddenAPIFlagsFile", "hiddenapi flags") + rule.Build("hiddenAPIFlagsFile", "hiddenapi flags") return outputPath } @@ -274,14 +274,14 @@ func flagsRule(ctx android.SingletonContext) android.Path { // emptyFlagsRule creates a rule to build an empty hiddenapi-flags.csv, which is needed by master-art-host builds that // have a partial manifest without frameworks/base but still need to build a boot image. func emptyFlagsRule(ctx android.SingletonContext) android.Path { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) outputPath := hiddenAPISingletonPaths(ctx).flags rule.Command().Text("rm").Flag("-f").Output(outputPath) rule.Command().Text("touch").Output(outputPath) - rule.Build(pctx, ctx, "emptyHiddenAPIFlagsFile", "empty hiddenapi flags") + rule.Build("emptyHiddenAPIFlagsFile", "empty hiddenapi flags") return outputPath } @@ -299,16 +299,16 @@ func metadataRule(ctx android.SingletonContext) android.Path { } }) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) outputPath := hiddenAPISingletonPaths(ctx).metadata rule.Command(). - BuiltTool(ctx, "merge_csv"). + BuiltTool("merge_csv"). FlagWithOutput("--output=", outputPath). Inputs(metadataCSV) - rule.Build(pctx, ctx, "hiddenAPIGreylistMetadataFile", "hiddenapi greylist metadata") + rule.Build("hiddenAPIGreylistMetadataFile", "hiddenapi greylist metadata") return outputPath } @@ -399,13 +399,13 @@ func (h *hiddenAPIIndexSingleton) GenerateBuildActions(ctx android.SingletonCont } }) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). - BuiltTool(ctx, "merge_csv"). + BuiltTool("merge_csv"). FlagWithArg("--header=", "signature,file,startline,startcol,endline,endcol,properties"). FlagWithOutput("--output=", hiddenAPISingletonPaths(ctx).index). Inputs(indexes) - rule.Build(pctx, ctx, "singleton-merged-hiddenapi-index", "Singleton merged Hidden API index") + rule.Build("singleton-merged-hiddenapi-index", "Singleton merged Hidden API index") h.index = hiddenAPISingletonPaths(ctx).index } diff --git a/java/java.go b/java/java.go index 8738e00cf..7ab4de2c3 100644 --- a/java/java.go +++ b/java/java.go @@ -3049,21 +3049,21 @@ func (j *DexImport) GenerateAndroidBuildActions(ctx android.ModuleContext) { dexOutputFile := android.PathForModuleOut(ctx, ctx.ModuleName()+".jar") if j.dexpreopter.uncompressedDex { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) temporary := android.PathForModuleOut(ctx, ctx.ModuleName()+".jar.unaligned") rule.Temporary(temporary) // use zip2zip to uncompress classes*.dex files rule.Command(). - BuiltTool(ctx, "zip2zip"). + BuiltTool("zip2zip"). FlagWithInput("-i ", inputJar). FlagWithOutput("-o ", temporary). FlagWithArg("-0 ", "'classes*.dex'") // use zipalign to align uncompressed classes*.dex files rule.Command(). - BuiltTool(ctx, "zipalign"). + BuiltTool("zipalign"). Flag("-f"). Text("4"). Input(temporary). @@ -3071,7 +3071,7 @@ func (j *DexImport) GenerateAndroidBuildActions(ctx android.ModuleContext) { rule.DeleteTemporaryFiles() - rule.Build(pctx, ctx, "uncompress_dex", "uncompress dex") + rule.Build("uncompress_dex", "uncompress dex") } else { ctx.Build(pctx, android.BuildParams{ Rule: android.Cp, diff --git a/java/kotlin.go b/java/kotlin.go index e8c030aa7..8067ad521 100644 --- a/java/kotlin.go +++ b/java/kotlin.go @@ -63,9 +63,9 @@ func kotlinCommonSrcsList(ctx android.ModuleContext, commonSrcFiles android.Path // we can't use the rsp file because it is already being used for srcs. // Insert a second rule to write out the list of resources to a file. commonSrcsList := android.PathForModuleOut(ctx, "kotlinc_common_srcs.list") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command().Text("cp").FlagWithRspFileInputList("", commonSrcFiles).Output(commonSrcsList) - rule.Build(pctx, ctx, "kotlin_common_srcs_list", "kotlin common_srcs list") + rule.Build("kotlin_common_srcs_list", "kotlin common_srcs list") return android.OptionalPathForPath(commonSrcsList) } return android.OptionalPath{} diff --git a/java/lint.go b/java/lint.go index 11f92e502..cd2a904d6 100644 --- a/java/lint.go +++ b/java/lint.go @@ -176,9 +176,9 @@ func (l *linter) writeLintProjectXML(ctx android.ModuleContext, // we can't use the rsp file because it is already being used for srcs. // Insert a second rule to write out the list of resources to a file. resourcesList = android.PathForModuleOut(ctx, "lint", "resources.list") - resListRule := android.NewRuleBuilder() + resListRule := android.NewRuleBuilder(pctx, ctx) resListRule.Command().Text("cp").FlagWithRspFileInputList("", l.resources).Output(resourcesList) - resListRule.Build(pctx, ctx, "lint_resources_list", "lint resources list") + resListRule.Build("lint_resources_list", "lint resources list") deps = append(deps, l.resources...) } @@ -192,7 +192,7 @@ func (l *linter) writeLintProjectXML(ctx android.ModuleContext, srcJarList := zipSyncCmd(ctx, rule, srcJarDir, l.srcJars) cmd := rule.Command(). - BuiltTool(ctx, "lint-project-xml"). + BuiltTool("lint-project-xml"). FlagWithOutput("--project_out ", projectXMLPath). FlagWithOutput("--config_out ", configXMLPath). FlagWithArg("--name ", ctx.ModuleName()) @@ -284,7 +284,7 @@ func (l *linter) lint(ctx android.ModuleContext) { } } - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) if l.manifest == nil { manifest := l.generateManifest(ctx, rule) @@ -347,7 +347,7 @@ func (l *linter) lint(ctx android.ModuleContext) { rule.Command().Text("rm -rf").Flag(cacheDir.String()).Flag(homeDir.String()) - rule.Build(pctx, ctx, "lint", "lint") + rule.Build("lint", "lint") l.outputs = lintOutputs{ html: html, @@ -511,12 +511,12 @@ func lintZip(ctx android.BuilderContext, paths android.Paths, outputPath android return paths[i].String() < paths[j].String() }) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) - rule.Command().BuiltTool(ctx, "soong_zip"). + rule.Command().BuiltTool("soong_zip"). FlagWithOutput("-o ", outputPath). FlagWithArg("-C ", android.PathForIntermediates(ctx).String()). FlagWithRspFileInputList("-r ", paths) - rule.Build(pctx, ctx, outputPath.Base(), outputPath.Base()) + rule.Build(outputPath.Base(), outputPath.Base()) } diff --git a/java/platform_compat_config.go b/java/platform_compat_config.go index cb8e6841a..9bc821dfe 100644 --- a/java/platform_compat_config.go +++ b/java/platform_compat_config.go @@ -86,15 +86,15 @@ func (p *platformCompatConfigSingleton) GenerateBuildActions(ctx android.Singlet return } - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) outputPath := platformCompatConfigPath(ctx) rule.Command(). - BuiltTool(ctx, "process-compat-config"). + BuiltTool("process-compat-config"). FlagForEachInput("--xml ", compatConfigMetadata). FlagWithOutput("--merged-config ", outputPath) - rule.Build(pctx, ctx, "merged-compat-config", "Merge compat config") + rule.Build("merged-compat-config", "Merge compat config") p.metadata = outputPath } @@ -106,7 +106,7 @@ func (p *platformCompatConfigSingleton) MakeVars(ctx android.MakeVarsContext) { } func (p *platformCompatConfig) GenerateAndroidBuildActions(ctx android.ModuleContext) { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) configFileName := p.Name() + ".xml" metadataFileName := p.Name() + "_meta.xml" @@ -115,13 +115,13 @@ func (p *platformCompatConfig) GenerateAndroidBuildActions(ctx android.ModuleCon path := android.PathForModuleSrc(ctx, String(p.properties.Src)) rule.Command(). - BuiltTool(ctx, "process-compat-config"). + BuiltTool("process-compat-config"). FlagWithInput("--jar ", path). FlagWithOutput("--device-config ", p.configFile). FlagWithOutput("--merged-config ", p.metadataFile) p.installDirPath = android.PathForModuleInstall(ctx, "etc", "compatconfig") - rule.Build(pctx, ctx, configFileName, "Extract compat/compat_config.xml and install it") + rule.Build(configFileName, "Extract compat/compat_config.xml and install it") } diff --git a/java/proto.go b/java/proto.go index 4d735ebbe..cc9abbeee 100644 --- a/java/proto.go +++ b/java/proto.go @@ -34,7 +34,7 @@ func genProto(ctx android.ModuleContext, protoFiles android.Paths, flags android outDir := srcJarFile.ReplaceExtension(ctx, "tmp") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command().Text("rm -rf").Flag(outDir.String()) rule.Command().Text("mkdir -p").Flag(outDir.String()) @@ -42,13 +42,13 @@ func genProto(ctx android.ModuleContext, protoFiles android.Paths, flags android for _, protoFile := range shard { depFile := srcJarFile.InSameDir(ctx, protoFile.String()+".d") rule.Command().Text("mkdir -p").Flag(filepath.Dir(depFile.String())) - android.ProtoRule(ctx, rule, protoFile, flags, flags.Deps, outDir, depFile, nil) + android.ProtoRule(rule, protoFile, flags, flags.Deps, outDir, depFile, nil) } // Proto generated java files have an unknown package name in the path, so package the entire output directory // into a srcjar. rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). Flag("-jar"). Flag("-write_if_changed"). FlagWithOutput("-o ", srcJarFile). @@ -66,7 +66,7 @@ func genProto(ctx android.ModuleContext, protoFiles android.Paths, flags android ruleDesc += " " + strconv.Itoa(i) } - rule.Build(pctx, ctx, ruleName, ruleDesc) + rule.Build(ruleName, ruleDesc) } return srcJarFiles diff --git a/java/robolectric.go b/java/robolectric.go index 62d1d998e..419efda88 100644 --- a/java/robolectric.go +++ b/java/robolectric.go @@ -199,7 +199,7 @@ func (r *robolectricTest) GenerateAndroidBuildActions(ctx android.ModuleContext) func generateRoboTestConfig(ctx android.ModuleContext, outputFile android.WritablePath, instrumentedApp *AndroidApp) { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) manifest := instrumentedApp.mergedManifestFile resourceApk := instrumentedApp.outputFile @@ -213,11 +213,11 @@ func generateRoboTestConfig(ctx android.ModuleContext, outputFile android.Writab Implicit(manifest). Implicit(resourceApk) - rule.Build(pctx, ctx, "generate_test_config", "generate test_config.properties") + rule.Build("generate_test_config", "generate test_config.properties") } func generateSameDirRoboTestConfigJar(ctx android.ModuleContext, outputFile android.ModuleOutPath) { - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) outputDir := outputFile.InSameDir(ctx) configFile := outputDir.Join(ctx, "com/android/tools/test_config.properties") @@ -230,12 +230,12 @@ func generateSameDirRoboTestConfigJar(ctx android.ModuleContext, outputFile andr Textf(`echo "android_resource_apk=%s.apk"`, ctx.ModuleName()). Text(") >>").Output(configFile) rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). FlagWithArg("-C ", outputDir.String()). FlagWithInput("-f ", configFile). FlagWithOutput("-o ", outputFile) - rule.Build(pctx, ctx, "generate_test_config_samedir", "generate test_config.properties") + rule.Build("generate_test_config_samedir", "generate test_config.properties") } func (r *robolectricTest) generateRoboSrcJar(ctx android.ModuleContext, outputFile android.WritablePath, diff --git a/java/sdk.go b/java/sdk.go index 971791f4a..32a4b5a88 100644 --- a/java/sdk.go +++ b/java/sdk.go @@ -544,7 +544,7 @@ func createSdkFrameworkAidl(ctx android.SingletonContext) { commitChangeForRestat(rule, tempPath, combinedAidl) - rule.Build(pctx, ctx, "framework_aidl", "generate framework.aidl") + rule.Build("framework_aidl", "generate framework.aidl") } // Creates a version of framework.aidl for the non-updatable part of the platform. @@ -558,7 +558,7 @@ func createNonUpdatableFrameworkAidl(ctx android.SingletonContext) { commitChangeForRestat(rule, tempPath, combinedAidl) - rule.Build(pctx, ctx, "framework_non_updatable_aidl", "generate framework_non_updatable.aidl") + rule.Build("framework_non_updatable_aidl", "generate framework_non_updatable.aidl") } func createFrameworkAidl(stubsModules []string, path android.OutputPath, ctx android.SingletonContext) *android.RuleBuilder { @@ -586,7 +586,7 @@ func createFrameworkAidl(stubsModules []string, path android.OutputPath, ctx and } } - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.MissingDeps(missingDeps) var aidls android.Paths @@ -597,7 +597,7 @@ func createFrameworkAidl(stubsModules []string, path android.OutputPath, ctx and rule.Command(). Text("rm -f").Output(aidl) rule.Command(). - BuiltTool(ctx, "sdkparcelables"). + BuiltTool("sdkparcelables"). Input(jar). Output(aidl) @@ -632,7 +632,7 @@ func nonUpdatableFrameworkAidlPath(ctx android.PathContext) android.OutputPath { func createAPIFingerprint(ctx android.SingletonContext) { out := ApiFingerprintPath(ctx) - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). Text("rm -f").Output(out) @@ -659,7 +659,7 @@ func createAPIFingerprint(ctx android.SingletonContext) { Output(out) } - rule.Build(pctx, ctx, "api_fingerprint", "generate api_fingerprint.txt") + rule.Build("api_fingerprint", "generate api_fingerprint.txt") } func ApiFingerprintPath(ctx android.PathContext) android.OutputPath { diff --git a/java/sdk_library.go b/java/sdk_library.go index 32bc07787..4e33d747b 100644 --- a/java/sdk_library.go +++ b/java/sdk_library.go @@ -2176,12 +2176,12 @@ func (module *sdkLibraryXml) GenerateAndroidBuildActions(ctx android.ModuleConte xmlContent := fmt.Sprintf(permissionsTemplate, libName, module.implPath(ctx)) module.outputFilePath = android.PathForModuleOut(ctx, libName+".xml").OutputPath - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command(). Text("/bin/bash -c \"echo -e '" + xmlContent + "'\" > "). Output(module.outputFilePath) - rule.Build(pctx, ctx, "java_sdk_xml", "Permission XML") + rule.Build("java_sdk_xml", "Permission XML") module.installDirPath = android.PathForModuleInstall(ctx, "etc", module.SubDir()) } diff --git a/linkerconfig/linkerconfig.go b/linkerconfig/linkerconfig.go index 1c44c746f..b24f61d2f 100644 --- a/linkerconfig/linkerconfig.go +++ b/linkerconfig/linkerconfig.go @@ -68,13 +68,13 @@ func (l *linkerConfig) GenerateAndroidBuildActions(ctx android.ModuleContext) { inputFile := android.PathForModuleSrc(ctx, android.String(l.properties.Src)) l.outputFilePath = android.PathForModuleOut(ctx, "linker.config.pb").OutputPath l.installDirPath = android.PathForModuleInstall(ctx, "etc") - linkerConfigRule := android.NewRuleBuilder() + linkerConfigRule := android.NewRuleBuilder(pctx, ctx) linkerConfigRule.Command(). - BuiltTool(ctx, "conv_linker_config"). + BuiltTool("conv_linker_config"). Flag("proto"). FlagWithInput("-s ", inputFile). FlagWithOutput("-o ", l.outputFilePath) - linkerConfigRule.Build(pctx, ctx, "conv_linker_config", + linkerConfigRule.Build("conv_linker_config", "Generate linker config protobuf "+l.outputFilePath.String()) if proptools.BoolDefault(l.properties.Installable, true) { diff --git a/python/proto.go b/python/proto.go index b71e047a5..53ebb5895 100644 --- a/python/proto.go +++ b/python/proto.go @@ -24,17 +24,17 @@ func genProto(ctx android.ModuleContext, protoFile android.Path, flags android.P outDir := srcsZipFile.ReplaceExtension(ctx, "tmp") depFile := srcsZipFile.ReplaceExtension(ctx, "srcszip.d") - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) rule.Command().Text("rm -rf").Flag(outDir.String()) rule.Command().Text("mkdir -p").Flag(outDir.String()) - android.ProtoRule(ctx, rule, protoFile, flags, flags.Deps, outDir, depFile, nil) + android.ProtoRule(rule, protoFile, flags, flags.Deps, outDir, depFile, nil) // Proto generated python files have an unknown package name in the path, so package the entire output directory // into a srcszip. zipCmd := rule.Command(). - BuiltTool(ctx, "soong_zip"). + BuiltTool("soong_zip"). FlagWithOutput("-o ", srcsZipFile) if pkgPath != "" { zipCmd.FlagWithArg("-P ", pkgPath) @@ -44,7 +44,7 @@ func genProto(ctx android.ModuleContext, protoFile android.Path, flags android.P rule.Command().Text("rm -rf").Flag(outDir.String()) - rule.Build(pctx, ctx, "protoc_"+protoFile.Rel(), "protoc "+protoFile.Rel()) + rule.Build("protoc_"+protoFile.Rel(), "protoc "+protoFile.Rel()) return srcsZipFile } diff --git a/rust/protobuf.go b/rust/protobuf.go index 235b4ad2b..0e7908950 100644 --- a/rust/protobuf.go +++ b/rust/protobuf.go @@ -93,7 +93,7 @@ func (proto *protobufDecorator) GenerateSource(ctx ModuleContext, deps PathDeps) // stemFile must be first here as the first path in BaseSourceProvider.OutputFiles is the library entry-point. outputs := android.WritablePaths{stemFile} - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) for _, protoFile := range protoFiles { protoName := strings.TrimSuffix(protoFile.Base(), ".proto") protoNames = append(protoNames, protoName) @@ -108,7 +108,7 @@ func (proto *protobufDecorator) GenerateSource(ctx ModuleContext, deps PathDeps) depFile := android.PathForModuleOut(ctx, protoName+".d") - android.ProtoRule(ctx, rule, protoFile, protoFlags, protoFlags.Deps, outDir, depFile, ruleOutputs) + android.ProtoRule(rule, protoFile, protoFlags, protoFlags.Deps, outDir, depFile, ruleOutputs) outputs = append(outputs, ruleOutputs...) } @@ -117,7 +117,7 @@ func (proto *protobufDecorator) GenerateSource(ctx ModuleContext, deps PathDeps) Text("printf '" + proto.genModFileContents(ctx, protoNames) + "' >"). Output(stemFile) - rule.Build(pctx, ctx, "protoc_"+ctx.ModuleName(), "protoc "+ctx.ModuleName()) + rule.Build("protoc_"+ctx.ModuleName(), "protoc "+ctx.ModuleName()) proto.BaseSourceProvider.OutputFiles = outputs.Paths() diff --git a/sdk/update.go b/sdk/update.go index ba63542a4..377aaae76 100644 --- a/sdk/update.go +++ b/sdk/update.go @@ -92,7 +92,7 @@ func (gc *generatedContents) Printfln(format string, args ...interface{}) { } func (gf *generatedFile) build(pctx android.PackageContext, ctx android.BuilderContext, implicits android.Paths) { - rb := android.NewRuleBuilder() + rb := android.NewRuleBuilder(pctx, ctx) content := gf.content.String() @@ -108,7 +108,7 @@ func (gf *generatedFile) build(pctx android.PackageContext, ctx android.BuilderC Text("| sed 's/\\\\n/\\n/g' >").Output(gf.path) rb.Command(). Text("chmod a+x").Output(gf.path) - rb.Build(pctx, ctx, gf.path.Base(), "Build "+gf.path.Base()) + rb.Build(gf.path.Base(), "Build "+gf.path.Base()) } // Collect all the members. diff --git a/sysprop/sysprop_library.go b/sysprop/sysprop_library.go index 828d1cf5c..6a53414ba 100644 --- a/sysprop/sysprop_library.go +++ b/sysprop/sysprop_library.go @@ -247,16 +247,16 @@ func (m *syspropLibrary) GenerateAndroidBuildActions(ctx android.ModuleContext) m.latestApiFile = android.PathForSource(ctx, ctx.ModuleDir(), "api", baseModuleName+"-latest.txt") // dump API rule - rule := android.NewRuleBuilder() + rule := android.NewRuleBuilder(pctx, ctx) m.dumpedApiFile = android.PathForModuleOut(ctx, "api-dump.txt") rule.Command(). - BuiltTool(ctx, "sysprop_api_dump"). + BuiltTool("sysprop_api_dump"). Output(m.dumpedApiFile). Inputs(android.PathsForModuleSrc(ctx, m.properties.Srcs)) - rule.Build(pctx, ctx, baseModuleName+"_api_dump", baseModuleName+" api dump") + rule.Build(baseModuleName+"_api_dump", baseModuleName+" api dump") // check API rule - rule = android.NewRuleBuilder() + rule = android.NewRuleBuilder(pctx, ctx) // 1. compares current.txt to api-dump.txt // current.txt should be identical to api-dump.txt. @@ -284,7 +284,7 @@ func (m *syspropLibrary) GenerateAndroidBuildActions(ctx android.ModuleContext) rule.Command(). Text("( "). - BuiltTool(ctx, "sysprop_api_checker"). + BuiltTool("sysprop_api_checker"). Input(m.latestApiFile). Input(m.currentApiFile). Text(" || ( echo").Flag("-e"). @@ -297,7 +297,7 @@ func (m *syspropLibrary) GenerateAndroidBuildActions(ctx android.ModuleContext) Text("touch"). Output(m.checkApiFileTimeStamp) - rule.Build(pctx, ctx, baseModuleName+"_check_api", baseModuleName+" check api") + rule.Build(baseModuleName+"_check_api", baseModuleName+" check api") } func (m *syspropLibrary) AndroidMk() android.AndroidMkData {