Update warning message

As requested on aosp/1975486

Fixes: 217248902
Test: Presubmits
Change-Id: I14e65722d8ab96125827d34e8501b4a518a27b57
This commit is contained in:
Cole Faust 2022-02-08 12:49:37 -08:00
parent 3e7f5c411d
commit f4e72cf642
2 changed files with 2 additions and 2 deletions

View file

@ -1119,7 +1119,7 @@ def init(g, handle):
rblf.inherit(handle, "foo/font", _font_init) rblf.inherit(handle, "foo/font", _font_init)
# There's some space and even this comment between the include_top and the inherit-product # There's some space and even this comment between the include_top and the inherit-product
rblf.inherit(handle, "foo/font", _font_init) rblf.inherit(handle, "foo/font", _font_init)
rblf.mkwarning("product.mk:11", "Including a path with a non-constant prefix, please convert this to a simple literal to generate cleaner starlark.") rblf.mkwarning("product.mk:11", "Please avoid starting an include path with a variable. See https://source.android.com/setup/build/bazel/product_config/issues/includes for details.")
_entry = { _entry = {
"foo/font.mk": ("foo/font", _font_init), "foo/font.mk": ("foo/font", _font_init),
"bar/font.mk": ("bar/font", _font1_init), "bar/font.mk": ("bar/font", _font1_init),

View file

@ -101,7 +101,7 @@ func (i inheritedDynamicModule) entryName() string {
func (i inheritedDynamicModule) emitSelect(gctx *generationContext) { func (i inheritedDynamicModule) emitSelect(gctx *generationContext) {
if i.needsWarning { if i.needsWarning {
gctx.newLine() gctx.newLine()
gctx.writef("%s.mkwarning(%q, %q)", baseName, i.location, "Including a path with a non-constant prefix, please convert this to a simple literal to generate cleaner starlark. See https://source.android.com/setup/build/bazel/product_config/issues/includes for details.") gctx.writef("%s.mkwarning(%q, %q)", baseName, i.location, "Please avoid starting an include path with a variable. See https://source.android.com/setup/build/bazel/product_config/issues/includes for details.")
} }
gctx.newLine() gctx.newLine()
gctx.writef("_entry = {") gctx.writef("_entry = {")