Commit graph

73318 commits

Author SHA1 Message Date
Treehugger Robot
8793576748 Merge "Globally disable -Wreorder-init-list." into main am: c70be4b986
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2794922

Change-Id: Idd07ec4dff8691e490d3d5f850c35a2efe18589e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-22 10:07:50 +00:00
Treehugger Robot
c70be4b986 Merge "Globally disable -Wreorder-init-list." into main 2023-10-22 09:49:55 +00:00
Krzysztof Kosiński
8f8cc1668e Globally disable -Wreorder-init-list.
This warning is triggered even when initializers don't have any
side effects, so it very rarely surfaces actual bugs/mistakes.
99% of the time it complains about a purely cosmetic issue.
Disable it by default in commonGlobalCFlags, which still allows
individual modules to opt into it.

Bug: 145210666
Test: presubmit
Change-Id: I671b5c457ee3d92b9cc37f020ba54e01e1a04f59
2023-10-22 05:09:40 +00:00
Jihoon Kang
51dec9e919 Merge "Modify the product variable Build_from_text_stub value" into main am: e8f21ac529
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2797656

Change-Id: I27137d763d82a47538d479bae87588f465a57d17
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-21 01:59:29 +00:00
Jihoon Kang
e8f21ac529 Merge "Modify the product variable Build_from_text_stub value" into main 2023-10-21 01:45:07 +00:00
Jihoon Kang
182b56b870 Default from-text stub generation in build
This change defaults Java stubs to be generated from API text files
during build. Using the `--build-from-source-stubs` flag, users can
toggle between the feature.

Test: m nothing && verify ninja path exists between android_stubs_current and android_stubs_current.from-text, and does not exist between android_stubs_current.from-source, m nothing --build-from-source-stub && verify the opposite
Bug: 274805756
Change-Id: I28834f92c1b1311e3fe0a71a6ea9e8ec2e278d7e
2023-10-20 23:11:19 +00:00
Jihoon Kang
531a416d6a Modify the product variable Build_from_text_stub value
productVariables.Build_from_test_stub is currently being set by the
config.buildFromTextStub value. However, this leads to divergence in the
behaviors between the exported BuildFromTextStub() value and the config
value, as the former depends on other factor (whether is it a coverage
build). This change fixes the divergence by making the product variable
value to be set by the former.

Test: m nothing
Bug: 301522358
Change-Id: Ic4de5a179dd1094eb8788663e4d6afa4bea724ea
2023-10-20 22:58:25 +00:00
Cole Faust
57e7d2f406 Merge "Load a list of plugins from vendor/google_clockwork" into main am: c9ef6f71cf
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2798384

Change-Id: Ib512090bd4a01cd3699eccb5706db0b9876fe99a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 22:27:34 +00:00
Cole Faust
c9ef6f71cf Merge "Load a list of plugins from vendor/google_clockwork" into main 2023-10-20 22:00:16 +00:00
Eric Rahm
58ebb11b4c Merge changes I33c95126,I126395d3,Iaa27fa0a,Ia149a81f into main am: 02237038e1
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2797724

Change-Id: I0c623dae2c58cc246fc71041d3b0fea2268cc282
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 21:22:27 +00:00
Eric Rahm
02237038e1 Merge changes I33c95126,I126395d3,Iaa27fa0a,Ia149a81f into main
* changes:
  Reapply "Use zstd to compress debug info in rust libraries"
  Reapply "Use zstd to compress debug info in cc libraries"
  Reapply "Compress debug info in clang builds with zstd"
  Decompress debug sections when creating debug info
2023-10-20 21:08:01 +00:00
Yu Liu
f11b7c3093 Support a few more attrs in cc_aconfig_library.
More might be added later when we have an allowlist.

Bug: 305998969
Test: b build with the change in ag/25094394
Change-Id: I92df843ac81f4e33ce7506db61c989a380015975
2023-10-20 19:17:53 +00:00
Cole Faust
97e19031c2 Load a list of plugins from vendor/google_clockwork
Some wear partners have vendor/google_clockwork but not vendor/google.

Bug: 290816499
Test: Presubmits
Change-Id: Id45f68bf6f734acc1ee6abbfd2314d9ff6be75fb
2023-10-20 11:54:16 -07:00
Vinh Tran
c55a1b2b31 Merge "Allowlist librustc_demangle_static" into main am: 4193286396
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2794696

Change-Id: I9b1cc132278c05e464ad05605160c8f191206455
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 18:37:12 +00:00
Vinh Tran
4193286396 Merge "Allowlist librustc_demangle_static" into main 2023-10-20 18:17:53 +00:00
Jihoon Kang
210643a421 Merge "Fix build configuration dependant Soong test" into main am: de88e35004
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2792092

Change-Id: I3684f45dd064f002249462183fdc4119184e883e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 16:51:30 +00:00
Spandan Das
1242eb23fc Merge "Turn on sandboxing for external/perfetto" into main am: 6bf35ad88c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2790323

Change-Id: I3972911a379df6a60a64115dc38c6d7839d1f738
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 16:49:34 +00:00
Jihoon Kang
de88e35004 Merge "Fix build configuration dependant Soong test" into main 2023-10-20 16:48:03 +00:00
Spandan Das
6bf35ad88c Merge "Turn on sandboxing for external/perfetto" into main 2023-10-20 16:26:29 +00:00
Matías Hernández
e07640ff65 Merge changes from topic "revert-2788316-JFVDBRFDKA" into main am: a76ea9ac49
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2796138

Change-Id: I4ea2a8ea80e8f5ac8b142097db6a1d2eb76ba767
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 16:07:24 +00:00
Eric Rahm
25acde2f56 Reapply "Use zstd to compress debug info in rust libraries"
This reverts commit 99d682ad4a.

Test: m
Bug: 305277519
Change-Id: I33c951265229d9f65670760c2255625ef3226707
2023-10-20 16:01:14 +00:00
Eric Rahm
1952471c56 Reapply "Use zstd to compress debug info in cc libraries"
This reverts commit d0500f10ef.

Test: m
Bug: 305277519
Change-Id: I126395d32cfc0048b6403c831613d9b4a178af4d
2023-10-20 16:01:14 +00:00
Eric Rahm
5571ab8599 Reapply "Compress debug info in clang builds with zstd"
This reverts commit 6d089b7de0.

Test: m
Bug: 305277519
Change-Id: Iaa27fa0aae8ef624b403e905bfb04df15e380baf
2023-10-20 16:01:14 +00:00
Eric Rahm
eba99f4ab1 Decompress debug sections when creating debug info
`create_minidebuginfo` can fail when processing objects with compressed
debuginfo. To work around this we can use `llvm-objcopy` to decompress
the debug sections prior to processing.

Test: m
Bug: 305277519
Change-Id: Ia149a81f01b0be974f395732c713fb23d92ac22f
2023-10-20 16:01:10 +00:00
Matías Hernández
a76ea9ac49 Merge changes from topic "revert-2788316-JFVDBRFDKA" into main
* changes:
  Revert "Decompress debug sections when creating debug info"
  Revert "Compress debug info in clang builds with zstd"
  Revert "Use zstd to compress debug info in cc libraries"
  Revert "Use zstd to compress debug info in rust libraries"
2023-10-20 15:48:28 +00:00
Anas Sulaiman
5e404e0580 Merge "support toggling compare mode for rbe actions" into main am: f76b3267d5
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2796314

Change-Id: Ica21f1662bc955f1030cf6e6775d976a4c2a4419
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 15:03:57 +00:00
Anas Sulaiman
f76b3267d5 Merge "support toggling compare mode for rbe actions" into main 2023-10-20 14:41:18 +00:00
Matías Hernández
77833b7502 Revert "Decompress debug sections when creating debug info"
Revert submission 2788316

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.corp.google.com/builds/quarterdeck?branch=git_main&target=panther-next-userdebug&lkgb=10981485&lkbb=10981536&fkbb=10981536, bug b/306625613

Reverted changes: /q/submissionid:2788316

Change-Id: Idebeff995fa2cd6dd23cd4a2675c9f3c7f8307d9
BUG: 306625613
2023-10-20 13:07:14 +00:00
Matías Hernández
6d089b7de0 Revert "Compress debug info in clang builds with zstd"
Revert submission 2788316

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.corp.google.com/builds/quarterdeck?branch=git_main&target=panther-next-userdebug&lkgb=10981485&lkbb=10981536&fkbb=10981536, bug b/306625613

Reverted changes: /q/submissionid:2788316

Change-Id: I7a49b82d26454fe34f8200622a38cdabc0f446cf
BUG: 306625613
2023-10-20 13:07:14 +00:00
Matías Hernández
d0500f10ef Revert "Use zstd to compress debug info in cc libraries"
Revert submission 2788316

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.corp.google.com/builds/quarterdeck?branch=git_main&target=panther-next-userdebug&lkgb=10981485&lkbb=10981536&fkbb=10981536, bug b/306625613

Reverted changes: /q/submissionid:2788316

Change-Id: Ice939d57214879416da06d7134c6a8b56eaf00e6
BUG: 306625613
2023-10-20 13:07:14 +00:00
Matías Hernández
99d682ad4a Revert "Use zstd to compress debug info in rust libraries"
Revert submission 2788316

Reason for revert: DroidMonitor-triggered revert due to breakage https://android-build.corp.google.com/builds/quarterdeck?branch=git_main&target=panther-next-userdebug&lkgb=10981485&lkbb=10981536&fkbb=10981536, bug b/306625613

Reverted changes: /q/submissionid:2788316

Change-Id: I78830209e04e5cd8872d75ec3a0faa46acd47ac6
BUG: 306625613
2023-10-20 13:07:14 +00:00
Eric Rahm
83c8da5f3c Merge changes Ia85d8dc0,I4ab3d47f,Ieeaa6554,I0b3c1f08 into main am: b60cd11bc7
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2788316

Change-Id: Iec51da037662a419bb00bd4d143622ac257251fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-20 10:55:36 +00:00
Eric Rahm
b60cd11bc7 Merge changes Ia85d8dc0,I4ab3d47f,Ieeaa6554,I0b3c1f08 into main
* changes:
  Use zstd to compress debug info in rust libraries
  Use zstd to compress debug info in cc libraries
  Compress debug info in clang builds with zstd
  Decompress debug sections when creating debug info
2023-10-20 10:32:13 +00:00
Jihoon Kang
cc9e2186e2 Fix build configuration dependant Soong test
This change fixes a Soong test that is dependent on the build
configuration (from-source stub build vs from-text stub build) by
setting the test configuration to build from source stub and add
an additional test case configured with build from text stub so
that the expected behaviors of both from-source and from-text
stub builds can be tested.

Bug: 275570206
Test: m nothing && m nothing --build-from-text-stub
Change-Id: I483be27ad3eebbf6af050e80265859919fc28fd8
2023-10-20 09:24:50 +00:00
Cole Faust
c361a39e1d Merge "Revert "Revert "Add GENRULE_SANDBOXING=false to non-sandboxed bu..."" into main am: a00cc919dd
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2796748

Change-Id: I86e9e7b7a4ac2a510928d5eba398ee3e1fde09be
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-19 23:22:21 +00:00
Cole Faust
a00cc919dd Merge "Revert "Revert "Add GENRULE_SANDBOXING=false to non-sandboxed bu..."" into main 2023-10-19 23:10:55 +00:00
Eric Rahm
a806f9dc44 Use zstd to compress debug info in rust libraries
We can save a significant amount of disk space by compressing debug info
in rust builds. This adds a flag that configures compressing debug info
at the link stage for rust binaries.

Test: m
Bug: 305277519
Change-Id: Ia85d8dc0e7bea35d9f9abfeae27a4610b3113e78
2023-10-19 22:47:44 +00:00
Eric Rahm
f52906f194 Use zstd to compress debug info in cc libraries
We can save a significant amount of disk space by compressing
debug info in `lld` cc builds. This change configures a build
flag to instruct lld to compress debug info when building cc
libraries. Rather than adding a global config we add this to
each target individually to avoid linker failures on windows
cross build targets.

Test: m
Bug: 305277519

Change-Id: I4ab3d47fb0de7e31a39fb671cccde1acee3a2018
2023-10-19 22:47:44 +00:00
Eric Rahm
fa0dff576b Compress debug info in clang builds with zstd
We can save a significant amount of disk space by compressing
debug info in `clang` builds. This change configures a build
flag to instruct clang to compress debug info.

Test: m
Bug: 305277519
Change-Id: Ieeaa655452d847e83ebc6bec0864e47c46f4c6fb
2023-10-19 22:24:58 +00:00
Eric Rahm
6f4c50ea9d Decompress debug sections when creating debug info
`create_minidebuginfo` can fail when processing objects with compressed
debuginfo. To work around this we can use `llvm-objcopy` to decompress
the debug sections prior to processing.

Test: m
Bug: 305277519
Change-Id: I0b3c1f08dfbcb7f8ebea2607ed3e22d901e63ecd
2023-10-19 22:24:58 +00:00
Treehugger Robot
9ee7878b18 Merge "Add bp2build converter for rust_ffi_static" into main am: 052f882a04
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2794872

Change-Id: I37bdedeb340b85136516853dd2736a73169a49f8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-19 21:32:34 +00:00
Treehugger Robot
052f882a04 Merge "Add bp2build converter for rust_ffi_static" into main 2023-10-19 21:03:51 +00:00
Treehugger Robot
78e70be0e2 Merge "Add detail string for the module marked bp2build unconvertible" into main am: 3b2c2547e9
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2786921

Change-Id: I2e5e779541f71c15542669792a2ef50cc1dc4a27
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-19 20:01:03 +00:00
Jihoon Kang
dd3491dcbe Merge "Disable from-text stub build for coverage build" into main am: 04803d4767
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2789434

Change-Id: I14b132f22c9e1486dda8baaf9b400018bb2f7d77
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-19 20:00:51 +00:00
Treehugger Robot
3b2c2547e9 Merge "Add detail string for the module marked bp2build unconvertible" into main 2023-10-19 19:24:26 +00:00
Jihoon Kang
04803d4767 Merge "Disable from-text stub build for coverage build" into main 2023-10-19 19:22:33 +00:00
Cole Faust
8263791e3a Merge "Add bazel-built modules as deps on the system image" into main am: b2435a464d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2791479

Change-Id: I327e32bd8aeaf80a745f2b59e599ff9349f949e5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-19 18:30:41 +00:00
Cole Faust
b2435a464d Merge "Add bazel-built modules as deps on the system image" into main 2023-10-19 18:04:08 +00:00
Zi Wang
11bd9d4c39 Add detail string for the module marked bp2build unconvertible
This change is only for the unconvertible modules types
from prebuilt_etc.go

Test: CI

Bug: 303725325
Change-Id: I06d8c1325c158c0669740abe7188281370655265
2023-10-19 09:54:29 -07:00
Vinh Tran
877df697cc Allowlist librustc_demangle_static
Test: b build
//external/rust/crates/rustc-demangle-capi:librustc_demangle_static
--config=android
Test: b build //external/rust/crates/rustc-demangle-capi:librustc_demangle_static
Bug:  297395183

Change-Id: I1ce220af8ef89001d4ffd608ee1bad27b8011538
2023-10-19 11:27:04 -04:00