Cole Faust
f4e72cf642
Update warning message
...
As requested on aosp/1975486
Fixes: 217248902
Test: Presubmits
Change-Id: I14e65722d8ab96125827d34e8501b4a518a27b57
2022-02-08 13:10:26 -08:00
Treehugger Robot
0959ae13e7
Merge "Use -fno-sanitize-link-runtime for bionic sanitizers" am: 3e7f5c411d
am: 8793c78b35
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975927
Change-Id: I403bd7772ddf309e3c1e0d963ecbdb2a8f2149d9
2022-02-08 21:01:00 +00:00
Treehugger Robot
8793c78b35
Merge "Use -fno-sanitize-link-runtime for bionic sanitizers" am: 3e7f5c411d
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975927
Change-Id: Ib3a130bfc330fdb93036a93c1cab08b7f136bb11
2022-02-08 20:45:03 +00:00
Treehugger Robot
3e7f5c411d
Merge "Use -fno-sanitize-link-runtime for bionic sanitizers"
2022-02-08 20:33:43 +00:00
Treehugger Robot
3a47638b76
Merge "Link to documentation about variables in include statements" am: cb1703d8b1
am: ccb3db98c7
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975486
Change-Id: I8fc159bad8b3cfc4fe9b5ebad334c273ed0c6dfb
2022-02-08 20:28:14 +00:00
Aditya Belsare
fe3c1bb5fc
Merge "Add cert_validator to allowed rust paths" am: 43832f6136
am: 7c74466aa7
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975528
Change-Id: I96cf1711581aa1d8097e815f5e2a58d1c00faf79
2022-02-08 20:27:28 +00:00
Treehugger Robot
ccb3db98c7
Merge "Link to documentation about variables in include statements" am: cb1703d8b1
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975486
Change-Id: I0d554ecb3dc213a43f70bdbd7c07531657eb12a0
2022-02-08 20:14:36 +00:00
Aditya Belsare
7c74466aa7
Merge "Add cert_validator to allowed rust paths" am: 43832f6136
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975528
Change-Id: I409f7ca02999a91cc611a678cd95c5ecae26bca2
2022-02-08 20:13:29 +00:00
Treehugger Robot
cb1703d8b1
Merge "Link to documentation about variables in include statements"
2022-02-08 20:04:57 +00:00
Aditya Belsare
43832f6136
Merge "Add cert_validator to allowed rust paths"
2022-02-08 19:40:13 +00:00
Cole Faust
cb5e6fb13b
Merge "Remove --root, require the cwd to be the root" am: 076b9c26e9
am: 68f638fd5b
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1971500
Change-Id: I583f0c06dc5bcfeac7796b2e2e77112436f8fe9b
2022-02-08 19:04:47 +00:00
Yu Liu
5daae6f2b6
Merge "Support bssl hash injection for libcrypto." am: febce2dfa7
am: 126db90364
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1966148
Change-Id: I7b1b1e9c2933b47eba3c7e2bba1c07de727e551f
2022-02-08 19:04:35 +00:00
Cole Faust
68f638fd5b
Merge "Remove --root, require the cwd to be the root" am: 076b9c26e9
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1971500
Change-Id: I0c293d1bceeb4d131614199e1318336c63725e73
2022-02-08 18:48:37 +00:00
Yu Liu
126db90364
Merge "Support bssl hash injection for libcrypto." am: febce2dfa7
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1966148
Change-Id: Ia89d6d05ed9b2c3b436c7a86a7e02fc1f02e7298
2022-02-08 18:40:45 +00:00
Cole Faust
076b9c26e9
Merge "Remove --root, require the cwd to be the root"
2022-02-08 18:34:27 +00:00
Yu Liu
febce2dfa7
Merge "Support bssl hash injection for libcrypto."
2022-02-08 16:59:34 +00:00
Jingwen Chen
20d9caa528
Merge "Omit musl related cc_genrules from bp2build." am: db07f002b8
am: 0f3068995d
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1976207
Change-Id: I446c33265f33c09549af36726e9d6debb050b497
2022-02-08 08:29:24 +00:00
Jingwen Chen
0f3068995d
Merge "Omit musl related cc_genrules from bp2build." am: db07f002b8
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1976207
Change-Id: I0a258dec6c572290891c922de514d4f09443d9cc
2022-02-08 08:11:55 +00:00
Jingwen Chen
db07f002b8
Merge "Omit musl related cc_genrules from bp2build."
2022-02-08 07:43:51 +00:00
Aditya Belsare
c0bd27b3b0
Add cert_validator to allowed rust paths
...
Test: m libcert_request_validator works
Change-Id: I40b8027e98a775dc1b9d3a8ab4431c12d6088c12
2022-02-08 07:32:31 +00:00
Treehugger Robot
30d3d4babc
Merge "Export htmlnotice, xmlnotice, and textnotice." am: c7bf27ba7a
am: 54da56d074
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1976067
Change-Id: I108a017e6449896c4ed67d387432b7bc5b0493df
2022-02-08 06:18:28 +00:00
Treehugger Robot
54da56d074
Merge "Export htmlnotice, xmlnotice, and textnotice." am: c7bf27ba7a
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1976067
Change-Id: I8af530424f85017d37272c65e95e096242748973
2022-02-08 06:05:57 +00:00
Treehugger Robot
c7bf27ba7a
Merge "Export htmlnotice, xmlnotice, and textnotice."
2022-02-08 05:52:14 +00:00
Jingwen Chen
f6b4cd4bcd
Omit musl related cc_genrules from bp2build.
...
These trigger a few failure modes (duplicate genrule srcs, failure in
matching config conditions, depending on unconverted soong_zip host
tool).
Test: CI
Bug: 218405924
Change-Id: I15c119803a057e94ef6a941df3b58103d42eb4e4
2022-02-08 04:47:48 +00:00
Treehugger Robot
a16ecabf5f
Merge "Disable tidy default DeprecatedOrUnsafeBufferHandling check" am: cf637f101c
am: ccf8597e8a
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1976066
Change-Id: Icbdb22c61ca357da5622bd72055f2c5ed660ec52
2022-02-08 04:06:32 +00:00
Treehugger Robot
ccf8597e8a
Merge "Disable tidy default DeprecatedOrUnsafeBufferHandling check" am: cf637f101c
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1976066
Change-Id: Icdde9e0d5820fc7f45d3e2165b151f40774af987
2022-02-08 03:48:48 +00:00
Treehugger Robot
cf637f101c
Merge "Disable tidy default DeprecatedOrUnsafeBufferHandling check"
2022-02-08 03:30:31 +00:00
Jooyung Han
4749d6884d
Merge changes I11693286,I8d79a434 am: 472be14f26
am: 601cb3422d
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1972300
Change-Id: I4eba5b2457cbbe863de08afd6fe482f742c55ec3
2022-02-08 01:39:40 +00:00
Colin Cross
234b01de96
Use -fno-sanitize-link-runtime for bionic sanitizers
...
Currently when using sanitizers and building for the device
the -fsanitize= argument is not passed to the linker so that the
linker won't add the runtimes, which have already been added
as explicit dependencies. Pass -fno-sanitize-link-runtime instead
in case the linker has other behaviors when passed -fsanitize=
besides adding the runtimes. Also check for bionic instead of host
so that linux bionic gets the same linker behavior as bionic for
the device.
Test: m USE_HOST_MUSL=true host-native
Test: m checkbuild
Change-Id: I0f2966e2fd4ae8adc5cb21eb116c349bcc0c668f
2022-02-08 01:35:23 +00:00
Jooyung Han
601cb3422d
Merge changes I11693286,I8d79a434 am: 472be14f26
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1972300
Change-Id: Ic6352169bdd3883d1f8646816dd51fc31e68f269
2022-02-08 01:21:16 +00:00
Treehugger Robot
26f4afa245
Merge "Close opened paths" am: 217a70e713
am: 4c8f8b8c00
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1972548
Change-Id: I2d36dd67b02065c4bd58beb946f6d102b5bf5036
2022-02-08 01:08:52 +00:00
Jooyung Han
472be14f26
Merge changes I11693286,I8d79a434
...
* changes:
VNDK libs use "unique" APEX variants
use_vndk_as_stable APEX shouldn't include VNDK lib
2022-02-08 01:03:41 +00:00
Treehugger Robot
4c8f8b8c00
Merge "Close opened paths" am: 217a70e713
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1972548
Change-Id: I9976b7ad0c2bbf00e3ed8c7d2e72ffd2c1eb636d
2022-02-08 00:56:53 +00:00
Chih-Hung Hsieh
9bcce2ef3a
Disable tidy default DeprecatedOrUnsafeBufferHandling check
...
This will suppress warning like:
system/chre/chpp/app.c:637:3: warning: Call to function 'memset' is insecure
as it does not provide security checks introduced in the C11 standard.
Replace with analogous functions that support length arguments or provides
boundary checks such as 'memset_s' in case of C11
[clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling]
Test: WITH_TIDY=1 CLANG_ANALYZER_CHECKS=1 make tidy-system-chre-chpp_subset
Change-Id: I87a7bba31aa10260fc408317a8cd54bf80c03152
2022-02-07 16:44:13 -08:00
Treehugger Robot
217a70e713
Merge "Close opened paths"
2022-02-08 00:33:04 +00:00
Treehugger Robot
b3fea8cebb
Merge "Use soong's finder to find included makefiles in mk2rbc" am: eae56c8a52
am: 3baafe54cb
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1962180
Change-Id: If100ce2c739e60401520b60eee002c7943b54785
2022-02-07 22:49:58 +00:00
Treehugger Robot
3baafe54cb
Merge "Use soong's finder to find included makefiles in mk2rbc" am: eae56c8a52
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1962180
Change-Id: I964fa2c1fe7b79133b30d9ea801b39f339c1ab60
2022-02-07 22:32:57 +00:00
Treehugger Robot
b464962d50
Merge "Close more files." am: 56f3510cd2
am: 5e73b06ea2
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975187
Change-Id: Ic6cef0a0780c7b6530607a28664b41a38468f30f
2022-02-07 22:27:01 +00:00
Treehugger Robot
dd690a1636
Merge "Add logging of file resource limits in Soong" am: 1aa1f1aa95
am: 1b5ecbe412
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975186
Change-Id: I0d02811504d70dbdedb0edf4f6099e1745c25497
2022-02-07 22:26:45 +00:00
Treehugger Robot
eae56c8a52
Merge "Use soong's finder to find included makefiles in mk2rbc"
2022-02-07 22:20:46 +00:00
Yu Liu
75be7b94d6
Support bssl hash injection for libcrypto.
...
Bug: 215541108
Test: Build libcrypto with Bazel and verify the hash injected, add unit
test
Change-Id: I0375307aab0b1e60a8be298d680e1e0af1ebb454
Change-Id: I9133ce398e2024fe7834a292bf2f5ba3222d630b
2022-02-07 14:15:42 -08:00
Treehugger Robot
5e73b06ea2
Merge "Close more files." am: 56f3510cd2
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975187
Change-Id: I3602a83708dafadced820db77beef12dc2e71f1a
2022-02-07 22:09:20 +00:00
Treehugger Robot
1b5ecbe412
Merge "Add logging of file resource limits in Soong" am: 1aa1f1aa95
...
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/1975186
Change-Id: I571bc03719fb29f12fa4c3b51ba0e056338e0313
2022-02-07 22:09:02 +00:00
Treehugger Robot
56f3510cd2
Merge "Close more files."
2022-02-07 21:52:24 +00:00
Treehugger Robot
1aa1f1aa95
Merge "Add logging of file resource limits in Soong"
2022-02-07 21:49:56 +00:00
Cole Faust
7dbdfac3cc
Link to documentation about variables in include statements
...
As requested in aosp/1962181
Fixes: 217248902
Test: Presubmits
Change-Id: Ib0f99a4b86999782bfcf3ccf89375a929cf5127f
2022-02-07 12:31:20 -08:00
Cole Faust
9b6111aaed
Remove --root, require the cwd to be the root
...
This allows us to use relative paths everywhere.
It also produces more accurate emulation of TOPDIR,
which should be an empty string.
Bug: 213508006
Test: go test
Change-Id: Ie4e357687486e84e9f4aad0f6776d8feb2b9fc63
2022-02-07 11:45:01 -08:00
Cole Faust
8d47c48082
Use soong's finder to find included makefiles in mk2rbc
...
Having soong generate a list of makefiles for mk2rbc
to look through is much faster than having mk2rbc search
itself. Profiling the readLinesFromeFile() function that
reads the list of makefiles shows it takes on the order
of 200 microseconds, much faster than the ~5 seconds
it takes for mk2rbc to search the tree itself.
This CL also allows include statements that are prefixed
with a variable. The concern with this was that there
would be a lot of load statemnts emitted for generic
include statements, causing the generated code to look
ugly, and converting and loading all those files could
cause performance issues. On the performance issues
front, there's already a check that it doesn't result
in over 150 potentially included files. We can lower
that number if necessary, but it's probably good for now.
On the generated code front, while it's true that it's
ugly, it's better to have working but ugly generated
code than refusing to generate anything working at all.
To ensure the soong finder step isn't slowed down due
to having to find a bunch of new makefiles, I profiled
the combination of newSourceFinder and FindSources in main.go:
Baseline incremental:
338.011634ms
340.853335ms
348.541762ms
333.229644ms
349.124824ms
Baseline clean:
1.003836419s
1.006203912s
996.193648ms
1.031005604s
1.03691152s
Modified incremental:
349.029285ms
349.264496ms
351.774948ms
337.63187ms
359.425306ms
Modified clean:
1.028238704s
1.053103506s
1.032757506s
1.016631201s
1.04288108s
So we can see the times are barely affected by this change.
Fixes: 213508006
Test: go test
Change-Id: Iab18bfb127ba3b7e63f2c01f69064805a8398764
2022-02-07 11:41:28 -08:00
Liz Kammer
a754178d4f
Add logging of file resource limits in Soong
...
Test: m nothing and verify in logs
Change-Id: I4b51089ce1d222927a180b260fb9bc0e3b77c468
2022-02-07 13:38:52 -05:00
Liz Kammer
7fe2400039
Close more files.
...
Test: m nothing
Change-Id: I4914337feb4ee2499c270b8504a097a2fd597ab3
2022-02-07 13:18:15 -05:00