Commit graph

74104 commits

Author SHA1 Message Date
Jihoon Kang
c831389625 Revert^2 "Add flagged api hide conditional to droidstubs"
This reverts commit 1180919dda.

Test: go test ./java && m TARGET_PRODUCT=sdk TESTING_TARGET_RELEASE_NEXT=true nothing and inspect ninja command for generating stubs and verify the flag is included && m TARGET_PRODUCT=sdk TARGET_RELEASE=trunk_food nothing and inspect ninja command for generating stubs and verify the flag is not included
Bug: 299570421
Change-Id: I4967376c0236bad729398af80fa59b48dbab5f21
2023-10-03 01:04:00 +00:00
Jihoon Kang
f3aa3225b6 Revert^2 "Add soong config variable Release_expose_flagged_api"
This reverts commit 5548bf3053.

Test: m nothing
Bug: 299570421
Change-Id: I9f70648fb6657bbf4f5681cd6d40517d70a8fefb
2023-10-03 01:00:42 +00:00
Thiébaud Weksteen
82dd82e3ae Merge changes from topic "linter_integration_tests" into main am: 77b232da24 am: 11e2cee9a6 am: 9e0a9d859a
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2769019

Change-Id: Ic6f9d079fb9550b09ace5b5786761b46fa0f38aa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-03 00:33:56 +00:00
Treehugger Robot
afbd47b9d7 Merge "Remove -Wsign-promo." into main am: 2eff89a8ce am: 1b3e900e4c am: 7d9a64a6db
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770219

Change-Id: Ie23a7962daa838aecd1a1bc2cf928de6ec663b3e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-03 00:33:08 +00:00
Krzysztof Kosiński
b0bf4aac7c Merge "More documentation for C++ global config." into main am: eae6635a0f am: 2cf4265572 am: b9d2d04d75
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770218

Change-Id: If292d4d82e9ba799b1eb91dbaedb53634ec77908
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-03 00:32:34 +00:00
Chris Parsons
5f1b3c7ad8 create, but dont register, bp2build_deps mutator
This is the bulk of the "allowlist v2" feature. It will disable bp2build
generation for modules which have transitive dependencies without a
bazel build definition.

This CL includes this mutator, but doesn't register it as a bp2build
mutator (outside of a few unit tests). This allows us to easily iterate
on completion of this feature and ensure there are no launch blockers
before we finalize the change in AOSP.

Bug: 285631638
Test: Unit tests
Change-Id: Ifb0a079c409ca19b02cafa3fab2efa0d3deebc50
2023-10-03 00:16:30 +00:00
Thiébaud Weksteen
9e0a9d859a Merge changes from topic "linter_integration_tests" into main am: 77b232da24 am: 11e2cee9a6
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2769019

Change-Id: Id42122ad6f40e317cec4a05e0989f15197d22d0b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 23:59:43 +00:00
Treehugger Robot
7d9a64a6db Merge "Remove -Wsign-promo." into main am: 2eff89a8ce am: 1b3e900e4c
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770219

Change-Id: Ibc2641ecea70435b035c260d4618825e46811977
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 23:43:34 +00:00
Krzysztof Kosiński
b9d2d04d75 Merge "More documentation for C++ global config." into main am: eae6635a0f am: 2cf4265572
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770218

Change-Id: I0a94c6ce169a51c116994bbbb794ec0233aea603
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 23:43:23 +00:00
Mark Dacek
aa5cc2cd6a Revert "Modify symlink_forest to rerun when soong_build has changed."
This reverts commit 23a4120c57.

Reason for revert: broke soong_integration

Change-Id: I4d51841756675b3745244d23e13aefda0916614b
2023-10-02 23:40:33 +00:00
Thiébaud Weksteen
11e2cee9a6 Merge changes from topic "linter_integration_tests" into main am: 77b232da24
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2769019

Change-Id: I644f41e0eefef143396008663d02aa1c2f07b348
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 23:30:03 +00:00
Treehugger Robot
1b3e900e4c Merge "Remove -Wsign-promo." into main am: 2eff89a8ce
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770219

Change-Id: I5aa4ad1382edbb1335d83e8f2170deb53ffd4618
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 23:27:55 +00:00
Thiébaud Weksteen
77b232da24 Merge changes from topic "linter_integration_tests" into main
* changes:
  Add .lint tagged output to Java modules
  Add lint.suppress_exit_code attribute
2023-10-02 23:26:39 +00:00
Treehugger Robot
2eff89a8ce Merge "Remove -Wsign-promo." into main 2023-10-02 23:14:26 +00:00
Dwayne Barry
2554047ed9 Merge changes from topic "revert-2646423-HDQXAAHWBW" into main am: e298d42044 am: 0df7036509 am: 9508704561
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2768071

Change-Id: Ic7e427f9088347336b32004394342f874288be88
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 23:12:55 +00:00
Krzysztof Kosiński
2cf4265572 Merge "More documentation for C++ global config." into main am: eae6635a0f
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770218

Change-Id: Iea1588705a75630c398bda2931123e6df94022a4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 23:12:35 +00:00
Dwayne Barry
9508704561 Merge changes from topic "revert-2646423-HDQXAAHWBW" into main am: e298d42044 am: 0df7036509
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2768071

Change-Id: I36637ff93bc4815cfdf438accf02bf7fa78fbb7d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 22:41:16 +00:00
Krzysztof Kosiński
eae6635a0f Merge "More documentation for C++ global config." into main 2023-10-02 22:27:21 +00:00
Dwayne Barry
0df7036509 Merge changes from topic "revert-2646423-HDQXAAHWBW" into main am: e298d42044
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2768071

Change-Id: I3efb286e8e011c2fb5ad2d3f6c4706be44e67d83
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 22:07:13 +00:00
Yu Liu
f2b94010c8 Convert java_aconfig_library to bazel.
Bug: 297357579
Test: Unit test and AconfigJavaHostTest
Change-Id: Icf944cc0b2a7382107923d49b2d2ff0eb4113638
2023-10-02 15:04:19 -07:00
Dwayne Barry
e298d42044 Merge changes from topic "revert-2646423-HDQXAAHWBW" into main
* changes:
  Revert "NDK library: enable feature flags for dumping ABI repres..."
  Revert "NDK library: enable feature flags for diffing ABI repres..."
2023-10-02 21:40:32 +00:00
Android Culprit Assistant
cd44909edc Revert "NDK library: enable feature flags for dumping ABI repres..."
This revert was created by Android Culprit Assistant. The culprit was identified in the following culprit search session (http://go/aca-get/e18f14a6-af8b-4b9e-8f8e-73515c608887).

Change-Id: Ia32769fc520459ce7cb61f8e5b1def623eee93ff
2023-10-02 21:26:39 +00:00
Android Culprit Assistant
6dabfdda65 Revert "NDK library: enable feature flags for diffing ABI repres..."
This revert was created by Android Culprit Assistant. The culprit was identified in the following culprit search session (http://go/aca-get/e18f14a6-af8b-4b9e-8f8e-73515c608887).

Change-Id: I4e0b62eea9e1c0ff49fbbf92e900606ccf93b93a
2023-10-02 21:26:39 +00:00
Wei Li
1c40d6cefe Merge "Change sbom_test.sh to take command line arguments for target product, release and build variant, which is for a corresponding change in CI." into main am: 0af40657ff am: 5f49a8e36e am: e4b6a23cb0
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770025

Change-Id: I4dd92c2874225ddd7dc798b902d582b82ebea28a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 21:06:28 +00:00
Christopher Parsons
a9abf7e090 Merge "Treat src=name filegroups as handcrafted targets" into main am: aa3e435857 am: 87fbbe641d am: dd03dde9c2
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2766186

Change-Id: Id12f2ac71f7c33eab1c0e8f39e47cea99c07a14b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 21:04:58 +00:00
Wei Li
e4b6a23cb0 Merge "Change sbom_test.sh to take command line arguments for target product, release and build variant, which is for a corresponding change in CI." into main am: 0af40657ff am: 5f49a8e36e
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770025

Change-Id: I329d2f2ae0bf088750beb21a8a98dbe6fa39d775
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 20:03:45 +00:00
Christopher Parsons
dd03dde9c2 Merge "Treat src=name filegroups as handcrafted targets" into main am: aa3e435857 am: 87fbbe641d
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2766186

Change-Id: I0e36fe1e95afb2b080e7813f224d2f851a7d2528
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 20:01:17 +00:00
Mark Dacek
331c999e94 Merge "Modify symlink_forest to rerun when soong_build has changed." into main am: e20b7589b4 am: 55c467dd51 am: 9574fb9ab2
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2758108

Change-Id: Ibf3060021ce0de91b37756701d5eac7981c8be19
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 19:59:18 +00:00
Wei Li
5f49a8e36e Merge "Change sbom_test.sh to take command line arguments for target product, release and build variant, which is for a corresponding change in CI." into main am: 0af40657ff
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2770025

Change-Id: I566856eacea24d4659d76fce37a4e8dd6b9cb171
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 18:35:52 +00:00
Christopher Parsons
87fbbe641d Merge "Treat src=name filegroups as handcrafted targets" into main am: aa3e435857
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2766186

Change-Id: Ib25d2952b0f8aca01fbe651550e1a50967e3b605
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 18:35:30 +00:00
Mark Dacek
9574fb9ab2 Merge "Modify symlink_forest to rerun when soong_build has changed." into main am: e20b7589b4 am: 55c467dd51
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2758108

Change-Id: I7759f157177fa248a577ec7984a131bde06bfd45
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 18:33:12 +00:00
Wei Li
0af40657ff Merge "Change sbom_test.sh to take command line arguments for target product, release and build variant, which is for a corresponding change in CI." into main 2023-10-02 18:14:33 +00:00
Spandan Das
a7da3f0e0b Create bp2build converter for versioned_ndk_headers
This module type is used by a single soong module - `common_libc` in
bionic/libc

Implementation details
- Convert this module type to ndk_headers rule. Bazel's ndk_headers rule
  will have a boolean attribute `run_versioner` to determine if
  verioner should be run on the headers
- Add this module type to the alwaysConvert bp2build list
- Add the converted target for `common_libc` to the deps of
  `ndk_sysroot`. This ensures that unbundled apps link against the
  versioned NDK headers of libc

Test: go test ./bp2build
Test: b build //bionic/libc:common_libc --config=android
Test: for f in $(find bazel-bin/bionic/libc/common_libc.versioned -type f); do cmp $f ${f/bazel-bin\/bionic\/libc\/common_libc.versioned/out\/soong\/ndk\/sysroot\/usr\/include}; done # no diff

Bug: 301169067

Change-Id: I55be202f0589db9bdc743c8be41c9c5afd74c352
2023-10-02 17:35:55 +00:00
Christopher Parsons
aa3e435857 Merge "Treat src=name filegroups as handcrafted targets" into main 2023-10-02 17:35:44 +00:00
Zi Wang
2260933688 Allowlist tradefed-common-util and some dependents for tradefed
Test: CI

Bug: 283193845
Change-Id: Id9e8eefcf47080e786c62466658c7cb1f31b055d
2023-10-02 09:56:34 -07:00
Mark Dacek
55c467dd51 Merge "Modify symlink_forest to rerun when soong_build has changed." into main am: e20b7589b4
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2758108

Change-Id: I6c6f2028868304284588ecf4fa6998b973e9f7bb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 16:25:07 +00:00
Mark Dacek
e20b7589b4 Merge "Modify symlink_forest to rerun when soong_build has changed." into main 2023-10-02 15:36:43 +00:00
Romain Jobredeaux
61535ddb6f Merge "Use manual BUILD files in jdk8 and allowlist apache-commons-compress" into main am: e2007bfd0e am: fc6a6fd081 am: 49b07dc069
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2767831

Change-Id: Ideb27e2135fac3a4b6071f39f763180616c39fa4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 15:28:36 +00:00
Aleksei Vetrov
0b97beff20 Merge changes I94a0e2de,I95ebfef6 into main am: bf62b334f6 am: 3306e5228a am: c600c8b9f4
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2646423

Change-Id: Iff1edd58b3f8ed8f86cfe9f3f419a8e5dfc70740
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 15:28:26 +00:00
Romain Jobredeaux
49b07dc069 Merge "Use manual BUILD files in jdk8 and allowlist apache-commons-compress" into main am: e2007bfd0e am: fc6a6fd081
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2767831

Change-Id: Id85f25741908bc67982813fcd9f2bbc2bbebc626
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 14:25:22 +00:00
Aleksei Vetrov
c600c8b9f4 Merge changes I94a0e2de,I95ebfef6 into main am: bf62b334f6 am: 3306e5228a
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2646423

Change-Id: I6836367ef771711213c08083590d533d3ea6c2ab
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 14:25:11 +00:00
Romain Jobredeaux
fc6a6fd081 Merge "Use manual BUILD files in jdk8 and allowlist apache-commons-compress" into main am: e2007bfd0e
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2767831

Change-Id: I39fbdd11d59b1b3905cd55ebd4146913b8e64e5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 14:19:44 +00:00
Romain Jobredeaux
e2007bfd0e Merge "Use manual BUILD files in jdk8 and allowlist apache-commons-compress" into main 2023-10-02 13:38:50 +00:00
Aleksei Vetrov
3306e5228a Merge changes I94a0e2de,I95ebfef6 into main am: bf62b334f6
Original change: https://android-review.googlesource.com/c/platform/build/soong/+/2646423

Change-Id: I00b43583290322a31c1ca36bfcde5ce596327544
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-10-02 13:17:16 +00:00
Aleksei Vetrov
bf62b334f6 Merge changes I94a0e2de,I95ebfef6 into main
* changes:
  NDK library: enable feature flags for diffing ABI representations
  NDK library: enable feature flags for dumping ABI representations
2023-10-02 12:40:59 +00:00
Thiébaud Weksteen
d054436434 Add .lint tagged output to Java modules
The linter output can be referenced in other modules for further
processing.

Bug: 302400088
Test: m nothing
Change-Id: I1809b70d8d98ced5d8f3d5f068c6639c782ebebc
2023-10-02 10:12:30 +11:00
Krzysztof Kosiński
29c60f34fb Remove -Wsign-promo.
This flag has no effect in Clang:
https://clang.llvm.org/docs/DiagnosticsReference.html#wsign-promo

Bug: 296606895
Test: presubmit
Change-Id: I59c1e6b6cf541529b9f4741accdf26822572426f
2023-09-30 06:15:22 +00:00
Krzysztof Kosiński
1a4572ec9c More documentation for C++ global config.
Bug: 296606895
Test: presubmit
Change-Id: I19a4fa327bf1eac192067caf6d064a740124caf6
2023-09-30 05:49:09 +00:00
Wei Li
3b3173d5db Change sbom_test.sh to take command line arguments for target product, release and build variant, which is for a corresponding change in CI.
Bug: 276778945
Test: build/soong/tests/sbom_test.sh TARGET_PRODUCT=aosp_cf_x86_64_phone TARGET_RELEASE=trunk_staging TARGET_BUILD_VARIANT=userdebug
Change-Id: I2d9e271e4ae351e3626657aa2ac2a1a967c15fc8
2023-09-29 16:52:11 -07:00
MarkDacek
23a4120c57 Modify symlink_forest to rerun when soong_build has changed.
Also remove existing symlink_forest_version functionality.

This remedies issues pertaining to b/300122962 - symlinks not
clearing after a revert

Timing wise - this doesn't present a performance regression
on a clean build. When soong_build changes, it's considerably longer
but no different from the time when symlink_forest_version is changed.

Bug: 300288299
Test: build/soong/tests/symlink_forest_rerun_test.sh
Change-Id: I0e95aac315dfea7ea3b8bb9a3eb0c6408300bd3b
2023-09-29 22:53:07 +00:00