platform_build_soong/cc/util.go
Colin Cross 6d88dbad0e Reorder local and global flags
Native compiler flags are currently applied in approximately:
global cflags
local cflags
local include dirs
global include dirs
global conlyflags
local conlyflags
global cppflags
local cppflags

This means that a flag that is enabled in the global cppflags
cannot be disabled in the local cflags, and an Android.bp author
must know to disable it in the local cppflags.

The previous CL split the global and local flags into separate
variables.  Rearrange the order that the variables are applied
to be:
global cflags
global conlyflags
global cppflags
local cflags
local include dirs
local conlyflags
local cppflags
global include dirs

Bug: 143713277
Test: m native

Change-Id: I171524ab40096a636a8e549e1e4bc3347ef9f97a
2019-11-07 15:27:58 -08:00

122 lines
4 KiB
Go

// Copyright 2015 Google Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package cc
import (
"fmt"
"path/filepath"
"regexp"
"strings"
"android/soong/android"
)
// Efficiently converts a list of include directories to a single string
// of cflags with -I prepended to each directory.
func includeDirsToFlags(dirs android.Paths) string {
return android.JoinWithPrefix(dirs.Strings(), "-I")
}
func ldDirsToFlags(dirs []string) string {
return android.JoinWithPrefix(dirs, "-L")
}
func libNamesToFlags(names []string) string {
return android.JoinWithPrefix(names, "-l")
}
var indexList = android.IndexList
var inList = android.InList
var filterList = android.FilterList
var removeListFromList = android.RemoveListFromList
var removeFromList = android.RemoveFromList
var libNameRegexp = regexp.MustCompile(`^lib(.*)$`)
func moduleToLibName(module string) (string, error) {
matches := libNameRegexp.FindStringSubmatch(module)
if matches == nil {
return "", fmt.Errorf("Library module name %s does not start with lib", module)
}
return matches[1], nil
}
func flagsToBuilderFlags(in Flags) builderFlags {
return builderFlags{
globalCommonFlags: strings.Join(in.Global.CommonFlags, " "),
globalAsFlags: strings.Join(in.Global.AsFlags, " "),
globalYasmFlags: strings.Join(in.Global.YasmFlags, " "),
globalCFlags: strings.Join(in.Global.CFlags, " "),
globalToolingCFlags: strings.Join(in.Global.ToolingCFlags, " "),
globalToolingCppFlags: strings.Join(in.Global.ToolingCppFlags, " "),
globalConlyFlags: strings.Join(in.Global.ConlyFlags, " "),
globalCppFlags: strings.Join(in.Global.CppFlags, " "),
globalLdFlags: strings.Join(in.Global.LdFlags, " "),
localCommonFlags: strings.Join(in.Local.CommonFlags, " "),
localAsFlags: strings.Join(in.Local.AsFlags, " "),
localYasmFlags: strings.Join(in.Local.YasmFlags, " "),
localCFlags: strings.Join(in.Local.CFlags, " "),
localToolingCFlags: strings.Join(in.Local.ToolingCFlags, " "),
localToolingCppFlags: strings.Join(in.Local.ToolingCppFlags, " "),
localConlyFlags: strings.Join(in.Local.ConlyFlags, " "),
localCppFlags: strings.Join(in.Local.CppFlags, " "),
localLdFlags: strings.Join(in.Local.LdFlags, " "),
aidlFlags: strings.Join(in.aidlFlags, " "),
rsFlags: strings.Join(in.rsFlags, " "),
libFlags: strings.Join(in.libFlags, " "),
extraLibFlags: strings.Join(in.extraLibFlags, " "),
tidyFlags: strings.Join(in.TidyFlags, " "),
sAbiFlags: strings.Join(in.SAbiFlags, " "),
toolchain: in.Toolchain,
coverage: in.Coverage,
tidy: in.Tidy,
sAbiDump: in.SAbiDump,
emitXrefs: in.EmitXrefs,
systemIncludeFlags: strings.Join(in.SystemIncludeFlags, " "),
assemblerWithCpp: in.AssemblerWithCpp,
groupStaticLibs: in.GroupStaticLibs,
proto: in.proto,
protoC: in.protoC,
protoOptionsFile: in.protoOptionsFile,
yacc: in.Yacc,
}
}
func addPrefix(list []string, prefix string) []string {
for i := range list {
list[i] = prefix + list[i]
}
return list
}
func addSuffix(list []string, suffix string) []string {
for i := range list {
list[i] = list[i] + suffix
}
return list
}
// linkDirOnDevice/linkName -> target
func makeSymlinkCmd(linkDirOnDevice string, linkName string, target string) string {
dir := filepath.Join("$(PRODUCT_OUT)", linkDirOnDevice)
return "mkdir -p " + dir + " && " +
"ln -sf " + target + " " + filepath.Join(dir, linkName)
}