20acc5c520
Some checks for common errors with user-provided compiler and linker flags: * Using -I instead of include_dirs * Using -l<lib> in ldflags instead of host_ldlibs (or shared_libs) * Using -L in ldflags * Splitting a multi-word flag into two flags * Combining two flags into one list entry * Using a path that could search outside the source or output trees * Using a non-whitelisted library in host_ldlibs Maybe some of the flag checks should happen during a static analysis pass, but we don't have one right now, and this only adds ~1/2 second to our 73 second Mega_device runs (recompile the changed code, run soong_build, then report unknown target). Change-Id: Icea7436260f1caa62c0cec29817a1cfea27b3e7c
128 lines
3.1 KiB
Go
128 lines
3.1 KiB
Go
// Copyright 2015 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package cc
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"android/soong/android"
|
|
)
|
|
|
|
// Efficiently converts a list of include directories to a single string
|
|
// of cflags with -I prepended to each directory.
|
|
func includeDirsToFlags(dirs android.Paths) string {
|
|
return android.JoinWithPrefix(dirs.Strings(), "-I")
|
|
}
|
|
|
|
func includeFilesToFlags(files android.Paths) string {
|
|
return android.JoinWithPrefix(files.Strings(), "-include ")
|
|
}
|
|
|
|
func ldDirsToFlags(dirs []string) string {
|
|
return android.JoinWithPrefix(dirs, "-L")
|
|
}
|
|
|
|
func libNamesToFlags(names []string) string {
|
|
return android.JoinWithPrefix(names, "-l")
|
|
}
|
|
|
|
func indexList(s string, list []string) int {
|
|
for i, l := range list {
|
|
if l == s {
|
|
return i
|
|
}
|
|
}
|
|
|
|
return -1
|
|
}
|
|
|
|
func inList(s string, list []string) bool {
|
|
return indexList(s, list) != -1
|
|
}
|
|
|
|
func filterList(list []string, filter []string) (remainder []string, filtered []string) {
|
|
for _, l := range list {
|
|
if inList(l, filter) {
|
|
filtered = append(filtered, l)
|
|
} else {
|
|
remainder = append(remainder, l)
|
|
}
|
|
}
|
|
|
|
return
|
|
}
|
|
|
|
func removeFromList(s string, list []string) (bool, []string) {
|
|
i := indexList(s, list)
|
|
if i != -1 {
|
|
return true, append(list[:i], list[i+1:]...)
|
|
} else {
|
|
return false, list
|
|
}
|
|
}
|
|
|
|
var libNameRegexp = regexp.MustCompile(`^lib(.*)$`)
|
|
|
|
func moduleToLibName(module string) (string, error) {
|
|
matches := libNameRegexp.FindStringSubmatch(module)
|
|
if matches == nil {
|
|
return "", fmt.Errorf("Library module name %s does not start with lib", module)
|
|
}
|
|
return matches[1], nil
|
|
}
|
|
|
|
func flagsToBuilderFlags(in Flags) builderFlags {
|
|
return builderFlags{
|
|
globalFlags: strings.Join(in.GlobalFlags, " "),
|
|
asFlags: strings.Join(in.AsFlags, " "),
|
|
cFlags: strings.Join(in.CFlags, " "),
|
|
conlyFlags: strings.Join(in.ConlyFlags, " "),
|
|
cppFlags: strings.Join(in.CppFlags, " "),
|
|
yaccFlags: strings.Join(in.YaccFlags, " "),
|
|
ldFlags: strings.Join(in.LdFlags, " "),
|
|
libFlags: strings.Join(in.libFlags, " "),
|
|
nocrt: in.Nocrt,
|
|
toolchain: in.Toolchain,
|
|
clang: in.Clang,
|
|
}
|
|
}
|
|
|
|
func copyVariantFlags(m map[string][]string) map[string][]string {
|
|
ret := make(map[string][]string, len(m))
|
|
for k, v := range m {
|
|
l := make([]string, len(m[k]))
|
|
for i := range m[k] {
|
|
l[i] = v[i]
|
|
}
|
|
ret[k] = l
|
|
}
|
|
return ret
|
|
}
|
|
|
|
func variantOrDefault(variants map[string]string, choice string) string {
|
|
if ret, ok := variants[choice]; ok {
|
|
return ret
|
|
}
|
|
return variants[""]
|
|
}
|
|
|
|
func addPrefix(list []string, prefix string) []string {
|
|
for i := range list {
|
|
list[i] = prefix + list[i]
|
|
}
|
|
return list
|
|
}
|