e7c71c344d
Teach rustc to generate object files instead of a linked executable for binary and shared library crates. This lets us skip the lengthy Rust compilation phase when only the C++ dependencies of these crates have changed. This works using a Python script that replaces the linker invoked by rustc and converts the linker command line into a rspfile that can be used during the link phase. The script makes certain assumptions about how rustc invokes the linker, but since we control the version of Rust we use, we can update the script if those assumptions ever break. I've asked the Rust developers about adding an official way to do this so hopefully we won't need to rely on this hack in the future. The rustc rule for Kythe has been altered to pass linker=true, somewhat consistent with the main rustc rule, which now doesn't invoke the actual linker either. `m xref_rust` still succeeds, but hopefully we can find someone who knows more about the rest of the Kythe pipeline who can let us know whether it should still work. Otherwise, let's use this CL as an opportunity to find out whether the rest of the pipeline is happy with linker=true, since otherwise we will find it hard to maintain the Kythe rule in the future. Change-Id: Ifb9c8689c1bd78c0afcf6fdfd111140d20377536
92 lines
3.3 KiB
Go
92 lines
3.3 KiB
Go
// Copyright 2020 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rust
|
|
|
|
import (
|
|
"github.com/google/blueprint"
|
|
|
|
"android/soong/cc"
|
|
)
|
|
|
|
var CovLibraryName = "libprofile-clang-extras"
|
|
var ProfilerBuiltins = "libprofiler_builtins.rust_sysroot"
|
|
|
|
// Add '%c' to default specifier after we resolve http://b/210012154
|
|
const profileInstrFlag = "-fprofile-instr-generate=/data/misc/trace/clang-%p-%m.profraw"
|
|
|
|
type coverage struct {
|
|
Properties cc.CoverageProperties
|
|
|
|
// Whether binaries containing this module need --coverage added to their ldflags
|
|
linkCoverage bool
|
|
}
|
|
|
|
func (cov *coverage) props() []interface{} {
|
|
return []interface{}{&cov.Properties}
|
|
}
|
|
|
|
func (cov *coverage) deps(ctx DepsContext, deps Deps) Deps {
|
|
if cov.Properties.NeedCoverageVariant {
|
|
ctx.AddVariationDependencies([]blueprint.Variation{
|
|
{Mutator: "link", Variation: "static"},
|
|
}, cc.CoverageDepTag, CovLibraryName)
|
|
|
|
// no_std modules are missing libprofiler_builtins which provides coverage, so we need to add it as a dependency.
|
|
if rustModule, ok := ctx.Module().(*Module); ok && rustModule.compiler.noStdlibs() {
|
|
ctx.AddVariationDependencies([]blueprint.Variation{{Mutator: "rust_libraries", Variation: "rlib"}}, rlibDepTag, ProfilerBuiltins)
|
|
}
|
|
}
|
|
|
|
return deps
|
|
}
|
|
|
|
func (cov *coverage) flags(ctx ModuleContext, flags Flags, deps PathDeps) (Flags, PathDeps) {
|
|
|
|
if !ctx.DeviceConfig().NativeCoverageEnabled() {
|
|
return flags, deps
|
|
}
|
|
|
|
if cov.Properties.CoverageEnabled {
|
|
flags.Coverage = true
|
|
coverage := ctx.GetDirectDepWithTag(CovLibraryName, cc.CoverageDepTag).(cc.LinkableInterface)
|
|
flags.RustFlags = append(flags.RustFlags,
|
|
"-C instrument-coverage", "-g")
|
|
flags.LinkFlags = append(flags.LinkFlags,
|
|
profileInstrFlag, "-g", coverage.OutputFile().Path().String(), "-Wl,--wrap,open")
|
|
deps.LibDeps = append(deps.LibDeps, coverage.OutputFile().Path())
|
|
|
|
// no_std modules are missing libprofiler_builtins which provides coverage, so we need to add it as a dependency.
|
|
if rustModule, ok := ctx.Module().(*Module); ok && rustModule.compiler.noStdlibs() {
|
|
profiler_builtins := ctx.GetDirectDepWithTag(ProfilerBuiltins, rlibDepTag).(*Module)
|
|
deps.RLibs = append(deps.RLibs, RustLibrary{Path: profiler_builtins.OutputFile().Path(), CrateName: profiler_builtins.CrateName()})
|
|
}
|
|
|
|
if cc.EnableContinuousCoverage(ctx) {
|
|
flags.RustFlags = append(flags.RustFlags, "-C llvm-args=--runtime-counter-relocation")
|
|
flags.LinkFlags = append(flags.LinkFlags, "-Wl,-mllvm,-runtime-counter-relocation")
|
|
}
|
|
}
|
|
|
|
return flags, deps
|
|
}
|
|
|
|
func (cov *coverage) begin(ctx BaseModuleContext) {
|
|
if ctx.Host() {
|
|
// Host coverage not yet supported.
|
|
} else {
|
|
// Update useSdk and sdkVersion args if Rust modules become SDK aware.
|
|
cov.Properties = cc.SetCoverageProperties(ctx, cov.Properties, ctx.RustModule().nativeCoverage(), false, "")
|
|
}
|
|
}
|