9e8451e524
Move the linting properties to an enum with 4 possible options: "default", "android", "vendor" or "none". The previous logic for default, based on the module's location, is kept. It is now possible to force the upgrade to a certain lint level for some modules (e.g. external/[...]/android). Update the unit tests and documentation. Bug: 163400111 Test: m Change-Id: I8e464b04401158ed2d3c518a9b72f145a9835c99
48 lines
1.6 KiB
Go
48 lines
1.6 KiB
Go
// Copyright 2020 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rust
|
|
|
|
import (
|
|
"android/soong/rust/config"
|
|
)
|
|
|
|
type ClippyProperties struct {
|
|
// name of the lint set that should be used to validate this module.
|
|
//
|
|
// Possible values are "default" (for using a sensible set of lints
|
|
// depending on the module's location), "android" (for the strictest
|
|
// lint set that applies to all Android platform code), "vendor" (for a
|
|
// relaxed set) and "none" (to disable the execution of clippy). The
|
|
// default value is "default". See also the `lints` property.
|
|
Clippy_lints *string
|
|
}
|
|
|
|
type clippy struct {
|
|
Properties ClippyProperties
|
|
}
|
|
|
|
func (c *clippy) props() []interface{} {
|
|
return []interface{}{&c.Properties}
|
|
}
|
|
|
|
func (c *clippy) flags(ctx ModuleContext, flags Flags, deps PathDeps) (Flags, PathDeps) {
|
|
enabled, lints, err := config.ClippyLintsForDir(ctx.ModuleDir(), c.Properties.Clippy_lints)
|
|
if err != nil {
|
|
ctx.PropertyErrorf("clippy_lints", err.Error())
|
|
}
|
|
flags.Clippy = enabled
|
|
flags.ClippyFlags = append(flags.ClippyFlags, lints)
|
|
return flags, deps
|
|
}
|