6587beddfa
This replaces the _kati_always_build_ hack with a ninja feature so that ninja can actually understand what's happening. This means that we can turn on some more options and checks around expected output filenames: * Remove the output file(s) before the command executes * Error if the output file(s) don't exist after the execution * Error if the output is a directory They're turned on immediately during the soong bootstrap runs, as those run a limited number of rules. The main ninja execution does not remove the output files, and prints warnings instead of errors for the others. I'll turn them on as we understand how often those warnings are seen. Test: m (check for new warnings) Test: treehugger (check for new warnings) Change-Id: I7f5c1a361dd1498eb54a2c07a918f3b0aa086e4c
225 lines
6.2 KiB
Go
225 lines
6.2 KiB
Go
// Copyright 2017 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package build
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"sort"
|
|
"strconv"
|
|
"strings"
|
|
"time"
|
|
|
|
"android/soong/ui/metrics"
|
|
"android/soong/ui/status"
|
|
)
|
|
|
|
func runNinja(ctx Context, config Config) {
|
|
ctx.BeginTrace(metrics.PrimaryNinja, "ninja")
|
|
defer ctx.EndTrace()
|
|
|
|
fifo := filepath.Join(config.OutDir(), ".ninja_fifo")
|
|
nr := status.NewNinjaReader(ctx, ctx.Status.StartTool(), fifo)
|
|
defer nr.Close()
|
|
|
|
executable := config.PrebuiltBuildTool("ninja")
|
|
args := []string{
|
|
"-d", "keepdepfile",
|
|
"-d", "keeprsp",
|
|
"--frontend_file", fifo,
|
|
}
|
|
|
|
args = append(args, config.NinjaArgs()...)
|
|
|
|
var parallel int
|
|
if config.UseRemoteBuild() {
|
|
parallel = config.RemoteParallel()
|
|
} else {
|
|
parallel = config.Parallel()
|
|
}
|
|
args = append(args, "-j", strconv.Itoa(parallel))
|
|
if config.keepGoing != 1 {
|
|
args = append(args, "-k", strconv.Itoa(config.keepGoing))
|
|
}
|
|
|
|
args = append(args, "-f", config.CombinedNinjaFile())
|
|
|
|
args = append(args,
|
|
"-o", "usesphonyoutputs=yes",
|
|
"-w", "dupbuild=err",
|
|
"-w", "missingdepfile=err")
|
|
|
|
cmd := Command(ctx, config, "ninja", executable, args...)
|
|
cmd.Sandbox = ninjaSandbox
|
|
if config.HasKatiSuffix() {
|
|
cmd.Environment.AppendFromKati(config.KatiEnvFile())
|
|
}
|
|
|
|
// Allow both NINJA_ARGS and NINJA_EXTRA_ARGS, since both have been
|
|
// used in the past to specify extra ninja arguments.
|
|
if extra, ok := cmd.Environment.Get("NINJA_ARGS"); ok {
|
|
cmd.Args = append(cmd.Args, strings.Fields(extra)...)
|
|
}
|
|
if extra, ok := cmd.Environment.Get("NINJA_EXTRA_ARGS"); ok {
|
|
cmd.Args = append(cmd.Args, strings.Fields(extra)...)
|
|
}
|
|
|
|
logPath := filepath.Join(config.OutDir(), ".ninja_log")
|
|
ninjaHeartbeatDuration := time.Minute * 5
|
|
if overrideText, ok := cmd.Environment.Get("NINJA_HEARTBEAT_INTERVAL"); ok {
|
|
// For example, "1m"
|
|
overrideDuration, err := time.ParseDuration(overrideText)
|
|
if err == nil && overrideDuration.Seconds() > 0 {
|
|
ninjaHeartbeatDuration = overrideDuration
|
|
}
|
|
}
|
|
|
|
// Filter the environment, as ninja does not rebuild files when environment variables change.
|
|
//
|
|
// Anything listed here must not change the output of rules/actions when the value changes,
|
|
// otherwise incremental builds may be unsafe. Vars explicitly set to stable values
|
|
// elsewhere in soong_ui are fine.
|
|
//
|
|
// For the majority of cases, either Soong or the makefiles should be replicating any
|
|
// necessary environment variables in the command line of each action that needs it.
|
|
if cmd.Environment.IsEnvTrue("ALLOW_NINJA_ENV") {
|
|
ctx.Println("Allowing all environment variables during ninja; incremental builds may be unsafe.")
|
|
} else {
|
|
cmd.Environment.Allow(append([]string{
|
|
"ASAN_SYMBOLIZER_PATH",
|
|
"HOME",
|
|
"JAVA_HOME",
|
|
"LANG",
|
|
"LC_MESSAGES",
|
|
"OUT_DIR",
|
|
"PATH",
|
|
"PWD",
|
|
"PYTHONDONTWRITEBYTECODE",
|
|
"TMPDIR",
|
|
"USER",
|
|
|
|
// TODO: remove these carefully
|
|
"ASAN_OPTIONS",
|
|
"TARGET_BUILD_APPS",
|
|
"TARGET_BUILD_VARIANT",
|
|
"TARGET_PRODUCT",
|
|
// b/147197813 - used by art-check-debug-apex-gen
|
|
"EMMA_INSTRUMENT_FRAMEWORK",
|
|
|
|
// Goma -- gomacc may not need all of these
|
|
"GOMA_DIR",
|
|
"GOMA_DISABLED",
|
|
"GOMA_FAIL_FAST",
|
|
"GOMA_FALLBACK",
|
|
"GOMA_GCE_SERVICE_ACCOUNT",
|
|
"GOMA_TMP_DIR",
|
|
"GOMA_USE_LOCAL",
|
|
|
|
// RBE client
|
|
"RBE_compare",
|
|
"RBE_exec_root",
|
|
"RBE_exec_strategy",
|
|
"RBE_invocation_id",
|
|
"RBE_log_dir",
|
|
"RBE_platform",
|
|
"RBE_remote_accept_cache",
|
|
"RBE_remote_update_cache",
|
|
"RBE_server_address",
|
|
// TODO: remove old FLAG_ variables.
|
|
"FLAG_compare",
|
|
"FLAG_exec_root",
|
|
"FLAG_exec_strategy",
|
|
"FLAG_invocation_id",
|
|
"FLAG_log_dir",
|
|
"FLAG_platform",
|
|
"FLAG_remote_accept_cache",
|
|
"FLAG_remote_update_cache",
|
|
"FLAG_server_address",
|
|
|
|
// ccache settings
|
|
"CCACHE_COMPILERCHECK",
|
|
"CCACHE_SLOPPINESS",
|
|
"CCACHE_BASEDIR",
|
|
"CCACHE_CPP2",
|
|
"CCACHE_DIR",
|
|
}, config.BuildBrokenNinjaUsesEnvVars()...)...)
|
|
}
|
|
|
|
cmd.Environment.Set("DIST_DIR", config.DistDir())
|
|
cmd.Environment.Set("SHELL", "/bin/bash")
|
|
|
|
ctx.Verboseln("Ninja environment: ")
|
|
envVars := cmd.Environment.Environ()
|
|
sort.Strings(envVars)
|
|
for _, envVar := range envVars {
|
|
ctx.Verbosef(" %s", envVar)
|
|
}
|
|
|
|
// Poll the ninja log for updates; if it isn't updated enough, then we want to show some diagnostics
|
|
done := make(chan struct{})
|
|
defer close(done)
|
|
ticker := time.NewTicker(ninjaHeartbeatDuration)
|
|
defer ticker.Stop()
|
|
checker := &statusChecker{}
|
|
go func() {
|
|
for {
|
|
select {
|
|
case <-ticker.C:
|
|
checker.check(ctx, config, logPath)
|
|
case <-done:
|
|
return
|
|
}
|
|
}
|
|
}()
|
|
|
|
ctx.Status.Status("Starting ninja...")
|
|
cmd.RunAndStreamOrFatal()
|
|
}
|
|
|
|
type statusChecker struct {
|
|
prevTime time.Time
|
|
}
|
|
|
|
func (c *statusChecker) check(ctx Context, config Config, pathToCheck string) {
|
|
info, err := os.Stat(pathToCheck)
|
|
var newTime time.Time
|
|
if err == nil {
|
|
newTime = info.ModTime()
|
|
}
|
|
if newTime == c.prevTime {
|
|
// ninja may be stuck
|
|
dumpStucknessDiagnostics(ctx, config, pathToCheck, newTime)
|
|
}
|
|
c.prevTime = newTime
|
|
}
|
|
|
|
// dumpStucknessDiagnostics gets called when it is suspected that Ninja is stuck and we want to output some diagnostics
|
|
func dumpStucknessDiagnostics(ctx Context, config Config, statusPath string, lastUpdated time.Time) {
|
|
|
|
ctx.Verbosef("ninja may be stuck; last update to %v was %v. dumping process tree...", statusPath, lastUpdated)
|
|
|
|
// The "pstree" command doesn't exist on Mac, but "pstree" on Linux gives more convenient output than "ps"
|
|
// So, we try pstree first, and ps second
|
|
pstreeCommandText := fmt.Sprintf("pstree -pal %v", os.Getpid())
|
|
psCommandText := "ps -ef"
|
|
commandText := pstreeCommandText + " || " + psCommandText
|
|
|
|
cmd := Command(ctx, config, "dump process tree", "bash", "-c", commandText)
|
|
output := cmd.CombinedOutputOrFatal()
|
|
ctx.Verbose(string(output))
|
|
|
|
ctx.Verbosef("done\n")
|
|
}
|