c31929962b
Bazel run shell actions begin `bin/bash -c <command>`, without escaping, the command can be treated as an argument to `bin/bash`. Test: build/bazel/mixed_droid.sh Change-Id: I423cb393da2e6ac97448ec77b2596f12670dfd31
459 lines
18 KiB
Go
459 lines
18 KiB
Go
// Copyright 2020 Google Inc. All rights reserved.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package bazel
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"path/filepath"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"github.com/google/blueprint/proptools"
|
|
)
|
|
|
|
// artifact contains relevant portions of Bazel's aquery proto, Artifact.
|
|
// Represents a single artifact, whether it's a source file or a derived output file.
|
|
type artifact struct {
|
|
Id int
|
|
PathFragmentId int
|
|
}
|
|
|
|
type pathFragment struct {
|
|
Id int
|
|
Label string
|
|
ParentId int
|
|
}
|
|
|
|
// KeyValuePair represents Bazel's aquery proto, KeyValuePair.
|
|
type KeyValuePair struct {
|
|
Key string
|
|
Value string
|
|
}
|
|
|
|
// depSetOfFiles contains relevant portions of Bazel's aquery proto, DepSetOfFiles.
|
|
// Represents a data structure containing one or more files. Depsets in Bazel are an efficient
|
|
// data structure for storing large numbers of file paths.
|
|
type depSetOfFiles struct {
|
|
Id int
|
|
DirectArtifactIds []int
|
|
TransitiveDepSetIds []int
|
|
}
|
|
|
|
// action contains relevant portions of Bazel's aquery proto, Action.
|
|
// Represents a single command line invocation in the Bazel build graph.
|
|
type action struct {
|
|
Arguments []string
|
|
EnvironmentVariables []KeyValuePair
|
|
InputDepSetIds []int
|
|
Mnemonic string
|
|
OutputIds []int
|
|
TemplateContent string
|
|
Substitutions []KeyValuePair
|
|
}
|
|
|
|
// actionGraphContainer contains relevant portions of Bazel's aquery proto, ActionGraphContainer.
|
|
// An aquery response from Bazel contains a single ActionGraphContainer proto.
|
|
type actionGraphContainer struct {
|
|
Artifacts []artifact
|
|
Actions []action
|
|
DepSetOfFiles []depSetOfFiles
|
|
PathFragments []pathFragment
|
|
}
|
|
|
|
// BuildStatement contains information to register a build statement corresponding (one to one)
|
|
// with a Bazel action from Bazel's action graph.
|
|
type BuildStatement struct {
|
|
Command string
|
|
Depfile *string
|
|
OutputPaths []string
|
|
InputPaths []string
|
|
SymlinkPaths []string
|
|
Env []KeyValuePair
|
|
Mnemonic string
|
|
}
|
|
|
|
// A helper type for aquery processing which facilitates retrieval of path IDs from their
|
|
// less readable Bazel structures (depset and path fragment).
|
|
type aqueryArtifactHandler struct {
|
|
// Maps middleman artifact Id to input artifact depset ID.
|
|
// Middleman artifacts are treated as "substitute" artifacts for mixed builds. For example,
|
|
// if we find a middleman action which has outputs [foo, bar], and output [baz_middleman], then,
|
|
// for each other action which has input [baz_middleman], we add [foo, bar] to the inputs for
|
|
// that action instead.
|
|
middlemanIdToDepsetIds map[int][]int
|
|
// Maps depset Id to depset struct.
|
|
depsetIdToDepset map[int]depSetOfFiles
|
|
// depsetIdToArtifactIdsCache is a memoization of depset flattening, because flattening
|
|
// may be an expensive operation.
|
|
depsetIdToArtifactIdsCache map[int][]int
|
|
// Maps artifact Id to fully expanded path.
|
|
artifactIdToPath map[int]string
|
|
}
|
|
|
|
// The tokens should be substituted with the value specified here, instead of the
|
|
// one returned in 'substitutions' of TemplateExpand action.
|
|
var TemplateActionOverriddenTokens = map[string]string{
|
|
// Uses "python3" for %python_binary% instead of the value returned by aquery
|
|
// which is "py3wrapper.sh". See removePy3wrapperScript.
|
|
"%python_binary%": "python3",
|
|
}
|
|
|
|
// This pattern matches the MANIFEST file created for a py_binary target.
|
|
var manifestFilePattern = regexp.MustCompile(".*/.+\\.runfiles/MANIFEST$")
|
|
|
|
// The file name of py3wrapper.sh, which is used by py_binary targets.
|
|
var py3wrapperFileName = "/py3wrapper.sh"
|
|
|
|
func newAqueryHandler(aqueryResult actionGraphContainer) (*aqueryArtifactHandler, error) {
|
|
pathFragments := map[int]pathFragment{}
|
|
for _, pathFragment := range aqueryResult.PathFragments {
|
|
pathFragments[pathFragment.Id] = pathFragment
|
|
}
|
|
|
|
artifactIdToPath := map[int]string{}
|
|
for _, artifact := range aqueryResult.Artifacts {
|
|
artifactPath, err := expandPathFragment(artifact.PathFragmentId, pathFragments)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
artifactIdToPath[artifact.Id] = artifactPath
|
|
}
|
|
|
|
depsetIdToDepset := map[int]depSetOfFiles{}
|
|
for _, depset := range aqueryResult.DepSetOfFiles {
|
|
depsetIdToDepset[depset.Id] = depset
|
|
}
|
|
|
|
// Do a pass through all actions to identify which artifacts are middleman artifacts.
|
|
middlemanIdToDepsetIds := map[int][]int{}
|
|
for _, actionEntry := range aqueryResult.Actions {
|
|
if actionEntry.Mnemonic == "Middleman" {
|
|
for _, outputId := range actionEntry.OutputIds {
|
|
middlemanIdToDepsetIds[outputId] = actionEntry.InputDepSetIds
|
|
}
|
|
}
|
|
}
|
|
return &aqueryArtifactHandler{
|
|
middlemanIdToDepsetIds: middlemanIdToDepsetIds,
|
|
depsetIdToDepset: depsetIdToDepset,
|
|
depsetIdToArtifactIdsCache: map[int][]int{},
|
|
artifactIdToPath: artifactIdToPath,
|
|
}, nil
|
|
}
|
|
|
|
func (a *aqueryArtifactHandler) getInputPaths(depsetIds []int) ([]string, error) {
|
|
inputPaths := []string{}
|
|
|
|
for _, inputDepSetId := range depsetIds {
|
|
inputArtifacts, err := a.artifactIdsFromDepsetId(inputDepSetId)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
for _, inputId := range inputArtifacts {
|
|
if middlemanInputDepsetIds, isMiddlemanArtifact := a.middlemanIdToDepsetIds[inputId]; isMiddlemanArtifact {
|
|
// Add all inputs from middleman actions which created middleman artifacts which are
|
|
// in the inputs for this action.
|
|
swappedInputPaths, err := a.getInputPaths(middlemanInputDepsetIds)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
inputPaths = append(inputPaths, swappedInputPaths...)
|
|
} else {
|
|
inputPath, exists := a.artifactIdToPath[inputId]
|
|
if !exists {
|
|
return nil, fmt.Errorf("undefined input artifactId %d", inputId)
|
|
}
|
|
inputPaths = append(inputPaths, inputPath)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TODO(b/197135294): Clean up this custom runfiles handling logic when
|
|
// SourceSymlinkManifest and SymlinkTree actions are supported.
|
|
filteredInputPaths := filterOutPy3wrapperAndManifestFileFromInputPaths(inputPaths)
|
|
|
|
return filteredInputPaths, nil
|
|
}
|
|
|
|
// See go/python-binary-host-mixed-build for more details.
|
|
// 1) For py3wrapper.sh, there is no action for creating py3wrapper.sh in the aquery output of
|
|
// Bazel py_binary targets, so there is no Ninja build statements generated for creating it.
|
|
// 2) For MANIFEST file, SourceSymlinkManifest action is in aquery output of Bazel py_binary targets,
|
|
// but it doesn't contain sufficient information so no Ninja build statements are generated
|
|
// for creating it.
|
|
// So in mixed build mode, when these two are used as input of some Ninja build statement,
|
|
// since there is no build statement to create them, they should be removed from input paths.
|
|
func filterOutPy3wrapperAndManifestFileFromInputPaths(inputPaths []string) []string {
|
|
filteredInputPaths := []string{}
|
|
for _, path := range inputPaths {
|
|
if strings.HasSuffix(path, py3wrapperFileName) || manifestFilePattern.MatchString(path) {
|
|
continue
|
|
}
|
|
filteredInputPaths = append(filteredInputPaths, path)
|
|
}
|
|
return filteredInputPaths
|
|
}
|
|
|
|
func (a *aqueryArtifactHandler) artifactIdsFromDepsetId(depsetId int) ([]int, error) {
|
|
if result, exists := a.depsetIdToArtifactIdsCache[depsetId]; exists {
|
|
return result, nil
|
|
}
|
|
if depset, exists := a.depsetIdToDepset[depsetId]; exists {
|
|
result := depset.DirectArtifactIds
|
|
for _, childId := range depset.TransitiveDepSetIds {
|
|
childArtifactIds, err := a.artifactIdsFromDepsetId(childId)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
result = append(result, childArtifactIds...)
|
|
}
|
|
a.depsetIdToArtifactIdsCache[depsetId] = result
|
|
return result, nil
|
|
} else {
|
|
return nil, fmt.Errorf("undefined input depsetId %d", depsetId)
|
|
}
|
|
}
|
|
|
|
// AqueryBuildStatements returns an array of BuildStatements which should be registered (and output
|
|
// to a ninja file) to correspond one-to-one with the given action graph json proto (from a bazel
|
|
// aquery invocation).
|
|
func AqueryBuildStatements(aqueryJsonProto []byte) ([]BuildStatement, error) {
|
|
buildStatements := []BuildStatement{}
|
|
|
|
var aqueryResult actionGraphContainer
|
|
err := json.Unmarshal(aqueryJsonProto, &aqueryResult)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
aqueryHandler, err := newAqueryHandler(aqueryResult)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
for _, actionEntry := range aqueryResult.Actions {
|
|
if shouldSkipAction(actionEntry) {
|
|
continue
|
|
}
|
|
outputPaths := []string{}
|
|
var depfile *string
|
|
for _, outputId := range actionEntry.OutputIds {
|
|
outputPath, exists := aqueryHandler.artifactIdToPath[outputId]
|
|
if !exists {
|
|
return nil, fmt.Errorf("undefined outputId %d", outputId)
|
|
}
|
|
ext := filepath.Ext(outputPath)
|
|
if ext == ".d" {
|
|
if depfile != nil {
|
|
return nil, fmt.Errorf("found multiple potential depfiles %q, %q", *depfile, outputPath)
|
|
} else {
|
|
depfile = &outputPath
|
|
}
|
|
} else {
|
|
outputPaths = append(outputPaths, outputPath)
|
|
}
|
|
}
|
|
inputPaths, err := aqueryHandler.getInputPaths(actionEntry.InputDepSetIds)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
buildStatement := BuildStatement{
|
|
Command: strings.Join(proptools.ShellEscapeListIncludingSpaces(actionEntry.Arguments), " "),
|
|
Depfile: depfile,
|
|
OutputPaths: outputPaths,
|
|
InputPaths: inputPaths,
|
|
Env: actionEntry.EnvironmentVariables,
|
|
Mnemonic: actionEntry.Mnemonic,
|
|
}
|
|
|
|
if isSymlinkAction(actionEntry) {
|
|
if len(inputPaths) != 1 || len(outputPaths) != 1 {
|
|
return nil, fmt.Errorf("Expect 1 input and 1 output to symlink action, got: input %q, output %q", inputPaths, outputPaths)
|
|
}
|
|
out := outputPaths[0]
|
|
outDir := proptools.ShellEscapeIncludingSpaces(filepath.Dir(out))
|
|
out = proptools.ShellEscapeIncludingSpaces(out)
|
|
in := filepath.Join("$PWD", proptools.ShellEscapeIncludingSpaces(inputPaths[0]))
|
|
// Use absolute paths, because some soong actions don't play well with relative paths (for example, `cp -d`).
|
|
buildStatement.Command = fmt.Sprintf("mkdir -p %[1]s && rm -f %[2]s && ln -sf %[3]s %[2]s", outDir, out, in)
|
|
buildStatement.SymlinkPaths = outputPaths[:]
|
|
} else if isTemplateExpandAction(actionEntry) && len(actionEntry.Arguments) < 1 {
|
|
if len(outputPaths) != 1 {
|
|
return nil, fmt.Errorf("Expect 1 output to template expand action, got: output %q", outputPaths)
|
|
}
|
|
expandedTemplateContent := expandTemplateContent(actionEntry)
|
|
// The expandedTemplateContent is escaped for being used in double quotes and shell unescape,
|
|
// and the new line characters (\n) are also changed to \\n which avoids some Ninja escape on \n, which might
|
|
// change \n to space and mess up the format of Python programs.
|
|
// sed is used to convert \\n back to \n before saving to output file.
|
|
// See go/python-binary-host-mixed-build for more details.
|
|
command := fmt.Sprintf(`/bin/bash -c 'echo "%[1]s" | sed "s/\\\\n/\\n/g" > %[2]s && chmod a+x %[2]s'`,
|
|
escapeCommandlineArgument(expandedTemplateContent), outputPaths[0])
|
|
buildStatement.Command = command
|
|
} else if isPythonZipperAction(actionEntry) {
|
|
if len(inputPaths) < 1 || len(outputPaths) != 1 {
|
|
return nil, fmt.Errorf("Expect 1+ input and 1 output to python zipper action, got: input %q, output %q", inputPaths, outputPaths)
|
|
}
|
|
buildStatement.InputPaths, buildStatement.Command = removePy3wrapperScript(buildStatement)
|
|
buildStatement.Command = addCommandForPyBinaryRunfilesDir(buildStatement, inputPaths[0], outputPaths[0])
|
|
// Add the python zip file as input of the corresponding python binary stub script in Ninja build statements.
|
|
// In Ninja build statements, the outputs of dependents of a python binary have python binary stub script as input,
|
|
// which is not sufficient without the python zip file from which runfiles directory is created for py_binary.
|
|
//
|
|
// The following logic relies on that Bazel aquery output returns actions in the order that
|
|
// PythonZipper is after TemplateAction of creating Python binary stub script. If later Bazel doesn't return actions
|
|
// in that order, the following logic might not find the build statement generated for Python binary
|
|
// stub script and the build might fail. So the check of pyBinaryFound is added to help debug in case later Bazel might change aquery output.
|
|
// See go/python-binary-host-mixed-build for more details.
|
|
pythonZipFilePath := outputPaths[0]
|
|
pyBinaryFound := false
|
|
for i, _ := range buildStatements {
|
|
if len(buildStatements[i].OutputPaths) == 1 && buildStatements[i].OutputPaths[0]+".zip" == pythonZipFilePath {
|
|
buildStatements[i].InputPaths = append(buildStatements[i].InputPaths, pythonZipFilePath)
|
|
pyBinaryFound = true
|
|
}
|
|
}
|
|
if !pyBinaryFound {
|
|
return nil, fmt.Errorf("Could not find the correspondinging Python binary stub script of PythonZipper: %q", outputPaths)
|
|
}
|
|
} else if len(actionEntry.Arguments) < 1 {
|
|
return nil, fmt.Errorf("received action with no command: [%v]", buildStatement)
|
|
}
|
|
buildStatements = append(buildStatements, buildStatement)
|
|
}
|
|
|
|
return buildStatements, nil
|
|
}
|
|
|
|
// expandTemplateContent substitutes the tokens in a template.
|
|
func expandTemplateContent(actionEntry action) string {
|
|
replacerString := []string{}
|
|
for _, pair := range actionEntry.Substitutions {
|
|
value := pair.Value
|
|
if val, ok := TemplateActionOverriddenTokens[pair.Key]; ok {
|
|
value = val
|
|
}
|
|
replacerString = append(replacerString, pair.Key, value)
|
|
}
|
|
replacer := strings.NewReplacer(replacerString...)
|
|
return replacer.Replace(actionEntry.TemplateContent)
|
|
}
|
|
|
|
func escapeCommandlineArgument(str string) string {
|
|
// \->\\, $->\$, `->\`, "->\", \n->\\n, '->'"'"'
|
|
replacer := strings.NewReplacer(
|
|
`\`, `\\`,
|
|
`$`, `\$`,
|
|
"`", "\\`",
|
|
`"`, `\"`,
|
|
"\n", "\\n",
|
|
`'`, `'"'"'`,
|
|
)
|
|
return replacer.Replace(str)
|
|
}
|
|
|
|
// removePy3wrapperScript removes py3wrapper.sh from the input paths and command of the action of
|
|
// creating python zip file in mixed build mode. py3wrapper.sh is returned as input by aquery but
|
|
// there is no action returned by aquery for creating it. So in mixed build "python3" is used
|
|
// as the PYTHON_BINARY in python binary stub script, and py3wrapper.sh is not needed and should be
|
|
// removed from input paths and command of creating python zip file.
|
|
// See go/python-binary-host-mixed-build for more details.
|
|
// TODO(b/205879240) remove this after py3wrapper.sh could be created in the mixed build mode.
|
|
func removePy3wrapperScript(bs BuildStatement) (newInputPaths []string, newCommand string) {
|
|
// Remove from inputs
|
|
filteredInputPaths := []string{}
|
|
for _, path := range bs.InputPaths {
|
|
if !strings.HasSuffix(path, py3wrapperFileName) {
|
|
filteredInputPaths = append(filteredInputPaths, path)
|
|
}
|
|
}
|
|
newInputPaths = filteredInputPaths
|
|
|
|
// Remove from command line
|
|
var re = regexp.MustCompile(`\S*` + py3wrapperFileName)
|
|
newCommand = re.ReplaceAllString(bs.Command, "")
|
|
return
|
|
}
|
|
|
|
// addCommandForPyBinaryRunfilesDir adds commands creating python binary runfiles directory.
|
|
// runfiles directory is created by using MANIFEST file and MANIFEST file is the output of
|
|
// SourceSymlinkManifest action is in aquery output of Bazel py_binary targets,
|
|
// but since SourceSymlinkManifest doesn't contain sufficient information
|
|
// so MANIFEST file could not be created, which also blocks the creation of runfiles directory.
|
|
// See go/python-binary-host-mixed-build for more details.
|
|
// TODO(b/197135294) create runfiles directory from MANIFEST file once it can be created from SourceSymlinkManifest action.
|
|
func addCommandForPyBinaryRunfilesDir(bs BuildStatement, zipperCommandPath, zipFilePath string) string {
|
|
// Unzip the zip file, zipFilePath looks like <python_binary>.zip
|
|
runfilesDirName := zipFilePath[0:len(zipFilePath)-4] + ".runfiles"
|
|
command := fmt.Sprintf("%s x %s -d %s", zipperCommandPath, zipFilePath, runfilesDirName)
|
|
// Create a symbolic link in <python_binary>.runfiles/, which is the expected structure
|
|
// when running the python binary stub script.
|
|
command += fmt.Sprintf(" && ln -sf runfiles/__main__ %s", runfilesDirName)
|
|
return bs.Command + " && " + command
|
|
}
|
|
|
|
func isSymlinkAction(a action) bool {
|
|
return a.Mnemonic == "Symlink" || a.Mnemonic == "SolibSymlink"
|
|
}
|
|
|
|
func isTemplateExpandAction(a action) bool {
|
|
return a.Mnemonic == "TemplateExpand"
|
|
}
|
|
|
|
func isPythonZipperAction(a action) bool {
|
|
return a.Mnemonic == "PythonZipper"
|
|
}
|
|
|
|
func shouldSkipAction(a action) bool {
|
|
// TODO(b/180945121): Handle complex symlink actions.
|
|
if a.Mnemonic == "SymlinkTree" || a.Mnemonic == "SourceSymlinkManifest" {
|
|
return true
|
|
}
|
|
// Middleman actions are not handled like other actions; they are handled separately as a
|
|
// preparatory step so that their inputs may be relayed to actions depending on middleman
|
|
// artifacts.
|
|
if a.Mnemonic == "Middleman" {
|
|
return true
|
|
}
|
|
// Skip "Fail" actions, which are placeholder actions designed to always fail.
|
|
if a.Mnemonic == "Fail" {
|
|
return true
|
|
}
|
|
// TODO(b/180946980): Handle FileWrite. The aquery proto currently contains no information
|
|
// about the contents that are written.
|
|
if a.Mnemonic == "FileWrite" {
|
|
return true
|
|
}
|
|
return false
|
|
}
|
|
|
|
func expandPathFragment(id int, pathFragmentsMap map[int]pathFragment) (string, error) {
|
|
labels := []string{}
|
|
currId := id
|
|
// Only positive IDs are valid for path fragments. An ID of zero indicates a terminal node.
|
|
for currId > 0 {
|
|
currFragment, ok := pathFragmentsMap[currId]
|
|
if !ok {
|
|
return "", fmt.Errorf("undefined path fragment id %d", currId)
|
|
}
|
|
labels = append([]string{currFragment.Label}, labels...)
|
|
if currId == currFragment.ParentId {
|
|
return "", fmt.Errorf("Fragment cannot refer to itself as parent %#v", currFragment)
|
|
}
|
|
currId = currFragment.ParentId
|
|
}
|
|
return filepath.Join(labels...), nil
|
|
}
|